Re: [Spice-devel] [PATCH win-vdagent] Don't exit when receiving unknown messages

2019-03-01 Thread Frediano Ziglio
> On Thu, 2019-02-28 at 03:31 -0500, Frediano Ziglio wrote: > > > > > > In 8251fa25, a check on the minimum size of a message was > > > introduced. > > > For unsupported messages, the vdagent simply exited. This makes it > > > difficult to extend the vdagent protocol without breaking old > > > >

Re: [Spice-devel] [PATCH spice-server 2/2] Only send device display info to supported agents

2019-03-01 Thread Frediano Ziglio
> > Only send the graphics device display info to agents that advertise the > VD_AGENT_CAP_GRAPHICS_DEVICE_INFO capability > > Signed-off-by: Jonathon Jongsma > --- > server/reds-private.h | 1 + > server/reds.c | 9 + > 2 files changed, 10 insertions(+) > > diff --git a/server

[Spice-devel] [PATCH v7 3/4] drm/qxl: remove conflicting framebuffers earlier

2019-03-01 Thread Gerd Hoffmann
Add error checking while being at it. Signed-off-by: Gerd Hoffmann Reviewed-by: Daniel Vetter --- drivers/gpu/drm/qxl/qxl_drv.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/qxl/qxl_drv.c b/drivers/gpu/drm/qxl/qxl_drv.c index bb81e310eb6d..578d867a81d5

Re: [Spice-devel] [linux/vd-agent v2 2/3] gitlab-ci: remove copr dependency

2019-03-01 Thread Frediano Ziglio
> From: Victor Toso > > Instead of relying in copr builds, we should rely on relative branch > in gitlab for spice dependencies such as spice-protocol. > > This patch moves the dependencies to a variable and builds > spice-protocol instead of using spice-protocol from nightly spice > copr. > >

Re: [Spice-devel] [linux/vd-agent v2 3/3] gitlab-ci: run singular job for build options

2019-03-01 Thread Frediano Ziglio
> From: Victor Toso > > There are two main bottlenecks in CI: > 1. Network might be slow for bootstrapping; > 2. Big job queues to get a runners to run our jobs. > > This patch reduces the three jobs to a single one in order to prevent > long delays when CI resources are scarce which is a common

Re: [Spice-devel] [PATCH linux vdagent] Advertise VD_AGENT_CAP_GRAPHICS_DEVICE_INFO

2019-03-01 Thread Frediano Ziglio
> > Since we now support the graphics device info message, advertise this > fact when sending capabilities to the server. > > Signed-off-by: Jonathon Jongsma Acked-by: Frediano Ziglio > --- > src/vdagentd/vdagentd.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/vdagentd/vdage