Re: [Spice-devel] [PATCH 0/5] Clean up TTM mmap offsets

2019-02-27 Thread Christian König
Am 07.02.19 um 10:45 schrieb Thomas Zimmermann: Am 07.02.19 um 10:36 schrieb Koenig, Christian: Am 07.02.19 um 09:59 schrieb Thomas Zimmermann: Almost all TTM-based drivers use the same values for the mmap-able range of BO addresses. Each driver therefore duplicates the DRM_FILE_PAGE_OFFSET con

[Spice-devel] [vdagent-win PATCH] Remove support for very old Fedora versions

2019-02-27 Thread Frediano Ziglio
Signed-off-by: Frediano Ziglio --- mingw-spice-vdagent.spec.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mingw-spice-vdagent.spec.in b/mingw-spice-vdagent.spec.in index d129a7b..5fa9b7a 100644 --- a/mingw-spice-vdagent.spec.in +++ b/mingw-spice-vdagent.spec.in @@ -2,7 +2

[Spice-devel] [vdagent-win PATCH] build: Check we can link libpng statically

2019-02-27 Thread Frediano Ziglio
Catch the problem during configure instead of having to wait the build to fail. On Fedora try for instance to remove mingw64-zlib-static package, the missing dependency won't be detected during configure. Signed-off-by: Frediano Ziglio --- configure.ac | 10 -- m4/pushvars.m4 | 15

[Spice-devel] [PATCH vd_agent_linux] Ignore autogenerated test

2019-02-27 Thread Frediano Ziglio
Signed-off-by: Frediano Ziglio --- .gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/.gitignore b/.gitignore index 76d4081..b3f32e2 100644 --- a/.gitignore +++ b/.gitignore @@ -11,6 +11,7 @@ src/stamp-h1 tests/test-*.log tests/test-*.trs tests/test-file-xfers +tests/test-device-in

[Spice-devel] [linux/vd-agent 1/3] gitlab-ci: remove sudo

2019-02-27 Thread Victor Toso
From: Victor Toso The jobs already run as root. Also removes an extra empty line. Signed-off-by: Victor Toso --- .gitlab-ci.yml | 15 +++ 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index f0b77a7..ad4fb80 100644 --- a/.gitlab-ci.yml

[Spice-devel] [linux/vd-agent 2/3] gitlab-ci: Move the dependencies to a variable

2019-02-27 Thread Victor Toso
From: Victor Toso Signed-off-by: Victor Toso --- .gitlab-ci.yml | 16 ++-- 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index ad4fb80..fc40c04 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -1,12 +1,16 @@ image: fedora:latest

[Spice-devel] [linux/vd-agent 3/3] gitlab-ci: run singular job for build options

2019-02-27 Thread Victor Toso
From: Victor Toso There are two main bottlenecks in CI: 1. Network might be slow for bootstrapping; 2. Big job queues to get a runners to run our jobs. This patch reduces the three jobs to a single one in order to prevent long delays when CI resources are scarce which is a common scenario. No m

Re: [Spice-devel] [PATCH vd_agent_linux] Ignore autogenerated test

2019-02-27 Thread Victor Toso
Hi, On Wed, Feb 27, 2019 at 10:57:58AM +, Frediano Ziglio wrote: > Signed-off-by: Frediano Ziglio > --- > .gitignore | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/.gitignore b/.gitignore > index 76d4081..b3f32e2 100644 > --- a/.gitignore > +++ b/.gitignore > @@ -11,6 +11,7 @@ src

[Spice-devel] [PATCH v2 spice-streaming-agent] Add copr Makefile

2019-02-27 Thread Snir Sheriber
This Makefile script is invoked by copr to build source rpm See: https://docs.pagure.org/copr.copr/user_documentation.html#make-srpm --- Changes from v1 are script improvements and description --- .copr/Makefile | 21 + 1 file changed, 21 insertions(+) create mode 100644 .c

Re: [Spice-devel] [linux/vd-agent 1/3] gitlab-ci: remove sudo

2019-02-27 Thread Frediano Ziglio
> > From: Victor Toso > > The jobs already run as root. > Also removes an extra empty line. > > Signed-off-by: Victor Toso Acked-by: Frediano Ziglio > --- > .gitlab-ci.yml | 15 +++ > 1 file changed, 7 insertions(+), 8 deletions(-) > > diff --git a/.gitlab-ci.yml b/.gitlab-ci.

Re: [Spice-devel] [linux/vd-agent 2/3] gitlab-ci: Move the dependencies to a variable

2019-02-27 Thread Frediano Ziglio
> > From: Victor Toso > > Signed-off-by: Victor Toso > --- > .gitlab-ci.yml | 16 ++-- > 1 file changed, 10 insertions(+), 6 deletions(-) > > diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml > index ad4fb80..fc40c04 100644 > --- a/.gitlab-ci.yml > +++ b/.gitlab-ci.yml > @@ -1,12 +1,16

Re: [Spice-devel] [linux/vd-agent 3/3] gitlab-ci: run singular job for build options

2019-02-27 Thread Frediano Ziglio
> > From: Victor Toso > > There are two main bottlenecks in CI: > 1. Network might be slow for bootstrapping; > 2. Big job queues to get a runners to run our jobs. > > This patch reduces the three jobs to a single one in order to prevent > long delays when CI resources are scarce which is a com

Re: [Spice-devel] [linux/vd-agent 2/3] gitlab-ci: Move the dependencies to a variable

2019-02-27 Thread Victor Toso
Hi, On Wed, Feb 27, 2019 at 07:49:20AM -0500, Frediano Ziglio wrote: > > > > From: Victor Toso > > > > Signed-off-by: Victor Toso > > --- > > .gitlab-ci.yml | 16 ++-- > > 1 file changed, 10 insertions(+), 6 deletions(-) > > > > diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml > > in

Re: [Spice-devel] [linux/vd-agent 3/3] gitlab-ci: run singular job for build options

2019-02-27 Thread Victor Toso
On Wed, Feb 27, 2019 at 07:52:11AM -0500, Frediano Ziglio wrote: > > > > From: Victor Toso > > > > There are two main bottlenecks in CI: > > 1. Network might be slow for bootstrapping; > > 2. Big job queues to get a runners to run our jobs. > > > > This patch reduces the three jobs to a single

Re: [Spice-devel] [linux/vd-agent 2/3] gitlab-ci: Move the dependencies to a variable

2019-02-27 Thread Frediano Ziglio
> > Hi, > > On Wed, Feb 27, 2019 at 07:49:20AM -0500, Frediano Ziglio wrote: > > > > > > From: Victor Toso > > > > > > Signed-off-by: Victor Toso > > > --- > > > .gitlab-ci.yml | 16 ++-- > > > 1 file changed, 10 insertions(+), 6 deletions(-) > > > > > > diff --git a/.gitlab-ci.

Re: [Spice-devel] [linux/vd-agent 2/3] gitlab-ci: Move the dependencies to a variable

2019-02-27 Thread Victor Toso
Hi, On Wed, Feb 27, 2019 at 11:13:06AM +, Victor Toso wrote: > From: Victor Toso > > Signed-off-by: Victor Toso > --- > .gitlab-ci.yml | 16 ++-- > 1 file changed, 10 insertions(+), 6 deletions(-) > > diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml > index ad4fb80..fc40c04 100644

[Spice-devel] [linux/vd-agent v2 2/3] gitlab-ci: remove copr dependency

2019-02-27 Thread Victor Toso
From: Victor Toso Instead of relying in copr builds, we should rely on relative branch in gitlab for spice dependencies such as spice-protocol. This patch moves the dependencies to a variable and builds spice-protocol instead of using spice-protocol from nightly spice copr. Signed-off-by: Victo

[Spice-devel] [linux/vd-agent v2 3/3] gitlab-ci: run singular job for build options

2019-02-27 Thread Victor Toso
From: Victor Toso There are two main bottlenecks in CI: 1. Network might be slow for bootstrapping; 2. Big job queues to get a runners to run our jobs. This patch reduces the three jobs to a single one in order to prevent long delays when CI resources are scarce which is a common scenario. No m

Re: [Spice-devel] [linux/vd-agent 2/3] gitlab-ci: Move the dependencies to a variable

2019-02-27 Thread Frediano Ziglio
> > Hi, > > On Wed, Feb 27, 2019 at 11:13:06AM +, Victor Toso wrote: > > From: Victor Toso > > > > Signed-off-by: Victor Toso > > --- > > .gitlab-ci.yml | 16 ++-- > > 1 file changed, 10 insertions(+), 6 deletions(-) > > > > diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml > > in

Re: [Spice-devel] [linux/vd-agent 2/3] gitlab-ci: Move the dependencies to a variable

2019-02-27 Thread Victor Toso
Hi, On Wed, Feb 27, 2019 at 09:36:55AM -0500, Frediano Ziglio wrote: > > > > Hi, > > > > On Wed, Feb 27, 2019 at 11:13:06AM +, Victor Toso wrote: > > > From: Victor Toso > > > > > > Signed-off-by: Victor Toso > > > --- > > > .gitlab-ci.yml | 16 ++-- > > > 1 file changed, 10

[Spice-devel] [PATCH spice-streaming-agent] Update .gitlab-ci.yml

2019-02-27 Thread Snir Sheriber
Do not count on copr nightly for getting the dependencies Signed-off-by: Snir Sheriber --- .gitlab-ci.yml | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index ab1b2a3..808e3ec 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -1,1

[Spice-devel] [vdagent-win PATCH] Fix indentation

2019-02-27 Thread Frediano Ziglio
Signed-off-by: Frediano Ziglio --- vdagent/as_user.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/vdagent/as_user.cpp b/vdagent/as_user.cpp index c8016da..fc1f056 100644 --- a/vdagent/as_user.cpp +++ b/vdagent/as_user.cpp @@ -42,7 +42,7 @@ bool AsUser::begin() re

Re: [Spice-devel] [vdagent-win PATCH] Fix indentation

2019-02-27 Thread Victor Toso
Hi, On Wed, Feb 27, 2019 at 04:42:36PM +, Frediano Ziglio wrote: > Signed-off-by: Frediano Ziglio > --- > vdagent/as_user.cpp | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/vdagent/as_user.cpp b/vdagent/as_user.cpp > index c8016da..fc1f056 100644 > --- a/vdagent/as

[Spice-devel] [PATCH win-vdagent] Don't exit when receiving unknown messages

2019-02-27 Thread Jonathon Jongsma
In 8251fa25, a check on the minimum size of a message was introduced. For unsupported messages, the vdagent simply exited. This makes it difficult to extend the vdagent protocol without breaking old installations. Instead, just print a warning indicating that an unsupported message was received and

Re: [Spice-devel] [linux/vd-agent v2 3/5] README: Remove non relevant features information

2019-02-27 Thread Jakub Janku
Hi, On Mon, Feb 25, 2019 at 6:04 PM Victor Toso wrote: > > From: Victor Toso > > It is not relevant nowadays that *spicec* client was removed and even > monitors_config does not reach spice-vdagent in modern Guests. > Can't really evaluate this with my current knowledge of spice & monitor config