Re: [Spice-devel] [PATCH 19/26] drm/qxl: Use drm_fb_helper_fill_info

2019-01-25 Thread Daniel Vetter
On Fri, Jan 25, 2019 at 07:39:26AM +0100, Gerd Hoffmann wrote: > On Thu, Jan 24, 2019 at 05:58:24PM +0100, Daniel Vetter wrote: > > This should not result in any changes. > > I'd love to merge https://patchwork.freedesktop.org/series/53951/ > instead (which will -- among other things -- switch qxl

Re: [Spice-devel] [PATCH v2 1/2] display-gst: small refactor get_decoded_frame()

2019-01-25 Thread Frediano Ziglio
> From: Victor Toso > > Small refactor to make each code block a bit more obvious. > > This code should (1) find the @buffer in the queue; (2) remove all old > elements from queue. That perfectly fit in two loops in sequence, but > they don't need to be nested and they don't need to use the same

[Spice-devel] [PATCH v3] display-gst: small refactor get_decoded_frame()

2019-01-25 Thread Victor Toso
From: Victor Toso Small refactor to make each code block a bit more obvious. This code should (1) find the @buffer in the queue; (2) remove all old elements from queue. That perfectly fit in two loops in sequence, but they don't need to be nested and they don't need to use the same pointer (gstf

Re: [Spice-devel] [PATCH v3] display-gst: small refactor get_decoded_frame()

2019-01-25 Thread Frediano Ziglio
> > From: Victor Toso > > Small refactor to make each code block a bit more obvious. > > This code should (1) find the @buffer in the queue; (2) remove all old > elements from queue. That perfectly fit in two loops in sequence, but > they don't need to be nested and they don't need to use the s

[Spice-devel] [PATCH spice-gtk v4] channel-display: Instrument code to get frame and queue statistics

2019-01-25 Thread Frediano Ziglio
This patch is based on some work from Victor Toso (statistics) and Snir Sheriber (GStreamer probing). All GstBuffers are queued into decoding_queue and a probe is attached to the sink in order to understand when the buffers are decoded. Previously we didn't add frames to decoding_queue in case of d

[Spice-devel] [PATCH spice-gtk v5] channel-display: Instrument code to get frame and queue statistics

2019-01-25 Thread Frediano Ziglio
This patch is based on some work from Victor Toso (statistics) and Snir Sheriber (GStreamer probing). All GstBuffers are queued into decoding_queue and a probe is attached to the sink in order to understand when the buffers are decoded. Previously we didn't add frames to decoding_queue in case of d

Re: [Spice-devel] [PATCH spice-gtk v5] channel-display: Instrument code to get frame and queue statistics

2019-01-25 Thread Victor Toso
Hi, On Fri, Jan 25, 2019 at 11:57:18AM +, Frediano Ziglio wrote: > This patch is based on some work from Victor Toso (statistics) and > Snir Sheriber (GStreamer probing). > All GstBuffers are queued into decoding_queue and a probe is > attached to the sink in order to understand when the buffe

Re: [Spice-devel] [PATCH v3 18/23] drm/qxl: remove dead qxl fbdev emulation code

2019-01-25 Thread Sam Ravnborg
Hi Noralf. > > Lovely diffstat, thanks to the new generic fbdev emulation. > > > > drm/qxl/Makefile |2 > > drm/qxl/qxl_draw.c | 232 > > drm/qxl/qxl_drv.h | 21 --- > > drm/qxl/qxl_fb.c | 300 > >