[Spice-devel] [PATCH 7/7] drm: Split out drm_probe_helper.h

2018-12-11 Thread Daniel Vetter
Having the probe helper stuff (which pretty much everyone needs) in the drm_crtc_helper.h file (which atomic drivers should never need) is confusing. Split them out. To make sure I actually achieved the goal here I went through all drivers. And indeed, all atomic drivers are now free of drm_crtc_h

Re: [Spice-devel] [PATCH 7/7] drm: Split out drm_probe_helper.h

2018-12-11 Thread Benjamin Gaignard
Le lun. 10 déc. 2018 à 12:10, Benjamin Gaignard a écrit : > > Le lun. 10 déc. 2018 à 11:24, Thierry Reding > a écrit : > > > > On Mon, Dec 10, 2018 at 11:11:33AM +0100, Daniel Vetter wrote: > > > Having the probe helper stuff (which pretty much everyone needs) in > > > the drm_crtc_helper.h file

[Spice-devel] [PATCH 7/7] drm: Split out drm_probe_helper.h

2018-12-11 Thread Daniel Vetter
Having the probe helper stuff (which pretty much everyone needs) in the drm_crtc_helper.h file (which atomic drivers should never need) is confusing. Split them out. To make sure I actually achieved the goal here I went through all drivers. And indeed, all atomic drivers are now free of drm_crtc_h

Re: [Spice-devel] [PATCH 7/7] drm: Split out drm_probe_helper.h

2018-12-11 Thread Neil Armstrong
On 10/12/2018 11:11, Daniel Vetter wrote: > Having the probe helper stuff (which pretty much everyone needs) in > the drm_crtc_helper.h file (which atomic drivers should never need) is > confusing. Split them out. > > To make sure I actually achieved the goal here I went through all > drivers. And

[Spice-devel] [PATCH 5/7] drm/qxl: Don't set the dpms hook

2018-12-11 Thread Daniel Vetter
Doesn't do anything with atomic. Signed-off-by: Daniel Vetter Cc: Dave Airlie Cc: Gerd Hoffmann Cc: virtualizat...@lists.linux-foundation.org Cc: spice-devel@lists.freedesktop.org --- drivers/gpu/drm/qxl/qxl_display.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/qxl/qxl_d

Re: [Spice-devel] [PATCH 7/7] drm: Split out drm_probe_helper.h

2018-12-11 Thread Benjamin Gaignard
Le lun. 10 déc. 2018 à 11:24, Thierry Reding a écrit : > > On Mon, Dec 10, 2018 at 11:11:33AM +0100, Daniel Vetter wrote: > > Having the probe helper stuff (which pretty much everyone needs) in > > the drm_crtc_helper.h file (which atomic drivers should never need) is > > confusing. Split them out

Re: [Spice-devel] [PATCH 7/7] drm: Split out drm_probe_helper.h

2018-12-11 Thread Thierry Reding
On Mon, Dec 10, 2018 at 11:11:33AM +0100, Daniel Vetter wrote: > Having the probe helper stuff (which pretty much everyone needs) in > the drm_crtc_helper.h file (which atomic drivers should never need) is > confusing. Split them out. > > To make sure I actually achieved the goal here I went throu

[Spice-devel] [spice-gtk v1 1/2] Deprecate “color-depth” properties

2018-12-11 Thread Victor Toso
From: Victor Toso With commit 1a980f3712 we deprecated some command line options. The color-depth one is the only one which is not used for testing/debug purposes. The intention of this option is to set guest's video driver color configuration, currently only windows guest agent uses this featur

[Spice-devel] [spice-gtk v1 2/2] option: Remove --spice-color-depth

2018-12-11 Thread Victor Toso
From: Victor Toso As this is NOP from previous patch and has been deprecated since v0.34 Signed-off-by: Victor Toso --- src/spice-option.c | 32 1 file changed, 32 deletions(-) diff --git a/src/spice-option.c b/src/spice-option.c index 6b400bc..d91b10a 100644

Re: [Spice-devel] [spice-gtk v2 6/7] channel-main: clipboard grab: don't fail silently

2018-12-11 Thread Victor Toso
Hi, On Mon, Dec 10, 2018 at 08:39:46AM -0500, Frediano Ziglio wrote: > > On Mon, Dec 10, 2018 at 07:42:35AM -0500, Frediano Ziglio wrote: > > > > > > > > From: Victor Toso > > > > > > > > Spice client should listen to SpiceMainChannel::agent-connected > > > > notification and avoid calling any

Re: [Spice-devel] [PATCH vdagent-linux 3/4] introduce VDAgentConnection

2018-12-11 Thread Jakub Janku
Hi, Victor! Many thanks for reviewing this series. On Thu, Dec 6, 2018 at 4:20 PM Victor Toso wrote: > > Hi, > > First of all, tested. Seems to work fine! Great! > > This one I think it can be improved to have a clear design around > VDAgentConnection. The other three patches could be merged fa

Re: [Spice-devel] [spice-gtk v2 2/7] channel-main: clipboard request: wakeup only when needed

2018-12-11 Thread Jakub Janku
Hi, On Mon, Dec 10, 2018 at 12:03 PM Victor Toso wrote: > > From: Victor Toso > > This patch makes agent_clipboard_request() to return true only when > the message request to the agent is successfully queued to be sent. > > By checking the return value, we can avoid wakeup the channel > unnecess