Remove dependency from main protocol allowing to run the
test independently from generation setting.
This is useful with Meson allowing to not generate all code.
Signed-off-by: Frediano Ziglio
---
tests/Makefile.am| 9 ++---
tests/meson.build| 17 ++---
t
On Wed, Jul 04, 2018 at 12:29:15PM -0400, Frediano Ziglio wrote:
> >
> > On Wed, Jul 04, 2018 at 11:38:14AM -0400, Frediano Ziglio wrote:
> > > Another question is however "Are we going to use g_critical as
> > > g_critical?". It sounds a tricky question. Let say that a new person
> > > starts to
Hi,
On Wed, Jul 04, 2018 at 12:29:15PM -0400, Frediano Ziglio wrote:
> >
> > On Wed, Jul 04, 2018 at 11:38:14AM -0400, Frediano Ziglio wrote:
> > > Another question is however "Are we going to use g_critical
> > > as g_critical?". It sounds a tricky question. Let say that
> > > a new person start
On 07/04/2018 07:00 PM, Frediano Ziglio wrote:
Hi,
On 07/03/2018 06:22 PM, Frediano Ziglio wrote:
Hi,
On 05/25/2018 03:55 PM, Frediano Ziglio wrote:
display_queue is queued with decoded frames ready to be displayed.
However current code can insert a timeout before displaying and
removing
On Wed, Jul 04, 2018 at 05:23:52PM +0100, Frediano Ziglio wrote:
> This patch just changes some spaces fixing some possible misleading
> indentation.
>
> Signed-off-by: Frediano Ziglio
Acked-by: Victor Toso
> ---
> common/canvas_base.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(
Sure,
Acked-by: Christophe Fergeau
On Wed, Jul 04, 2018 at 05:23:52PM +0100, Frediano Ziglio wrote:
> This patch just changes some spaces fixing some possible misleading
> indentation.
>
> Signed-off-by: Frediano Ziglio
> ---
> common/canvas_base.c | 4 ++--
> 1 file changed, 2 insertions(+)
Hi,
On Wed, Jul 04, 2018 at 06:57:17PM +0100, Frediano Ziglio wrote:
> Signed-off-by: Frediano Ziglio
> ---
> spice.proto | 6 --
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/spice.proto b/spice.proto
> index e678ef8..3084c2b 100644
> --- a/spice.proto
> +++ b/spice.pr
Hey,
On Wed, Jul 04, 2018 at 04:31:45PM -0500, Carlos González wrote:
> Every attempt to send to such address results in the following error from
> the SMTP server:
> 550 5.1.1 : Recipient address
> rejected: User unknown in local recipient table
>
> This same issue happened back when trying to e
Acked-by: Christophe Fergeau
On Wed, Jul 04, 2018 at 04:27:11PM +0100, Frediano Ziglio wrote:
> Make code faster on platforms not supporting unaligned access by
> default.
> SPICE_UNALIGNED_CAST is just silencing possible alignment warning and,
> if enabled, produces some logs, however in this c
>
> Hi,
>
> On Wed, Jul 04, 2018 at 06:57:17PM +0100, Frediano Ziglio wrote:
> > Signed-off-by: Frediano Ziglio
> > ---
> > spice.proto | 6 --
> > 1 file changed, 4 insertions(+), 2 deletions(-)
> >
> > diff --git a/spice.proto b/spice.proto
> > index e678ef8..3084c2b 100644
> > --- a/spi
> On 07/04/2018 07:00 PM, Frediano Ziglio wrote:
> > > Hi,
> >
>
> > > On 07/03/2018 06:22 PM, Frediano Ziglio wrote:
> >
>
> > > > > Hi,
> > > >
> > >
> >
>
> > > > > On 05/25/2018 03:55 PM, Frediano Ziglio wrote:
> > > >
> > >
> >
>
> > > > > > display_queue is queued with decode
On Mon, 2018-07-02 at 08:43 +0100, Frediano Ziglio wrote:
> Signed-off-by: Frediano Ziglio
> ---
> vdagent/display_setting.cpp | 81 +
>
> 1 file changed, 36 insertions(+), 45 deletions(-)
>
> diff --git a/vdagent/display_setting.cpp
> b/vdagent/display_setti
SPICE expect to have each frame in a single message.
So far the stream-device did not do that.
That works fine for H264 streams but not for mjpeg.
The client handles by itself mjpeg streams, and not via
gstreamer, and is assuming that a message contains the
whole frame. Since it currently not, usin
I guess this avoids the error I just pointed out in the previous patch.
This patch looks fine, but the previous patch should still be fixed
in case this one gets reverted sometime in the future for some reason.
One minor comment below.
Acked-by: Jonathon Jongsma
On Mon, 2018-07-02 at 08:43
Sure
Acked-by: Jonathon Jongsma
On Mon, 2018-07-02 at 08:43 +0100, Frediano Ziglio wrote:
> Make automatic the release of this pointer.
> Also avoids having a leak if VDAgent::run is called twice.
>
> Signed-off-by: Frediano Ziglio
> ---
> vdagent/vdagent.cpp | 6 ++
> 1 file changed, 2 i
On 07/05/2018 12:18 PM, Frediano Ziglio wrote:
On 07/04/2018 07:00 PM, Frediano Ziglio wrote:
Hi,
On 07/03/2018 06:22 PM, Frediano Ziglio wrote:
Hi,
On 05/25/2018 03:55 PM, Frediano Ziglio wrote:
>
> On Mon, 2018-07-02 at 08:43 +0100, Frediano Ziglio wrote:
> > Signed-off-by: Frediano Ziglio
> > ---
> > vdagent/display_setting.cpp | 81 +
> >
> > 1 file changed, 36 insertions(+), 45 deletions(-)
> >
> > diff --git a/vdagent/display_setting.cpp
> > b/
>
> I guess this avoids the error I just pointed out in the previous patch.
>This patch looks fine, but the previous patch should still be fixed
> in case this one gets reverted sometime in the future for some reason.
>
> One minor comment below.
>
> Acked-by: Jonathon Jongsma
>
>
> On Mo
On Mon, 2018-07-02 at 08:43 +0100, Frediano Ziglio wrote:
> Handle _control_event and _stop_event destruction in destructor.
> Still allows to call VDAgent::run multiple time if needed.
Remove "Still"
Acked-by: Jonathon Jongsma
>
> Signed-off-by: Frediano Ziglio
> ---
> vdagent/vdagent.cpp |
Acked-by: Jonathon Jongsma
On Mon, 2018-07-02 at 08:43 +0100, Frediano Ziglio wrote:
> More C++ style.
> Also avoids missing cleanup calls.
>
> Signed-off-by: Frediano Ziglio
> ---
> vdagent/vdagent.cpp | 16 +++-
> 1 file changed, 3 insertions(+), 13 deletions(-)
>
> diff --git
On Mon, 2018-07-02 at 11:35 -0400, Frediano Ziglio wrote:
> >
> > > On 2 Jul 2018, at 09:43, Frediano Ziglio
> > > wrote:
> > >
> > > As the value is never used we can pass NULL in CreateThread.
> > >
> > > Signed-off-by: Frediano Ziglio
> > > ---
> > > vdagent/vdagent.cpp | 3 +--
> > > 1 file
In summary: change Avoids to Avoid.
Acked-by: Jonathon Jongsma
On Mon, 2018-07-02 at 08:43 +0100, Frediano Ziglio wrote:
> The check can be done a single time, no reason to cache
> supported_system_version() value.
>
> Signed-off-by: Frediano Ziglio
> ---
> vdagent/vdagent.cpp | 8 +++-
>
> On 5 Jul 2018, at 15:14, Jonathon Jongsma wrote:
>
> On Mon, 2018-07-02 at 11:35 -0400, Frediano Ziglio wrote:
>>>
On 2 Jul 2018, at 09:43, Frediano Ziglio
wrote:
As the value is never used we can pass NULL in CreateThread.
Signed-off-by: Frediano Ziglio
>>>
>
> SPICE expect to have each frame in a single message.
> So far the stream-device did not do that.
> That works fine for H264 streams but not for mjpeg.
> The client handles by itself mjpeg streams, and not via
> gstreamer, and is assuming that a message contains the
> whole frame. Since it curr
On 19/06/2018 10:09, Victor Toso wrote:
Hi,
On Mon, Jun 18, 2018 at 04:23:32PM +0200, Mitja Mihelič wrote:
Does it work fine with remote-viewer?
Question ^
You could try different image compression too,
e.g image-compression=off
https://people.freedesktop.org/~teuf/spice-doc/html/ch03.html
On 05/07/2018 16:56, Mitja Mihelič wrote:
On 19/06/2018 10:09, Victor Toso wrote:
Hi,
On Mon, Jun 18, 2018 at 04:23:32PM +0200, Mitja Mihelič wrote:
Does it work fine with remote-viewer?
Question ^
You could try different image compression too,
e.g image-compression=off
https://people.f
When GstVideoOverly is used there is no appsink, playing of a frame is
done according the time value of its buffer
---
Currently no error will happen since counting pending frames is not
done and that will cause some checks will to fail and avoid critic error.
but should be safer to return here. Is
---
Hopfully it's clear to understand the separation i did here without
re-numbering:/
---
src/channel-display-gst.c | 35 +--
1 file changed, 21 insertions(+), 14 deletions(-)
diff --git a/src/channel-display-gst.c b/src/channel-display-gst.c
index ff0ecd8..1ccc78
Seems reasonable
Acked-by: Jonathon Jongsma
On Mon, 2018-07-02 at 08:43 +0100, Frediano Ziglio wrote:
> The only reason we call this function is to check if the
> system should support some APIs.
> Instead just check directly if these APIs are supported
> calling GetProcAddress directly.
>
>
Sounds like you don't support that address at all?
When first subscribing to the list, confirmation and welcome messages
-along with basic usage instructions- came from that address!
And in the basic instructions it's mentioned one can change settings
*either* through web interface *and* that addr
Patches 17-19 don't seem particularly compelling to me, but I guess I
don't mind. Unless anybody else objects:
Acked-by: Jonathon Jongsma
On Mon, 2018-07-02 at 08:43 +0100, Frediano Ziglio wrote:
> As log type is passed as constant in some macros and the lockup
> is basically using this name w
ACK series
On Tue, 2018-07-03 at 12:42 +0200, Christophe Fergeau wrote:
> spice-gtk was the last user, and stopped using it on Jun 14th 2017
> in 040090ccba34 "build-sys: remove -DSPICE_DISABLE_ABORT"
>
> Signed-off-by: Christophe Fergeau
> ---
> common/log.c | 4
> common/spice_
Acked-by: Jonathon Jongsma
On Tue, 2018-07-03 at 12:42 +0200, Christophe Fergeau wrote:
> Signed-off-by: Christophe Fergeau
> ---
> server/dispatcher.c | 1 -
> server/red-common.h | 1 -
> 2 files changed, 2 deletions(-)
>
> diff --git a/server/dispatcher.c b/server/dispatcher.c
> index 0953
>
> Acked-by: Jonathon Jongsma
>
As a follow up of these patches I think an update to spice-common
submodule hash in spice-server/spice-gtk would be helpful.
Frediano
>
> On Tue, 2018-07-03 at 12:42 +0200, Christophe Fergeau wrote:
> > Signed-off-by: Christophe Fergeau
> > ---
> > server/d
> Sounds like you don't support that address at all?
> When first subscribing to the list, confirmation and welcome messages -along
> with basic usage instructions- came from that address!
> And in the basic instructions it's mentioned one can change settings *either*
> through web interface *and*
>
> ACK series
>
For some reasons Meson build is failing, see
https://gitlab.freedesktop.org/spice/spice-common/-/jobs/8351.
I checked common/.deps/pixman_utils.Plo (autotool file dependencies)
and there are GLib headers (don't ask me where they came from)
Frediano
> On Tue, 2018-07-03 at 12:
Acked the entire series.
note that this patch is much shorter without space changes.
>
> ---
> Hopfully it's clear to understand the separation i did here without
> re-numbering:/
> ---
> src/channel-display-gst.c | 35 +--
> 1 file changed, 21 insertions(+), 14
37 matches
Mail list logo
