Signed-off-by: Frediano Ziglio
---
tests/Makefile.am | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/tests/Makefile.am b/tests/Makefile.am
index 457bb23..39d30c0 100644
--- a/tests/Makefile.am
+++ b/tests/Makefile.am
@@ -18,9 +18,7 @@ test_logging_LDADD =
Signed-off-by: Frediano Ziglio
---
common/Makefile.am | 6 +++---
tests/Makefile.am | 12 ++--
2 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/common/Makefile.am b/common/Makefile.am
index 3cbc49f..5ca6538 100644
--- a/common/Makefile.am
+++ b/common/Makefile.am
@@ -88,10
This will allow printing run-time information to stderr (by using
LOG_NOTICE level) without classifying it as warning/error or by
enabling debug mode.
---
src/spice-streaming-agent.cpp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
This follows a suggestion to print run-time informative lo
This allows users of the library to redirect where these messages go
through use of g_log_set_default_handler() rather than unconditionally
printing on stderr.
Signed-off-by: Christophe Fergeau
---
Let's first address spice-common use of spice_printerr, more patches
will be coming for spice-serve
>
> This allows users of the library to redirect where these messages go
> through use of g_log_set_default_handler() rather than unconditionally
> printing on stderr.
>
> Signed-off-by: Christophe Fergeau
> ---
> Let's first address spice-common use of spice_printerr, more patches
> will be com
It was only used twice, for what looks like adhoc debugging. This commit
removes it, similarly to what was done for some spice_printerr() calls.
---
server/red-channel.h | 3 ---
server/red-qxl.c | 4
2 files changed, 7 deletions(-)
diff --git a/server/red-channel.h b/server/red-channel.
Depending on the context, we want to output a warning or just a debug
log.
---
server/dcc.c | 6 +++--
server/inputs-channel-client.c| 3 ++-
server/inputs-channel.c | 6 ++---
server/main-channel-client.c | 42 ++-
server/main
These calls seem to have been added for debugging for a very specific
purpose. At the very least, they should have been using g_debug() rather
than spice_printerr(). This commit removes these.
---
server/char-device.c | 1 -
server/inputs-channel.c | 2 --
server/main-channel-client
The remaining occurrences of spice_printerr() are warnings when
something unexpected happens, they can be replaced with g_warning() so
that users of spice-server can redirect them with
g_log_set_default_handler().
---
server/agent-msg-filter.c | 8
server/char-device.c| 8
>
> These calls seem to have been added for debugging for a very specific
> purpose. At the very least, they should have been using g_debug() rather
> than spice_printerr(). This commit removes these.
Acked the series
> ---
> server/char-device.c | 1 -
> server/inputs-channel.c |
For the 2 patches,
Acked-by: Christophe Fergeau
On Thu, Jun 28, 2018 at 08:14:01AM +0100, Frediano Ziglio wrote:
> Signed-off-by: Frediano Ziglio
> ---
> tests/Makefile.am | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/tests/Makefile.am b/tests/Makefile.am
> index
>
> This will allow printing run-time information to stderr (by using
> LOG_NOTICE level) without classifying it as warning/error or by
> enabling debug mode.
Seems reasonable
> ---
> src/spice-streaming-agent.cpp | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> This follows a sugge
Now warnings are printed through g_warning which causes the test to
fail. We need to use g_test_expect_message() to prevent that failure.
Signed-off-by: Christophe Fergeau
---
server/tests/test-agent-msg-filter.c | 10 ++
1 file changed, 10 insertions(+)
diff --git a/server/tests/test-a
Hi
On 06/28/2018 03:47 PM, Frediano Ziglio wrote:
This will allow printing run-time information to stderr (by using
LOG_NOTICE level) without classifying it as warning/error or by
enabling debug mode.
Seems reasonable
---
src/spice-streaming-agent.cpp | 2 +-
1 file changed, 1 insertion(+
QUIC is implemented using 2 C template files.
One for single channel and one for multiple (RGB) channels.
Unify the 2 templates to have a single source.
Frediano Ziglio (6):
quic: Call encode from golomb_coding
quic: Continue template unification
quic: Other template unification
quic: More
golomb_coding is always followed by a encode call.
Simplify code calling directly it, no reason to pass back output
using pointers.
Signed-off-by: Frediano Ziglio
---
common/quic.c | 2 ++
common/quic_family_tmpl.c | 6 ++
common/quic_rgb_tmpl.c| 43
Start defining the macro the same for both templates.
Unify function initial declaration using DECLARE_CHANNEL_VARIABLES
and DECLARE_STATE_VARIABLES macros.
Signed-off-by: Frediano Ziglio
---
common/quic_rgb_tmpl.c | 160 ++
common/quic_tmpl.c | 192 ++
Define SAME_PIXEL also for single channel.
Define _PIXEL_A in single channel similarly to rgb.
Define COMPRESS_xx/UNCOMPRESS_xx macros in a more similar way,
using channel name.
Signed-off-by: Frediano Ziglio
---
common/quic_rgb_tmpl.c | 18 +++---
common/quic_tmpl.c | 141 +
Now that the 2 template files are the same we can use a single file.
Signed-off-by: Frediano Ziglio
---
common/Makefile.am | 1 -
common/quic.c | 8 +-
common/quic_rgb_tmpl.c | 669 -
3 files changed, 4 insertions(+), 674 deletions(-)
del
Use a APPLY_ALL_COMP macro to unify single/multiple channel processing.
Make declaration on compress_rowXX function more similar.
Call directly encode_state_run from templates.
Signed-off-by: Frediano Ziglio
---
common/quic.c | 21 --
common/quic_rgb_tmpl.c | 110 --
Define and reuse a COPY_PIXEL macro to copy a pixel.
After this commit the 2 template files are exactly the same.
Signed-off-by: Frediano Ziglio
---
common/quic_rgb_tmpl.c | 11 ---
common/quic_tmpl.c | 9 -
2 files changed, 16 insertions(+), 4 deletions(-)
diff --git a/com
>
> Now warnings are printed through g_warning which causes the test to
> fail. We need to use g_test_expect_message() to prevent that failure.
>
> Signed-off-by: Christophe Fergeau
> ---
> server/tests/test-agent-msg-filter.c | 10 ++
> 1 file changed, 10 insertions(+)
>
> diff --git
2018-06-26 14:06 GMT-05:00 Carlos González :
> I guess the spice-server patch will need more testing before release?
>
> Finally, and just mere curiosity,
> with 3D would you perhaps mean 3D graphic acceleration?
> Are there by chance plans for supporting host-to-guest copy-pasting of
> directorie
> 2018-06-26 14:06 GMT-05:00 Carlos González < piteccel...@gmail.com > :
> > I guess the spice-server patch will need more testing before release?
>
> > Finally, and just mere curiosity,
>
> > with 3D would you perhaps mean 3D graphic acceleration?
>
> > Are there by chance plans for supportin
>
> Hi
>
>
> On 06/28/2018 03:47 PM, Frediano Ziglio wrote:
> >> This will allow printing run-time information to stderr (by using
> >> LOG_NOTICE level) without classifying it as warning/error or by
> >> enabling debug mode.
> > Seems reasonable
> >
> >> ---
> >> src/spice-streaming-agent.cpp
Hi,
On Thu, Jun 28, 2018 at 4:53 PM, Frediano Ziglio wrote:
>> 2018-06-26 14:06 GMT-05:00 Carlos González < piteccel...@gmail.com > :
>
>> > I guess the spice-server patch will need more testing before release?
>>
>
>> > Finally, and just mere curiosity,
>>
>> > with 3D would you perhaps mean 3D
The remaining occurrences of spice_printerr() are warnings when
something unexpected happens, they can be replaced with g_warning() so
that users of spice-server can redirect them with
g_log_set_default_handler().
Signed-off-by: Frediano Ziglio
---
src/channel-display.c | 6 +++---
1 file change
All usages of this macro were removed.
A library should not log to standard error but use log facilities
so remove this macro to avoid possible future usage.
Signed-off-by: Frediano Ziglio
---
common/log.h | 4
1 file changed, 4 deletions(-)
diff --git a/common/log.h b/common/log.h
index e
First thanks all for helping in my previous thread.
Since last answers were posted under a different thread title, I realized I
did make a mistake in trying to mix different topics in a single thread.
Sorry.
Back to topic, I think I'm still globally confused regarding where to get
all needed Windo
This avoids compilers detect misaligned access.
The structure is allocated at the beginning of a page so surely
will be 4 bytes aligned.
Aligning to 4 bytes maintains the size of the structure unchanged
avoiding possible ABI changes.
clang currently generates an invalid function call if a misaligne
On Wed, 2018-06-27 at 14:57 +0100, Frediano Ziglio wrote:
> Although source of these data should be safe improve data checks
> to avoid some overflows.
>
> Signed-off-by: Frediano Ziglio
> ---
> vdagent/vdagent.cpp | 13 ++---
> 1 file changed, 10 insertions(+), 3 deletions(-)
>
> diff
31 matches
Mail list logo
