[Spice-devel] [PATCH spice-server] red-channel-client: Do not allocate iovec array statically in the class

2018-06-18 Thread Frediano Ziglio
This array is just used locally in red_channel_client_handle_outgoing so declare it there. Signed-off-by: Frediano Ziglio --- server/red-channel-client.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/server/red-channel-client.c b/server/red-channel-client.c index 8

Re: [Spice-devel] Windows 10 KVM guest very slow in SPICE console

2018-06-18 Thread Frediano Ziglio
> > Hi, > > On Thu, Jun 14, 2018 at 12:04:22PM -0500, Carlos González wrote: > > Hello. > > > > I installed a Windows 10 KVM guest through libvirt on an > > openSUSE host. I use it with SPICE console through host's > > installed package virt-viewer. The guest uses qcow2 storage > > format, and ha

[Spice-devel] [PATCH spice-gtk] Support h265 streams

2018-06-18 Thread Snir Sheriber
This requires spice protocol v0.12.15 Signed-off-by: Snir Sheriber --- configure.ac | 6 +++--- src/channel-display-priv.h | 5 + 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/configure.ac b/configure.ac index 768e180..1cc3000 100644 --- a/configure.ac +++ b/co

[Spice-devel] [PATCH spice-common] protocol: Add support for h265 video codec

2018-06-18 Thread Snir Sheriber
Signed-off-by: Snir Sheriber --- spice.proto | 1 + 1 file changed, 1 insertion(+) diff --git a/spice.proto b/spice.proto index 6ee4766..e678ef8 100644 --- a/spice.proto +++ b/spice.proto @@ -359,6 +359,7 @@ enum8 video_codec_type { VP8, H264, VP9, +H265, }; flags8 stream_

[Spice-devel] [PATCH 0/0] Add support for h265/HEVC video codec

2018-06-18 Thread Snir Sheriber
This series adds support in h265 protocol to spice (intended for stream-channel streams) spice-common was also updated but bumping it in the other components and changing its required spice-protocol version does not seem necessary changed: spice-server spice-protocol spice-common spice-gtk --

[Spice-devel] [PATCH spice-protocol] Add support for h265 video codec

2018-06-18 Thread Snir Sheriber
Signed-off-by: Snir Sheriber --- spice/enums.h| 1 + spice/protocol.h | 1 + 2 files changed, 2 insertions(+) diff --git a/spice/enums.h b/spice/enums.h index f593777..34e84c3 100644 --- a/spice/enums.h +++ b/spice/enums.h @@ -162,6 +162,7 @@ typedef enum SpiceVideoCodecType { SPICE_VID

[Spice-devel] [PATCH spice-server] Support h265 in stream-channel

2018-06-18 Thread Snir Sheriber
And update required spice-protocol version to 0.12.15 Signed-off-by: Snir Sheriber --- configure.ac| 2 +- server/stream-channel.c | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index 2443ccf3..6cbd6a99 100644 --- a/configure.ac +++ b

[Spice-devel] [PATCH spice-server] reds: Remove possible alignment warning using Clang

2018-06-18 Thread Frediano Ziglio
Although capabilities inside link message are handled as arrays of 4 bytes unsigned integers we don't need capabilities to be aligned to 4 bytes just to call g_memdup so use a pointer to uint8_t instead. Signed-off-by: Frediano Ziglio --- server/reds.c | 4 ++-- 1 file changed, 2 insertions(+),

[Spice-devel] [PATCH spice-server] dcc: Use "base" as pipe item base field name

2018-06-18 Thread Frediano Ziglio
Most of pipe items use this name for the base field. This also allows to use SPICE_UPCAST macros instead of a long SPICE_CONTAINEROF. Signed-off-by: Frediano Ziglio --- server/dcc-send.c | 3 +-- server/dcc.c | 4 ++-- server/dcc.h | 2 +- 3 files changed, 4 insertions(+), 5 deletions(

Re: [Spice-devel] [PATCH 0/0] Add support for h265/HEVC video codec

2018-06-18 Thread Frediano Ziglio
> > This series adds support in h265 protocol to spice (intended for > stream-channel streams) > > spice-common was also updated but bumping it in the other components > and changing its required spice-protocol version does not seem necessary > > changed: > spice-server > spice-protocol > spice-

[Spice-devel] [PATCH spice-server v2] Use "base" as pipe item base field name

2018-06-18 Thread Frediano Ziglio
Most of pipe items use this name for the base field. This also allows to use SPICE_UPCAST macros instead of a long SPICE_CONTAINEROF. Signed-off-by: Frediano Ziglio --- server/dcc-send.c| 21 - server/dcc.c | 29 ++--

Re: [Spice-devel] [PATCH spice-server v2] Use "base" as pipe item base field name

2018-06-18 Thread Christophe Fergeau
Acked-by: Christophe Fergeau On Mon, Jun 18, 2018 at 11:29:38AM +0100, Frediano Ziglio wrote: > Most of pipe items use this name for the base field. > This also allows to use SPICE_UPCAST macros instead of a long > SPICE_CONTAINEROF. > > Signed-off-by: Frediano Ziglio > --- > server/dcc-send.

Re: [Spice-devel] [PATCH spice-server] reds: Remove possible alignment warning using Clang

2018-06-18 Thread Christophe Fergeau
Acked-by: Christophe Fergeau On Mon, Jun 18, 2018 at 10:38:53AM +0100, Frediano Ziglio wrote: > Although capabilities inside link message are handled as arrays > of 4 bytes unsigned integers we don't need capabilities to be > aligned to 4 bytes just to call g_memdup so use a pointer to > uint8_t

Re: [Spice-devel] [PATCH spice-server] red-channel-client: Do not allocate iovec array statically in the class

2018-06-18 Thread Christophe Fergeau
Acked-by: Christophe Fergeau On Mon, Jun 18, 2018 at 08:35:52AM +0100, Frediano Ziglio wrote: > This array is just used locally in red_channel_client_handle_outgoing > so declare it there. > > Signed-off-by: Frediano Ziglio > --- > server/red-channel-client.c | 9 - > 1 file changed,

Re: [Spice-devel] [spice-server 1/4] Update spice-common submodule

2018-06-18 Thread Frediano Ziglio
> > This brings in the following changes: > > Christophe Fergeau (21): > quic: Remove configurable RLE_PRED > quic: Remove configurable PRED > quic: Get rid of QUIC_RGB #define > quic: Get rid of RLE_STAT #define > quic: Get rid of RLE #define > quic: Factor co

Re: [Spice-devel] Spice console pixelated noise on display changes

2018-06-18 Thread Mitja Mihelič
On 14/06/2018 11:01, Frediano Ziglio wrote: Hi, On Wed, Jun 13, 2018 at 10:11:00AM +0200, Mitja Mihelič wrote: Dear all, We are running the following setup: ovirt-engine host: - CentOS release 7.5.1804 - ovirt-engine-4.1.9.1-1.el7.centos.noarch - spice-html5-0.1.7-1.el7.noarch We have notic

Re: [Spice-devel] [spice-server 4/4] build: Prepare for 0.14.1 release

2018-06-18 Thread Frediano Ziglio
> > Hi, > > On Fri, Jun 08, 2018 at 04:25:29PM +0200, Christophe Fergeau wrote: > > Signed-off-by: Christophe Fergeau > > --- > > NEWS | 23 +++ > > configure.ac | 2 +- > > spice-common | 2 +- > > 3 files changed, 25 insertions(+), 2 deletions(-) > > > > diff --

Re: [Spice-devel] [PATCH 0/0] Add support for h265/HEVC video codec

2018-06-18 Thread Christophe de Dinechin
As a follow up to the question I asked during the weekly meeting, what is the plan for selecting between codecs? Easy case: client and agent have only one shared codec combination. We have to pick that one. More complicated: say both sides support h264, vp9 and h265. Which one do we pick? Rig

[Spice-devel] [PATCH spice-server] build: Remove unsupported --enable-automated-tests option on make distcheck

2018-06-18 Thread Frediano Ziglio
--enable-automated-tests option was removed in commit 6517ea5cbb07b ("test-display-base: Always compile with AUTOMATED_TESTS enabled"). Signed-off-by: Frediano Ziglio --- Makefile.am | 1 - 1 file changed, 1 deletion(-) diff --git a/Makefile.am b/Makefile.am index cef44291..8acc019b 100644 ---

Re: [Spice-devel] [PATCH spice-server] build: Remove unsupported --enable-automated-tests option on make distcheck

2018-06-18 Thread Christophe de Dinechin
> On 18 Jun 2018, at 16:49, Frediano Ziglio wrote: > > --enable-automated-tests option was removed in commit 6517ea5cbb07b > ("test-display-base: Always compile with AUTOMATED_TESTS enabled"). > > Signed-off-by: Frediano Ziglio > --- > Makefile.am | 1 - > 1 file changed, 1 deletion(-) > > dif

Re: [Spice-devel] [spice-server 4/4] build: Prepare for 0.14.1 release

2018-06-18 Thread Christophe Fergeau
On Mon, Jun 18, 2018 at 10:24:11AM -0400, Frediano Ziglio wrote: > > > > Hi, > > > > On Fri, Jun 08, 2018 at 04:25:29PM +0200, Christophe Fergeau wrote: > > > Signed-off-by: Christophe Fergeau > > > --- > > > NEWS | 23 +++ > > > configure.ac | 2 +- > > > spice-com

Re: [Spice-devel] [PATCH 0/0] Add support for h265/HEVC video codec

2018-06-18 Thread Snir Sheriber
Hi, On 06/18/2018 05:27 PM, Christophe de Dinechin wrote: As a follow up to the question I asked during the weekly meeting, what is the plan for selecting between codecs? Easy case: client and agent have only one shared codec combination. We have to pick that one. More complicatwed: say bot

[Spice-devel] [PATCH spice-server] ci: Add make distcheck test

2018-06-18 Thread Frediano Ziglio
Signed-off-by: Frediano Ziglio --- .gitlab-ci.yml | 6 ++ 1 file changed, 6 insertions(+) Results example at https://gitlab.freedesktop.org/freddy77/spice/-/jobs/3912 diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index d9620e5f..becdb28b 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -4

Re: [Spice-devel] [PATCH v2 spice-streaming-agent 1/1] Adding gstreamer based plugin

2018-06-18 Thread Lukáš Hrázký
Hi Snir, mostly C++ and error handling notes :) I hope it's not too painful :D On Sun, 2018-06-10 at 11:14 +0300, Snir Sheriber wrote: > Gstreamer based plugin utilizing gstreamer elements to capture > screen from X, convert and encode into h264/vp8/vp9/mjpeg stream > Configure with --enable-gst

Re: [Spice-devel] On channel priority

2018-06-18 Thread Frediano Ziglio
> > Hi, > > I started looking at "webdav: copying big files makes the session > unusable" bug https://gitlab.freedesktop.org/spice/spice-gtk/issues/7, > and had a few ideas worth sharing. Of course, one of the problem with > this is how to measure the benefit when doing any additional tweaking. >

Re: [Spice-devel] [spice-server 3/4] docs: Add documentation for the streaming device

2018-06-18 Thread Christophe Fergeau
Ping? Christophe On Fri, Jun 08, 2018 at 04:25:28PM +0200, Christophe Fergeau wrote: > Signed-off-by: Christophe Fergeau > --- > docs/manual/manual.txt | 51 ++ > 1 file changed, 51 insertions(+) > > diff --git a/docs/manual/manual.txt b/docs/manual/manu

Re: [Spice-devel] [spice-server 4/4] build: Prepare for 0.14.1 release

2018-06-18 Thread Frediano Ziglio
> > On Mon, Jun 18, 2018 at 10:24:11AM -0400, Frediano Ziglio wrote: > > > > > > Hi, > > > > > > On Fri, Jun 08, 2018 at 04:25:29PM +0200, Christophe Fergeau wrote: > > > > Signed-off-by: Christophe Fergeau > > > > --- > > > > NEWS | 23 +++ > > > > configure.ac |

Re: [Spice-devel] [spice-server 3/4] docs: Add documentation for the streaming device

2018-06-18 Thread Frediano Ziglio
> > Ping? > > Christophe > > On Fri, Jun 08, 2018 at 04:25:28PM +0200, Christophe Fergeau wrote: > > Signed-off-by: Christophe Fergeau > > --- > > docs/manual/manual.txt | 51 ++ > > 1 file changed, 51 insertions(+) > > > > diff --git a/docs/manual/manu

Re: [Spice-devel] [PATCH spice-server 1/3] Add support for building with meson

2018-06-18 Thread Frediano Ziglio
Not much replies to this specific patch, but I agree was better to integrate dependencies (spice-protocol and spice-common) projects first. > > Signed-off-by: Eduardo Lima (Etrunko) > --- > Makefile.am | 3 + > docs/Makefile.am | 1 + > docs/manual/Makefile.am

Re: [Spice-devel] Windows 10 KVM guest very slow in SPICE console

2018-06-18 Thread Carlos González
>> I would suggest trying some SSD. >> >I don't think this is going to improve much if not nothing. >I have a SSD and a much more recent laptop. Windows 10 is slow using >local WiFi. This is caused by the graphic stack changes in Windows 10 >and the way currently optimizations are done for QXL by