Re: [Spice-devel] [spice-gtk v1 1/2] Revert "channel-usbredir: Fix crash on channel-up"

Hi, Could we have this revert for the release and then I'll open a bug to fix it properly during the next release? Once more, the patch that is being reverted fixes a crash on channel-up of channel-usbredir.c while running spicy-stats tool, see [0] - The crash can be avoided with a check done in

Re: [Spice-devel] [spice-gtk v1 1/2] Revert "channel-usbredir: Fix crash on channel-up"

Fine with me, hopefully we won't forget to fix this for good :-/ Acked-by: Christophe Fergeau Christophe On Mon, Jun 11, 2018 at 09:11:40AM +0200, Victor Toso wrote: > Hi, > > Could we have this revert for the release and then I'll open a > bug to fix it properly during the next release? > >

Re: [Spice-devel] [spice-gtk v1 1/2] Revert "channel-usbredir: Fix crash on channel-up"

Hi, On Mon, Jun 11, 2018 at 11:50:05AM +0200, Christophe Fergeau wrote: > Fine with me, hopefully we won't forget to fix this for good :-/ https://gitlab.freedesktop.org/spice/spice-gtk/issues/67 > Acked-by: Christophe Fergeau Thanks, I'll be pushing this shortly! Cheers, > Christophe > > O

[Spice-devel] [spice-gtk 1/2] Update spice-common

From: Victor Toso Christophe Fergeau (21): quic: Remove configurable RLE_PRED quic: Remove configurable PRED quic: Get rid of QUIC_RGB #define quic: Get rid of RLE_STAT #define quic: Get rid of RLE #define quic: Factor common code quic: Introduce CommonSt

[Spice-devel] [spice-gtk 2/2] Update NEWS for v0.35 release

From: Victor Toso Signed-off-by: Victor Toso --- NEWS | 24 1 file changed, 24 insertions(+) diff --git a/NEWS b/NEWS index e691583..dbfc1a3 100644 --- a/NEWS +++ b/NEWS @@ -1,3 +1,27 @@ +v0.35 += + +- TLS v1.0 was disabled (rhbz#1521053) +- New Add SpiceSession::d

[Spice-devel] [spice-gtk 0/2] spice-gtk v0.35 release

From: Victor Toso Hi, If nothing comes up, I'd like to do a release later Today of spice-gtk. Cheers, toso Victor Toso (2): Update spice-common Update NEWS for v0.35 release NEWS | 24 spice-common | 2 +- 2 files changed, 25 insertions(+), 1 del

Re: [Spice-devel] [spice-gtk 2/2] Update NEWS for v0.35 release

On Mon, Jun 11, 2018 at 01:32:37PM +0200, Victor Toso wrote: > From: Victor Toso > > Signed-off-by: Victor Toso > --- > NEWS | 24 > 1 file changed, 24 insertions(+) > > diff --git a/NEWS b/NEWS > index e691583..dbfc1a3 100644 > --- a/NEWS > +++ b/NEWS > @@ -1,3 +1,27

Re: [Spice-devel] [spice-gtk 2/2] Update NEWS for v0.35 release

Hi, Thanks! diff --git a/NEWS b/NEWS index dbfc1a3..840c78b 100644 --- a/NEWS +++ b/NEWS @@ -5,12 +5,12 @@ v0.35 - New Add SpiceSession::disconnected signal - Use GstVideoOverlay if possible to render directly on Gstreamer's sink element - Handling smooth-scroll for scroll events on touchpads

[Spice-devel] [spice-gtk v2 2/2] Update NEWS for v0.35 release

From: Victor Toso Signed-off-by: Victor Toso --- NEWS | 24 1 file changed, 24 insertions(+) diff --git a/NEWS b/NEWS index e691583..840c78b 100644 --- a/NEWS +++ b/NEWS @@ -1,3 +1,27 @@ +v0.35 += + +- TLS v1.0 was disabled (rhbz#1521053) +- New Add SpiceSession::d

Re: [Spice-devel] [spice-gtk 2/2] Update NEWS for v0.35 release

On Mon, Jun 11, 2018 at 02:46:51PM +0200, Victor Toso wrote: > Hi, > > Thanks! > > diff --git a/NEWS b/NEWS > index dbfc1a3..840c78b 100644 > --- a/NEWS > +++ b/NEWS > @@ -5,12 +5,12 @@ v0.35 > - New Add SpiceSession::disconnected signal "New Add" looks dubious too? > - Use GstVideoOverlay if

Re: [Spice-devel] [spice-gtk 2/2] Update NEWS for v0.35 release

Hi, On Mon, Jun 11, 2018 at 02:55:14PM +0200, Christophe Fergeau wrote: > On Mon, Jun 11, 2018 at 02:46:51PM +0200, Victor Toso wrote: > > Hi, > > > > Thanks! > > > > diff --git a/NEWS b/NEWS > > index dbfc1a3..840c78b 100644 > > --- a/NEWS > > +++ b/NEWS > > @@ -5,12 +5,12 @@ v0.35 > > - New A

Re: [Spice-devel] [spice-server v2] ci: Pass --enable-celt051 to configure

On Fri, Jun 08, 2018 at 08:08:48PM +0200, Christophe Fergeau wrote: > It's now mandatory to explicitly enable/disable CELT at configure time > if celt051-devel is installed. > > Signed-off-by: Christophe Fergeau Acked-by: Victor Toso > --- > I botched my testing of the previous version, this one

Re: [Spice-devel] [spice-server 2/4] build: Explicitly disable celt051 when running make distcheck

Hi, On Fri, Jun 08, 2018 at 04:25:27PM +0200, Christophe Fergeau wrote: > With spice-common commit 72b0d603e12, SPICE_CHECK_CELT051 will error out > if celt051-devel is installed, but neither --enable-celt051 nor > --disable-celt051 are specified. This could be a problem when running > make distch

Re: [Spice-devel] [spice-gtk v2 2/2] Update NEWS for v0.35 release

On Mon, Jun 11, 2018 at 02:48:05PM +0200, Victor Toso wrote: > From: Victor Toso > > Signed-off-by: Victor Toso > --- > NEWS | 24 > 1 file changed, 24 insertions(+) > > diff --git a/NEWS b/NEWS > index e691583..840c78b 100644 > --- a/NEWS > +++ b/NEWS > @@ -1,3 +1,27

Re: [Spice-devel] [spice-gtk 1/2] Update spice-common

Acked-by: Christophe Fergeau You probably need something like this for make distcheck/CI diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index a34eb0e7..e2c35ef9 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -10,7 +10,7 @@ before_script: makecheck: script: - - ./autogen.sh --enable-stat

[Spice-devel] [spice-gtk 1/3] Update spice-common

From: Victor Toso Christophe Fergeau (21): quic: Remove configurable RLE_PRED quic: Remove configurable PRED quic: Get rid of QUIC_RGB #define quic: Get rid of RLE_STAT #define quic: Get rid of RLE #define quic: Factor common code quic: Introduce CommonSt

[Spice-devel] [spice-gtk 3/3] Update NEWS for v0.35 release

From: Victor Toso Signed-off-by: Victor Toso Acked-by: Christophe Fergeau --- NEWS | 24 1 file changed, 24 insertions(+) diff --git a/NEWS b/NEWS index e691583..3f54f77 100644 --- a/NEWS +++ b/NEWS @@ -1,3 +1,27 @@ +v0.35 += + +- TLS v1.0 was disabled (rhbz#15210

[Spice-devel] [spice-gtk 2/3] build-sys: disable celt051 by default

From: Christophe Fergeau With spice-common commit 72b0d603e12, SPICE_CHECK_CELT051 will error out if celt051-devel is installed, but neither --enable-celt051 nor --disable-celt051 are specified. This could be a problem when running make distcheck, so this commit adds --disable-celt051 so that we