Re: [Spice-devel] [PATCH spice-gtk 1/4] Avoid clang warnings on casts with stricter alignment requirements

2017-05-11 Thread Frediano Ziglio
> > > > On 11 May 2017, at 10:17, Frediano Ziglio wrote: > > > >> > >> For example, something like this: > >> uint8_t *p8; > >> uint32_t *p32 = (uint32_t *) p8; > >> > >> generates a warning like this: > >> spice-channel.c:1350:10: error: cast from 'uint8_t *' (aka 'unsigned char > >> *'

Re: [Spice-devel] [PATCH spice-gtk 1/4] Avoid clang warnings on casts with stricter alignment requirements

2017-05-11 Thread Christophe de Dinechin
> On 11 May 2017, at 10:37, Frediano Ziglio wrote: > >> >> >>> On 11 May 2017, at 10:17, Frediano Ziglio wrote: >>> For example, something like this: uint8_t *p8; uint32_t *p32 = (uint32_t *) p8; generates a warning like this: spice-channel.c:1350:10:

Re: [Spice-devel] [PATCH spice-gtk 1/4] Avoid clang warnings on casts with stricter alignment requirements

2017-05-11 Thread Frediano Ziglio
... > > > > > g_array_set_size(c->remote_common_caps, num_common_caps); > > > > > > > > > > > > > > > for (i = 0; i < num_common_caps; i++, caps++) { > > > > > > > > > > > > I cannot find these macros defined in spice-gtk. Where are they? > > spice-common. I think I announced it in the

Re: [Spice-devel] [PATCH spice-gtk 5/5] display-gst: Use Playbin for GStreamer 1.9.0 onwards

2017-05-11 Thread Victor Toso
Hi, On Wed, May 10, 2017 at 03:41:40AM +, Daimon Wang wrote: > Ah, glad to know the difference. I'm using 1.2.4-1, where vaapi is not > the default.For versions before 1.9.0, maybe we can try with > "autoplug-select" signal, > from  > http://gstreamer-devel.966125.n4.nabble.com/Change-the-rank

Re: [Spice-devel] [spice-server v2 5/6] Make RedCharDeviceWriteBuffer::refs private

2017-05-11 Thread Christophe de Dinechin
> > On 28 Apr 2017, at 11:11, Christophe Fergeau wrote: > > Signed-off-by: Christophe Fergeau > --- > server/char-device.c | 11 ++- > server/char-device.h | 1 - > 2 files changed, 6 insertions(+), 6 deletions(-) > > diff --git a/server/char-device.c b/server/char-device.c > index 7e77

Re: [Spice-devel] [PATCH spice-gtk 1/4] Avoid clang warnings on casts with stricter alignment requirements

2017-05-11 Thread Christophe de Dinechin
> On 11 May 2017, at 11:17, Frediano Ziglio wrote: > > ... > > > > g_array_set_size(c->remote_common_caps, num_common_caps); > for (i = 0; i < num_common_caps; i++, caps++) { > > > I cannot find these macros defined in spice-gtk. Where are they? > > spice-common. I think I announced it

[Spice-devel] [PATCH spice-gtk v2 0/4] Another set of macOS pre-enablement patches

2017-05-11 Thread Christophe de Dinechin
From: Christophe de Dinechin This patch set eliminates warnings detected by clang with respect to type alignments. Vittorio Toso had submitted something similar. In this version, I took into account comments by Christophe Fergeau regarding how to know which casts were aligned and which ones were

[Spice-devel] [PATCH spice-gtk v2 4/4] Add check for macOS, disable ucontext on macOS (deprecated)

2017-05-11 Thread Christophe de Dinechin
From: Christophe de Dinechin Signed-off-by: Christophe de Dinechin --- configure.ac | 14 ++ 1 file changed, 14 insertions(+) diff --git a/configure.ac b/configure.ac index 74b5811..ecab365 100644 --- a/configure.ac +++ b/configure.ac @@ -62,6 +62,18 @@ esac AC_MSG_RESULT([$os_win

[Spice-devel] [PATCH spice-gtk v2 3/4] Remove warning about unused variable when building on macOS

2017-05-11 Thread Christophe de Dinechin
From: Christophe de Dinechin On macOS, neither of the two cases implemented in set_mouse_accel applies. We get the following eror message: CC spice-widget.lo spice-widget.c:944:26: error: unused variable 'd' [-Werror,-Wunused-variable] SpiceDisplayPrivate *d = display->priv; Signed-

[Spice-devel] [PATCH spice-gtk v2 2/4] Avoid warning about snprintf on non-Linux platforms

2017-05-11 Thread Christophe de Dinechin
From: Christophe de Dinechin Without #include , calls to snprintf in the file cause a warning. The file is left aside on purpose, since src/usbutil.c may be compiled on Windows where this file does not exist. Signed-off-by: Christophe de Dinechin --- src/usbutil.c | 2 +- 1 file changed, 1 in

[Spice-devel] [PATCH spice-gtk v2 1/4] Avoid clang warnings on casts with stricter alignment requirements

2017-05-11 Thread Christophe de Dinechin
From: Christophe de Dinechin For example, something like this: uint8_t *p8; uint32_t *p32 = (uint32_t *) p8; generates a warning like this: spice-channel.c:1350:10: error: cast from 'uint8_t *' (aka 'unsigned char *') to 'uint32_t *' (aka 'unsigned int *') increases required al

Re: [Spice-devel] [PATCH spice-gtk v2 4/4] Add check for macOS, disable ucontext on macOS (deprecated)

2017-05-11 Thread Daniel P. Berrange
On Thu, May 11, 2017 at 12:47:08PM +0200, Christophe de Dinechin wrote: > From: Christophe de Dinechin > > Signed-off-by: Christophe de Dinechin > --- > configure.ac | 14 ++ > 1 file changed, 14 insertions(+) > > diff --git a/configure.ac b/configure.ac > index 74b5811..ecab365 10

Re: [Spice-devel] [PATCH spice-gtk v2 4/4] Add check for macOS, disable ucontext on macOS (deprecated)

2017-05-11 Thread Frediano Ziglio
> > On Thu, May 11, 2017 at 12:47:08PM +0200, Christophe de Dinechin wrote: > > From: Christophe de Dinechin > > > > Signed-off-by: Christophe de Dinechin > > --- > > configure.ac | 14 ++ > > 1 file changed, 14 insertions(+) > > > > diff --git a/configure.ac b/configure.ac > > in

Re: [Spice-devel] [PATCH spice-gtk v2 4/4] Add check for macOS, disable ucontext on macOS (deprecated)

2017-05-11 Thread Daniel P. Berrange
On Thu, May 11, 2017 at 07:08:13AM -0400, Frediano Ziglio wrote: > > > > On Thu, May 11, 2017 at 12:47:08PM +0200, Christophe de Dinechin wrote: > > > From: Christophe de Dinechin > > > > > > Signed-off-by: Christophe de Dinechin > > > --- > > > configure.ac | 14 ++ > > > 1 file c

Re: [Spice-devel] Windows 10 guest: 2D/3D Accel

2017-05-11 Thread Michal Suchánek
On Tue, 9 May 2017 17:22:46 +0200 Oscar Segarra wrote: > Hi, Christophe, > > Thanks a lot again for the detailed explanation. > > I understand perfectly the difference between client, host and guest. > In my enviornment client is ferdora 25, host is Centos 7 and guest is > Windows 10. > > Rega

Re: [Spice-devel] [PATCH spice-server v4] sound: Remove sound channel global list

2017-05-11 Thread Jonathon Jongsma
On Tue, 2017-05-09 at 19:50 +0100, Frediano Ziglio wrote: > Use the channel list from RedState to iterate over all channels. By the way, this should be RedsState rather than RedState. > This removes one more global variable. > > Signed-off-by: Frediano Ziglio > --- >  server/reds.c  | 18 +

Re: [Spice-devel] [PATCH spice-gtk 0/5] Fix documentation strings

2017-05-11 Thread Jonathon Jongsma
ACK series On Wed, 2017-05-10 at 11:33 +0200, Pavel Grunt wrote: > Hi, > > I noticed that some symbol were not displayed in the gtk-doc > documentation. This series should improve that. > > Thanks, > > Pavel Grunt (5): >   doc: Set correct label >   doc: Remove invalid parameter of property >  

Re: [Spice-devel] [spice-server v2 5/6] Make RedCharDeviceWriteBuffer::refs private

2017-05-11 Thread Christophe Fergeau
On Thu, May 11, 2017 at 11:24:28AM +0200, Christophe de Dinechin wrote: > > > > On 28 Apr 2017, at 11:11, Christophe Fergeau wrote: > > > > Signed-off-by: Christophe Fergeau > > --- > > server/char-device.c | 11 ++- > > server/char-device.h | 1 - > > 2 files changed, 6 insertions(+), 6

[Spice-devel] [PATCH spice-gtk v2 0/5] Always use Playbin to create the pipeline

2017-05-11 Thread Victor Toso
From: Victor Toso -- v1-> v2: Adressing Frediano comments in v1 * Rebased * Removed caps="" for older version of GStreamer. No clear info on the issue that one had at that time. Still, video/x-h264 is the stream format that we receive and an error because of that should really be a bug in

[Spice-devel] [PATCH spice-gtk v2 3/5] display-gst: check GstRegistry for decoding elements

2017-05-11 Thread Victor Toso
From: Victor Toso With this patch, we can find all the elements in the registry that are video decoders which can handle the predefined GstCaps. Main benefits are: - We don't rely on predefined list of GstElements. We don't need to update them; - debugging: It does help to know what the regist

[Spice-devel] [PATCH spice-gtk v2 4/5] display-gst: remove SPICE_GSTVIDEO_AUTO check

2017-05-11 Thread Victor Toso
From: Victor Toso By using this environment variable, we could use decodebin to let GStreamer automatically find the best elements to get the streaming decoded. It was disable by default, in an attempt to have a easy way to test it. Follow up patch will use Playbin to create the pipeline which d

[Spice-devel] [PATCH spice-gtk v2 5/5] display-gst: Use Playbin for GStreamer 1.9.0 onwards

2017-05-11 Thread Victor Toso
From: Victor Toso The Playbin can provide the full pipeline which reduces the overall maintenance in the code as we don't need to track which decoder can work with our stream type. We need to maintain the GstCaps per SPICE_VIDEO_CODEC_TYPE in order to tell Playbin the type of data we expect. Thi

[Spice-devel] [PATCH spice-gtk v2 1/5] display-gst: include capabilities for h264

2017-05-11 Thread Victor Toso
From: Victor Toso Removing a comment in the code that says that incomplete GstCaps could trigger errors as this seems to be working fine. We should include all necessary parameters based on spice-protocol. At this time, the information we have from protocol is the stream-type which this patch inc

[Spice-devel] [PATCH spice-gtk v2 2/5] display-gst: move "caps=" from struct to pipeline

2017-05-11 Thread Victor Toso
From: Victor Toso This way we have a map of the necessary GstCaps to a given SPICE_VIDEO_CODEC_TYPE. This patch is also a preparatory patch to: - Identify which GstElements in GstRegistry can handle this GstCaps - Use Playbin as wrapper to all elements beside GstAppSrc and GstAppSink. In thi

Re: [Spice-devel] [PATCH spice-gtk v2 4/4] Add check for macOS, disable ucontext on macOS (deprecated)

2017-05-11 Thread Christophe de Dinechin
> On 11 May 2017, at 12:56, Daniel P. Berrange wrote: > > On Thu, May 11, 2017 at 12:47:08PM +0200, Christophe de Dinechin wrote: >> From: Christophe de Dinechin >> >> Signed-off-by: Christophe de Dinechin >> --- >> configure.ac | 14 ++ >> 1 file changed, 14 insertions(+) >> >> d