Re: [Spice-devel] [PATCH spice-protocol] Add support for VP9 video codec

2017-01-27 Thread Victor Toso
Hi, On Thu, Jan 26, 2017 at 12:31:34PM -0500, Frediano Ziglio wrote: > ping I agree with Christophe on > > Yes, I would wait until we have server/client patches using this > > before getting it in. > > > > Christophe I might have missed, but I did not see the patch encoding with vp9enc toso

Re: [Spice-devel] [PATCH spice-protocol] Add support for VP9 video codec

2017-01-27 Thread Frediano Ziglio
> > Hi, > > On Thu, Jan 26, 2017 at 12:31:34PM -0500, Frediano Ziglio wrote: > > ping > > I agree with Christophe on > > > > Yes, I would wait until we have server/client patches using this > > > before getting it in. > > > > > > Christophe > > I might have missed, but I did not see the patch

[Spice-devel] [PATCH qxl-wddm-dod] Do not take into account move operations for mapping

2017-01-27 Thread Frediano Ziglio
This is a follow up of 31ca5d035d2b24912044ef69ff23b3b854cd72dd ("Implements screen to screen move correctly"). As now we don't copy memory to implement moves there's no reason to take into account these area for memory mappings as memory is not accessed anymore. Signed-off-by: Frediano Ziglio -

Re: [Spice-devel] [PATCH spice-server] gstreamer: Include only needed fields in SpiceFormatForGStreamer structure

2017-01-27 Thread Christophe Fergeau
On Thu, Jan 26, 2017 at 10:07:47PM +, Frediano Ziglio wrote: > This structure is used to store format information for > both Gstreamer 0.10 and 1.0 however the two format uses > different fields from it. > Use a macro to filter only needed fields. > This currently also fixes a compile error usi

Re: [Spice-devel] [PATCH spice-jhbuild v2] Update repositories for virt-viewer and virt-manager

2017-01-27 Thread Christophe Fergeau
Acked-by: Christophe Fergeau On Thu, Jan 26, 2017 at 04:21:25PM -0200, Eduardo Lima (Etrunko) wrote: > fedorahosted.org is shutting down soon, and projects have migrated to > different locations. Virt-viewer moved to pagure.io, while virt-manger > is now hosted on github. > > https://www.redhat

Re: [Spice-devel] [PATCH spice-server] display-channel: Remove current_size field

2017-01-27 Thread Christophe Fergeau
Acked-by: Christophe Fergeau On Thu, Jan 26, 2017 at 06:17:53PM +, Frediano Ziglio wrote: > This field is used only for debugging. > Remove it reducing a bit all these "current" fields around. > > Signed-off-by: Frediano Ziglio > --- > server/display-channel-private.h | 1 - > server/disp

[Spice-devel] [PATCH spice-server v2] gstreamer: Include only needed fields in SpiceFormatForGStreamer structure

2017-01-27 Thread Frediano Ziglio
This structure is used to store format information for both Gstreamer 0.10 and 1.0 however the two format uses different fields from it. Use a macro to filter only needed fields. This currently also fixes a compile error using Gstreamer 0.10 (GST_VIDEO_FORMAT_RGB15 not defined as not available). S

Re: [Spice-devel] [PATCH spice-server] spicevmc: Check correctly rcc argument

2017-01-27 Thread Christophe Fergeau
On Thu, Jan 26, 2017 at 10:41:24AM -0500, Frediano Ziglio wrote: > > > > Do not check rcc after being use but before. > > > > Signed-off-by: Frediano Ziglio > > --- > > server/spicevmc.c | 7 +++ > > 1 file changed, 3 insertions(+), 4 deletions(-) > > > > diff --git a/server/spicevmc.c b/s

Re: [Spice-devel] [PATCH spice-server] reds-stream: Simplify error logic

2017-01-27 Thread Christophe Fergeau
On Thu, Jan 26, 2017 at 04:00:55PM +, Frediano Ziglio wrote: > Handling read returning 0 (usually end of connection/pipe) > is the same of handling an error (read result -1) with errno == 0 > so merge the two paths to reuse code and simplify. > > Signed-off-by: Frediano Ziglio > --- > > Patc

[Spice-devel] [PATCH spice-common] build-sys: don't dist spice-protocol.html

2017-01-27 Thread marcandre . lureau
From: Marc-André Lureau The HTML file is not built by default. This fixes make distcheck in spice-gtk. Signed-off-by: Marc-André Lureau --- docs/Makefile.am | 1 - 1 file changed, 1 deletion(-) diff --git a/docs/Makefile.am b/docs/Makefile.am index aa7c715..20f46ef 100644 --- a/docs/Makefile.

[Spice-devel] [PATCH spice-gtk] pygtk: remove bindings leftover

2017-01-27 Thread marcandre . lureau
From: Marc-André Lureau PyGtk 2.0 got removed in 0917002c48a0a5deb615d120a0e5997eefc89fd4, remove some remaining files. Signed-off-by: Marc-André Lureau --- src/Makefile.am | 2 - src/spice-client-gtk-manual.defs | 117 --- src/spice-client-gtk.overri

Re: [Spice-devel] [client v3 05/10] audio: Remove spice_audio_new() from the public header

2017-01-27 Thread Marc-André Lureau
Hi On Tue, Nov 1, 2016 at 1:20 PM Pavel Grunt wrote: > On Mon, 2016-10-31 at 17:15 +0100, Victor Toso wrote: > > Hi, > > > > On Thu, Oct 27, 2016 at 04:07:15PM -0500, Jonathon Jongsma wrote: > > > Seems OK to me. Looks like it was deprecated in Feb 2012. Anybody > > > else > > > have objections

Re: [Spice-devel] [PATCH spice-common] build-sys: don't dist spice-protocol.html

2017-01-27 Thread Frediano Ziglio
> > From: Marc-André Lureau > > The HTML file is not built by default. > This fixes make distcheck in spice-gtk. > > Signed-off-by: Marc-André Lureau > --- > docs/Makefile.am | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/docs/Makefile.am b/docs/Makefile.am > index aa7c715..20f46ef

[Spice-devel] [PATCH spice-gtk 0/4] Deprecation warnings

2017-01-27 Thread marcandre . lureau
From: Marc-André Lureau Hi, The following series fixes a few warnings related to deprecated symbols. Marc-André Lureau (4): Revert "audio: Remove spice_audio_new() from the public header" audio: fix deprecation warning Give a hint about spice_usb_device_manager_disconnect_device() dep

[Spice-devel] [PATCH spice-gtk 2/4] audio: fix deprecation warning

2017-01-27 Thread marcandre . lureau
From: Marc-André Lureau Use a private function to avoid the spice_audio_new() deprecation warning. Signed-off-by: Marc-André Lureau --- spice-common | 2 +- src/spice-audio-priv.h | 3 +++ src/spice-audio.c | 39 +++ src/spice-session.c|

[Spice-devel] [PATCH spice-gtk 3/4] Give a hint about spice_usb_device_manager_disconnect_device() deprecation

2017-01-27 Thread marcandre . lureau
From: Marc-André Lureau Signed-off-by: Marc-André Lureau --- src/usb-device-manager.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/usb-device-manager.h b/src/usb-device-manager.h index 219fe44..0376e49 100644 --- a/src/usb-device-manager.h +++ b/src/usb-device-manager

[Spice-devel] [PATCH spice-gtk 1/4] Revert "audio: Remove spice_audio_new() from the public header"

2017-01-27 Thread marcandre . lureau
From: Marc-André Lureau This reverts commit c6d9fa1c4af03d9875bf503ce6eabc9e7b52acc3. There is no rush to remove a deprecated API from public headers. It's better to do that when the whole library breaks API/ABI altogether. Signed-off-by: Marc-André Lureau --- src/spice-audio-priv.h | 2 -- s

[Spice-devel] [PATCH spice-gtk 4/4] usb: remove disconnect_device() deprecation warning

2017-01-27 Thread marcandre . lureau
From: Marc-André Lureau Use a static function instead of the deprecated public function. The usage of the function seems to be fine for sync case, since the device was already removed, but I added a TODO just in case someone looks at this code. Signed-off-by: Marc-André Lureau --- src/usb-dev

Re: [Spice-devel] [PATCH spice-gtk 3/4] Give a hint about spice_usb_device_manager_disconnect_device() deprecation

2017-01-27 Thread Marc-André Lureau
- Original Message - > From: Marc-André Lureau > > Signed-off-by: Marc-André Lureau > --- > src/usb-device-manager.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/usb-device-manager.h b/src/usb-device-manager.h > index 219fe44..0376e49 100644 > --- a/sr

Re: [Spice-devel] [PATCH spice-gtk 1/2] spice-gtk-session: Add sync modifiers property

2017-01-27 Thread Marc-André Lureau
H On Tue, May 3, 2016 at 5:41 PM Pavel Grunt wrote: > It will help in cases where syncing modifiers keys is complicated: > * not working leds for modifiers keys > * different keyboard layout on the guest side > Since it's only for testing (isn't it?), wouldn't an environment variable be a bet

Re: [Spice-devel] [PATCH spice-jhbuild v2] Update repositories for virt-viewer and virt-manager

2017-01-27 Thread Eduardo Lima (Etrunko)
On 01/27/2017 08:19 AM, Christophe Fergeau wrote: > > Acked-by: Christophe Fergeau > Puhsed, thank you. -- Eduardo de Barros Lima (Etrunko) Software Engineer - RedHat etru...@redhat.com signature.asc Description: OpenPGP digital signature ___ Spi

Re: [Spice-devel] [PATCH v6 4/5] vdagentd: early return on bad message size

2017-01-27 Thread Michal Suchánek
On Wed, 25 Jan 2017 08:24:55 +0100 Christophe Fergeau wrote: > On Tue, Jan 24, 2017 at 07:52:11PM +0100, Michal Suchánek wrote: > > On Tue, 24 Jan 2017 09:45:37 +0100 > > Christophe Fergeau wrote: > > > > > > In this big switch, VD_AGENT_FILE_XFER_* and > > > VD_AGENT_CLIENT_DISCONNECTED were

[Spice-devel] [PATCH v7 1/3] vdagentd: Quiet uninitialized variable warning.

2017-01-27 Thread Michal Suchanek
With gcc 6.2.1 I cannot build vdagentd because gcc detects msg_type as potentially uninitialized and vdagentd is built with -Werror. gcc 4.8.5 does not detect the issue and gcc 7 should be able to tell that do_client_file_xfer is called only with values of message_header->type handled in the switc

[Spice-devel] [PATCH v7 2/3] vdagentd: early return on bad message size

2017-01-27 Thread Michal Suchanek
From: Victor Toso The payload size for each message should be the size of the expected struct or bigger when it contain arrays of no fixed size. This patch creates the vdagent_message_min_size[] static array and function vdagent_message_check_size() that checks message size with the expected siz

[Spice-devel] [PATCH v7 3/3] vdagentd: Do endian swapping.

2017-01-27 Thread Michal Suchanek
This allows running big endian and little endian guest side by side using cut & paste between them. There is a general design idea that swapping should come as close to virtio_read/virtio_write as possible. In particular, the protocol between vdagent and vdagentd is guest-specific and in native en

Re: [Spice-devel] [PATCH spice-gtk] pygtk: remove bindings leftover

2017-01-27 Thread Pavel Grunt
ack On Fri, 2017-01-27 at 14:45 +0400, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > PyGtk 2.0 got removed in 0917002c48a0a5deb615d120a0e5997eefc89fd4, > remove some remaining files. > > Signed-off-by: Marc-André Lureau > --- >  src/Makefile.am  |   2 - >  sr