Change-Id: I4cc6dbe33d7d189d74189188ca18a46b85362237
Bug-Url: https://bugzilla.redhat.com/1398560
Signed-off-by: Yedidyah Bar David
---
win-guest-tools.nsis | 8
1 file changed, 8 insertions(+)
diff --git a/win-guest-tools.nsis b/win-guest-tools.nsis
index 2092edc..8d57d85 100644
--- a/
From: Christophe Fergeau
This requires WinVer from nsis 3.01.
At the moment, the qxl-wddm-dod driver on the virtio-win ISO is not the
latest one from
https://www.spice-space.org/download/windows/qxl-wddm-dod/
Change-Id: I773e4b76bd896fcea074b8f32a1b0cff854841b5
Signed-off-by: Christophe Fergeau
From: Christophe Fergeau
Change-Id: I36da80234227c610a246d33c867204241b32e536
Signed-off-by: Christophe Fergeau
---
Makefile | 4 ++--
ovirt-guest-tools-iso.spec.in | 6 +++---
version.txt | 4 ++--
3 files changed, 7 insertions(+), 7 deletions(-)
diff --
On Mon, Jan 23, 2017 at 5:23 PM, Christophe Fergeau wrote:
> Hey,
>
> On Mon, Jan 23, 2017 at 12:08:46PM +0200, Yedidyah Bar David wrote:
>> Hi all,
>>
>> I now posted here 3 patches. First two were posted by Christophe a few
>> weeks ago, and I amended them a bit, last is to add virtio-rng.
>
> S
Hey,
On Mon, Jan 23, 2017 at 02:53:54PM +0100, Michal Suchanek wrote:
> From: Victor Toso
>
> The payload size for each message should be the size of the expected
> struct or bigger when it contain arrays of no fixed size.
>
> This patch creates the vdagent_message_min_size[] static array with
Looks good to me,
Acked-by: Christophe Fergeau
On Mon, Jan 23, 2017 at 02:53:53PM +0100, Michal Suchanek wrote:
> Move some mouse-specific code from the start of
> virtio_port_read_complete to a separate helper
> as is the case with other message types.
>
> Signed-off-by: Michal Suchanek
> ---
On Tue, Jan 24, 2017 at 10:18:02AM +0200, Yedidyah Bar David wrote:
> On Mon, Jan 23, 2017 at 5:23 PM, Christophe Fergeau
> wrote:
> > Hey,
> >
> > On Mon, Jan 23, 2017 at 12:08:46PM +0200, Yedidyah Bar David wrote:
> >> Hi all,
> >>
> >> I now posted here 3 patches. First two were posted by Chri
On Tue, Jan 24, 2017 at 10:49 AM, Christophe Fergeau
wrote:
> On Tue, Jan 24, 2017 at 10:18:02AM +0200, Yedidyah Bar David wrote:
>> On Mon, Jan 23, 2017 at 5:23 PM, Christophe Fergeau
>> wrote:
>> > Hey,
>> >
>> > On Mon, Jan 23, 2017 at 12:08:46PM +0200, Yedidyah Bar David wrote:
>> >> Hi all,
ACK to the changes on top of the initial patch.
Christophe
On Tue, Jan 24, 2017 at 10:16:20AM +0200, Yedidyah Bar David wrote:
> From: Christophe Fergeau
>
> Change-Id: I36da80234227c610a246d33c867204241b32e536
> Signed-off-by: Christophe Fergeau
> ---
> Makefile | 4 ++--
On Tue, Jan 24, 2017 at 09:57:33AM +0200, Yedidyah Bar David wrote:
> The referenced nsis-simple-service-plugin-1.30-2 was built in oVirt's
> jenkins [1] from the spec file in [2].
>
> [1]
> http://jenkins.ovirt.org/job/nsis-simple-service-plugin_master_create-rpms-fc24-x86_64_merged/4/
> [2]
>
Changes on top of my initial patch look good.
Christophe
On Tue, Jan 24, 2017 at 10:16:19AM +0200, Yedidyah Bar David wrote:
> From: Christophe Fergeau
>
> This requires WinVer from nsis 3.01.
> At the moment, the qxl-wddm-dod driver on the virtio-win ISO is not the
> latest one from
> https://
On Sat, Jan 21, 2017 at 04:30:02AM -0500, Frediano Ziglio wrote:
> >
> > On Tue, Jan 10, 2017 at 02:20:39PM +, Frediano Ziglio wrote:
> > > This format is required to add metadata.
> > > These metadata can be used to pass different strides or additional
> > > information to pass dma buffers.
>
On Tue, Jan 24, 2017 at 10:16:21AM +0200, Yedidyah Bar David wrote:
> Change-Id: I4cc6dbe33d7d189d74189188ca18a46b85362237
> Bug-Url: https://bugzilla.redhat.com/1398560
> Signed-off-by: Yedidyah Bar David
> ---
> win-guest-tools.nsis | 8
> 1 file changed, 8 insertions(+)
>
> diff --gi
On Mon, Jan 23, 2017 at 02:53:52PM +0100, Michal Suchanek wrote:
> The message types are defined by the protocol so the same array is
> always passed into the server anyway. So define the array size to be the
> number of message types and just use the array and limit directly in
> udscs. If somebod
From: Sebastian Andrzej Siewior
The latter is deprecated, so might be removed at some point in the
future. This also adds a compatibility wrapper for OpenSSL < 1.1.0.
Signed-off-by: Sebastian Andrzej Siewior
Signed-off-by: Christophe Fergeau
---
Here is the patch with a FIXME, I have a sligh
On Tue, Jan 24, 2017 at 11:10 AM, Christophe Fergeau
wrote:
> On Tue, Jan 24, 2017 at 10:16:21AM +0200, Yedidyah Bar David wrote:
>> Change-Id: I4cc6dbe33d7d189d74189188ca18a46b85362237
>> Bug-Url: https://bugzilla.redhat.com/1398560
>> Signed-off-by: Yedidyah Bar David
>> ---
>> win-guest-tools
On Tue, Jan 24, 2017 at 11:51:25AM +0200, Yedidyah Bar David wrote:
> Also acked your patches, pushed, and merged in both oVirt gerrit and
> gitlab. Thanks for the reviews!
Cool, thanks!
Christophe
signature.asc
Description: PGP signature
___
Spice-de
stat_file->stat has already been dereferenced by the time the check is
done. This commit moves it earlier, before the first dereference
attempt.
---
server/stat-file.c | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/server/stat-file.c b/server/stat-file.c
index de455b6..
Initializing 'node' to NULL silences this warning:
stat-file.c: In function 'stat_file_add_node':
stat-file.c:180:15: error: 'node' may be used uninitialized in this function
[-Werror=maybe-uninitialized]
g_strlcpy(node->name, name, sizeof(node->name));
^~~~
cc1: all warnings
>
> stat_file->stat has already been dereferenced by the time the check is
> done. This commit moves it earlier, before the first dereference
> attempt.
> ---
> server/stat-file.c | 8 +++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/server/stat-file.c b/server/stat-fil
Changes since v6:
- merged some patches;
- updated a commit message.
Changes since v5:
- fix some typos;
- removed some inlines from some replacement functions;
- simplify setting video metadata to avoid image copying.
Changes since v4:
- merged some patches;
- fix include file name;
- use G_OPTI
Signed-off-by: Frediano Ziglio
---
server/tests/Makefile.am| 1 +
server/tests/video-encoders | 21 +
2 files changed, 22 insertions(+)
create mode 100755 server/tests/video-encoders
diff --git a/server/tests/Makefile.am b/server/tests/Makefile.am
index f696f9f..a6570e7
This format is required to add metadata to the source buffer
using gst_buffer_add_video_meta_full.
This metadata can be used to pass strides/offsets, or
dmabuf-specific information.
Signed-off-by: Frediano Ziglio
---
server/gstreamer-encoder.c | 12 +++-
1 file changed, 7 insertions(+),
If bitmap stride and stream stride are different copy was used.
Using GStreamer 1.0 you can avoid the copy setting correctly
image offset and stride.
Signed-off-by: Frediano Ziglio
---
server/gstreamer-encoder.c | 22 ++
1 file changed, 18 insertions(+), 4 deletions(-)
diff
Filter out commands which should not happen. Should it be a
g_warn_if_fail() or such instead?
Based on a patch from Frediano Ziglio
Signed-off-by: Christophe Fergeau
---
server/sound.c | 4
1 file changed, 4 insertions(+)
diff --git a/server/sound.c b/server/sound.c
index 1f88149..a53ebc
We can use the marshaller provided by the dummy RedChannelClient
associated with SndChannelClient.
Based on a patch from Frediano Ziglio
Signed-off-by: Christophe Fergeau
---
server/sound.c | 49 -
1 file changed, 28 insertions(+), 21 deletions(-
It's ok to remove it because ?
Based on a patch from Frediano Ziglio
Signed-off-by: Christophe Fergeau
---
server/sound.c | 9 -
1 file changed, 9 deletions(-)
diff --git a/server/sound.c b/server/sound.c
index 28a290c..6025972 100644
--- a/server/sound.c
+++ b/server/sound.c
@@ -1475
We can get it from our DummyChannelClient rather than storing it in
SndChannelClient.
Based on a patch from Frediano Ziglio
Signed-off-by: Christophe Fergeau
---
server/sound.c | 21 +++--
1 file changed, 11 insertions(+), 10 deletions(-)
diff --git a/server/sound.c b/server/s
This is in preparation for making them inherit from RedChannelClient.
Doing it in one go would result in a very huge commit, so this commit
starts by turning these into GObjects, while still using a
DummyChannelClient instance for sending the data.
Based on a patch from Frediano Ziglio
Signed-of
Hey,
This series is an attempt at splitting "sound: Convert SndChannelClient to
GObject"
https://lists.freedesktop.org/archives/spice-devel/2017-January/034773.html
in much smaller chunks to ease reviews, and make git history more usable.
This might be a bit artificial at times (especially the co
SndChannelClient is now inheriting from GObject, and has switched
from using its own code for sending data to using RedChannelClient.
This commit makes it directly inherit from RedChannelClient rather than
having a channel_client field. This allows to get rid of the whole
DummyChannel/DummyChannelC
snd_set_command()/snd_send() are higher level methods which take care of
scheduling calls to the corresponding snd_*_send_*() methods when
appropriate. This commit switches a few direct snd_*_send_*() calls to
snd_set_command()/snd_send().
Based on a patch from Frediano Ziglio
Signed-off-by: Chr
On Tue, Jan 24, 2017 at 11:50:03AM +, Frediano Ziglio wrote:
> This format is required to add metadata to the source buffer
> using gst_buffer_add_video_meta_full.
> This metadata can be used to pass strides/offsets, or
> dmabuf-specific information.
>
> Signed-off-by: Frediano Ziglio
Acked-
You can see that SndChannelClient has much less field
as the code to read/write from/to client is reused from
RedChannelClient instead of creating a fake RedChannelClient
just to make the system happy.
One of the different between the old sound code and all other
RedChannelClient objects was that
Missing detailed log...
Based on a patch from Frediano Ziglio
Signed-off-by: Christophe Fergeau
---
server/sound.c | 11 +++
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/server/sound.c b/server/sound.c
index bacd340..2165644 100644
--- a/server/sound.c
+++ b/server/sou
This is in preparation for switching SndChannelClient into a proper
RedChannelClient. The prototype of the new helper matches what is
expected from the RedChannel::config_socket vfunc.
To be able to achieve that, this commit associates the sound channel
RedsStream instance with the DummyChannelCli
stat_file->stat has already been dereferenced by the time the check is
done. This commit moves it earlier, before the first dereference
attempt.
---
server/stat-file.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/server/stat-file.c b/server/stat-file.c
index de455b6..b98
Initializing 'node' to NULL silences this warning:
stat-file.c: In function 'stat_file_add_node':
stat-file.c:180:15: error: 'node' may be used uninitialized in this function
[-Werror=maybe-uninitialized]
g_strlcpy(node->name, name, sizeof(node->name));
^~~~
cc1: all warnings
On Tue, Jan 24, 2017 at 06:41:04AM -0500, Frediano Ziglio wrote:
> >
> > stat_file->stat has already been dereferenced by the time the check is
> > done. This commit moves it earlier, before the first dereference
> > attempt.
> > ---
> > server/stat-file.c | 8 +++-
> > 1 file changed, 7 inse
On Tue, Jan 24, 2017 at 11:50:04AM +, Frediano Ziglio wrote:
> If bitmap stride and stream stride are different copy was used.
> Using GStreamer 1.0 you can avoid the copy setting correctly
> image offset and stride.
>
> Signed-off-by: Frediano Ziglio
> ---
> server/gstreamer-encoder.c | 22
>
> On Tue, Jan 10, 2017 at 03:59:38PM +, Frediano Ziglio wrote:
> > Code to read and process display commands were the same
> > so use a common function for better reuse.
> >
> > Signed-off-by: Frediano Ziglio
> > ---
> > server/red-worker.c | 38 ++
> >
>
> On Tue, Jan 24, 2017 at 11:50:04AM +, Frediano Ziglio wrote:
> > If bitmap stride and stream stride are different copy was used.
> > Using GStreamer 1.0 you can avoid the copy setting correctly
> > image offset and stride.
> >
> > Signed-off-by: Frediano Ziglio
> > ---
> > server/gstrea
On Tue, Jan 24, 2017 at 07:26:15AM -0500, Frediano Ziglio wrote:
> >
> > On Tue, Jan 10, 2017 at 03:59:38PM +, Frediano Ziglio wrote:
> > > Code to read and process display commands were the same
> > > so use a common function for better reuse.
> > >
> > > Signed-off-by: Frediano Ziglio
> >
>
> On Tue, Jan 24, 2017 at 07:26:15AM -0500, Frediano Ziglio wrote:
> > >
> > > On Tue, Jan 10, 2017 at 03:59:38PM +, Frediano Ziglio wrote:
> > > > Code to read and process display commands were the same
> > > > so use a common function for better reuse.
> > > >
> > > > Signed-off-by: Fred
>
> Missing detailed log...
>
Maybe:
Set error results before any error handling to
make easier returning on error conditions.
Split error condition in order to avoid to use a pointer
before NULL check.
> Based on a patch from Frediano Ziglio
>
> Signed-off-by: Christophe Fergeau
> ---
> s
Removed from code in a7565265532f6abec0fd3c6d843683b58eee070a
---
doc/reference/spice-gtk-sections.txt | 2 --
1 file changed, 2 deletions(-)
diff --git a/doc/reference/spice-gtk-sections.txt
b/doc/reference/spice-gtk-sections.txt
index 386e737..f2235e8 100644
--- a/doc/reference/spice-gtk-secti
>
> This is in preparation for switching SndChannelClient into a proper
> RedChannelClient. The prototype of the new helper matches what is
> expected from the RedChannel::config_socket vfunc.
>
> To be able to achieve that, this commit associates the sound channel
> RedsStream instance with the
Change-Id: If2403d6801e7970bf1b7b88ff271b9c0e28d2628
Signed-off-by: Yedidyah Bar David
---
ovirt-guest-tools-iso.spec.in | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/ovirt-guest-tools-iso.spec.in b/ovirt-guest-tools-iso.spec.in
index e51dea9..04fee49 100644
--- a/ovirt-
On Tue, Jan 24, 2017 at 07:35:25AM -0500, Frediano Ziglio wrote:
> > > + * stride is different simply passing appropriate offset and
> > > stride */
> > > +gsize offset = src->left * encoder->format->bpp / 8;
> > > +gint stride = bitmap->stride;
> > > +gst_buffer_add
>
> Filter out commands which should not happen. Should it be a
> g_warn_if_fail() or such instead?
>
> Based on a patch from Frediano Ziglio
>
> Signed-off-by: Christophe Fergeau
> ---
> server/sound.c | 4
> 1 file changed, 4 insertions(+)
>
> diff --git a/server/sound.c b/server/soun
>
> We can use the marshaller provided by the dummy RedChannelClient
> associated with SndChannelClient.
>
> Based on a patch from Frediano Ziglio
>
> Signed-off-by: Christophe Fergeau
Acked
> ---
> server/sound.c | 49 -
> 1 file changed, 28
>
> We can get it from our DummyChannelClient rather than storing it in
> SndChannelClient.
>
> Based on a patch from Frediano Ziglio
>
> Signed-off-by: Christophe Fergeau
Acked
> ---
> server/sound.c | 21 +++--
> 1 file changed, 11 insertions(+), 10 deletions(-)
>
> diff
ack
- Original Message -
> Removed from code in a7565265532f6abec0fd3c6d843683b58eee070a
> ---
> doc/reference/spice-gtk-sections.txt | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/doc/reference/spice-gtk-sections.txt
> b/doc/reference/spice-gtk-sections.txt
> index 386e737..f
>
> It's ok to remove it because ?
>
> Based on a patch from Frediano Ziglio
>
> Signed-off-by: Christophe Fergeau
Because I hate polling and was removed time ago :)
Really, now RedChannelClient try to send/receive data when it can
reducing latency.
This code was here as it was possible that
>
> snd_set_command()/snd_send() are higher level methods which take care of
> scheduling calls to the corresponding snd_*_send_*() methods when
> appropriate. This commit switches a few direct snd_*_send_*() calls to
> snd_set_command()/snd_send().
>
> Based on a patch from Frediano Ziglio
>
>
>
> On Tue, Jan 24, 2017 at 07:35:25AM -0500, Frediano Ziglio wrote:
> > > > + * stride is different simply passing appropriate offset and
> > > > stride */
> > > > +gsize offset = src->left * encoder->format->bpp / 8;
> > > > +gint stride = bitmap->stride;
> > > > +
Acked-by: Christophe Fergeau
On Tue, Jan 24, 2017 at 03:44:27PM +0200, Yedidyah Bar David wrote:
> Change-Id: If2403d6801e7970bf1b7b88ff271b9c0e28d2628
> Signed-off-by: Yedidyah Bar David
> ---
> ovirt-guest-tools-iso.spec.in | 5 -
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> dif
On Tue, Jan 24, 2017 at 4:29 PM, Christophe Fergeau wrote:
>
> Acked-by: Christophe Fergeau
Thanks. Pushed to gitlab. Didn't create a merge request but pushed directly -
hope that's ok. Otherwise please explain the flow you want in such cases.
>
> On Tue, Jan 24, 2017 at 03:44:27PM +0200, Yedid
>
> Initializing 'node' to NULL silences this warning:
>
> stat-file.c: In function 'stat_file_add_node':
> stat-file.c:180:15: error: 'node' may be used uninitialized in this function
> [-Werror=maybe-uninitialized]
> g_strlcpy(node->name, name, sizeof(node->name));
>^~~~
>
On Mon, 23 Jan 2017 16:58:14 +0100
Michal Suchánek wrote:
> On Mon, 23 Jan 2017 15:40:57 +0100
> Christophe de Dinechin wrote:
>
> > On 23/01/2017 14:53, Michal Suchanek wrote:
> > > This allows running big endian and little endian guest side by
> > > side using cut & paste between them.
> >
Hi,
as it looks somebody is touching this part of code.
Looking at APIs (stat-file.h) we have these functions:
RedStatFile *stat_file_new(unsigned int max_nodes);
void stat_file_free(RedStatFile *stat_file);
void stat_file_unlink(RedStatFile *file_stat);
const char *stat_file_get_shm_name(RedSt
61 matches
Mail list logo
