Re: [Spice-devel] [PATCH spice-gtk v5 4/9] channel-display: implement preferred video codec msgc

2017-01-19 Thread Pavel Grunt
Hi Victor, On Thu, 2017-01-19 at 08:46 +0100, Victor Toso wrote: > Hi, > > On Wed, Jan 18, 2017 at 11:27:40AM +0100, Pavel Grunt wrote: > > Hi Victor, > > > > On Fri, 2017-01-06 at 09:18 +0100, Victor Toso wrote: > > > From: Victor Toso > > > > > > * SPICE_MSGC_DISPLAY_PREFERRED_VIDEO_CODEC_TY

Re: [Spice-devel] [PATCH spice-gtk v5 4/9] channel-display: implement preferred video codec msgc

2017-01-19 Thread Victor Toso
Hi, On Thu, Jan 19, 2017 at 09:09:58AM +0100, Pavel Grunt wrote: > Hi Victor, > > On Thu, 2017-01-19 at 08:46 +0100, Victor Toso wrote: > > Hi, > > > > On Wed, Jan 18, 2017 at 11:27:40AM +0100, Pavel Grunt wrote: > > > Hi Victor, > > > > > > On Fri, 2017-01-06 at 09:18 +0100, Victor Toso wrote:

[Spice-devel] Fwd: Dreadful performance under Windows 10 Enterprise 2016 LTSB

2017-01-19 Thread George Diamantopoulos
Forgot to add spice-devel to recipients list. Forwarding message... On 10 January 2017 at 11:34, Frediano Ziglio wrote: > On 10 January 2017 at 10:34, Pavel Grunt wrote: > >> Hi, >> >> On Tue, 2017-01-10 at 10:06 +0200, George Diamantopoulos wrote: >> > Hello all, >> > >> > I'm trying out qxl-dod

Re: [Spice-devel] [PATCH spice-server v5 7/9] reds: drop sscanf() in favour of g_strsplit()

2017-01-19 Thread Uri Lublin
On 01/06/2017 10:19 AM, Victor Toso wrote: From: Victor Toso As there is a need to iterate over every encoder:codec pair and we do a check for every encoder and every codec, g_strsplit() is less complex and easier to follow. This change makes much easier to extend the input which is currently

Re: [Spice-devel] [PATCH spice-html5] Only drop an mjpeg frame if we are not currently processing one.

2017-01-19 Thread Pavel Grunt
On Thu, 2016-12-29 at 15:28 -0600, Jeremy White wrote: > Signed-off-by: Jeremy White > --- >  display.js | 11 +-- >  1 file changed, 9 insertions(+), 2 deletions(-) > > diff --git a/display.js b/display.js > index 6691c5e..c450088 100644 > --- a/display.js > +++ b/display.js > @@ -582,7 +

Re: [Spice-devel] [PATCH spice-server v5 7/9] reds: drop sscanf() in favour of g_strsplit()

2017-01-19 Thread Victor Toso
Hi, On Thu, Jan 19, 2017 at 12:14:06PM +0200, Uri Lublin wrote: > On 01/06/2017 10:19 AM, Victor Toso wrote: > > From: Victor Toso > > > > As there is a need to iterate over every encoder:codec pair and we do > > a check for every encoder and every codec, g_strsplit() is less > > complex and easi

[Spice-devel] [spice-gtk] Move spicy tools to its own folder

2017-01-19 Thread Victor Toso
From: Victor Toso So we can have the tools and the libraries in different folders. - In the src/Makefile.am I've only removed the lines related to the tools but not all lines were copied into tools/Makefile.am as we don't really need them. Other lines were adjusted to have the paths correc

Re: [Spice-devel] [spice-gtk] Move spicy tools to its own folder

2017-01-19 Thread Christophe Fergeau
On Thu, Jan 19, 2017 at 02:16:14PM +0100, Victor Toso wrote: > From: Victor Toso > > So we can have the tools and the libraries in different folders. > > - In the src/Makefile.am I've only removed the lines related to the > tools but not all lines were copied into tools/Makefile.am as we > d

Re: [Spice-devel] Dreadful performance under Windows 10 Enterprise 2016 LTSB

2017-01-19 Thread Christophe Fergeau
On Tue, Jan 10, 2017 at 10:06:33AM +0200, George Diamantopoulos wrote: > Hello all, > > I'm trying out qxl-dod in a new installation, and performance is so low > that the guest is practically unusable. Redrawing takes about 4-5 seconds. > I have used qxl-dod in the past on the same hardware with m

[Spice-devel] [spice-gtk v2] Move spicy tools to its own folder

2017-01-19 Thread Victor Toso
From: Victor Toso So we can have the tools and the libraries in different folders. In the src/Makefile.am I've only removed the lines related to the tools but not all lines were copied into tools/Makefile.am as we don't really need them. Other lines were adjusted to have the paths correctly; Si

Re: [Spice-devel] [spice-gtk v2] Move spicy tools to its own folder

2017-01-19 Thread Christophe Fergeau
You need diff --git a/tools/Makefile.am b/tools/Makefile.am index 204dc50..0bdb3c5 100644 --- a/tools/Makefile.am +++ b/tools/Makefile.am @@ -2,6 +2,7 @@ bin_PROGRAMS = spicy-stats spicy-screenshot TOOLS_CPPFLAGS = \ -DSPICE_COMPILATION \ + -I$(top

[Spice-devel] [PATCH v3 1/2] autotools: Add automake conditional for gstreamer

2017-01-19 Thread Snir Sheriber
Adding conditional for having gstreamer_0_10 or gstreamer_1_0, removing the previous conditionals and update relevant ifdefs with the newly defined conditional --- configure.ac | 3 +-- server/Makefile.am | 8 +--- server/reds.c | 4 ++

Re: [Spice-devel] [client] streaming: Fix a race condition in the GStreamer frame display queue

2017-01-19 Thread Christophe Fergeau
Hi, I've now pushed this patch with the amended log, hopefully it was correct ;) Christophe On Tue, Jan 03, 2017 at 10:56:49AM +0100, Christophe Fergeau wrote: > Hey, > > On Fri, Dec 23, 2016 at 04:07:49PM +0100, Francois Gouget wrote: > > When a frame is late we schedule its display right away

Re: [Spice-devel] [PATCH v4] Do endian swapping.

2017-01-19 Thread Victor Toso
Hi, On Fri, Jan 13, 2017 at 07:32:12PM +0100, Michal Suchanek wrote: > This allows running big endian and little endian guest side by side using > cut & paste between them. > > There is a general design idea that swapping should come as close to > virtio_read/virtio_write as possible. In particula

Re: [Spice-devel] [spice-gtk v2] Move spicy tools to its own folder

2017-01-19 Thread Victor Toso
Hi, On Thu, Jan 19, 2017 at 03:27:21PM +0100, Christophe Fergeau wrote: > You need > > diff --git a/tools/Makefile.am b/tools/Makefile.am > index 204dc50..0bdb3c5 100644 > --- a/tools/Makefile.am > +++ b/tools/Makefile.am > @@ -2,6 +2,7 @@ bin_PROGRAMS = spicy-stats spicy-screenshot > > TOOLS_CPP

Re: [Spice-devel] [PATCH v3 1/2] autotools: Add automake conditional for gstreamer

2017-01-19 Thread Christophe Fergeau
On Thu, Jan 19, 2017 at 04:29:18PM +0200, Snir Sheriber wrote: > Adding conditional for having gstreamer_0_10 or gstreamer_1_0, > removing the previous conditionals and update relevant ifdefs > with the newly defined conditional > --- > configure.ac | 3 +-- > server/Makefile

Re: [Spice-devel] [spice-common] ssl: Use ASN1_STRING_get0_data instead of ASN1_STRING_data

2017-01-19 Thread Christophe Fergeau
On Tue, Jan 17, 2017 at 03:19:00PM +0100, Victor Toso wrote: > Hi, > > On Fri, Jan 13, 2017 at 12:12:50PM +0100, Christophe Fergeau wrote: > > From: Sebastian Andrzej Siewior > > > > The latter is deprecated, so might be removed at some point in the > > future. This also adds a compatibility wra

[Spice-devel] [PATCH] Move mouse-specific handling out of virtio_port_read_complete

2017-01-19 Thread Michal Suchanek
Move some mouse-specific code from the start of virtio_port_read_complete to a separate helper as is the case with other message types. Signed-off-by: Michal Suchanek --- src/vdagentd/vdagentd.c | 43 --- 1 file changed, 24 insertions(+), 19 deletions(-)