>
> Looks fine, though it looks like there's also a few additions
> (
> Acked-by: Jonathon Jongsma
>
It seems jpeg includes are not self sufficient so the
additional stdio.h include
Frediano
>
> On Thu, 2016-12-08 at 18:32 +, Frediano Ziglio wrote:
> > Sort based on coding style.
> >
>
On Fri, Dec 16, 2016 at 03:38:09AM -0500, Frediano Ziglio wrote:
> >
> > Looks fine, though it looks like there's also a few additions
> > ( >
> > Acked-by: Jonathon Jongsma
> >
>
> It seems jpeg includes are not self sufficient so the
> additional stdio.h include
This belongs in the log then
>
> On Wed, 2016-12-14 at 16:03 -0500, Frediano Ziglio wrote:
> > >
> > >
> > > The fill_bits() function marshalls some data by reference. This
> > > data is
> > > owned by the RedDrawable that is owned by the Drawable that is
> > > owned by
> > > the RedDrawablePipeItem. Instead of keeping the
>
> Move all 'out' parameters to the end of the function.
Acked-by: Frediano Ziglio
> ---
> server/cursor-channel.c | 8
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/server/cursor-channel.c b/server/cursor-channel.c
> index dedee37..04483af 100644
> --- a/serv
Remove unused field
Signed-off-by: Frediano Ziglio
---
server/red-channel-client-private.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/server/red-channel-client-private.h
b/server/red-channel-client-private.h
index 76c9574..593fee5 100644
--- a/server/red-channel-client-private.h
+++ b/s
> On Fri, Dec 16, 2016 at 03:38:09AM -0500, Frediano Ziglio wrote:
> > >
> > > Looks fine, though it looks like there's also a few additions
> > > ( > >
> > > Acked-by: Jonathon Jongsma
> > >
> >
> > It seems jpeg includes are not self sufficient so the
> > additional stdio.h include
>
> Thi
>
> >
> > On Wed, 2016-12-14 at 16:03 -0500, Frediano Ziglio wrote:
> > > >
> > > >
> > > > The fill_bits() function marshalls some data by reference. This
> > > > data is
> > > > owned by the RedDrawable that is owned by the Drawable that is
> > > > owned by
> > > > the RedDrawablePipeItem. I
> The only time that the pipe item needs to be passed as the third
> argument to red_channel_client_init_send_data() is when the pipe item
> holds a data buffer that has been added to the marshaller by reference
> (spice_marshaller_add_by_ref()) and needs to be kept alive until the
> data has been
Execue me, you know, Spice supports two mouse modes: server and client.
Now, I want to know the details about server mouse modes. When setting server
mode about mouse,
What I need to do any work or change on servers? If you have any suggestions,
you could tell me.
Thank you very very much!
__
Ack the series
Pavel
On Thu, 2016-12-15 at 10:46 -0600, Jeremy White wrote:
> They are fairly noisy, and more appropriate to the
> more detailed level.
>
> Signed-off-by: Jeremy White
> ---
> display.js | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/display.js b/di
> Use spice_marshaller_add_by_ref_full() instead of
> spice_marshaller_add_by_ref() to allow the marshaller to manage the
> lifetime of the referenced data buffer rather than having to manage it
> by passing a PipeItem to red_channel_client_init_send_data(). Since the
> data is owned by CursorItem
On Fri, 2016-12-16 at 11:23 -0500, Frediano Ziglio wrote:
> >
> > Use spice_marshaller_add_by_ref_full() instead of
> > spice_marshaller_add_by_ref() to allow the marshaller to manage the
> > lifetime of the referenced data buffer rather than having to manage
> > it
> > by passing a PipeItem to re
Use spice_marshaller_add_by_ref_full() instead of
spice_marshaller_add_by_ref() to allow the marshaller to manage the
lifetime of the referenced data buffer rather than having to manage it
by passing a PipeItem to red_channel_client_init_send_data(). Since the
data is owned by CursorItem (which is
Create the cursor when the widget is realized
---
src/spice-widget.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/src/spice-widget.c b/src/spice-widget.c
index 72fbbc8..a27f5a2 100644
--- a/src/spice-widget.c
+++ b/src/spice-widget.c
@@ -460,12 +460,12 @@ stat
---
src/spice-widget.c | 46 --
1 file changed, 36 insertions(+), 10 deletions(-)
diff --git a/src/spice-widget.c b/src/spice-widget.c
index a27f5a2..a3d6526 100644
--- a/src/spice-widget.c
+++ b/src/spice-widget.c
@@ -2355,11 +2355,44 @@ static void sp
---
src/spice-widget.c | 26 ++
1 file changed, 22 insertions(+), 4 deletions(-)
diff --git a/src/spice-widget.c b/src/spice-widget.c
index a3d6526..cedc358 100644
--- a/src/spice-widget.c
+++ b/src/spice-widget.c
@@ -119,6 +119,9 @@ static void release_keys(SpiceDisplay *
---
src/spice-widget.c | 26 +++---
1 file changed, 19 insertions(+), 7 deletions(-)
diff --git a/src/spice-widget.c b/src/spice-widget.c
index cedc358..17cda84 100644
--- a/src/spice-widget.c
+++ b/src/spice-widget.c
@@ -1015,6 +1015,18 @@ static gboolean do_pointer_grab(Spic
Hi,
this is a follow up to Francois's patches which avoided some deprecated
warnings in the SpiceDisplay widget. The main difference is the usage
of GdkSeat api that was introduced in Gtk 3.20.
Pavel Grunt (5):
gtk: Use gdk_cursor_new_for_display
gtk: Avoid deprecated gdk_window_get_pointer
---
src/spice-widget.c | 28
1 file changed, 20 insertions(+), 8 deletions(-)
diff --git a/src/spice-widget.c b/src/spice-widget.c
index 17cda84..7ebd5f1 100644
--- a/src/spice-widget.c
+++ b/src/spice-widget.c
@@ -1113,6 +1113,24 @@ static void try_mouse_grab(SpiceDi
Hi,
I understand your question only vaguely so I'm writing my best guess
answer. The server mouse mode means that mouse events are sent via
server to the guest OS that in turn renders cursor on it's own. The main
downside is big latency, the mouse pointer position changes with
noticeable delay eve
This is a possible fix for Frediano's crash. We discussed this on IRC a
bit and I could not actually reproduce this issue. But I have a possible
theory about why the drawable may be being kept alive longer than
expected. In the past, we unreffed the pipe item directly in
red_channel_client_on_out_m
On Fri, 2016-12-16 at 16:25 +, Frediano Ziglio wrote:
> Use spice_marshaller_add_by_ref_full() instead of
> spice_marshaller_add_by_ref() to allow the marshaller to manage the
> lifetime of the referenced data buffer rather than having to manage
> it
> by passing a PipeItem to red_channel_clien
22 matches
Mail list logo
