[Spice-devel] Complaint about service of Spice mobile

2016-12-12 Thread Mahesh Sharma
I have a Spice mobile in this set complaint with keyboard light at the service centre of Sawai Madhopur the service person say incomplete of your complaint about 15 to 20 days please SOL my problem ___ Spice-devel mailing list Spice-devel@lists.freedeskto

[Spice-devel] MediaRedirection

2016-12-12 Thread Kenny Zhang
hi, Recently I used spice as remote viewer with Qemu, it's powerful. Compared with freerdp, the video player, only support media player, it's limited, and I get yours MediaRedirection( https://www.spice-space.org/page/Features/MediaRedirection), it's cost much CPU usage, seems is too heavy. So I w

[Spice-devel] [PATCH spice-server] gstreamer: Prevent integer overflow in delay computation

2016-12-12 Thread Frediano Ziglio
The partial expression "MSEC_PER_SEC * size * 8" can overflow if size is 536870 or more. This as the operation is done using 32 bit unsigned integers. Being the size potentially double of a compressed frame size the limit can be easily reached. As get_average_frame_size already return a 64 bit use

[Spice-devel] [PATCH spice-server] build: Optimise headers check

2016-12-12 Thread Frediano Ziglio
Check multiple headers using a single m4 macro. The resulting script is reduced. Signed-off-by: Frediano Ziglio --- configure.ac | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/configure.ac b/configure.ac index c978b92..a78b4ec 100644 --- a/configure.ac +++ b/configure.ac

Re: [Spice-devel] [PATCH spice-server] build: Optimise headers check

2016-12-12 Thread Pavel Grunt
On Mon, 2016-12-12 at 11:19 +, Frediano Ziglio wrote: > Check multiple headers using a single m4 macro. > The resulting script is reduced. > > Signed-off-by: Frediano Ziglio Acked-by: Pavel Grunt > --- >  configure.ac | 4 +--- >  1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git

Re: [Spice-devel] [PATCH spice-server] red-worker: Introduce RedWorkerMessageGlDraw structure

2016-12-12 Thread Pavel Grunt
On Fri, 2016-12-09 at 14:25 +, Frediano Ziglio wrote: > All RedWorker messages starts with RedWorker except > SpiceMsgDisplayGlDraw. > For coherence introduce a RedWorkerMessageGlDraw structure > holding just SpiceMsgDisplayGlDraw. This also allows possible > extensions. > > Signed-off-by: Fre

Re: [Spice-devel] MediaRedirection

2016-12-12 Thread Michal Suchánek
Hello, On Mon, 12 Dec 2016 16:15:53 +0800 Kenny Zhang wrote: > hi, > > Recently I used spice as remote viewer with Qemu, it's powerful. > Compared with freerdp, the video player, only support media player, > it's limited, and I get yours MediaRedirection( > https://www.spice-space.org/page/Feat

Re: [Spice-devel] [PATCH spice-server] Remove unused refs field

2016-12-12 Thread Christophe Fergeau
Acked-by: Christophe Fergeau On Fri, Dec 09, 2016 at 07:10:45PM +, Frediano Ziglio wrote: > refs was used before GObject for reference counting. > > Signed-off-by: Frediano Ziglio > --- > server/red-channel-client-private.h | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/server/

Re: [Spice-devel] [PATCH spice-server] Removed unused red_channel_pipes_new_add_tail function

2016-12-12 Thread Christophe Fergeau
Acked-by: Christophe Fergeau On Fri, Dec 09, 2016 at 07:10:44PM +, Frediano Ziglio wrote: > This function is supposed to add an item to the queue to > be sent before all other queued items. > Was never used. > > Signed-off-by: Frediano Ziglio > --- > server/red-channel.c | 6 -- > ser

Re: [Spice-devel] [PATCH] Do endian swapping.

2016-12-12 Thread Michal Suchánek
Hello, On Mon, 28 Nov 2016 15:08:34 +0100 Michal Suchanek wrote: > This allows running big endian and little endian guest side by side > using cut&paste between them. > > There is some general design idea that swapping should come as cloce > to virtio_read/virtio_write as possible. In particular

[Spice-devel] [PATCH spice-server] red-worker: Optimise check

2016-12-12 Thread Frediano Ziglio
Use compile time check instead of running one. Signed-off-by: Frediano Ziglio --- server/red-worker.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/server/red-worker.c b/server/red-worker.c index d6a5e77..9fd565f 100644 --- a/server/red-worker.c +++ b/server/red-worker.c @@

[Spice-devel] [PATCH spice-server 1/4] gitignore: Remove obsolete files

2016-12-12 Thread Frediano Ziglio
Signed-off-by: Frediano Ziglio --- server/.gitignore | 3 --- 1 file changed, 3 deletions(-) diff --git a/server/.gitignore b/server/.gitignore index 2ff8a4e..3b98549 100644 --- a/server/.gitignore +++ b/server/.gitignore @@ -6,7 +6,4 @@ .libs Makefile Makefile.in -generated_demarshallers.c -

[Spice-devel] [PATCH spice-server 2/4] gitignore: Limit scope of some files

2016-12-12 Thread Frediano Ziglio
This make more obvious which directory they refer and potentially avoid ignoring unwanted files. Signed-off-by: Frediano Ziglio --- .gitignore| 2 -- server/.gitignore | 4 +++- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.gitignore b/.gitignore index 44eb2b5..656f669

[Spice-devel] [PATCH spice-server 4/4] gitignore: Reduce html files exclusion

2016-12-12 Thread Frediano Ziglio
Limit the html files ignored. Can happen that you are working on some html files on your main spice-server directory and it's not desirable to ignore them. Signed-off-by: Frediano Ziglio --- .gitignore | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.gitignore b/.gitignore in

[Spice-devel] [PATCH spice-server 3/4] gitignore: Reuse global gitignore

2016-12-12 Thread Frediano Ziglio
Signed-off-by: Frediano Ziglio --- .gitignore| 1 + server/.gitignore | 5 - 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/.gitignore b/.gitignore index 656f669..cac10f9 100644 --- a/.gitignore +++ b/.gitignore @@ -37,3 +37,4 @@ docs/manual/manual.chunked/ docs/manual

Re: [Spice-devel] [qxl v2] spiceqxl: Improve the Xspice and Xorg configuration option descriptions

2016-12-12 Thread Christophe Fergeau
Hey, I've pushed this one with a few small changes: I've moved the 'sasl' option together with the password/disable-ticketing ones, and I've channged some 'sets'/'specifies' to 'set'/'specify' for consistency. Christophe On Thu, Dec 08, 2016 at 09:15:55AM +0100, Francois Gouget wrote: > Group t

[Spice-devel] [PATCH spice-server 6/6] gstreamer: Avoid memory copy if strides are different

2016-12-12 Thread Frediano Ziglio
If bitmap stride and stream stride are different copy was used. Using GStreamer 1.0 you can avoid the copy setting correctly image offset and stride. Signed-off-by: Frediano Ziglio --- server/gstreamer-encoder.c | 21 + 1 file changed, 17 insertions(+), 4 deletions(-) diff -

[Spice-devel] [PATCH spice-server 4/6] tests: Make possible to have a report of the video encoding

2016-12-12 Thread Frediano Ziglio
This allows to do some possible statistics or graph. Currently the report contain encoded sizes. Signed-off-by: Frediano Ziglio --- server/tests/test-gst.c | 31 +++ 1 file changed, 31 insertions(+) diff --git a/server/tests/test-gst.c b/server/tests/test-gst.c index

[Spice-devel] [PATCH spice-server 5/6] gstreamer: Add gst_format to the table of supported formats

2016-12-12 Thread Frediano Ziglio
This format is required to add metadata. These metadata can be used to pass different strides or additional information to pass dma buffers. Signed-off-by: Frediano Ziglio --- server/gstreamer-encoder.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/server/gstre

[Spice-devel] [PATCH spice-server 3/6] Compatibility for GStreamer 0.10 for test utility

2016-12-12 Thread Frediano Ziglio
Signed-off-by: Frediano Ziglio --- server/tests/test-gst.c | 65 ++--- 1 file changed, 62 insertions(+), 3 deletions(-) diff --git a/server/tests/test-gst.c b/server/tests/test-gst.c index f88db25..cfc3d4a 100644 --- a/server/tests/test-gst.c +++ b/ser

[Spice-devel] [PATCH spice-server 2/6] gstreamer: Do not warn for tested formats

2016-12-12 Thread Frediano Ziglio
These formats were tested manually using test-gst utility in server/tests. Signed-off-by: Frediano Ziglio --- server/gstreamer-encoder.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/server/gstreamer-encoder.c b/server/gstreamer-encoder.c index e28ab00..2f1ea8e 100644 --

Re: [Spice-devel] [PATCH spice-server] gstreamer: Prevent integer overflow in delay computation

2016-12-12 Thread Francois Gouget
On Mon, 12 Dec 2016, Frediano Ziglio wrote: > The partial expression "MSEC_PER_SEC * size * 8" can overflow if > size is 536870 or more. This as the operation is done using > 32 bit unsigned integers. Being the size potentially double of > a compressed frame size the limit can be easily reached. >

[Spice-devel] [PATCH spice-server 1/6] Add an helper to test VideoEncoder

2016-12-12 Thread Frediano Ziglio
Add an utility to make possible to check various features of VideoEncoder. 2 GStreamer plugins are used in a chain like this: (1) input pipeline -> (2) video encoder -> (3) output pipeline While converting output from (1) is compared with output of (3) making sure the streaming is working correct

Re: [Spice-devel] [PATCH spice-server] gstreamer: Prevent integer overflow in delay computation

2016-12-12 Thread Frediano Ziglio
> > On Mon, 12 Dec 2016, Frediano Ziglio wrote: > > > The partial expression "MSEC_PER_SEC * size * 8" can overflow if > > size is 536870 or more. This as the operation is done using > > 32 bit unsigned integers. Being the size potentially double of > > a compressed frame size the limit can be ea

[Spice-devel] [vdagent-win v1] Avoid drag and drop on locked session - corner case

2016-12-12 Thread Victor Toso
From: Victor Toso Hi, Sadly, I totally forgot to keep up with this in the past, I already said it works [0] but I rebase and test it once again just to be sure. It looks fine. [0] https://lists.freedesktop.org/archives/spice-devel/2016-August/031361.html This should fix a corner case from bug

[Spice-devel] [vdagent-win v1] vdagent-win: start vdagent with lock info from session

2016-12-12 Thread Victor Toso
From: Frediano Ziglio Would be something like this (not tested) --- common/vdcommon.h | 1 + vdagent/vdagent.cpp | 12 vdservice/vdservice.cpp | 7 +++ 3 files changed, 20 insertions(+) diff --git a/common/vdcommon.h b/common/vdcommon.h index c1920e9..6b53327 100644

Re: [Spice-devel] [vdagent-win v1] vdagent-win: start vdagent with lock info from session

2016-12-12 Thread Victor Toso
Hi, On Mon, Dec 12, 2016 at 10:42:43PM +0100, Victor Toso wrote: > From: Frediano Ziglio > > Would be something like this (not tested) I would just add the commit log from: https://lists.freedesktop.org/archives/spice-devel/2016-August/031381.html > --- > common/vdcommon.h | 1 + > vdag

Re: [Spice-devel] [vdagent-win v1] Avoid drag and drop on locked session - corner case

2016-12-12 Thread Victor Toso
Hi, Forgot to cc Frediano. On Mon, Dec 12, 2016 at 10:42:42PM +0100, Victor Toso wrote: > From: Victor Toso > > Hi, > > Sadly, I totally forgot to keep up with this in the past, I already said it > works [0] but I rebase and test it once again just to be sure. It looks fine. > > [0] https://l

Re: [Spice-devel] [spice-server v2 8/9] reds: add support to ranks for video codecs

2016-12-12 Thread Francois Gouget
On Wed, 2 Nov 2016, Victor Toso wrote: > From: Victor Toso > > This patch implements a new value to the preference introduced in > 497fcbb0a315b034ba keeping it backwards compatible. The new value is > the rank, which is an unsigned integer and should be set as last > argument. e.g: encoder:code

[Spice-devel] [protocol] macros: Mark unused SPICE_GNUC_XXX macros as deprecated

2016-12-12 Thread Francois Gouget
We don't want to maintain more macros than necessary and in the end the equivalent G_GNUC_XXX macros should be preferred. Should any project actually depend on these macros they can keep using them by defining the usual SPICE_DEPRECATED macro until they migrate away from them or the macros are re

Re: [Spice-devel] [spice-server v2 8/9] reds: add support to ranks for video codecs

2016-12-12 Thread Victor Toso
Hi, On Tue, Dec 13, 2016 at 05:58:52AM +0100, Francois Gouget wrote: > On Wed, 2 Nov 2016, Victor Toso wrote: > > > From: Victor Toso > > > > This patch implements a new value to the preference introduced in > > 497fcbb0a315b034ba keeping it backwards compatible. The new value is > > the rank, wh