On Thu, 2016-09-08 at 09:01 +0300, Dmitry Fleytman wrote:
> > On 7 Sep 2016, at 18:49 PM, Christophe Fergeau > m> wrote:
> >
> > On Wed, Sep 07, 2016 at 06:40:57PM +0300, Dmitry Fleytman wrote:
> > > > On 7 Sep 2016, at 18:20 PM, Christophe Fergeau > > > t.com> wrote:
> > > >
> > > > On Wed, Se
>
> Reduce direct access to RedChannelClient, and get ready to convert to
> GObject.
Acked-by: Frediano Ziglio ---
> Changes in v2:
> - updated copyright dates
> - removed unused function
> - made red_channel_client_seamless_migration_done() static
> - removed NULL check from function that c
>
> ---
> Changes in v2:
> - fixed copyright date
> - squashed frediano's fixup patch
>
> server/Makefile.am | 2 +
> server/cursor-channel-client.c | 119
> +
> server/cursor-channel-client.h | 44 +++
> server/cursor-channel
>
> Prepare to port to GObject by encapsulating all private data
> ---
> Changes in v2:
> - Fixed leak of priv by using 1-element array trick
>
> server/smartcard.c | 89
> --
> 1 file changed, 47 insertions(+), 42 deletions(-)
>
> diff --gi
>
> Encapsulate private data and prepare for port to GObject.
> ---
> Changes in v2:
> - Fixed leak of priv by using 1-element array trick
>
> server/inputs-channel-client.c | 29 +++--
> 1 file changed, 19 insertions(+), 10 deletions(-)
>
> diff --git a/server/inputs-c
>
> Encapsulate private data and prepare for port to GObject
> ---
> Changes in v2:
> - Fixed leak of priv by using 1-element array trick
>
> server/main-channel-client.c | 144
> ++-
> 1 file changed, 75 insertions(+), 69 deletions(-)
>
> diff --git a/
>
> Encapsulate private data and prepare for port to GObject
> ---
> Changes in v2:
> - Fixed leak of priv by using 1-element array trick
> - moved unrelated change
> - added red_channel_client_get_pipe() and
> red_channel_client_is_mini_header()
>to avoid accessing RedChannelClientPrivate
>
> These need to be introduced at the same time since cache-item.tmpl.c
> assumes that both of these classes will have a cache in the same place:
> either within the channel client struct itself or (now) within a priv
> struct owned by the channel client.
>
> This encapsulates private data and p
>
> Prepare for port to GObject
> ---
> Changes in v2:
> - none
>
> server/dcc-send.c| 86
>
> server/dcc.c | 6 ++--
> server/dcc.h | 2 +-
> server/display-channel.c | 4 +--
> 4 files changed, 49 insertions(
Fwiw, commits with only a shortlog and no details in the commit log
should be limited to very trivial ones. (picking that one up, but there
are quite a few one-line logs in this series).
Christophe
On Wed, Sep 07, 2016 at 04:10:31PM +0300, Sameeh Jubran wrote:
> Based on a patch by Sandy Stutsman
On Thu, Sep 08, 2016 at 09:01:58AM +0300, Dmitry Fleytman wrote:
>
> > On 7 Sep 2016, at 18:49 PM, Christophe Fergeau wrote:
> >
> > On Wed, Sep 07, 2016 at 06:40:57PM +0300, Dmitry Fleytman wrote:
> >>
> >>> On 7 Sep 2016, at 18:20 PM, Christophe Fergeau
> >>> wrote:
> >>>
> >>> On Wed, Sep
Looked at this a bit closer, any reason why this is limited to
spice-server.h and not including the other public headers? I don't
really understand why we need these enums at this point.
Also, some of the enums in spice-server.h are not taken into account
because they are not of the form typedef en
> On 8 Sep 2016, at 12:30 PM, Christophe Fergeau wrote:
>
> On Thu, Sep 08, 2016 at 09:01:58AM +0300, Dmitry Fleytman wrote:
>>
>>> On 7 Sep 2016, at 18:49 PM, Christophe Fergeau wrote:
>>>
>>> On Wed, Sep 07, 2016 at 06:40:57PM +0300, Dmitry Fleytman wrote:
> On 7 Sep 2016, at 18:2
>
> Also remove (main|inputs)_channel_client_get_base() function to prepare
> for porting to GObject.
> ---
> Changes in v2:
> -
>
> server/cache-item.tmpl.c | 2 +-
> server/dcc.c | 10 ++---
> server/inputs-channel-client.c | 10 +++--
> server/main-channel-client.c
> > On 8 Sep 2016, at 12:30 PM, Christophe Fergeau < cferg...@redhat.com >
> > wrote:
>
> > On Thu, Sep 08, 2016 at 09:01:58AM +0300, Dmitry Fleytman wrote:
>
> > > > On 7 Sep 2016, at 18:49 PM, Christophe Fergeau < cferg...@redhat.com >
> > > > wrote:
> > >
> >
>
> > > > On Wed, Sep 07, 20
On Thu, Sep 8, 2016 at 1:59 PM, Frediano Ziglio wrote:
> On 8 Sep 2016, at 12:30 PM, Christophe Fergeau
> wrote:
>
> On Thu, Sep 08, 2016 at 09:01:58AM +0300, Dmitry Fleytman wrote:
>
>
> On 7 Sep 2016, at 18:49 PM, Christophe Fergeau
> wrote:
>
> On Wed, Sep 07, 2016 at 06:40:57PM +0300, Dmitr
---
spiceconn.js | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/spiceconn.js b/spiceconn.js
index 010a446..796f954 100644
--- a/spiceconn.js
+++ b/spiceconn.js
@@ -189,8 +189,10 @@ SpiceConn.prototype =
if (msg.type > 500)
{
-
Some files had different line ending (some lines DOS while some others
UNIX). Use the same line ending using the nearest ending.
Signed-off-by: Frediano Ziglio
---
qxldod/QxlDod.cpp | 58 +--
qxldod/QxlDod.h | 2 +-
qxldod/driver.h
From: Dmitry Fleytman
Git detect these files as binary which cause some issues with log and
other command.
The conversion allows different tools (git, VS and different editors)
to work correctly.
Signed-off-by: Dmitry Fleytman
Signed-off-by: Frediano Ziglio
---
qxldod/qxldod.inf | Bin 4242 ->
>
> Some files had different line ending (some lines DOS while some others
> UNIX). Use the same line ending using the nearest ending.
>
> Signed-off-by: Frediano Ziglio
> ---
> qxldod/QxlDod.cpp | 58
> +--
> qxldod/QxlDod.h | 2 +-
>
>
> Looked at this a bit closer, any reason why this is limited to
> spice-server.h and not including the other public headers? I don't
> really understand why we need these enums at this point.
> Also, some of the enums in spice-server.h are not taken into account
> because they are not of the fo
Ah, I didn't realized before pushing /o\
Please make the summary shorter - you can put the other sentence to
the commit body.
On Thu, 2016-09-08 at 13:21 +0200, Oliver Gutierrez wrote:
> ---
> spiceconn.js | 6 --
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/spiceconn.
>
> Sorry for the delay in sending the next patch series. This is mostly the same
> series as previously sent, but with the first patch merged and changes from
> previous review. See individual patches for details.
>
> Jonathon Jongsma (10):
> Move RedChannelClient to separate file
> Move Cur
Ok. Thanks for the tips :D
On Thu, Sep 8, 2016 at 2:26 PM, Pavel Grunt wrote:
> Ah, I didn't realized before pushing /o\
>
> Please make the summary shorter - you can put the other sentence to
> the commit body.
>
> On Thu, 2016-09-08 at 13:21 +0200, Oliver Gutierrez wrote:
> > ---
> > spicecon
Debugger is not an object or command. It is a reserved word and DEBUG > 0 &&
syntax does not work with it
---
spiceconn.js | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/spiceconn.js b/spiceconn.js
index 010a446..796f954 100644
--- a/spiceconn.js
+++ b/spiceconn.js
@@ -
On Thu, 2016-09-08 at 14:51 +0200, Oliver Gutierrez wrote:
> Debugger is not an object or command. It is a reserved word and
> DEBUG > 0 && syntax does not work with it
> ---
> spiceconn.js | 6 --
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/spiceconn.js b/spiceconn.js
No need to generate marshallers for it
---
common/messages.h | 3 ---
spice.proto | 3 +--
2 files changed, 1 insertion(+), 5 deletions(-)
diff --git a/common/messages.h b/common/messages.h
index 516a345..c787166 100644
--- a/common/messages.h
+++ b/common/messages.h
@@ -386,9 +386,6 @@ typ
On Thu, 2016-09-08 at 08:26 -0400, Frediano Ziglio wrote:
> >
> >
> > Sorry for the delay in sending the next patch series. This is
> > mostly the same
> > series as previously sent, but with the first patch merged and
> > changes from
> > previous review. See individual patches for details.
> >
On Thu, 2016-09-08 at 08:25 -0400, Frediano Ziglio wrote:
> >
> >
> > Looked at this a bit closer, any reason why this is limited to
> > spice-server.h and not including the other public headers? I don't
> > really understand why we need these enums at this point.
> > Also, some of the enums in s
>
> I'm glad it's broadly usable; I hope to have a patch attacking the CPU
> usage sometime fairly soon.
I've pushed a series of patches that improve both CPU usage and
performance in the extreme damage case for me.
Cheers,
Jeremy
___
Spice-devel mail
Protocol states that name is an array of bytes but the marshallers are
considering it a pointer to an array of bytes. A client that does not
use demarshallers from spice-common will find an incorrect
implementation of spice-server SpiceMsgPortInit.
Reported-by: Oliver Gutierrez
Signed-off-by: Pav
Previously we were creating a variable named 'dev_state' and then
apparently not using it. Well, we *were* actually using it, but in a
convoluted sort of way. Creating a new RedCharDevice has a
side-effect of setting itself as the 'st' attribute of
SpiceCharDeviceInstance. So 'dev_state' and 'char_
Move all of the DisplayChannel data memembers into a private struct to
encapsulate things better. This necessitated a few new 'public' methods
and a small bit of refactoring to avoid poking into DisplayChannel
internals from too many places. The DisplayChannel and the
DisplayChannelClient are still
Removing more intrusive RingItems from various structures and improving
readibility.
---
server/image-encoders.c | 17 +++--
1 file changed, 7 insertions(+), 10 deletions(-)
diff --git a/server/image-encoders.c b/server/image-encoders.c
index 5759230..39aca6c 100644
--- a/server/image
Since this function is a DisplayChannel method, use a name consistent
with naming conventions.
---
server/display-channel.c | 2 +-
server/display-channel.h | 2 +-
server/red-worker.c | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/server/display-channel.c b/server/dis
More Ring cleanup
---
server/char-device.c | 72 ++--
1 file changed, 30 insertions(+), 42 deletions(-)
diff --git a/server/char-device.c b/server/char-device.c
index e01f34c..40512f8 100644
--- a/server/char-device.c
+++ b/server/char-device.c
@@ -
A few smaller cleanup patches before we start the GObject stuff.
Jonathon Jongsma (10):
RedsState: clean up spice_server_char_device_add_interface
Add DisplayChannelPrivate struct
Add CursorChannelPrivate struct
Rename display_channel_set_monitors_config_to_primary()
Replace a couple Rin
Make RedsState::mig_target_clients into a GList to improve encapsulation
and maintainability. Also RedsMigTargetClient::pending_links. With
GList, a type implementation can be ignorant of whether they're
contained within a list or not.
---
server/reds-private.h | 6 ++
server/reds.c |
Encapsulate private data of CursorChannel in a private struct. This
isn't very useful at the moment, but it will help prepare the way for
porting the RedChannel heirarchy to GObject.
---
server/cursor-channel.c | 53 -
1 file changed, 30 insertions(+
Instead of using a Ring (and having a ring item link in every pipe
item), store them in a GList. This also necesitated changing
RedCharDeviceVDIPort->priv->read_bufs to a GList as well.
---
server/cursor-channel.c | 2 -
server/dcc-send.c | 22 +--
server/dcc
This greatly improves the readability of the code and keeps things
encapsulated better.
---
server/dcc.c | 12 +---
server/dcc.h | 1 -
server/display-channel.c | 39 ++-
server/display-channel.h | 6 +-
server/stream.c
Change a couple more Rings to GList
---
server/char-device.c | 88 ++--
server/char-device.h | 1 -
2 files changed, 37 insertions(+), 52 deletions(-)
diff --git a/server/char-device.c b/server/char-device.c
index 957fb26..e01f34c 100644
--- a/serv
>
> Protocol states that name is an array of bytes but the marshallers are
> considering it a pointer to an array of bytes. A client that does not
> use demarshallers from spice-common will find an incorrect
> implementation of spice-server SpiceMsgPortInit.
>
> Reported-by: Oliver Gutierrez
> S
>
> Removing more intrusive RingItems from various structures and improving
> readibility.
> ---
> server/image-encoders.c | 17 +++--
> 1 file changed, 7 insertions(+), 10 deletions(-)
>
> diff --git a/server/image-encoders.c b/server/image-encoders.c
> index 5759230..39aca6c 100644
>
> Previously we were creating a variable named 'dev_state' and then
> apparently not using it. Well, we *were* actually using it, but in a
> convoluted sort of way. Creating a new RedCharDevice has a
> side-effect of setting itself as the 'st' attribute of
> SpiceCharDeviceInstance. So 'dev_stat
> >
> > Protocol states that name is an array of bytes but the marshallers are
> > considering it a pointer to an array of bytes. A client that does not
> > use demarshallers from spice-common will find an incorrect
> > implementation of spice-server SpiceMsgPortInit.
> >
> > Reported-by: Oliver
---
src/channel-display.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/src/channel-display.c b/src/channel-display.c
index 709b3d2..020b7fb 100644
--- a/src/channel-display.c
+++ b/src/channel-display.c
@@ -1816,7 +1816,6 @@ void spice_display_gl_draw_done(SpiceDisplayChannel
*display)
On Thu, 2016-09-08 at 13:39 -0400, Frediano Ziglio wrote:
> >
> >
> > Previously we were creating a variable named 'dev_state' and then
> > apparently not using it. Well, we *were* actually using it, but in
> > a
> > convoluted sort of way. Creating a new RedCharDevice has a
> > side-effect of se
Hi
- Original Message -
> ---
> src/channel-display.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/src/channel-display.c b/src/channel-display.c
> index 709b3d2..020b7fb 100644
> --- a/src/channel-display.c
> +++ b/src/channel-display.c
> @@ -1816,7 +1816,6 @@ void spice_displ
Hi,
On Thu, 2016-09-08 at 17:45 -0400, Marc-André Lureau wrote:
> Hi
>
> - Original Message -
> > ---
> > src/channel-display.c | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/src/channel-display.c b/src/channel-display.c
> > index 709b3d2..020b7fb 100644
> > --- a/src/cha
---
src/channel-main.c | 2 +-
src/usb-device-manager.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/channel-main.c b/src/channel-main.c
index 26c8c6d..990a06a 100644
--- a/src/channel-main.c
+++ b/src/channel-main.c
@@ -3128,7 +3128,7 @@ gboolean spice_main_fil
51 matches
Mail list logo
