184 (88 direct, 96 indirect) bytes in 1 blocks are definitely lost in
loss record 10,025 of 11,515 at 0x4C28BF6: malloc
(vg_replace_malloc.c:299)
by 0x9D33218: g_malloc (gmem.c:94)
by 0x9D49D02: g_slice_alloc (gslice.c:1025)
by 0x9D1CCBD: g_hash_table_new_full (ghash.c:711)
by 0x406196: connect
Acked-by: Christophe Fergeau
On Tue, May 10, 2016 at 10:28:28AM +0200, Victor Toso wrote:
> 184 (88 direct, 96 indirect) bytes in 1 blocks are definitely lost in
> loss record 10,025 of 11,515 at 0x4C28BF6: malloc
> (vg_replace_malloc.c:299)
> by 0x9D33218: g_malloc (gmem.c:94)
> by 0x9D49D02:
[root@fc21 spice-gtk-0.30]# mingw32-make
make all-recursive
make[1]: Entering directory '/home/luohongzhen/Downloads/spice-gtk-0.30'
Making all in spice-common
make[2]: Entering directory
'/home/luohongzhen/Downloads/spice-gtk-0.30/spice-common'
make all-recursive
make[3]: Entering directory
'/
>
> Hey,
>
> On Mon, May 09, 2016 at 11:09:40AM -0400, Frediano Ziglio wrote:
> > I think it's time to update this document
> >
> > >
> > > 1. C and C++ style
> > >
> > > All of the following are applicable for both c and c++, except for
> > > section 25
> > > which is c++ extension.
> > >
Hey,
On Tue, May 10, 2016 at 05:45:40AM -0400, Frediano Ziglio wrote:
> >
> > Hey,
> >
> > On Mon, May 09, 2016 at 11:09:40AM -0400, Frediano Ziglio wrote:
> > > I think it's time to update this document
> > >
> > > >
> > > > 1. C and C++ style
> > > >
> > > > All of the following are applic
Hi,
On Thu, May 05, 2016 at 02:43:33PM +0300, Snir Sheriber wrote:
> -New message type for compressed messages has been added to the protocol
> -SPICE_SPICEVMC_CAP_DATA_COMPRESS_LZ4 capability has been added
Let's keep the commit messages under 72 char.
> ---
> spice/enums.h| 10 ++
On Tue, May 10, 2016 at 12:23:30PM +0200, Victor Toso wrote:
> Hi,
>
> On Thu, May 05, 2016 at 02:43:33PM +0300, Snir Sheriber wrote:
> > -New message type for compressed messages has been added to the protocol
> > -SPICE_SPICEVMC_CAP_DATA_COMPRESS_LZ4 capability has been added
>
> Let's keep the
On Thu, May 05, 2016 at 02:43:32PM +0300, Snir Sheriber wrote:
> Compressed message type is CompressedData which contains compression
> type (1 byte) followed by the uncompressed data size (4 bytes) followed
> by the compressed data size (4 bytes) followed by the compressed data
Acked-by: Victor T
Hi,
On Thu, May 05, 2016 at 02:43:35PM +0300, Snir Sheriber wrote:
> Compressed message type is CompressedData which contains compression
> type (1 byte) followed by the uncompressed data size (4 bytes) followed
> by the compressed data size (4 bytes) followed by the compressed data
>
> If SPICE_
Hi,
On Thu, May 05, 2016 at 02:43:34PM +0300, Snir Sheriber wrote:
> Compressed message type is CompressedData which contains compression
> type (1 byte) followed by the uncompressed data size (4 bytes) followed
> by the compressed data size (4 bytes) followed by the compressed data
>
> If SPICE_U
Hi,
On Tue, May 10, 2016 at 11:16:43AM +0200, Christophe Fergeau wrote:
>
> Acked-by: Christophe Fergeau
Thanks, pushed as
https://cgit.freedesktop.org/spice/spice-gtk/commit/?id=e6ca385208d68204c470b51e312582bba8076551
>
> On Tue, May 10, 2016 at 10:28:28AM +0200, Victor Toso wrote:
> > 184
Hi Snir,
it is also needed to increase required version of the spice-protocol in
configure.ac for the components using new symbols.
Currently
spice-common requires spice-protocol >= 0.12.10
spice-gtk requires spice-protocol >= 0.12.11
spice-server requires spice-protocol >= 0.12.11
And the ne
Have you measured how much of a gain lz4 compression gives for some use
cases?
Christophe
On Thu, May 05, 2016 at 02:43:32PM +0300, Snir Sheriber wrote:
> Compressed message type is CompressedData which contains compression
> type (1 byte) followed by the uncompressed data size (4 bytes) followed
The conversion try keeps the content as is no matter if updated or not.
Asciidoc format is already used for manual.
Using a text format make easier to see git diff and send patches.
Also it's easier to convert to different format and copy to web pages.
Signed-off-by: Frediano Ziglio
---
docs/Mak
The conversion try keeps the content as is no matter if updated or not.
Asciidoc format is already used for manual.
Using a text format make easier to see git diff and send patches.
Also it's easier to convert to different format and copy to web pages.
Signed-off-by: Frediano Ziglio
---
docs/Mak
Hi Frediano,
Thanks! You can add
Related: https://bugs.freedesktop.org/show_bug.cgi?id=95258
And the generated file should be removed on clean. Also make distcheck is
failing for me:
No rule to make target 'spice_style.txt', needed by 'spice_style.html'. Stop.
Thanks,
Pavel
On Tue, 2016-05-10
On Tue, Apr 19, 2016 at 09:49:44AM +0200, Francois Gouget wrote:
> Note that we can only avoid copies for the first 1 Mpixels or so.
> That's because Spice splits larger frames into more chunks than we can
> fit GstMemory fragments in a GStreamer buffer. So if there are more
> pixels we will avoid
On Tue, May 10, 2016 at 02:27:42PM +0200, Pavel Grunt wrote:
> Hi Frediano,
>
> Thanks! You can add
> Related: https://bugs.freedesktop.org/show_bug.cgi?id=95258
>
> And the generated file should be removed on clean. Also make distcheck is
> failing for me:
>
> No rule to make target 'spice_styl
Changes since v2:
- split conversion and cleanup;
- fixed make distcheck distributing files.
Frediano Ziglio (2):
converts Spice_style.odt to asciidoc spice_style.txt
removed converted Spice_style.odf
docs/Makefile.am | 13 ++
docs/Spice_style.odt | Bin 19045 -> 0 bytes
docs/spice_styl
The conversion try keeps the content as is no matter if updated or not.
Asciidoc format is already used for manual.
Using a text format make easier to see git diff and send patches.
Also it's easier to convert to different format and copy to web pages.
Signed-off-by: Frediano Ziglio
---
docs/Mak
Signed-off-by: Frediano Ziglio
---
docs/Spice_style.odt | Bin 19045 -> 0 bytes
1 file changed, 0 insertions(+), 0 deletions(-)
delete mode 100644 docs/Spice_style.odt
diff --git a/docs/Spice_style.odt b/docs/Spice_style.odt
deleted file mode 100644
index
efdcd1a62ba0c4995e470b6a5ec22301f24ab3
Signed-off-by: Frediano Ziglio
---
configure.ac | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/configure.ac b/configure.ac
index 8419508..524e845 100644
--- a/configure.ac
+++ b/configure.ac
@@ -70,7 +70,7 @@ dnl Check optional features
SPICE_CHECK_SMARTCARD
AC_ARG_ENABLE
Acked-by: Christophe Fergeau
On Tue, May 10, 2016 at 01:57:19PM +0100, Frediano Ziglio wrote:
> Signed-off-by: Frediano Ziglio
> ---
> configure.ac | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/configure.ac b/configure.ac
> index 8419508..524e845 100644
> --- a/conf
Hey,
On Mon, May 09, 2016 at 11:20:00AM -0400, Frediano Ziglio wrote:
> >
> > Hey,
> >
> > On Mon, May 09, 2016 at 10:03:03AM +0100, Frediano Ziglio wrote:
> > > Removing an interface cause SpiceBaseInstance->st to be set to NULL.
> > > This pointer was then deferenced in agent code.
> > > As Sp
Use this style for include headers inside headers:
#include
#include
#include
#include
#include "spice_server.h"
Signed-off-by: Frediano Ziglio
---
server/cache-item.h | 3 ++-
server/dcc-encoders.h | 1 +
server/dispatcher.h | 1 +
server/display-channel.h
Different headers changes:
- every header must be auto sufficient;
- include an header only if definitions are necessary
(ie: don't include just to use some structure pointers).
Signed-off-by: Frediano Ziglio
---
server/agent-msg-filter.h | 9 ++---
server/cache-item.h |
>
> Hey,
>
> On Mon, May 09, 2016 at 11:20:00AM -0400, Frediano Ziglio wrote:
> > >
> > > Hey,
> > >
> > > On Mon, May 09, 2016 at 10:03:03AM +0100, Frediano Ziglio wrote:
> > > > Removing an interface cause SpiceBaseInstance->st to be set to NULL.
> > > > This pointer was then deferenced in age
Removing an interface cause SpiceBaseInstance->st to be set to NULL.
This pointer was then deferenced in agent code.
As SpiceBaseInstance should not be used after this call make sure
we don't keep pointers to it.
Signed-off-by: Frediano Ziglio
---
server/reds.c | 1 +
server/spice-server
On 05/10/2016 10:38 AM, Frediano Ziglio wrote:
> Removing an interface cause SpiceBaseInstance->st to be set to NULL.
> This pointer was then deferenced in agent code.
> As SpiceBaseInstance should not be used after this call make sure
> we don't keep pointers to it.
>
> Signed-off-by: Frediano Zi
Acked-by: Frediano Ziglio
Frediano
>
> It will help in cases where syncing modifiers keys is complicated:
> * not working leds for modifiers keys
> * different keyboard layout on the guest side
> ---
> src/spice-gtk-session.c | 30 ++
> 1 file changed, 30 insertio
Acked-by: Frediano Ziglio
Frediano
>
> ---
> src/spicy.c | 6 ++
> 1 file changed, 6 insertions(+)
>
> diff --git a/src/spicy.c b/src/spicy.c
> index 0475530..0826c03 100644
> --- a/src/spicy.c
> +++ b/src/spicy.c
> @@ -712,6 +712,7 @@ static const char *spice_display_properties[] = {
>
Removing an interface cause SpiceBaseInstance->st to be set to NULL.
This pointer was then deferenced in agent code.
As SpiceBaseInstance should not be used after this call make sure
we don't keep pointers to it.
Signed-off-by: Frediano Ziglio
---
server/reds.c | 1 +
server/spice-server
Acked-by: Christophe Fergeau
On Mon, May 09, 2016 at 02:21:04PM +0100, Frediano Ziglio wrote:
> This code make easier to be sure we don't have dangling pointers
> resetting in the function which free the structure.
>
> Signed-off-by: Frediano Ziglio
> ---
> server/char-device.c | 21 +
Hey,
On Tue, May 03, 2016 at 03:00:22PM -0500, Jonathon Jongsma wrote:
> @@ -2086,30 +2083,33 @@ void red_client_set_migration_seamless(RedClient
> *client) // dest
>
> void red_client_migrate(RedClient *client)
> {
> -RingItem *link, *next;
> +GList *link, *next;
> RedChannelCli
Hey,
This patch mostly looks good to me, a few minor comments:
On Tue, May 03, 2016 at 03:00:20PM -0500, Jonathon Jongsma wrote:
> Instead of using a Ring, use a GList to store the list of channel
> clients. This allows us to iterate the clients without poking inside of
> the client struct to get
There are still some GL_CANVAS occurrences in canvas_base.c after this
patch.
Apart from that, looks good to me.
Christophe
On Fri, May 06, 2016 at 05:14:50PM +0200, Pavel Grunt wrote:
> It is not needed since spice-server commit
> c5c176a5c7718177f23b07981556b5d460627498
signature.asc
Descrip
Changes since v3:
- added a comment;
- remove another fixed section number in the documentation using a link.
Changes since v2:
- split conversion and cleanup;
- fixed make distcheck distributing files.
Frediano Ziglio (2):
converts Spice_style.odt to asciidoc spice_style.txt
removed converte
Signed-off-by: Frediano Ziglio
---
docs/Spice_style.odt | Bin 19045 -> 0 bytes
1 file changed, 0 insertions(+), 0 deletions(-)
delete mode 100644 docs/Spice_style.odt
diff --git a/docs/Spice_style.odt b/docs/Spice_style.odt
deleted file mode 100644
index
efdcd1a62ba0c4995e470b6a5ec22301f24ab3
The conversion try keeps the content as is no matter if updated or not.
Asciidoc format is already used for manual.
Using a text format make easier to see git diff and send patches.
Also it's easier to convert to different format and copy to web pages.
Related: https://bugs.freedesktop.org/show_bu
Hi,
something like this can be added for `make clean` in docs:
diff --git a/docs/Makefile.am b/docs/Makefile.am
index a3e418a..3dba2c3 100644
--- a/docs/Makefile.am
+++ b/docs/Makefile.am
@@ -14,3 +14,6 @@ all-local: spice_style.html
spice_style.html: spice_style.txt
$(AM_V_GEN) $(ASCIIDO
Hi,
just a typo in the commit s/odf/odt
Acked-by: Pavel Grunt
On Tue, 2016-05-10 at 17:24 +0100, Frediano Ziglio wrote:
> Signed-off-by: Frediano Ziglio
> ---
> docs/Spice_style.odt | Bin 19045 -> 0 bytes
> 1 file changed, 0 insertions(+), 0 deletions(-)
> delete mode 100644 docs/Spice_styl
C++ use was removed many time ago.
Signed-off-by: Frediano Ziglio
---
docs/spice_style.txt | 120 +--
1 file changed, 2 insertions(+), 118 deletions(-)
diff --git a/docs/spice_style.txt b/docs/spice_style.txt
index f354c30..74aae0c 100644
--- a/do
Spice client is no more in this repository and also the style was changed
Signed-off-by: Frediano Ziglio
---
docs/spice_style.txt | 19 ---
1 file changed, 19 deletions(-)
diff --git a/docs/spice_style.txt b/docs/spice_style.txt
index 74aae0c..8966365 100644
--- a/docs/spice_sty
43 matches
Mail list logo
