[Spice-devel] [PATCH spice-gtk 2/6] doc: Remove private structs

2016-03-30 Thread Pavel Grunt
--- doc/reference/spice-gtk-sections.txt | 7 --- 1 file changed, 7 deletions(-) diff --git a/doc/reference/spice-gtk-sections.txt b/doc/reference/spice-gtk-sections.txt index 0c05168..a6fcfbf 100644 --- a/doc/reference/spice-gtk-sections.txt +++ b/doc/reference/spice-gtk-sections.txt @@ -33

[Spice-devel] [PATCH spice-gtk 4/6] spice-file-transfer-task: Fix docstring

2016-03-30 Thread Pavel Grunt
--- src/spice-file-transfer-task.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/spice-file-transfer-task.h b/src/spice-file-transfer-task.h index b97d107..18dc509 100644 --- a/src/spice-file-transfer-task.h +++ b/src/spice-file-transfer-task.h @@ -37,7 +37,7 @@ typedef s

[Spice-devel] [PATCH spice-gtk 5/6] doc: Ignore spicy-connect

2016-03-30 Thread Pavel Grunt
--- doc/reference/Makefile.am | 1 + 1 file changed, 1 insertion(+) diff --git a/doc/reference/Makefile.am b/doc/reference/Makefile.am index cb01f97..5aa8557 100644 --- a/doc/reference/Makefile.am +++ b/doc/reference/Makefile.am @@ -46,6 +46,7 @@ IGNORE_HFILES=

[Spice-devel] [PATCH spice-gtk 1/6] usb-device-manager: Fix docstring

2016-03-30 Thread Pavel Grunt
Add description, "Since" and change the parameter name in the docstring to match parameter name in the function definition. --- doc/reference/spice-gtk-sections.txt | 1 + src/usb-device-manager.c | 14 +- 2 files changed, 10 insertions(+), 5 deletions(-) diff --git a/doc

[Spice-devel] [PATCH spice-gtk 6/6] doc: Add description for spice_display_get_gl_scanout()

2016-03-30 Thread Pavel Grunt
--- src/channel-display.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/channel-display.c b/src/channel-display.c index 90d155e..431c2e7 100644 --- a/src/channel-display.c +++ b/src/channel-display.c @@ -532,6 +532,8 @@ void spice_display_change_preferred_compression(SpiceChannel *cha

[Spice-devel] [PATCH spice-gtk 3/6] doc: channel stability should be Stable

2016-03-30 Thread Pavel Grunt
--- src/channel-smartcard.c | 2 +- src/channel-usbredir.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/channel-smartcard.c b/src/channel-smartcard.c index 7f3306e..21df98a 100644 --- a/src/channel-smartcard.c +++ b/src/channel-smartcard.c @@ -35,7 +35,7 @@ * @titl

[Spice-devel] [PATCH spice-gtk 0/6] Fixes for autogenerated documentation

2016-03-30 Thread Pavel Grunt
Hi, Following patches adjust autogenerated docs (can be found at [0]) to recent changes (some classes are final now, there are new functions). They also silence some warnings when the docs are generated. Pavel [0] http://www.spice-space.org/spice-gtk.html Pavel Grunt (6): usb-device-manager:

Re: [Spice-devel] [PATCH spice-gtk 0/6] Fixes for autogenerated documentation

2016-03-30 Thread Christophe Fergeau
Acked-by: Christophe Fergeau On Wed, Mar 30, 2016 at 09:00:15AM +0200, Pavel Grunt wrote: > Hi, > > Following patches adjust autogenerated docs (can be found at [0]) to recent > changes (some classes are final now, there are new functions). > They also silence some warnings when the docs are ge

Re: [Spice-devel] [PATCH spice-gtk 2/6] doc: Remove private structs

2016-03-30 Thread Christophe Fergeau
On Wed, Mar 30, 2016 at 09:00:17AM +0200, Pavel Grunt wrote: > --- > doc/reference/spice-gtk-sections.txt | 7 --- > 1 file changed, 7 deletions(-) > > diff --git a/doc/reference/spice-gtk-sections.txt > b/doc/reference/spice-gtk-sections.txt > index 0c05168..a6fcfbf 100644 > --- a/doc/refer

[Spice-devel] [spice-gtk] build-sys: Update symbol files

2016-03-30 Thread Christophe Fergeau
The OSX-specific symbol files were not updated after the recent API additions/removals, and some removed symbols were still listed in map-file. --- src/map-file| 4 +--- src/spice-glib-sym-file | 3 +++ src/spice-gtk-sym-file | 2 -- 3 files changed, 4 insertions(+), 5 deletions(-) d

Re: [Spice-devel] [spice-gtk] build-sys: Update symbol files

2016-03-30 Thread Pavel Grunt
On Wed, 2016-03-30 at 10:59 +0200, Christophe Fergeau wrote: > The OSX-specific symbol files were not updated after the recent API > additions/removals, and some removed symbols were still listed in > map-file. Acked-by: Pavel Grunt > --- >  src/map-file| 4 +--- >  src/spice-glib-sym

Re: [Spice-devel] [PATCH spice-gtk 0/6] Fixes for autogenerated documentation

2016-03-30 Thread Pavel Grunt
On Wed, 2016-03-30 at 10:49 +0200, Christophe Fergeau wrote: > Acked-by: Christophe Fergeau > Thank you, pushed > On Wed, Mar 30, 2016 at 09:00:15AM +0200, Pavel Grunt wrote: > > > > Hi, > > > > Following patches adjust autogenerated docs (can be found at [0]) > > to recent > > changes (some c

Re: [Spice-devel] [PATCH] channel: do not free rcc->stream in red_channel_client_disconnect

2016-03-30 Thread Victor Toso
On Tue, Mar 29, 2016 at 09:35:12AM -0300, Eduardo Lima (Etrunko) wrote: > On 01/19/2016 08:14 AM, Victor Toso wrote: > > Hi, > > > > On Tue, Jan 19, 2016 at 09:52:24AM +, Frediano Ziglio wrote: > >> This fixes a crash if red_channel_client disconnect is called > >> handling a message. > >> Thi

[Spice-devel] [spice-server 2/3] Update NEWS for 0.13.1

2016-03-30 Thread Christophe Fergeau
--- NEWS | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/NEWS b/NEWS index e906e88..ecedcd8 100644 --- a/NEWS +++ b/NEWS @@ -1,4 +1,4 @@ -Major changes in 0.13.0: +Major changes in 0.13.1: *** IMPORTANT *** @@ -6,6 +6,18 @@ The 0.13.x

[Spice-devel] [spice-server 3/3] build-sys: Update libtool versioning for 0.13.1

2016-03-30 Thread Christophe Fergeau
--- configure.ac | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/configure.ac b/configure.ac index 9541b59..8419508 100644 --- a/configure.ac +++ b/configure.ac @@ -11,9 +11,9 @@ AC_PREREQ([2.57]) # - If any interfaces have been removed or changed since the last public re

[Spice-devel] [spice-server 1/3] Remove duplicate typedef from headers

2016-03-30 Thread Christophe Fergeau
This is causing compile errors with older gcc versions. reds.h includes reds-stream.h through red-channel.h so it will get the RedsState typedef this way. red-qxl.h includes spice-qxl.h through red-channel.h and then spice.h, so it will get the QXLState typedef this way. --- server/red-qxl.h | 2

Re: [Spice-devel] RFC: XSpice shift to an 'x11spice' approach

2016-03-30 Thread Pedro Francisco
Sending to list as well, this time. 2016-03-28 15:19 GMT+01:00 Jeremy White : > Hi folks, > > As you know, I've done a lot of work on XSpice over the past few years. > I plan to take a new approach by following the model of the excellent > 'x11vnc' client. Tell me, performance-wise, is there an

Re: [Spice-devel] [spice-server 1/3] Remove duplicate typedef from headers

2016-03-30 Thread Pavel Grunt
Hi, I agree that there should be the only one typedef. But I don't understand why not to include the needed header directly. We should try to "untagle" these header dependencies. Pavel On Wed, 2016-03-30 at 11:46 +0200, Christophe Fergeau wrote: > This is causing compile errors with older gcc ve

Re: [Spice-devel] [spice-server 2/3] Update NEWS for 0.13.1

2016-03-30 Thread Pavel Grunt
The series looks good, ack Pavel On Wed, 2016-03-30 at 11:46 +0200, Christophe Fergeau wrote: > --- >  NEWS | 14 +- >  1 file changed, 13 insertions(+), 1 deletion(-) > > diff --git a/NEWS b/NEWS > index e906e88..ecedcd8 100644 > --- a/NEWS > +++ b/NEWS > @@ -1,4 +1,4 @@ > -Major cha

[Spice-devel] [PATCH spice-common] Fix build in systems with Glib version older than 2.38

2016-03-30 Thread Eduardo Lima (Etrunko)
From: "Eduardo Lima (Etrunko)" Tests now include functions only available in glib 2.38. To avoid setting the dependency bar too high, we simply put them between #ifdef guards. Signed-off-by: Eduardo Lima (Etrunko) --- tests/test-logging.c | 4 tests/test-marshallers.c | 7 +++ 2 f

Re: [Spice-devel] "undefined reference" errors while running make

2016-03-30 Thread Eduardo Lima (Etrunko)
On 03/29/2016 12:08 PM, Mahmood Naderan wrote: > O that is good :thumsup: > I applied the patch and the compilation passed that file. However, I get > a new undefined reference in another file > > > root@cluster:spice-src# patch < patch > can't find file to patch at input line 5 The new patch at

Re: [Spice-devel] [spice-server 3/3] build-sys: Update libtool versioning for 0.13.1

2016-03-30 Thread Frediano Ziglio
> > --- > configure.ac | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/configure.ac b/configure.ac > index 9541b59..8419508 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -11,9 +11,9 @@ AC_PREREQ([2.57]) > # - If any interfaces have been removed or changed si

Re: [Spice-devel] [spice-server 1/3] Remove duplicate typedef from headers

2016-03-30 Thread Frediano Ziglio
> > This is causing compile errors with older gcc versions. > > reds.h includes reds-stream.h through red-channel.h so it will get the > RedsState typedef this way. > > red-qxl.h includes spice-qxl.h through red-channel.h and then spice.h, > so it will get the QXLState typedef this way. > --- >

Re: [Spice-devel] [phodav PATCH 1/3 v4] spice-webdavd-windows: Automount shared folder

2016-03-30 Thread Victor Toso
On Thu, Mar 24, 2016 at 04:39:40PM +0100, Lukas Venhoda wrote: > Try to connect to shared folder automatically on Windows. > > On each loop of run_service(), run a GTask, that waits for 0.5s. > If sharing is disabled, read_thread will immediately return and cause the > main_loop to stop. > This i

Re: [Spice-devel] [phodav PATCH 2/3 v3] spice-webdavd-windows: Check for mapped shared folder

2016-03-30 Thread Victor Toso
On Thu, Mar 24, 2016 at 04:39:41PM +0100, Lukas Venhoda wrote: > Check whether Spice Folder is already mapped. > If yes, don't try to map another one. > --- > Changes since v3: > - changed function is_spice_folder_mapped to get_spice_folder_letter > - Now returns the mapped folder drive letter

Re: [Spice-devel] [phodav PATCH 3/3 v3] spice-webdavd-windows: Dismount shared folder on service stop

2016-03-30 Thread Victor Toso
On Thu, Mar 24, 2016 at 04:39:42PM +0100, Lukas Venhoda wrote: > When stopping the service, automatically disconnect shared folder on > windows. Not dismounting could lead to multiple shared folders. > --- > Changes since v3: > - Better handeling of string names > - Syntax cleanup > - Remove glo

Re: [Spice-devel] [PATCH] channel: do not free rcc->stream in red_channel_client_disconnect

2016-03-30 Thread Eduardo Lima (Etrunko)
On 03/30/2016 06:44 AM, Victor Toso wrote: > On Tue, Mar 29, 2016 at 09:35:12AM -0300, Eduardo Lima (Etrunko) wrote: >> On 01/19/2016 08:14 AM, Victor Toso wrote: >>> Hi, >>> >>> On Tue, Jan 19, 2016 at 09:52:24AM +, Frediano Ziglio wrote: This fixes a crash if red_channel_client disconnec

Re: [Spice-devel] [PATCH spice-gtk 1/2] SpiceUsbDeviceManager: propagate errors from sub-tasks

2016-03-30 Thread Dmitry Fleytman
> On 29 Mar 2016, at 18:25 PM, Jonathon Jongsma wrote: > > Thanks, I've pushed these along with the other usbdk patches from Dmitry and > Kirill Thanks, Jonathon. > > > On Tue, 2016-03-29 at 16:49 +0200, Christophe Fergeau wrote: >> Acked-by: Christophe Fergeau >> >> On Thu, Mar 24, 2016 a

Re: [Spice-devel] [PATCH] [OT] channel: do not free rcc->stream in red_channel_client_disconnect

2016-03-30 Thread Frediano Ziglio
> > On 03/30/2016 06:44 AM, Victor Toso wrote: > > On Tue, Mar 29, 2016 at 09:35:12AM -0300, Eduardo Lima (Etrunko) wrote: > >> On 01/19/2016 08:14 AM, Victor Toso wrote: > >>> Hi, > >>> > >>> On Tue, Jan 19, 2016 at 09:52:24AM +, Frediano Ziglio wrote: > This fixes a crash if red_channel

Re: [Spice-devel] [spice-server 1/3] Remove duplicate typedef from headers

2016-03-30 Thread Christophe Fergeau
On Wed, Mar 30, 2016 at 09:15:07AM -0400, Frediano Ziglio wrote: > > > > This is causing compile errors with older gcc versions. > > > > reds.h includes reds-stream.h through red-channel.h so it will get the > > RedsState typedef this way. > > > > red-qxl.h includes spice-qxl.h through red-chann

Re: [Spice-devel] [PATCH 07/13] smartcard: Prepare to turn SmartcardState into a GObject

2016-03-30 Thread Jonathon Jongsma
On Wed, 2016-03-23 at 12:48 +, Frediano Ziglio wrote: > From: Christophe Fergeau > > This inherits from RedCharDevice. Once all char device states are > converted, we can turn the associated vfuncs into RedCharDeviceClass > vfuncs. Looks like this got split from the next patch but the log me

Re: [Spice-devel] [spice-server 1/3] Remove duplicate typedef from headers

2016-03-30 Thread Frediano Ziglio
> > On Wed, Mar 30, 2016 at 09:15:07AM -0400, Frediano Ziglio wrote: > > > > > > This is causing compile errors with older gcc versions. > > > > > > reds.h includes reds-stream.h through red-channel.h so it will get the > > > RedsState typedef this way. > > > > > > red-qxl.h includes spice-qxl.

Re: [Spice-devel] [PATCH 07/13] smartcard: Prepare to turn SmartcardState into a GObject

2016-03-30 Thread Frediano Ziglio
> > On Wed, 2016-03-23 at 12:48 +, Frediano Ziglio wrote: > > From: Christophe Fergeau > > > > This inherits from RedCharDevice. Once all char device states are > > converted, we can turn the associated vfuncs into RedCharDeviceClass > > vfuncs. > > Looks like this got split from the next p

Re: [Spice-devel] [spice-server 1/3] Remove duplicate typedef from headers

2016-03-30 Thread Christophe Fergeau
On Wed, Mar 30, 2016 at 01:38:20PM +0200, Pavel Grunt wrote: > Hi, > > I agree that there should be the only one typedef. But I don't > understand why not to include the needed header directly. We should try > to "untagle" these header dependencies. OH from my side I don't mind adding the headers

Re: [Spice-devel] [PATCH spice-common] Fix build in systems with Glib version older than 2.38

2016-03-30 Thread Christophe Fergeau
On Wed, Mar 30, 2016 at 09:12:56AM -0300, Eduardo Lima (Etrunko) wrote: > From: "Eduardo Lima (Etrunko)" > > Tests now include functions only available in glib 2.38. To avoid > setting the dependency bar too high, we simply put them between #ifdef > guards. > > Signed-off-by: Eduardo Lima (Etrun

Re: [Spice-devel] RFC: XSpice shift to an 'x11spice' approach

2016-03-30 Thread Jeremy White
On 03/29/2016 05:43 AM, Francois Gouget wrote: > On Mon, 28 Mar 2016, Jeremy White wrote: > [...] > >> Hi folks, >> >> As you know, I've done a lot of work on XSpice over the past few years. >> I plan to take a new approach by following the model of the excellent >> 'x11vnc' client. > [...] >> Wh

Re: [Spice-devel] RFC: XSpice shift to an 'x11spice' approach

2016-03-30 Thread Jeremy White
On 03/30/2016 04:57 AM, Pedro Francisco wrote: > Sending to list as well, this time. > > 2016-03-28 15:19 GMT+01:00 Jeremy White : >> Hi folks, >> >> As you know, I've done a lot of work on XSpice over the past few years. >> I plan to take a new approach by following the model of the excellent >>

Re: [Spice-devel] [spice-server 1/3] Remove duplicate typedef from headers

2016-03-30 Thread Christophe Fergeau
On Wed, Mar 30, 2016 at 11:37:41AM -0400, Frediano Ziglio wrote: > > Then reds-stream.h would need an additional #include "reds.h" as > > otherwise build fails as some places are including reds-stream.h without > > including reds.h > > You can either use "struct RedsState" or "SpiceServer". > The

[Spice-devel] [PATCH] Remove duplicate typedef from headers

2016-03-30 Thread Frediano Ziglio
This is causing compile errors with older gcc versions. reds.h includes reds-stream.h through red-channel.h so it will get the RedsState typedef this way. red-qxl.h includes spice-qxl.h through red-channel.h and then spice.h, so it will get the QXLState typedef this way. Signed-off-by: Christoph

Re: [Spice-devel] [PATCH 07/13] smartcard: Prepare to turn SmartcardState into a GObject

2016-03-30 Thread Jonathon Jongsma
On Wed, 2016-03-30 at 11:51 -0400, Frediano Ziglio wrote: > > > > On Wed, 2016-03-23 at 12:48 +, Frediano Ziglio wrote: > > > From: Christophe Fergeau > > > > > > This inherits from RedCharDevice. Once all char device states are > > > converted, we can turn the associated vfuncs into RedChar

Re: [Spice-devel] [PATCH] Remove duplicate typedef from headers

2016-03-30 Thread Christophe Fergeau
On Wed, Mar 30, 2016 at 05:33:50PM +0100, Frediano Ziglio wrote: > This is causing compile errors with older gcc versions. > > reds.h includes reds-stream.h through red-channel.h so it will get the > RedsState typedef this way. > > red-qxl.h includes spice-qxl.h through red-channel.h and then spi

[Spice-devel] [PATCH 01/10] char-device: Avoid use-after-free

2016-03-30 Thread Frediano Ziglio
From: Christophe Fergeau Reset pointer after freeing the structure pointing to it. --- server/char-device.c | 1 + 1 file changed, 1 insertion(+) diff --git a/server/char-device.c b/server/char-device.c index 6704678..53bfe82 100644 --- a/server/char-device.c +++ b/server/char-device.c @@ -211,

[Spice-devel] [PATCH 03/10] spicevmc: Introduce RedCharDeviceSpiceVmc GObject

2016-03-30 Thread Frediano Ziglio
From: Christophe Fergeau --- server/spicevmc.c | 80 +-- 1 file changed, 66 insertions(+), 14 deletions(-) diff --git a/server/spicevmc.c b/server/spicevmc.c index 367132c..666941f 100644 --- a/server/spicevmc.c +++ b/server/spicevmc.c @@ -61,

[Spice-devel] [PATCH 08/10] reds: Make VDIPortState a GObject

2016-03-30 Thread Frediano Ziglio
From: Christophe Fergeau This inherits from RedCharDevice. Signed-off-by: Christophe Fergeau --- server/reds-private.h | 2 +- server/reds.c | 242 -- 2 files changed, 157 insertions(+), 87 deletions(-) diff --git a/server/reds-private

[Spice-devel] [PATCH 00/10] Backported some patches from refactory branches (30th Mar)

2016-03-30 Thread Frediano Ziglio
Changes: - merged some patches; - rename some property nick name; - move some hunks from "Introduce RedCharDeviceSpiceVmc GObject" to "Move SpiceVmcState::pipe_item to RedCharDeviceSpiceVmc" (private declaration); - split "Make SpiceCharDeviceState a GObject"; - remove some temporary defines fr

[Spice-devel] [PATCH 10/10] Move SpiceCharDeviceCallbacks into RedCharDeviceClass

2016-03-30 Thread Frediano Ziglio
From: Christophe Fergeau This structure holding virtual function pointers was kept until now as a RedCharDevice member in order to make the GObject conversion easier. Now that all RedCharDevice children are converted to GObject, it can be moved into RedCharDeviceClass. --- server/char-device.c |

[Spice-devel] [PATCH 09/10] reds: Remove spice_char_device_state_create()

2016-03-30 Thread Frediano Ziglio
From: Christophe Fergeau Nothing is using it anymore now that CharDevice classes are gobjectified. --- server/char-device.c | 42 -- server/char-device.h | 11 +-- 2 files changed, 1 insertion(+), 52 deletions(-) diff --git a/server/char-device.c

[Spice-devel] [PATCH 04/10] spicevmc: Move SpiceVmcState::pipe_item to RedCharDeviceSpiceVmc

2016-03-30 Thread Frediano Ziglio
From: Christophe Fergeau This pipe item belongs to the char device, not to the spicevmc channel. --- server/spicevmc.c | 35 --- 1 file changed, 28 insertions(+), 7 deletions(-) diff --git a/server/spicevmc.c b/server/spicevmc.c index 666941f..b047b66 100644 ---

[Spice-devel] [PATCH 07/10] reds: Prepare to make VDIPortState a GObject

2016-03-30 Thread Frediano Ziglio
From: Christophe Fergeau This inherits from RedCharDevice. Signed-off-by: Christophe Fergeau Signed-off-by: Frediano Ziglio --- server/reds.c | 383 +- 1 file changed, 194 insertions(+), 189 deletions(-) diff --git a/server/reds.c b/ser

[Spice-devel] [PATCH 02/10] char-device: Make SpiceCharDeviceState a GObject

2016-03-30 Thread Frediano Ziglio
From: Christophe Fergeau --- server/char-device.c | 352 ++- server/char-device.h | 43 ++- 2 files changed, 304 insertions(+), 91 deletions(-) diff --git a/server/char-device.c b/server/char-device.c index 53bfe82..7fd2a0b 100644 --- a/serve

[Spice-devel] [PATCH 06/10] reds: Make VDIPortState private to reds.c

2016-03-30 Thread Frediano Ziglio
From: Christophe Fergeau VDIPortState and VDIReadBuf don't really need to be defined in a header file as they are only used in reds.c --- server/reds-private.h | 56 + server/reds.c | 167 +- 2 files changed, 113 insertions

[Spice-devel] [PATCH 05/10] smartcard: Turn SmartcardState into a GObject

2016-03-30 Thread Frediano Ziglio
From: Christophe Fergeau This inherits from RedCharDevice. Once all char device states are converted, we can turn the associated vfuncs into RedCharDeviceClass vfuncs. Signed-off-by: Christophe Fergeau --- server/smartcard.c | 125 ++--- server/s

Re: [Spice-devel] RFC: XSpice shift to an 'x11spice' approach

2016-03-30 Thread Pedro Francisco
2016-03-30 17:09 GMT+01:00 Jeremy White : > I'm not sure I follow the relevance to this thread, though. You're right. Since x11vnc is able to provide Remote Desktop Services [1] I got myself confused about x11spice using framebuffer. [1] http://www.karlrunge.com/x11vnc/x11vnc_opts.html#opt-svc _

Re: [Spice-devel] RFC: XSpice shift to an 'x11spice' approach

2016-03-30 Thread Pedro Francisco
2016-03-28 15:19 GMT+01:00 Jeremy White : > This should have a number of benefits. First, it should create a new > capability - the ability to share an existing desktop via Spice. I'm all for this. Personally I don't need the 'xpra' part. Running full-screen, "Remote Desktop" style, sharing a ex

[Spice-devel] [PATCH v2 spice-common] Fix build in systems with Glib version older than 2.38

2016-03-30 Thread Eduardo Lima (Etrunko)
Tests now include functions only available in glib 2.38. To avoid setting the dependency bar too high, we simply put them between #ifdef guards. Signed-off-by: Eduardo Lima (Etrunko) --- tests/test-logging.c | 4 tests/test-marshallers.c | 4 2 files changed, 8 insertions(+) diff

Re: [Spice-devel] [PATCH 08/13] smartcard: Turn SmartcardState into a GObject

2016-03-30 Thread Jonathon Jongsma
On Wed, 2016-03-23 at 12:48 +, Frediano Ziglio wrote: > From: Christophe Fergeau > > This inherits from RedCharDevice. Once all char device states are > converted, we can turn the associated vfuncs into RedCharDeviceClass > vfuncs. > > Signed-off-by: Christophe Fergeau > --- > server/smart

Re: [Spice-devel] [PATCH 01/10] char-device: Avoid use-after-free

2016-03-30 Thread Jonathon Jongsma
On Wed, 2016-03-30 at 18:20 +0100, Frediano Ziglio wrote: > From: Christophe Fergeau > > Reset pointer after freeing the structure pointing to it. > --- > server/char-device.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/server/char-device.c b/server/char-device.c > index 6704678..5

Re: [Spice-devel] [PATCH 02/10] char-device: Make SpiceCharDeviceState a GObject

2016-03-30 Thread Jonathon Jongsma
On Wed, 2016-03-30 at 18:20 +0100, Frediano Ziglio wrote: > From: Christophe Fergeau > > --- > server/char-device.c | 352 ++ > - > server/char-device.h | 43 ++- > 2 files changed, 304 insertions(+), 91 deletions(-) > > diff --git a/server/c

Re: [Spice-devel] [PATCH 03/10] spicevmc: Introduce RedCharDeviceSpiceVmc GObject

2016-03-30 Thread Jonathon Jongsma
On Wed, 2016-03-30 at 18:21 +0100, Frediano Ziglio wrote: > From: Christophe Fergeau > > --- > server/spicevmc.c | 80 +- > - > 1 file changed, 66 insertions(+), 14 deletions(-) > > diff --git a/server/spicevmc.c b/server/spicevmc.c > index 36

Re: [Spice-devel] [PATCH 04/10] spicevmc: Move SpiceVmcState::pipe_item to RedCharDeviceSpiceVmc

2016-03-30 Thread Jonathon Jongsma
see my comments at https://lists.freedesktop.org/archives/spice-devel/2016-March/027794.html On Wed, 2016-03-30 at 18:21 +0100, Frediano Ziglio wrote: > From: Christophe Fergeau > > This pipe item belongs to the char device, not to the spicevmc channel. > --- > server/spicevmc.c | 35 +

Re: [Spice-devel] [PATCH 05/10] smartcard: Turn SmartcardState into a GObject

2016-03-30 Thread Jonathon Jongsma
See comments at https://lists.freedesktop.org/archives/spice-devel/2016-March/027850.html On Wed, 2016-03-30 at 18:21 +0100, Frediano Ziglio wrote: > From: Christophe Fergeau > > This inherits from RedCharDevice. Once all char device states are > converted, we can turn the associated vfuncs int

Re: [Spice-devel] [PATCH 02/10] char-device: Make SpiceCharDeviceState a GObject

2016-03-30 Thread Jonathon Jongsma
On Wed, 2016-03-30 at 14:25 -0500, Jonathon Jongsma wrote: > On Wed, 2016-03-30 at 18:20 +0100, Frediano Ziglio wrote: > > From: Christophe Fergeau > > > > --- > > server/char-device.c | 352 ++-- > > -- > > - > > server/char-device.h | 43 ++- > >

Re: [Spice-devel] [PATCH 05/10] smartcard: Turn SmartcardState into a GObject

2016-03-30 Thread Jonathon Jongsma
Here's a patch that I think could be squashed into this one: diff --git a/server/smartcard.c b/server/smartcard.c index f592a9f..3d40f59 100644 --- a/server/smartcard.c +++ b/server/smartcard.c @@ -67,7 +67,6 @@ G_DEFINE_TYPE(RedCharDeviceSmartcard, red_char_device_smartcard, RED_TYPE_CHAR_D #def

[Spice-devel] [PATCH] Use RedCharDevice instead of SpiceCharDeviceState

2016-03-30 Thread Jonathon Jongsma
These two type names are typedefs of eachother, but it's confusing to have two different typenames for the same type throughout the code. Convert everythign to use RedCharDevice. --- This patch should apply to the end of this patch series. Comments? server/char-device.c | 238 +

Re: [Spice-devel] [PATCH] Use RedCharDevice instead of SpiceCharDeviceState

2016-03-30 Thread Victor Toso
Hi Jonathon, On Wed, Mar 30, 2016 at 05:17:47PM -0500, Jonathon Jongsma wrote: > These two type names are typedefs of eachother, but it's confusing to > have two different typenames for the same type throughout the code. > Convert everythign to use RedCharDevice. I agree with you about this. > -