Hey,
On Mon, Mar 28, 2016 at 06:00:27PM -0300, Eduardo Lima (Etrunko) wrote:
> From: "Eduardo Lima (Etrunko)"
>
> Recent logging tests make use of g_test_subprocess() and
> g_test_trap_subprocess() functions, available only in glib newer than
> 2.38.
glib 2.38 is far too new to be used as the g
On Mon, Mar 28, 2016 at 06:00:28PM -0300, Eduardo Lima (Etrunko) wrote:
> From: "Eduardo Lima (Etrunko)"
>
> It is required to compile ssl-verify.[ch].
Makes sense. Any idea why it could be built without issues so far? Did
you hit some compilation problems which led to this patch?
Acked-by: Chr
> On Wed, Mar 23, 2016 at 12:48:27PM +, Frediano Ziglio wrote:
> > From: Jonathon Jongsma
> >
> > Allows more explicit inheritance relationship, and numerous other
> > advantages.
> > ---
> > server/dispatcher.c | 234
> > ---
> > server/di
On Thu, 2016-03-24 at 13:58 +0100, Christophe Fergeau wrote:
> On Wed, Mar 23, 2016 at 05:59:03PM +0100, Pavel Grunt wrote:
> >
> > On Wed, 2016-03-23 at 17:45 +0100, Christophe Fergeau wrote:
> > >
> > > But it seems these are good enough, when I tested this, Xorg was
> > > picking
> > > the QXL
Hey,
I believe this could be pushed to the 0.12 branch as well?
Christophe
On Thu, Feb 18, 2016 at 09:49:45AM +, Frediano Ziglio wrote:
> This could happen with buggy driver.
>
> Signed-off-by: Frediano Ziglio
> ---
> server/memslot.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-
Hey,
Does this make sense to have this in the 0.12 branch too?
Christophe
On Tue, Jan 19, 2016 at 10:36:58AM +, Frediano Ziglio wrote:
> This fixes a crash if red_channel_client disconnect is called
> handling a message.
> This can happen for instance handling SPICE_MSGC_ACK which calls
> re
>
> Hey,
>
> I believe this could be pushed to the 0.12 branch as well?
>
> Christophe
>
Agreed
Frediano
> On Thu, Feb 18, 2016 at 09:49:45AM +, Frediano Ziglio wrote:
> > This could happen with buggy driver.
> >
> > Signed-off-by: Frediano Ziglio
> > ---
> > server/memslot.c | 2 +-
>
On Mon, 28 Mar 2016, Jeremy White wrote:
[...]
> Hi folks,
>
> As you know, I've done a lot of work on XSpice over the past few years.
> I plan to take a new approach by following the model of the excellent
> 'x11vnc' client.
[...]
> What do others think? What am I over looking?
One of the big
On 03/29/2016 05:24 AM, Christophe Fergeau wrote:
> On Mon, Mar 28, 2016 at 06:00:28PM -0300, Eduardo Lima (Etrunko) wrote:
>> From: "Eduardo Lima (Etrunko)"
>>
>> It is required to compile ssl-verify.[ch].
>
> Makes sense. Any idea why it could be built without issues so far? Did
> you hit some
On 03/29/2016 05:18 AM, Christophe Fergeau wrote:
> Hey,
>
> On Mon, Mar 28, 2016 at 06:00:27PM -0300, Eduardo Lima (Etrunko) wrote:
>> From: "Eduardo Lima (Etrunko)"
>>
>> Recent logging tests make use of g_test_subprocess() and
>> g_test_trap_subprocess() functions, available only in glib newer
On 01/19/2016 08:14 AM, Victor Toso wrote:
> Hi,
>
> On Tue, Jan 19, 2016 at 09:52:24AM +, Frediano Ziglio wrote:
>> This fixes a crash if red_channel_client disconnect is called
>> handling a message.
>> This can happen for instance handling SPICE_MSGC_ACK which calls
>> red_channel_client_pu
On Tue, Mar 29, 2016 at 09:26:49AM -0300, Eduardo Lima (Etrunko) wrote:
> On 03/29/2016 05:18 AM, Christophe Fergeau wrote:
> > Hey,
> >
> > On Mon, Mar 28, 2016 at 06:00:27PM -0300, Eduardo Lima (Etrunko) wrote:
> >> From: "Eduardo Lima (Etrunko)"
> >>
> >> Recent logging tests make use of g_tes
"&&" has higher precedency than "?:"
Fixes:
https://bugs.freedesktop.org/show_bug.cgi?id=94738
---
src/spice-widget.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/src/spice-widget.c b/src/spice-widget.c
index 21b1c14..67a9cc1 100644
--- a/src/spice-widget.c
+++ b/src
eglTerminate should be called on unrealize. This not yet fix all the
leaks but reduces it significantly from 318kb to 74kb as definitely lost
and around 1mb to 8kb as indirectly lost.
4,096 bytes in 1 blocks are definitely lost in loss record
9,762 of 9,882
at 0x35B19E40: drm_intel_gem_bo_map (
On 03/29/2016 09:54 AM, Mahmood Naderan wrote:
>>What is the version of glib in your system?
>>Those functions were added in version 2.38.
>
> OK. Currently I am using Centos-6.5 which is rather old.
> Anyway thanks...
>
I am working on a patch to fix this error in older systems, such as
RHEL6
ack
On Tue, Mar 29, 2016 at 3:03 PM, Pavel Grunt wrote:
> "&&" has higher precedency than "?:"
>
> Fixes:
> https://bugs.freedesktop.org/show_bug.cgi?id=94738
> ---
> src/spice-widget.c | 7 +++
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/src/spice-widget.c b/src/spice
Hey,
Works fine! Thanks!
On Tue, Mar 29, 2016 at 03:03:03PM +0200, Pavel Grunt wrote:
> "&&" has higher precedency than "?:"
Maybe a small summary of the issue that his patch fixes?
>
> Fixes:
> https://bugs.freedesktop.org/show_bug.cgi?id=94738
> ---
> src/spice-widget.c | 7 +++
> 1 file
ack (that makes me wonder if we should have a global EGLDisplay instead of each
widget).
- Original Message -
> eglTerminate should be called on unrealize. This not yet fix all the
> leaks but reduces it significantly from 318kb to 74kb as definitely lost
> and around 1mb to 8kb as indire
On Tue, 2016-03-29 at 15:39 +0200, Victor Toso wrote:
> Hey,
>
> Works fine! Thanks!
>
> On Tue, Mar 29, 2016 at 03:03:03PM +0200, Pavel Grunt wrote:
> >
> > "&&" has higher precedency than "?:"
> Maybe a small summary of the issue that his patch fixes?
>
> >
> >
> > Fixes:
> > https://bugs.f
Acked-by: Christophe Fergeau
On Thu, Mar 24, 2016 at 03:29:23PM -0500, Jonathon Jongsma wrote:
> _connect_device_async_cb() just turned TRUE unconditionally even if the
> sub-task had failed. Instad, introduce a
> _spice_usb_device_manager_connect_device_finish() function which passes
> up the r
Logical operators like "&&" has higher precedency than "?:".
Readiness of SpiceDisplay was wrongly determined due to missing
parentheses around the ternary operator.
Fixes:
https://bugs.freedesktop.org/show_bug.cgi?id=94738
---
src/spice-widget.c | 11 ++-
1 file changed, 6 insertions(+),
O that is good :thumsup:I applied the patch and the compilation passed that
file. However, I get a new undefined reference in another file
root@cluster:spice-src# patch < patch
can't find file to patch at input line 5
Perhaps you should have used the -p or --strip option?
The text leading up to t
Hi,
On Tue, Mar 29, 2016 at 09:55:53AM -0400, Marc-André Lureau wrote:
> ack (that makes me wonder if we should have a global EGLDisplay instead of
> each widget).
Single EGLDisplay would work with multi-monitor?
>
> - Original Message -
> > eglTerminate should be called on unrealize. T
Hi,
On Tue, Mar 29, 2016 at 05:08:28PM +0200, Pavel Grunt wrote:
> Logical operators like "&&" has higher precedency than "?:".
> Readiness of SpiceDisplay was wrongly determined due to missing
> parentheses around the ternary operator.
>
> Fixes:
> https://bugs.freedesktop.org/show_bug.cgi?id=94
Thanks, I've pushed these along with the other usbdk patches from Dmitry and
Kirill
On Tue, 2016-03-29 at 16:49 +0200, Christophe Fergeau wrote:
> Acked-by: Christophe Fergeau
>
> On Thu, Mar 24, 2016 at 03:29:23PM -0500, Jonathon Jongsma wrote:
> > _connect_device_async_cb() just turned TRUE u
Hi
- Original Message -
> Hi,
>
> On Tue, Mar 29, 2016 at 09:55:53AM -0400, Marc-André Lureau wrote:
> > ack (that makes me wonder if we should have a global EGLDisplay instead of
> > each widget).
>
> Single EGLDisplay would work with multi-monitor?
It doesn't have to do with multi-mon
Hi,
On Tue, 2016-03-29 at 17:23 +0200, Victor Toso wrote:
> Hi,
>
> On Tue, Mar 29, 2016 at 05:08:28PM +0200, Pavel Grunt wrote:
> >
> > Logical operators like "&&" has higher precedency than "?:".
> > Readiness of SpiceDisplay was wrongly determined due to missing
> > parentheses around the tern
>
> Hey,
>
> Does this make sense to have this in the 0.12 branch too?
>
> Christophe
>
I remember I was able to reproduce... I don't remember how.
Something like adding a line somewhere.
Perhaps shutting down the socket before handling SPICE_MSGC_ACK?
I think the patch is safe and fix a real
Dropped in 70a00b8fcc2ca85d3601f6ac4895f906f9032e77
---
doc/reference/spice-gtk-sections.txt | 2 --
1 file changed, 2 deletions(-)
diff --git a/doc/reference/spice-gtk-sections.txt
b/doc/reference/spice-gtk-sections.txt
index a108386..8947893 100644
--- a/doc/reference/spice-gtk-sections.txt
++
Parameter name is "self"
---
src/usb-device-manager.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/usb-device-manager.c b/src/usb-device-manager.c
index c36a9a8..b5fa694 100644
--- a/src/usb-device-manager.c
+++ b/src/usb-device-manager.c
@@ -233,7 +233,7 @@ G_DEFINE_BOX
ack
- Original Message -
> Dropped in 70a00b8fcc2ca85d3601f6ac4895f906f9032e77
> ---
> doc/reference/spice-gtk-sections.txt | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/doc/reference/spice-gtk-sections.txt
> b/doc/reference/spice-gtk-sections.txt
> index a108386..8947893 100
On Wed, 2016-03-23 at 12:48 +, Frediano Ziglio wrote:
> From: Christophe Fergeau
>
> ---
> server/spicevmc.c | 102 ++---
> -
> 1 file changed, 88 insertions(+), 14 deletions(-)
>
> diff --git a/server/spicevmc.c b/server/spicevmc.c
> index f7
On Tue, 2016-03-29 at 11:53 -0500, Jonathon Jongsma wrote:
> On Wed, 2016-03-23 at 12:48 +, Frediano Ziglio wrote:
> > From: Christophe Fergeau
> >
> > ---
> > server/spicevmc.c | 102 ++-
> > --
> > -
> > 1 file changed, 88 insertions(+), 14
Hi,
On Tue, Mar 29, 2016 at 09:55:53AM -0400, Marc-André Lureau wrote:
> ack (that makes me wonder if we should have a global EGLDisplay instead of
> each widget).
Pushed!
https://cgit.freedesktop.org/spice/spice-gtk/commit/?id=181ec2511902483
>
> - Original Message -
> > eglTerminate
On Wed, 2016-03-23 at 12:48 +, Frediano Ziglio wrote:
> From: Christophe Fergeau
>
> This pipe item belongs to the char device, not to the spicevmc channel.
I'm not so sure about this. In general PipeItem seems to be pretty closely tied
to spice communication (i.e. spice channels and channel
35 matches
Mail list logo
