>
> Removing more global variables
> ---
>
> v2:
> - use gboolean type instead of int
>
>
> server/reds-private.h | 1 +
> server/reds.c | 10 +-
> 2 files changed, 6 insertions(+), 5 deletions(-)
>
> diff --git a/server/reds-private.h b/server/reds-private.h
> index bc790e8
On Tue, 2016-02-02 at 16:05 +, Frediano Ziglio wrote:
> From: Jonathon Jongsma
>
> Since this is public API, we can't easily change the signature of the
> function to take a RedsState argument, so instead we apply a hack and
> store the reds argument inside the device state struct when the
>
On Tue, 2016-02-02 at 16:05 +, Frediano Ziglio wrote:
> From: Jonathon Jongsma
>
> Also requires adding reds_get_streaming_video() accessor so that
> other
> files can check this value.
> ---
> server/red-dispatcher.c | 7 ---
> server/red-worker.c | 2 +-
> server/reds-private.h |
Hi
- Original Message -
> On Mi, 2016-02-03 at 13:27 +0900, Sunny Shin wrote:
> > I heard that iptv uses udp multicast, so I thought that performance
> > might be better if we use udp for video streaming.
>
> spice != tv. No multicast here. Oh, and udp/multicast doesn't improve
> perfor
On 01/18/2016 01:03 PM, Francois Gouget wrote:
The source changed so here is the new revision of this patchset.
This patch series adds support for using GStreamer to encode and decode
the video streams, adding support for VP8 and h264 codecs. As before the
patches can also be grabbed from the r
This patchset attempt to fix some possible hangs with main loop,
improve latency and loop usage and decrease cpu usage.
Changes from v1:
- fixed typos in comments (Jonathon);
- better message for commit (Jonathon);
- reuse more code adding items;
- use gboolean and TRUE/FALSE instead of bool and t
Make sure we process commands after we can send data to client.
If during processing we detected that there was too much data in the
clients queues the processing of commands just stop till the next
iteration.
However if all data are pushed in a single iteration of the loop
and commands were alread
Now that processing is correctly restored there is no need to keep
polling to avoid main loop hangs. Reduce the polling count to 1
(just try once).
This reduce cpu usage if guests are mainly idle.
If you consider 100 guests waiting to login with cursor blinking
and considering the polling was done
The req_cmd_notification callback is called by spice-server when it
has processed all commands and wants to be notified (by a wakeup) that
new commands have been appended to the command queue.
Replay utility tries to fill the commands when it detects that
spice-server is trying to read commands but
During every iteration of the main worker loop, outgoing data was pushed to
the client. However, there was no guarantee that the loop would be woken up
in every situation. So there were some conditions where the loop would stop
iterating until a new event was sent.
Currently, the events that can w
>
> ping
>
Integrated part of the patches
There are still some issues not replied and I'd like to see the problem
of pending drawing while fd removed fixed.
Frediano
> On Mon, Jan 11, 2016 at 1:40 PM, Marc-André Lureau
> wrote:
> > The following series implements the x11 client-side suppor
Hi
On Fri, Jan 22, 2016 at 12:36 PM, Marc-André Lureau
wrote:
> Hi
>
> On Tue, Jan 19, 2016 at 11:41 AM, Frediano Ziglio wrote:
>> Instead of using libserver.a to include necessary functions we include
>> single files to check for dependencies.
>>
>> Signed-off-by: Frediano Ziglio
>> ---
>> se
has_fd was not initialized.
Signed-off-by: Frediano Ziglio
---
common/marshaller.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/common/marshaller.c b/common/marshaller.c
index cffc641..00a7123 100644
--- a/common/marshaller.c
+++ b/common/marshaller.c
@@ -117,6 +117,7 @@ static void spice
>
> Hi
>
> On Fri, Jan 22, 2016 at 12:36 PM, Marc-André Lureau
> wrote:
> > Hi
> >
> > On Tue, Jan 19, 2016 at 11:41 AM, Frediano Ziglio
> > wrote:
> >> Instead of using libserver.a to include necessary functions we include
> >> single files to check for dependencies.
> >>
> >> Signed-off-by: F
On Tue, 2016-02-02 at 16:05 +, Frediano Ziglio wrote:
> From: Jonathon Jongsma
>
> Required adding a RedsState arg to reds_get_agent_mouse()
> ---
> server/inputs-channel.c | 8
> server/reds-private.h | 2 ++
> server/reds.c | 10 +-
> server/reds.h
ack
- Original Message -
> has_fd was not initialized.
>
> Signed-off-by: Frediano Ziglio
> ---
> common/marshaller.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/common/marshaller.c b/common/marshaller.c
> index cffc641..00a7123 100644
> --- a/common/marshaller.c
> +++ b/c
Hi
- Original Message -
> >
> > Hi
> >
> > On Fri, Jan 22, 2016 at 12:36 PM, Marc-André Lureau
> > wrote:
> > > Hi
> > >
> > > On Tue, Jan 19, 2016 at 11:41 AM, Frediano Ziglio
> > > wrote:
> > >> Instead of using libserver.a to include necessary functions we include
> > >> single file
Signed-off-by: Frediano Ziglio
---
spice-common | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/spice-common b/spice-common
index 472e563..fd9ba72 16
--- a/spice-common
+++ b/spice-common
@@ -1 +1 @@
-Subproject commit 472e563591a80f75679be2ea855e660c6ee51721
+Subproject c
This patch, which has now been committed as 8b14dc11, breaks Xspice.
With it I get the following error on startup:
(process:25109): Spice-CRITICAL **: reds-stream.c:271:reds_stream_send_msgfd:
condition `reds_stream_is_plain_unix(stream)' failed
Unfortuntely I have not found a fix/workaround.
Hi
- Original Message -
>
> This patch, which has now been committed as 8b14dc11, breaks Xspice.
> With it I get the following error on startup:
>
> (process:25109): Spice-CRITICAL **: reds-stream.c:271:reds_stream_send_msgfd:
> condition `reds_stream_is_plain_unix(stream)' failed
>
> U
Ack
On Wed, 2016-02-03 at 11:54 +, Frediano Ziglio wrote:
> Signed-off-by: Frediano Ziglio
> ---
> spice-common | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/spice-common b/spice-common
> index 472e563..fd9ba72 16
> --- a/spice-common
> +++ b/spice-common
> @@
>
> From: Jonathon Jongsma
>
> Also required adding reds_get_zlib_glz_state() for external access.
> ---
> server/red-worker.c | 2 +-
> server/reds-private.h | 1 +
> server/reds.c | 9 +++--
> server/reds.h | 2 +-
> 4 files changed, 10 insertions(+), 4 deletions(-)
>
>
>
> From: Jonathon Jongsma
>
> Removing more global variables
> ---
> server/reds-private.h | 1 +
> server/reds.c | 16
> 2 files changed, 9 insertions(+), 8 deletions(-)
>
> diff --git a/server/reds-private.h b/server/reds-private.h
> index 9bfade8..52f88f8 100644
>
>
> From: Jonathon Jongsma
>
> Removing more global variables
> ---
> server/reds-private.h | 1 +
> server/reds.c | 16
> 2 files changed, 9 insertions(+), 8 deletions(-)
>
> diff --git a/server/reds-private.h b/server/reds-private.h
> index 52f88f8..9c3db70 100644
>
>
> From: Jonathon Jongsma
>
> Removing more global variables
> ---
> server/reds-private.h | 1 +
> server/reds.c | 6 +++---
> 2 files changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/server/reds-private.h b/server/reds-private.h
> index 9c3db70..5042773 100644
> --- a/serve
On Tue, 2016-02-02 at 16:06 +, Frediano Ziglio wrote:
> From: Jonathon Jongsma
>
> Removing more global variables
Acked-by: Pavel Grunt
> ---
> server/reds-private.h | 1 +
> server/reds.c | 6 +++---
> 2 files changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/server/reds-p
On Wed, 3 Feb 2016, Marc-André Lureau wrote:
> Hi
>
> - Original Message -
> >
> > This patch, which has now been committed as 8b14dc11, breaks Xspice.
> > With it I get the following error on startup:
> >
> > (process:25109): Spice-CRITICAL **:
> > reds-stream.c:271:reds_stream_send_m
OK
Acked-by: Jonathon Jongsma
On Fri, 2016-01-29 at 10:53 +, Frediano Ziglio wrote:
> Now that processing is correctly restored there is no need to keep
> polling to avoid main loop hangs. Reduce the polling count to 1
> (just try once).
> This reduce cpu usage if guests are mainly idle.
>
Acked-by: Jonathon Jongsma
On Wed, 2016-02-03 at 10:48 +, Frediano Ziglio wrote:
> During every iteration of the main worker loop, outgoing data was pushed to
> the client. However, there was no guarantee that the loop would be woken up
> in every situation. So there were some conditions wher
On Wed, 2016-02-03 at 10:48 +, Frediano Ziglio wrote:
> The req_cmd_notification callback is called by spice-server when it
> has processed all commands and wants to be notified (by a wakeup) that
> new commands have been appended to the command queue.
> Replay utility tries to fill the command
Acked-by: Jonathon Jongsma
On Wed, 2016-02-03 at 10:48 +, Frediano Ziglio wrote:
> Make sure we process commands after we can send data to client.
> If during processing we detected that there was too much data in the
> clients queues the processing of commands just stop till the next
> itera
Just acked the previous version before I noticed this new patchset.
Acked-by: Jonathon Jongsma
On Wed, 2016-02-03 at 10:48 +, Frediano Ziglio wrote:
> Now that processing is correctly restored there is no need to keep
> polling to avoid main loop hangs. Reduce the polling count to 1
> (jus
Hi,
On Mon, Jan 11, 2016 at 01:40:40PM +0100, Marc-André Lureau wrote:
> For size-allocate, it's simpler to connect to the signal rather than
> override the default signal handler since there is no automatic chaining
> to parent handler otherwise. Doing this removes the need to have a
> window.
N
Hi
- Original Message -
> Hi,
>
> On Mon, Jan 11, 2016 at 01:40:40PM +0100, Marc-André Lureau wrote:
> > For size-allocate, it's simpler to connect to the signal rather than
> > override the default signal handler since there is no automatic chaining
> > to parent handler otherwise. Doing
- Original Message -
> Hi
>
> - Original Message -
> > Hi,
> >
> > On Mon, Jan 11, 2016 at 01:40:40PM +0100, Marc-André Lureau wrote:
> > > For size-allocate, it's simpler to connect to the signal rather than
> > > override the default signal handler since there is no automatic
On Wed, Feb 03, 2016 at 12:19:35PM -0500, Marc-André Lureau wrote:
> Hi
>
> - Original Message -
> > Hi,
> >
> > On Mon, Jan 11, 2016 at 01:40:40PM +0100, Marc-André Lureau wrote:
> > > For size-allocate, it's simpler to connect to the signal rather than
> > > override the default signal ha
On Wed, 2016-02-03 at 10:08 +0100, Pavel Grunt wrote:
> On Tue, 2016-02-02 at 16:05 +, Frediano Ziglio wrote:
> > From: Jonathon Jongsma
> >
> > Also requires adding reds_get_streaming_video() accessor so that
> > other
> > files can check this value.
> > ---
> > server/red-dispatcher.c | 7
Required adding a RedsState arg to reds_get_agent_mouse()
---
server/inputs-channel.c | 8
server/reds-private.h | 2 ++
server/reds.c | 10 +-
server/reds.h | 2 +-
4 files changed, 12 insertions(+), 10 deletions(-)
diff --git a/server/inputs-channel.c b
Also requires adding reds_get_streaming_video() accessor so that other
files can check this value.
---
- Changed back to assert
server/red-dispatcher.c | 7 ---
server/red-worker.c | 2 +-
server/reds-private.h | 1 +
server/reds.c | 9 +++--
server/reds.h | 2
39 matches
Mail list logo
