Hi Pavel:
Thanks for your reply, and you provide topdown branch.
在 2016-01-29 14:48:54，"Pavel Grunt" 写道：
>Hi Melo,
>
>On Fri, 2016-01-29 at 11:10 +0800, 苏成才 wrote:
>> Hi Grunt:
>> Thanks for your reply, and I would like to support both spice-gtk
>> and spice-html5, if I stop the
To see how many images and data could not be compressed.
---
server/dcc.c | 27 +++
server/display-channel.c | 11 +++
server/display-channel.h | 1 +
3 files changed, 39 insertions(+)
diff --git a/server/dcc.c b/server/dcc.c
index bf692f8..15cec72 100
Hi Melo,
unfortunately I don't know about any other patches to solve the
problem.
Regards,
Pavel
On Fri, 2016-01-29 at 16:54 +0800, 苏成才 wrote:
> Hi Pavel:
> Just now I tried the branch "topdown", and the problem of upside
> down solved. But the mouse shape doesn't display properly and some
> wi
On Wed, 2016-01-27 at 12:48 +, Frediano Ziglio wrote:
> From: Jonathon Jongsma
>
Acked-by: Pavel Grunt
> ---
> server/reds.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/server/reds.c b/server/reds.c
> index ebb1629..8b17a76 100644
> --- a/server/reds.c
> ++
Hi Pavel:
Thanks for your help, anyway the upside down problem has been solved, it's
a big step :-). I will try to fix other problems.
Best regards,
Melo
At 2016-01-29 17:01:09, "Pavel Grunt" wrote:
Hi Melo,
unfortunately I don't know about any other patches to solve the problem.
On Wed, 2016-01-27 at 12:48 +, Frediano Ziglio wrote:
> From: Jonathon Jongsma
>
> Acked-by: Frediano Ziglio
> ---
> server/display-channel.c | 13 +++--
> server/display-channel.h | 3 +--
> server/reds-private.h| 2 ++
> server/reds.c| 20
>
On Wed, 2016-01-27 at 12:48 +, Frediano Ziglio wrote:
> From: Jonathon Jongsma
>
> Remove another global variable
Acked-by: Pavel Grunt
> ---
> server/reds-private.h | 1 +
> server/reds.c | 8
> 2 files changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/server/reds
On Wed, 2016-01-27 at 12:48 +, Frediano Ziglio wrote:
> From: Jonathon Jongsma
>
> removing more global variables
> ---
> server/reds-private.h | 1 +
> server/reds.c | 8
> 2 files changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/server/reds-private.h b/server/red
On Wed, 2016-01-27 at 12:48 +, Frediano Ziglio wrote:
> From: Jonathon Jongsma
>
> Since this is public API, we can't easily change the signature of the
> function to take a RedsState argument, so instead we apply a hack and
> store the reds argument inside the device state struct when the
>
>
> On Wed, 2016-01-27 at 12:48 +, Frediano Ziglio wrote:
> > From: Jonathon Jongsma
> >
> > Acked-by: Frediano Ziglio
> > ---
> > server/display-channel.c | 13 +++--
> > server/display-channel.h | 3 +--
> > server/reds-private.h| 2 ++
> > server/reds.c| 20 +++
This patchset attempt to fix some possible hangs with main loop,
improve latency and loop usage and decrease cpu usage.
Frediano Ziglio (4):
worker: push data when clients can receive them
replay: remove a message that could be caused by a race condition
worker: avoid blocking loop
worker:
The req_cmd_notification callback is called by spice-server when it
has processed all commands and wants to be notified (by a wakeup) that
new commands has been appended to the command queue.
Replay utility try to fill the commands when it detects spice-server
is trying to read commands but there a
Data were pushed during the main red worker loop.
However there was no garantiee that there was some activities that
make the loop do another iteration.
This could cause in some condition the loop to stop till a new event
was sent.
Events were:
- data from dispatcher (including wake up from guest);
Now that processing is correctly restored there is no need to keep
polling to avoid main loop hangs. Reduce the polling count to 1
(just try once).
This reduce cpu usage if guests are mainly idle.
If you consider 100 guests waiting to login with cursor blinking
and considering the polling was done
Make sure we process commands after we can send data to client.
If during processing we detected that there was too data in the clients
queues the processing of commands just stop till the next iteration.
However if all data are pushed in a single iteration of the loop
and commands were already pro
From: Jonathon Jongsma
Removing more global variables
---
server/reds-private.h | 1 +
server/reds.c | 8
2 files changed, 5 insertions(+), 4 deletions(-)
diff --git a/server/reds-private.h b/server/reds-private.h
index 6ce02f9..f6cd16b 100644
--- a/server/reds-private.h
+++ b/
From: Jonathon Jongsma
---
server/reds-private.h | 1 +
server/reds.c | 32 +++-
2 files changed, 16 insertions(+), 17 deletions(-)
diff --git a/server/reds-private.h b/server/reds-private.h
index 4d620ec..6ce02f9 100644
--- a/server/reds-private.h
+++ b/ser
From: Jonathon Jongsma
Removing more global variables
---
server/reds-private.h | 1 +
server/reds.c | 7 +++
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/server/reds-private.h b/server/reds-private.h
index f6cd16b..87645df 100644
--- a/server/reds-private.h
+++ b/s
From: Jonathon Jongsma
Removing more global variables
---
server/reds-private.h | 2 ++
server/reds.c | 20 +---
2 files changed, 11 insertions(+), 11 deletions(-)
diff --git a/server/reds-private.h b/server/reds-private.h
index 6d36065..c1ecac1 100644
--- a/server/reds
From: Jonathon Jongsma
Since this is public API, we can't easily change the signature of the
function to take a RedsState argument, so instead we apply a hack and
store the reds argument inside the device state struct when the
interface is added, and retrieve it for use later when it is removed.
From: Jonathon Jongsma
Removing more global variables
---
server/reds-private.h | 1 +
server/reds.c | 14 +++---
2 files changed, 8 insertions(+), 7 deletions(-)
diff --git a/server/reds-private.h b/server/reds-private.h
index 87645df..6d36065 100644
--- a/server/reds-private.
From: Jonathon Jongsma
Also change API of reds_has_vdagent() to take RedsState arg. Removes
another global variable.
---
server/inputs-channel.c | 8 +++
server/main-channel.c | 2 +-
server/reds-private.h | 1 +
server/reds.c | 55 --
From: Jonathon Jongsma
Acked-by: Frediano Ziglio
---
server/display-channel.c | 13 +++--
server/display-channel.h | 3 +--
server/reds-private.h| 1 +
server/reds.c| 20
server/reds.h| 5 ++---
5 files changed, 23 insertions(+), 19 de
From: Jonathon Jongsma
Removing more global variables
---
server/reds-private.h | 4
server/reds.c | 13 ++---
2 files changed, 10 insertions(+), 7 deletions(-)
diff --git a/server/reds-private.h b/server/reds-private.h
index 506ef8c..96dfa6a 100644
--- a/server/reds-priva
From: Jonathon Jongsma
Removing more global variables
---
server/red-dispatcher.c | 4 ++--
server/red-worker.c | 3 ++-
server/reds-private.h | 1 +
server/reds.c | 14 +++---
server/reds.h | 1 -
5 files changed, 12 insertions(+), 11 deletions(-)
diff --g
From: Jonathon Jongsma
Remove more global variables
---
server/reds-private.h | 1 +
server/reds.c | 9 -
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/server/reds-private.h b/server/reds-private.h
index c94adb1..506ef8c 100644
--- a/server/reds-private.h
+++ b/s
From: Jonathon Jongsma
Also required adding reds_get_jpeg_state() for external access.
---
server/red-worker.c | 2 +-
server/reds-private.h | 1 +
server/reds.c | 9 +++--
server/reds.h | 2 +-
4 files changed, 10 insertions(+), 4 deletions(-)
diff --git a/server/red-work
From: Jonathon Jongsma
Prefer local argument variable over global 'reds' variable
---
server/reds.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/server/reds.c b/server/reds.c
index 2d10c46..8e8afb9 100644
--- a/server/reds.c
+++ b/server/reds.c
@@ -3191,13 +3191,11 @
From: Jonathon Jongsma
Removing more global variables
---
server/reds-private.h | 4
server/reds.c | 28 ++--
2 files changed, 18 insertions(+), 14 deletions(-)
diff --git a/server/reds-private.h b/server/reds-private.h
index c1ecac1..c94adb1 100644
--- a/s
From: Jonathon Jongsma
Move them into the RedsState struct, adjust functions that use these
variables to take a RedsState arg.
---
server/reds-private.h | 4
server/reds.c | 27 ---
2 files changed, 16 insertions(+), 15 deletions(-)
diff --git a/server/reds
This patchset supersedes the previous.
Changes from previous version:
- merged some patches;
- remove some g_return_val_if_fail not necessary;
- added some patches to the set.
Jonathon Jongsma (18):
Change spice_server_set_ticket() to use local 'reds'
spice_server_add_interface: use local 're
From: Jonathon Jongsma
Removing more global variables
---
server/reds-private.h | 1 +
server/reds.c | 10 +-
2 files changed, 6 insertions(+), 5 deletions(-)
diff --git a/server/reds-private.h b/server/reds-private.h
index 96dfa6a..15cf636 100644
--- a/server/reds-private.h
++
From: Jonathon Jongsma
Rather than using global 'reds' variable
---
server/reds.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/server/reds.c b/server/reds.c
index 9e56780..2d10c46 100644
--- a/server/reds.c
+++ b/server/reds.c
@@ -3601,13 +3601,11 @@ SPICE_GNUC_VISIBLE
From: Jonathon Jongsma
Also requires adding reds_get_streaming_video() accessor so that other
files can check this value.
---
server/red-dispatcher.c | 7 ---
server/red-worker.c | 2 +-
server/reds-private.h | 1 +
server/reds.c | 9 +++--
server/reds.h | 2 +-
> On 29 Jan 2016, at 24:42 AM, Jonathon Jongsma wrote:
>
> On Thu, 2015-10-29 at 17:26 +0200, Dmitry Fleytman wrote:
>> Signed-off-by: Dmitry Fleytman
>> ---
>> spice-common | 2 +-
>> src/usb-device-manager.c | 108 --
>> -
>> 2 files cha
This allows compressions using external programs or any type
of filters.
To use it set SPICE_WORKER_RECORD_FILTER environment to the
filter command you want to use. The command is executed with
g_spawn_async_with_pipes (which uses execve) so is not a shell
command although the command is parsed us
Signed-off-by: Frediano Ziglio
---
server/red-record-qxl.c | 14 +++---
server/red-record-qxl.h | 12 ++--
server/red-worker.c | 12 ++--
3 files changed, 19 insertions(+), 19 deletions(-)
diff --git a/server/red-record-qxl.c b/server/red-record-qxl.c
index 9add176..5
Remove global/static from red_record_qxl.c.
Defined a structure and use it to hold record state.
Signed-off-by: Frediano Ziglio
---
server/red-record-qxl.c | 58 +++--
server/red-record-qxl.h | 12 +++---
server/red-worker.c | 28 +++---
>
> To see how many images and data could not be compressed.
> ---
> server/dcc.c | 27 +++
> server/display-channel.c | 11 +++
> server/display-channel.h | 1 +
> 3 files changed, 39 insertions(+)
>
> diff --git a/server/dcc.c b/server/dcc.c
> index
On Fri, 2016-01-29 at 08:41 -0500, Frediano Ziglio wrote:
> >
> > To see how many images and data could not be compressed.
> > ---
> > server/dcc.c | 27 +++
> > server/display-channel.c | 11 +++
> > server/display-channel.h | 1 +
> > 3 files changed
On Fri, 2016-01-29 at 13:28 +, Frediano Ziglio wrote:
> Remove global/static from red_record_qxl.c.
> Defined a structure and use it to hold record state.
>
> Signed-off-by: Frediano Ziglio
> ---
> server/red-record-qxl.c | 58 +++-
> -
> server/re
Acked-by: Jonathon Jongsma
On Fri, 2016-01-29 at 13:28 +, Frediano Ziglio wrote:
> Signed-off-by: Frediano Ziglio
> ---
> server/red-record-qxl.c | 14 +++---
> server/red-record-qxl.h | 12 ++--
> server/red-worker.c | 12 ++--
> 3 files changed, 19 insertions(
>
> On Fri, 2016-01-29 at 13:28 +, Frediano Ziglio wrote:
> > Remove global/static from red_record_qxl.c.
> > Defined a structure and use it to hold record state.
> >
> > Signed-off-by: Frediano Ziglio
> > ---
> > server/red-record-qxl.c | 58
> > +++
It is needed for g_source_set_ready_time()
Set GLIB_VERSION_MAX_ALLOWED to avoid using not available functions.
---
configure.ac | 9 +++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/configure.ac b/configure.ac
index 2b09ec7..f2f37dd 100644
--- a/configure.ac
+++ b/configur
On Fri, 2016-01-29 at 16:44 +0100, Pavel Grunt wrote:
> It is needed for g_source_set_ready_time()
>
> Set GLIB_VERSION_MAX_ALLOWED to avoid using not available functions.
> ---
> configure.ac | 9 +++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/configure.ac b/config
On Fri, 2016-01-29 at 10:57 -0500, Frediano Ziglio wrote:
> >
> > On Fri, 2016-01-29 at 13:28 +, Frediano Ziglio wrote:
> > > Remove global/static from red_record_qxl.c.
> > > Defined a structure and use it to hold record state.
> > >
> > > Signed-off-by: Frediano Ziglio
> > > ---
> > > ser
I personally don't think it's very useful to introduce a variable without
actually using it anywhere. I'd prefer to combine it with the next commit.
Reviewed-by: Jonathon Jongsma
On Thu, 2015-10-29 at 17:26 +0200, Dmitry Fleytman wrote:
> This flag will be used by future code to distinguish
> b
47 matches
Mail list logo
