On Fri, Oct 16, 2015 at 04:07:43PM -0500, Jeremy White wrote:
> On 10/16/2015 11:04 AM, Christophe Fergeau wrote:
> > On Fri, Oct 02, 2015 at 11:21:03AM -0500, Jeremy White wrote:
> >> Signed-off-by: Jeremy White ---
> >> examples/spiceqxl.xorg.conf.example | 24
> >> 1 fi
---
server/glz_encoder_dictionary.c | 2 +-
server/red_channel.c| 4 ++--
server/red_worker.c | 2 +-
server/reds.c | 2 +-
4 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/server/glz_encoder_dictionary.c b/server/glz_encoder_dictionary.c
ind
For streaming devices it might be necessary from application to drop
data for different reasons. This patch provides a new callback that it
is called before queueing the most recent iso packages.
Related: https://bugzilla.redhat.com/show_bug.cgi?id=1264156
---
usbredirhost/usbredirhost.c | 19 +++
This is already better then v2 due the fact that we are only dropping
isochronous packets. Still need to find a way to drop the correct
amount of packages so usbredir always start sending data from start of
payload (not in the middle of a frame, for instance)
cheers,
Victor Toso (1):
usbredirho
When channel wants to send much more data then the wire can handle, the
queue grows fast. This patch does not limit the queue growth but
introduces an internal API to check if queue size is too big.
This internal API is used with usbredirhost_can_write_iso callback from
usbredir. This way, we gara
On Fri, Oct 16, 2015 at 04:06:28PM -0500, Jeremy White wrote:
> >>
>
> >> static void spiceqxl_uinput_read_cb(int fd, int event, void
> >> *opaque) { @@ -30,14 +31,20 @@ static void
> >> spiceqxl_uinput_read_cb(int fd, int event, void *opaque) static
> >> int y = -1; static int buttons_state = 0;
ACK.
On Fri, Oct 16, 2015 at 03:47:14PM -0500, Jeremy White wrote:
> Also shift to libspiceccid_la_CFLAGS.
>
> Signed-off-by: Jeremy White
> ---
> src/spiceccid/Makefile.am | 5 ++---
> src/spiceccid/spiceccid.c | 2 +-
> 2 files changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/src/sp
On Fri, Oct 02, 2015 at 11:21:01AM -0500, Jeremy White wrote:
> Since the introduction of vdagent support in commit
> 294daff7ea930f338ec6d77ec3465b6f727c168e, the
> SpiceAgentMouse setting has not really operated correctly.
>
> That is, if SpiceVdagentEnabled was true, the value
> of SpiceAgentMo
Acked!
- Original Message -
> From: "snir sheriber"
> To: spice-devel@lists.freedesktop.org
> Cc: "snir sheriber"
> Sent: Sunday, October 18, 2015 8:51:56 AM
> Subject: [Spice-devel] [PATCH] fix spelling mistakes in comments (reseting
> to resetting & dummym to dummy)
>
> ---
> ser
On Mon, Oct 19, 2015 at 01:56:07PM +0200, Christophe Fergeau wrote:
> On Fri, Oct 02, 2015 at 11:21:01AM -0500, Jeremy White wrote:
> > Since the introduction of vdagent support in commit
> > 294daff7ea930f338ec6d77ec3465b6f727c168e, the
> > SpiceAgentMouse setting has not really operated correctly
On Thu, Oct 08, 2015 at 07:48:03AM +0200, Victor Toso wrote:
> Would make sense to remove other tabs as well?
>
>
> grep -nrIP '\t' server/ --exclude=Makefile*
> server/mjpeg_encoder.c:277: unsigned char ** outbuffer;/* target
> buffer */
> server/mjpeg_encoder.c:279: uint8_t * buffer;
Adding Hans ...
On Mon, Oct 19, 2015 at 12:07 PM, Victor Toso wrote:
> This is already better then v2 due the fact that we are only dropping
> isochronous packets. Still need to find a way to drop the correct
> amount of packages so usbredir always start sending data from start of
> payload (not
Hey,
This has been pushed already, but 2 cosmetic comments:
- you might want to capitalize your first/last name (Snir Sheriber
rather than snir sheriber)
- it's better to keep the short log (first line of the commit log) short
(60 characters or so) as this makes things more readable in various
Hi,
On 19-10-15 14:25, Fabiano Fidêncio wrote:
Adding Hans ...
Thanks, I missed the original patch, Victor, can you please
Cc me when sending this patches, and perhaps resend v3 with
me in the Cc ?
On Mon, Oct 19, 2015 at 12:07 PM, Victor Toso wrote:
This is already better then v2 due the
Hi,
On Mon, Oct 19, 2015 at 02:35:02PM +0200, Hans de Goede wrote:
> Hi,
>
> On 19-10-15 14:25, Fabiano Fidêncio wrote:
> >Adding Hans ...
>
> Thanks, I missed the original patch, Victor, can you please
> Cc me when sending this patches, and perhaps resend v3 with
> me in the Cc ?
>
Sure, I'll ap
p.s.
One more thing, when I reproduced this myself I noticed a
couple of other worrisome things:
1) When I stop the webcam-app inside the guest, the camera does
not stop streaming on the client side. As if the control request
being send from the client to stop the stream never reaches the
webcam
Hi,
On Mon, Oct 19, 2015 at 02:54:41PM +0200, Hans de Goede wrote:
> p.s.
>
> One more thing, when I reproduced this myself I noticed a
> couple of other worrisome things:
>
> 1) When I stop the webcam-app inside the guest, the camera does
> not stop streaming on the client side. As if the control
Currently a single type of surface is allocated in a specific BAR.
This also changes from userspace driver to the kernel one.
This way it could happen that allocation are failing even if there are
plenty of space in the other BAR.
For instance this can happen trying to change resolution as the old
If memory is not enough in the default BAR for a type try other BAR
this allow better memory usage and avoid memory allocation failure
if a BAR is quite small and other is quite unused.
Signed-off-by: Frediano Ziglio
---
drivers/gpu/drm/qxl/qxl_object.c | 11 +++
1 file changed, 7 insert
Instead of relaying on surface type use the actual placement.
This allow to have different placement for a single type of
surface.
Signed-off-by: Frediano Ziglio
---
drivers/gpu/drm/qxl/qxl_cmd.c | 2 +-
drivers/gpu/drm/qxl/qxl_drv.h | 9 -
2 files changed, 9 insertions(+), 2 deletions(-
While testing, I came to the same conclusion as Marc-André - commit 1587063.
Hans, why the complexity of the "rules & target", isn't "ConditionPath*"
sufficient?
Besides, the lack of "WantedBy=multi-user.target" - back and forth with
'graphical.target' - 'spice-vdagentd' is "lost".
Obviously X
For testing purposes:
http://goo.gl/Gm4ffO
spice/
spice-vdagent-0.16.0-5.fc24.src.rpm
spice-vdagent-0.16.0-5.fc24.x86_64.rpm
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/spice-devel
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
> The code changes correspond to what this log describes, but why is
> it better to defer enabling the agent to on_connect()?
I've done more digging, and I think I missed the larger flaw on this
issue. That is, rather than enabling/disabling the mous
Hi,
On 19-10-15 16:55, poma wrote:
While testing, I came to the same conclusion as Marc-André - commit 1587063.
Hans, why the complexity of the "rules & target", isn't "ConditionPath*"
sufficient?
Besides, the lack of "WantedBy=multi-user.target" - back and forth with
'graphical.target' - 's
Also revise the expression of the default value to be consistent.
Signed-off-by: Jeremy White
---
examples/spiceqxl.xorg.conf.example | 61 ++---
1 file changed, 43 insertions(+), 18 deletions(-)
diff --git a/examples/spiceqxl.xorg.conf.example
b/examples/spiceq
Otherwise, you constantly spin loop, getting a return code of 0,
and pegging CPU usage at 100%.
Signed-off-by: Jeremy White
---
src/spiceqxl_uinput.c | 13 -
src/spiceqxl_uinput.h | 1 +
src/spiceqxl_vdagent.c | 2 ++
3 files changed, 15 insertions(+), 1 deletion(-)
diff --git a
This means that we do not attempt to use agent mouse
mode if there is no connected agent.
It fixes a bug which would occur if an agent disconnected
after session startup which would result in having no
useful mouse.
Signed-off-by: Jeremy White
---
src/spiceqxl_vdagent.c | 7 +--
1 file chan
This patch series is a set of minor patches for XSpice around vdagent support.
It improves the documentation of the options, corrects an option that did
not work as expected, and handles an agent disconnection more intelligently.
The code changes in this second version are substantially different
Since the introduction of vdagent support in commit
294daff7ea930f338ec6d77ec3465b6f727c168e, the
SpiceAgentMouse setting has not really operated correctly.
That is, if SpiceVdagentEnabled was true, the value
of SpiceAgentMouse was overridden.
This patch corrects that.
It also shifts the default
29 matches
Mail list logo
