Hey,
On Mon, Sep 21, 2015 at 04:09:45PM -0500, Jeremy White wrote:
> Thanks for all the review. Francois and I were just off at the Wine
> conference, so forgive us if we're a little slow responding.
Thanks for the heads up, I'm not fully done with the reviews yet anyway.
Enjoy the conference!
On Mon, Sep 21, 2015 at 03:36:05PM +0200, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> ---
> Makefile.am | 1 +
> NEWS| 6 ++
> 2 files changed, 7 insertions(+)
> create mode 100644 NEWS
>
> diff --git a/Makefile.am b/Makefile.am
> index bf29337..2e737a9 100644
I see this has been pushed now, but I'd still go with this follow-up
patch (not even compile tested :-(
From c148234cb8eb0b64dcff27c3c16df4f27cf79ba9 Mon Sep 17 00:00:00 2001
From: Christophe Fergeau
Date: Tue, 22 Sep 2015 11:03:11 +0200
Subject: [PATCH] xddm: Remove unneeded FillVidModeInfo 'ind
On Thu, Aug 27, 2015 at 09:00:46PM +0200, Francois Gouget wrote:
> The GStreamer video encoder supports both regular and sized streams.
> It is otherwise quite basic and lacks any rate control: the bitrate is set at
> startup and will not react to changes in the network conditions. Still it
> sho
Hi
On Tue, Sep 22, 2015 at 10:50 AM, Christophe Fergeau
wrote:
> libtool: link: gcc -g3 -ggdb3 -O0 -Wall -o .libs/vscclient
> src/vscclient.o ./.libs/libcacard.so -lglib-2.0 -lssl3 -lsmime3 -lnss3
> -lnssutil3 -lplds4 -lplc4 -lnspr4 -lpthread -ldl -Wl,-rpath
> -Wl,/usr/local/lib
>
> src/vscclien
Hi
As previously discussed in the thread "libcacard: use the library?",
libcacard has been made a standalone project, which is now hosted next
with the Spice project.
release: http://www.spice-space.org/download/libcacard/libcacard-2.5.0.tar.xz
sha1sum: bbb211beaea3085bc2ced14c610f508db181fc2d
g
Hey,
On Thu, Sep 17, 2015 at 10:21:59AM -0500, Jonathon Jongsma wrote:
> > This all sounds good to me, just one question, are you going to change
> > 'progress_callback' to report total progress, or is it going to stay as
> > it is now? (in other words, if an application only wants to display that
Hey,
On Thu, Aug 27, 2015 at 09:01:02PM +0200, Francois Gouget wrote:
> This way the video encoder is not forced to use malloc()/free().
> This also allows more flexibility in how the video encoder manages the buffer
> which allows for a zero-copy implementation in both video encoders.
> The curr
On Thu, Aug 27, 2015 at 09:01:10PM +0200, Francois Gouget wrote:
> To do so we wrap the source bitmap chunks in GstMemory objects that become
> part of the GStreamer buffer, and rely on the buffer's lifetime being short
> enough.
> Note that we can only avoid copies for the first 1 Mpixels or so.
ACK.
On Thu, Aug 27, 2015 at 09:01:15PM +0200, Francois Gouget wrote:
> Signed-off-by: Francois Gouget
> ---
>
> Changes since take 4:
> - Tweaked the h264 options comments.
>
> server/gstreamer_encoder.c | 17 -
> server/red_dispatcher.c| 2 ++
> 2 files changed, 18 inse
Does anybody object to this series?
On Mon, 2015-09-14 at 10:05 -0500, Jonathon Jongsma wrote:
> This error only started occurring after patch 1/2.
>
>
> On Fri, 2015-09-11 at 17:37 -0400, Marc-André Lureau wrote:
> > Hi
> >
> > - Original Message -
> > > spice-client.h is a super-heade
spice_main_file_copy_async() allows you to pass a NULL-terminated array
of files to transfer to the guest. It also allows you to pass a
progress_callback function to monitor the progress of the transfer, but
this progress callback is called separately for each file that is
transferred, and there ar
On Thu, Aug 27, 2015 at 09:01:38PM +0200, Francois Gouget wrote:
> Otherwise it may get wrapped to a much lower value than intended.
>
> Signed-off-by: Francois Gouget
> ---
>
> For instance x264enc has a 100Mbps limit so 102Mbps would give a 2Mbps
> bit rate.
>
> server/gstreamer_encoder.c |
There were several shortcomings to the existing file transfer API,
particularly in terms of monitoring ongoing file transfers. The major
issue is that spice_main_file_copy_async() allows you to pass an array
of files, but the progress callback does not provide a way to
identify which file the callb
- Original Message -
> Does anybody object to this series?
Yes, you broke the build with 1/2 and then you fix it in 2/2? and you didn't
explain what the point of it.
At the minimum, the two patches should be merged and explain why this change is
necessary.
>
> On Mon, 2015-09-14 at
On Tue, 2015-09-22 at 11:30 -0400, Marc-André Lureau wrote:
>
> - Original Message -
> > Does anybody object to this series?
>
> Yes, you broke the build with 1/2 and then you fix it in 2/2? and you didn't
> explain what the point of it.
The point of it? channel-main.c should include ch
Feel free to review this, but I just noticed that this patch broke the
gtk2 build. So there will need to be a few changes to fix that.
On Tue, 2015-09-22 at 10:26 -0500, Jonathon Jongsma wrote:
> There were several shortcomings to the existing file transfer API,
> particularly in terms of monito
- Original Message -
> On Tue, 2015-09-22 at 11:30 -0400, Marc-André Lureau wrote:
> >
> > - Original Message -
> > > Does anybody object to this series?
> >
> > Yes, you broke the build with 1/2 and then you fix it in 2/2? and you
> > didn't explain what the point of it.
>
> T
Hi
- Original Message -
>
>
> - Original Message -
> > On Tue, 2015-09-22 at 11:30 -0400, Marc-André Lureau wrote:
> > >
> > > - Original Message -
> > > > Does anybody object to this series?
> > >
> > > Yes, you broke the build with 1/2 and then you fix it in 2/2? and
Maybe I applied these patches on top of a wrong commit, but I needed
diff --git a/src/usb-device-manager.c b/src/usb-device-manager.c
index e7da42e..ca8473f 100644
--- a/src/usb-device-manager.c
+++ b/src/usb-device-manager.c
@@ -1517,8 +1517,8 @@ void
spice_usb_device_manager_connect_device_asyn
It compiles and and is functionally the same as the prior versions, but cleaner.
-S
On 9/22/2015 5:08 AM, Christophe Fergeau wrote:
> I see this has been pushed now, but I'd still go with this follow-up
> patch (not even compile tested :-(
>
> From c148234cb8eb0b64dcff27c3c16df4f27cf79ba9 Mon Sep
On Sun, Aug 16, 2015 at 03:35:41PM +0300, Dmitry Fleytman wrote:
> From: Kirill Moizik
>
> USB redirection flow on Windows includes a number of reset requests issued
> to the port that hosts the device deing redirected.
>
> Each port reset emulates device removal and reinsertion and produces
> c
On Sun, Aug 16, 2015 at 03:35:42PM +0300, Dmitry Fleytman wrote:
> From: Kirill Moizik
>
> Signed-off-by: Kirill Moizik
> Signed-off-by: Dmitry Fleytman
> ---
> src/usb-device-manager.c | 58
> +++-
> 1 file changed, 33 insertions(+), 25 deletions(-
On Sun, Aug 16, 2015 at 03:35:45PM +0300, Dmitry Fleytman wrote:
> From: Kirill Moizik
>
> Signed-off-by: Kirill Moizik
> Signed-off-by: Dmitry Fleytman
> ---
> src/usb-device-manager.c | 71
> ++--
> 1 file changed, 62 insertions(+), 9 deletions(-)
What's happening if we don't do that ? warnings ? broken compilation ?
On Sun, Aug 16, 2015 at 03:35:46PM +0300, Dmitry Fleytman wrote:
> From: Kirill Moizik
>
> Signed-off-by: Kirill Moizik
> Signed-off-by: Dmitry Fleytman
> ---
> src/usb-device-manager.c | 6 ++
> 1 file changed, 2 inse
On Sun, Aug 16, 2015 at 03:35:49PM +0300, Dmitry Fleytman wrote:
> From: Kirill Moizik
>
> Signed-off-by: Kirill Moizik
> Signed-off-by: Dmitry Fleytman
> ---
> src/channel-usbredir.c | 43 ---
> src/map-file | 1 +
> 2 files changed, 37 inser
On Tue, Sep 08, 2015 at 08:42:00PM +0300, Dmitry Fleytman wrote:
> > This patchs series makes start/stop USB redirection flows run in their own
> > threads.
> > It solves spice-gtk freeze problems since start and stop redirection are
> > time consuming operations.
> > This series include new api
---
Anybody have any pending changes to include in a new spice-protocol release? If
not, I propose making a new release. sometime in the next few days.
NEWS | 7 +++
1 file changed, 7 insertions(+)
diff --git a/NEWS b/NEWS
index be86c47..a342d38 100644
--- a/NEWS
+++ b/NEWS
@@ -1,3 +1,10 @
28 matches
Mail list logo
