Re: [Spice-devel] [spice-common RFC] Introduce SPICE_COMMON_SETUP m4 macro

2013-11-12 Thread Christophe Fergeau
On Fri, Nov 08, 2013 at 08:02:39PM -0500, Marc-André Lureau wrote: > > Good that you have a SSD, it takes 30 seconds here every time I run > > autogen.sh in spice/ or spice-gtk/, and most of these 30 seconds is > > duplicating work that has already been done in the toplevel configure.ac > > If you

[Spice-devel] spice-guest-tools-0.65 Integrity check failed

2013-11-12 Thread Christoph Blau
Hey There Thanks for this awesome driver suit. It works great and the speed is amazing! I am having a problem though - I want to update to 0.65. The download finished but I am getting "Installer Integrity check failed". I am using the download link here: http://www.spice-space.org/download/windo

Re: [Spice-devel] spice-guest-tools-0.65 Integrity check failed

2013-11-12 Thread Christophe Fergeau
On Tue, Nov 12, 2013 at 10:33:43AM +0200, Christoph Blau wrote: > I am having a problem though - I want to update to 0.65. The download > finished but I am getting "Installer Integrity check failed". > > I am using the download link here: > http://www.spice-space.org/download/windows/spice-guest-t

Re: [Spice-devel] [spice opus support 3/5 (take 2)] Add support for the Opus codec

2013-11-12 Thread Christophe Fergeau
On Sat, Nov 09, 2013 at 04:09:35PM -0600, Jeremy White wrote: > Hey Christophe, > > >> static WaveRecordAbstract* create_recorder(RecordClient& client, > >> uint32_t sampels_per_sec, > > > >I'd tend to fix the 'sampel' typo while changing these

Re: [Spice-devel] [spice opus support 3/5 (take 2)] Add support for the Opus codec

2013-11-12 Thread Jeremy White
Hmm. I can do that; my instinct is to avoid mixing changes in a patch; I would tend to do a patch just for the rename, so that the git history has a fairly clear record. Yeah, I did not want to burden you with an additional patch, especially as it does not have to do with what you are trying to

Re: [Spice-devel] [PATCH usbclerk] Fix possibly missing files after upgrade

2013-11-12 Thread Uri Lublin
On 11/09/2013 03:34 AM, Marc-André Lureau wrote: From: Marc-André Lureau This is similar to the fix for virt-viewer: https://www.redhat.com/archives/virt-tools-list/2013-November/msg00030.html Although it's not mandatory for simple cases, RemoveExistingProducts should be Schedule='afterInstall

[Spice-devel] [spice-gtk v5 0/2] Use system CA store

2013-11-12 Thread Christophe Fergeau
Hey, After a chat with Stef Walter (owner of https://fedoraproject.org/wiki/Features/SharedSystemCertificates ), it turns out that it's desirable for SPICE to make use of it, and that the detection code for the system trust store is not needed if we assume the distribution has done that unificatio

[Spice-devel] [spice-gtk v5 2/2] Use system-wide trust certificate store

2013-11-12 Thread Christophe Fergeau
Currently, spice-gtk will look in $HOME/.spicec/spice_truststore.pem by default for its trust certificate store (to verify the certificates used during SPICE TLS connections). However, these days a system-wide trust store can be found in /etc/pki or /etc/ssl. This commit checks at compile time wher

Re: [Spice-devel] [spice-gtk v5 2/2] Use system-wide trust certificate store

2013-11-12 Thread Christophe Fergeau
On Tue, Nov 12, 2013 at 04:20:03PM +0100, Christophe Fergeau wrote: > Currently, spice-gtk will look in $HOME/.spicec/spice_truststore.pem > by default for its trust certificate store (to verify the certificates > used during SPICE TLS connections). However, these days a system-wide > trust store c

[Spice-devel] [spice-gtk v5 1/2] Add SpiceSession:use-system-ca-file property

2013-11-12 Thread Christophe Fergeau
This property indicates whether to look into the system CA database when validating certificates in a TLS connection. This property defaults to TRUE, but is automatically set to FALSE when SpiceSession:ca-file is set. --- gtk/spice-option.c | 8 gtk/spice-session-priv.h | 3 +++ g

Re: [Spice-devel] [spice-gtk v5 2/2] Use system-wide trust certificate store

2013-11-12 Thread Marc-André Lureau
On Tue, Nov 12, 2013 at 4:20 PM, Christophe Fergeau wrote: > This commit checks at compile time where the trust store is located, > and then loads it before loading the user-specified trust store. In general, it's best to start with user path and then system path. Why this general rule should be

Re: [Spice-devel] [spice-gtk v5 2/2] Use system-wide trust certificate store

2013-11-12 Thread i iordanov
Hi Christophe, I know I may be opening a can of worms with this question, but it'll help with supporting mobile devices, and maybe improve portability. Typically we cross-compile binaries for mobile devices, so detecting the location of anything automatically will yield inappropriate results. In

Re: [Spice-devel] [spice-gtk v5 2/2] Use system-wide trust certificate store

2013-11-12 Thread Christophe Fergeau
On Tue, Nov 12, 2013 at 04:53:06PM +0100, Marc-André Lureau wrote: > On Tue, Nov 12, 2013 at 4:20 PM, Christophe Fergeau > wrote: > > This commit checks at compile time where the trust store is located, > > and then loads it before loading the user-specified trust store. > > > In general, it's

[Spice-devel] [spice-gtk v5] Use system-wide trust certificate store

2013-11-12 Thread Christophe Fergeau
Currently, spice-gtk will look in $HOME/.spicec/spice_truststore.pem by default for its trust certificate store (to verify the certificates used during SPICE TLS connections). However, these days, progress is under-way to have a system-wide certificate store [1]. In order to use it, we only need to

Re: [Spice-devel] [spice-gtk v5] Use system-wide trust certificate store

2013-11-12 Thread Marc-André Lureau
On Tue, Nov 12, 2013 at 5:24 PM, Christophe Fergeau wrote: > +if (use_system_ca) { > +rc = SSL_CTX_set_default_verify_paths(c->ctx); > +if (rc != 1) I assume this doesn't override the previously loaded CA, but could you verify? anyway, I think it would be safer to check previ

Re: [Spice-devel] [spice-gtk v5] Use system-wide trust certificate store

2013-11-12 Thread Christophe Fergeau
On Tue, Nov 12, 2013 at 05:32:36PM +0100, Marc-André Lureau wrote: > On Tue, Nov 12, 2013 at 5:24 PM, Christophe Fergeau > wrote: > > +if (use_system_ca) { > > +rc = SSL_CTX_set_default_verify_paths(c->ctx); > > +if (rc != 1) > > I assume this doesn't override the previously

[Spice-devel] [PATCH usbclerk] Fix version scheme for MSI upgrade

2013-11-12 Thread Marc-André Lureau
Use a major.minor.(micro << 8 + build) version scheme, following virt-viewer practice. The component guid can be removed, msitools generate a stable one, based on component location. --- Makefile.am | 6 +++--- configure.ac| 22 -- usbclerk.wxs.in | 8 3 fil

[Spice-devel] Opus support patch set take 3; 0/6

2013-11-12 Thread Jeremy White
The following patch series is take 3 of the Opus support patches. They test out cleanly for me in playback and record. I particularly focused on the test case of old qemu, new spice, although I also affirmed the test case of new spice, old client as well. This should be different from take 2 as

[Spice-devel] [spice-common opus support 2/6 (take 3)] Add support for the Opus codec.

2013-11-12 Thread Jeremy White
Signed-off-by: Jeremy White --- common/Makefile.am |2 + common/snd_codec.c | 136 +--- common/snd_codec.h | 20 ++-- configure.ac |4 ++ spice.proto|1 + spice1.proto |1 + 6 files changed, 153 insertions(

[Spice-devel] [spice opus support 4/6 (take 3)] Fix typo; sampel --> sample

2013-11-12 Thread Jeremy White
Signed-off-by: Jeremy White --- client/platform.h |4 ++-- client/windows/platform.cpp |8 client/windows/playback.cpp | 14 +++--- client/windows/playback.h |4 ++-- client/windows/record.cpp | 12 ++-- client/windows/record.h |4 ++-

[Spice-devel] [spice-protocol opus support 1/6 (take 3)] Add support for the Opus codec

2013-11-12 Thread Jeremy White
Signed-off-by: Jeremy White --- spice/enums.h|1 + spice/protocol.h |2 ++ 2 files changed, 3 insertions(+) diff --git a/spice/enums.h b/spice/enums.h index f192e43..fdcffa8 100644 --- a/spice/enums.h +++ b/spice/enums.h @@ -325,6 +325,7 @@ typedef enum SpiceAudioDataMode { SPIC

[Spice-devel] [spice opus support 3/6 (take 3)] Add support for the Opus codec

2013-11-12 Thread Jeremy White
Signed-off-by: Jeremy White --- client/audio_channels.h |3 +- client/audio_devices.h |8 --- client/platform.h |6 ++- client/playback_channel.cpp | 23 client/record_channel.cpp | 41 +- client/x11/platform.cpp | 10 ++-- client/x1

[Spice-devel] [qemu opus support 6/6 (take 3)] Add the ability to vary Spice playback and record rates, to facilitate Opus support.

2013-11-12 Thread Jeremy White
Signed-off-by: Jeremy White --- audio/spiceaudio.c | 27 +-- 1 file changed, 25 insertions(+), 2 deletions(-) diff --git a/audio/spiceaudio.c b/audio/spiceaudio.c index 5af436c..fceee50 100644 --- a/audio/spiceaudio.c +++ b/audio/spiceaudio.c @@ -25,8 +25,17 @@ #includ

[Spice-devel] [spice-gtk opus support 5/6 (take 3)] Add support for the Opus codec.

2013-11-12 Thread Jeremy White
Signed-off-by: Jeremy White --- gtk/Makefile.am|2 ++ gtk/channel-playback.c | 49 ++-- gtk/channel-record.c | 38 +++-- 3 files changed, 40 insertions(+), 49 deletions(-) diff --git a/gtk/Makefile.am b

Re: [Spice-devel] [PATCH usbclerk] Fix version scheme for MSI upgrade

2013-11-12 Thread Uri Lublin
On 11/12/2013 08:50 PM, Marc-André Lureau wrote: Use a major.minor.(micro << 8 + build) version scheme, following virt-viewer practice. The component guid can be removed, msitools generate a stable one, based on component location. --- Makefile.am | 6 +++--- configure.ac| 22 +++

Re: [Spice-devel] does spicec support usbredir?

2013-11-12 Thread Li Guang
Hi, Hans I did strictly as you said at http://hansdegoede.livejournal.com/11084.html, but, seems there's no effect in guest after selecting redirected USBdevice, can you help to take a look if there are something wrong for my configuration? Thanks a lot! Li guang the whole command line gener

Re: [Spice-devel] does spicec support usbredir?

2013-11-12 Thread Hans de Goede
Hi, On 11/13/2013 01:49 AM, Li Guang wrote: Hi, Hans I did strictly as you said at http://hansdegoede.livejournal.com/11084.html, but, seems there's no effect in guest after selecting redirected USBdevice, can you help to take a look if there are something wrong for my configuration? The com

Re: [Spice-devel] does spicec support usbredir?

2013-11-12 Thread Tomáš Chaloupka
I guess that its because in spice-gtk-0.21 USB redir is not working? Fixed by this patch: http://cgit.freedesktop.org/spice/spice-gtk/commit/?id=fb469ef815d7e8396aee49ad4ca4e5d4f882ee26 Tom 2013/11/13 Hans de Goede > Hi, > > > On 11/13/2013 01:49 AM, Li Guang wrote: > >> >> Hi, Hans >> >> I di

Re: [Spice-devel] does spicec support usbredir?

2013-11-12 Thread Hans de Goede
Hi, On 11/13/2013 08:31 AM, Tomáš Chaloupka wrote: I guess that its because in spice-gtk-0.21 USB redir is not working? Fixed by this patch: http://cgit.freedesktop.org/spice/spice-gtk/commit/?id=fb469ef815d7e8396aee49ad4ca4e5d4f882ee26 Ah, yes that is likely the culprit, good one. Regards,