Re: [Spice-devel] govirt 0.30 plans

2013-11-07 Thread Christophe Fergeau
On Wed, Nov 06, 2013 at 10:30:21PM -0500, i iordanov wrote: > Hi Christophe, > > On Wed, Nov 6, 2013 at 4:06 AM, Christophe Fergeau > wrote: > > Ah right, this property is only in librest git, see > > http://cgit.freedesktop.org/spice/spice-gtk/commit/?id=32b123f44fc79eaad388d6be09f103457f3 > >

Re: [Spice-devel] govirt 0.30 plans

2013-11-07 Thread Christophe Fergeau
On Wed, Nov 06, 2013 at 11:15:17PM -0500, i iordanov wrote: > I had gotten used to the functionality offered by oVirt Live 0.8 (I > think it bundles oVirt 3.0) where I was able to attach as user > "admin@internal" to virtual machines created in the Administrative > Console (rather than in the User

[Spice-devel] Spice Client API

2013-11-07 Thread Christopher Corsi
Hi Everyone, I'm looking for some pointers on the spice client API. There are some tasks we would like to automate in our system where we need to see/hear directly into QEMU VMs. Right now this is hacked together using wavcapture on the monitor and spice-client running inside of a VNC session, whi

Re: [Spice-devel] Spice Client API

2013-11-07 Thread Marc-André Lureau
Hi - Original Message - > Hi Everyone, > > I'm looking for some pointers on the spice client API. There are some tasks > we would like to automate in our system where we need to see/hear directly > into QEMU VMs. Right now this is hacked together using wavcapture on the > monitor and spic

Re: [Spice-devel] [patch 1/1] fix SASL for mechanism using WANT_CLIENT_FIRST

2013-11-07 Thread Christophe Fergeau
Hey, On Fri, Oct 25, 2013 at 10:43:13AM +0200, Christophe Fergeau wrote: > On Tue, Oct 22, 2013 at 11:07:56AM +0200, diet...@proxmox.com wrote: > > Current code works with DIGEST-MD5, but not with PLAIN. > > After spending quite some time on this, this seems right, we need to handle > sasl_client

[Spice-devel] [spice-gtk] Fix g_return_val_if_fail() in spice_session_get_use_ca_file()

2013-11-07 Thread Christophe Fergeau
spice_session_get_use_ca_file() returns a gboolean, but we were trying to return NULL from g_return_val_if_fail() --- gtk/spice-session.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gtk/spice-session.c b/gtk/spice-session.c index c989f0a..60526fe 100644 --- a/gtk/spice-sess

Re: [Spice-devel] [spice-gtk] Fix g_return_val_if_fail() in spice_session_get_use_ca_file()

2013-11-07 Thread Christophe Fergeau
On Thu, Nov 07, 2013 at 03:01:03PM +0100, Christophe Fergeau wrote: > spice_session_get_use_ca_file() returns a gboolean, but we were trying > to return NULL from g_return_val_if_fail() > --- > gtk/spice-session.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/gtk/spice-

Re: [Spice-devel] [spice-gtk] Fix g_return_val_if_fail() in spice_session_get_use_ca_file()

2013-11-07 Thread Marc-André Lureau
This is not upstream afaik (probably by lack of interest) - Original Message - > spice_session_get_use_ca_file() returns a gboolean, but we were trying > to return NULL from g_return_val_if_fail() > --- > gtk/spice-session.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > dif

Re: [Spice-devel] [spice-gtk PATCHv4 0/2] Use system CA store

2013-11-07 Thread Christophe Fergeau
On Fri, Oct 11, 2013 at 11:31:38AM +0200, Christophe Fergeau wrote: > On Thu, Oct 03, 2013 at 02:25:44PM +0200, Christophe Fergeau wrote: > > Ping? > > No taker? A NACK or an ACK, or a review would be much better than no answers :-/ Christophe pgpD9GMDHIQ61.pgp Description: PGP signature _

Re: [Spice-devel] [spice-gtk PATCHv4 0/2] Use system CA store

2013-11-07 Thread Marc-André Lureau
- Original Message - > On Fri, Oct 11, 2013 at 11:31:38AM +0200, Christophe Fergeau wrote: > > On Thu, Oct 03, 2013 at 02:25:44PM +0200, Christophe Fergeau wrote: > > > Ping? > > > > No taker? > > A NACK or an ACK, or a review would be much better than no answers :-/ There was discussi

Re: [Spice-devel] [patch 1/1] fix SASL for mechanism using WANT_CLIENT_FIRST

2013-11-07 Thread Dietmar Maurer
> On Fri, Oct 25, 2013 at 10:43:13AM +0200, Christophe Fergeau wrote: > > On Tue, Oct 22, 2013 at 11:07:56AM +0200, diet...@proxmox.com wrote: > > > Current code works with DIGEST-MD5, but not with PLAIN. > > > > After spending quite some time on this, this seems right, we need to > > handle > > sa

Re: [Spice-devel] Questions about Spice pv domUs

2013-11-07 Thread Fabio Fantoni
Il 06/11/2013 18:16, Stefano Stabellini ha scritto: On Tue, 5 Nov 2013, Fabio Fantoni wrote: Il 30/09/2013 16:56, Fabio Fantoni ha scritto: I'm trying to implement basic spice support on xen pv domUs. Test seems ok on Ubuntu 12.04 pv domU except mouse which is not visible. I also tried agent-m

Re: [Spice-devel] Questions about Spice pv domUs

2013-11-07 Thread Stefano Stabellini
On Thu, 7 Nov 2013, Fabio Fantoni wrote: > Il 06/11/2013 18:16, Stefano Stabellini ha scritto: > > On Tue, 5 Nov 2013, Fabio Fantoni wrote: > > > Il 30/09/2013 16:56, Fabio Fantoni ha scritto: > > > > I'm trying to implement basic spice support on xen pv domUs. > > > > > > > > Test seems ok on Ubu

Re: [Spice-devel] [spice sound rework 2/3 (take 4)] Revise the spice client and server to use the new snd_codec functions in spice-common.

2013-11-07 Thread Christophe Fergeau
On Tue, Nov 05, 2013 at 04:25:14PM -0600, Jeremy White wrote: > diff --git a/configure.ac b/configure.ac > index 882bf1b..b7f6140 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -230,11 +230,13 @@ AC_SUBST(PIXMAN_CFLAGS) > AC_SUBST(PIXMAN_LIBS) > SPICE_REQUIRES+=" pixman-1 >= 0.17.7" > >

Re: [Spice-devel] Questions about Spice pv domUs

2013-11-07 Thread Fabio Fantoni
Il 07/11/2013 16:25, Stefano Stabellini ha scritto: On Thu, 7 Nov 2013, Fabio Fantoni wrote: Il 06/11/2013 18:16, Stefano Stabellini ha scritto: On Tue, 5 Nov 2013, Fabio Fantoni wrote: Il 30/09/2013 16:56, Fabio Fantoni ha scritto: I'm trying to implement basic spice support on xen pv domUs.

[Spice-devel] [PATCH] Guarantee that 'uuid' property is notified after connection

2013-11-07 Thread Jonathon Jongsma
This creates a synchronization point and allows API users to rely on the fact that they'll always get a UUID notification before all of the channels are created. --- gtk/channel-main.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/gtk/channel-main.c b/gtk/channel-main.c index 5c3

Re: [Spice-devel] [PATCH] Guarantee that 'uuid' property is notified after connection

2013-11-07 Thread Marc-André Lureau
- Original Message - > This creates a synchronization point and allows API users to rely on the fact > that they'll always get a UUID notification before all of the channels are > created. > --- > gtk/channel-main.c | 10 ++ > 1 file changed, 10 insertions(+) > > diff --git a/gtk

Re: [Spice-devel] [PATCH spice-gtk 2/5] Add SPICE_MAX_CLIPBOARD environment variable

2013-11-07 Thread Jonathon Jongsma
I guess this would work for relatively simple cases (e.g. where the client doesn't change its max-clipboard property after construction), but if you wanted it to be a more reliable override, I'd suggested having a simple internal getter function something like static int get_max_clipboard(Spice

Re: [Spice-devel] [PATCH spice-gtk 2/5] Add SPICE_MAX_CLIPBOARD environment variable

2013-11-07 Thread Marc-André Lureau
- Original Message - > I guess this would work for relatively simple cases (e.g. where the client > doesn't change its max-clipboard property after construction), but if you > wanted it to be a more reliable override, I'd suggested having a simple > internal getter function something like

Re: [Spice-devel] Spice bug62033, Gnome bug 680195 rework: new inhibitors for desktop effects

2013-11-07 Thread Fedor Lyakhov
Hi Bastein, On Mon, Nov 4, 2013 at 4:27 PM, Hans de Goede wrote: > Hi, > > > On 11/02/2013 05:50 PM, Fedor Lyakhov wrote: >> >> Bastein, Hans, >> >> We need an agreement on this topic so I can implement something - and >> have it accepted in both Spice and Gnome eventually. >> >> There are 2 poss

Re: [Spice-devel] Spice bug62033, Gnome bug 680195 rework: new inhibitors for desktop effects

2013-11-07 Thread Fedor Lyakhov
OK, got it. Thanks for your patience. I'll CC you once the patch is ready... I understand reasons behind both of the approaches - this one is simple. But I'd need to add Spice vdagent D-Bus API for exactly this one use case... hope that more interface functions will need to be exposed in future.

Re: [Spice-devel] Spice bug62033, Gnome bug 680195 rework: new inhibitors for desktop effects

2013-11-07 Thread Marc-André Lureau
Fedor, - Original Message - > OK, got it. Thanks for your patience. I'll CC you once the patch is ready... > > I understand reasons behind both of the approaches - this one is > simple. But I'd need to add Spice vdagent D-Bus API for exactly this > one use case... hope that more interfac

[Spice-devel] [vdagent-win PATCH 1/6] vdagent: add as_user to run tasks with user privileges

2013-11-07 Thread Uri Lublin
The class calls Impersonate upon begin(), and Revert upon end() or destruction. The user is the current user that is logged in. create mode 100644 vdagent/as_user.cpp create mode 100644 vdagent/as_user.h diff --git a/Makefile.am b/Makefile.am index f907031..768e984 100644 --- a/Makefile.am +++

[Spice-devel] [vdagent-win PATCH 5/6] Makefile.am: tabify

2013-11-07 Thread Uri Lublin
diff --git a/Makefile.am b/Makefile.am index 768e984..da0b5a5 100644 --- a/Makefile.am +++ b/Makefile.am @@ -32,8 +32,8 @@ vdagent_SOURCES = \ vdagent/desktop_layout.h\ vdagent/display_setting.cpp \ vdagent/display_setting.h \ -

[Spice-devel] [vdagent-win PATCH 0/6] file_xfer fixes and some cleanups

2013-11-07 Thread Uri Lublin
The destination directory for file_xfer was a public one (e.g. desktop directory of all-users). This is since vdagent.exe does not run as current logged in user. This patchset makes the creation of the file run as the logged in user, such that the destination directory for file-xfer is the user's

[Spice-devel] [vdagent-win PATCH 4/6] vdagent: file-xfer: make user desktop the target directory

2013-11-07 Thread Uri Lublin
Before, the target directory was a public one (for all users), as file creation was not done with user privileges. Now that the file is created with user privileges, it's better to make the user desktop the target directory. diff --git a/vdagent/file_xfer.cpp b/vdagent/file_xfer.cpp index 0c44c45

[Spice-devel] [vdagent-win PATCH 2/6] file_xfer: create file with user privileges

2013-11-07 Thread Uri Lublin
diff --git a/vdagent/file_xfer.cpp b/vdagent/file_xfer.cpp index 66b489a..2a6480a 100644 --- a/vdagent/file_xfer.cpp +++ b/vdagent/file_xfer.cpp @@ -21,6 +21,7 @@ #include #include #include "file_xfer.h" +#include "as_user.h" FileXfer::~FileXfer() { @@ -44,6 +45,7 @@ void FileXfer::handle_

[Spice-devel] [vdagent-win PATCH 3/6] vdagent: file_xfer: make g_key_get_string safer

2013-11-07 Thread Uri Lublin
By providing the size of the destination string buffer. diff --git a/vdagent/file_xfer.cpp b/vdagent/file_xfer.cpp index 2a6480a..0c44c45 100644 --- a/vdagent/file_xfer.cpp +++ b/vdagent/file_xfer.cpp @@ -49,7 +49,7 @@ void FileXfer::handle_start(VDAgentFileXferStartMessage* start, status->

[Spice-devel] [vdagent-win PATCH 6/6] Makefile.am: add INCLUDES to AM_CPPFLAGS

2013-11-07 Thread Uri Lublin
Fixes the following autoreconf (automake) warning: Makefile.am:6: warning: 'INCLUDES' is the old name for 'AM_CPPFLAGS' (or '*_CPPFLAGS') diff --git a/Makefile.am b/Makefile.am index da0b5a5..fc017d5 100644 --- a/Makefile.am +++ b/Makefile.am @@ -3,13 +3,13 @@ MAINTAINERCLEANFILES = DIST_SUBDIR

Re: [Spice-devel] [PATCH 2/2] vdagent: add max-clipboard message

2013-11-07 Thread Uri Lublin
On 11/06/2013 10:07 PM, Marc-André Lureau wrote: Add an optional message sent by the client to ask the agent not to send clipboard data bigger than a certain size, in bytes. The message can be sent if the agent supports the capability MAX_CLIPBOARD, at any time. The agent is free to ignore or f

Re: [Spice-devel] [PATCH 2/2] vdagent: add max-clipboard message

2013-11-07 Thread Marc-André Lureau
On Thu, Nov 7, 2013 at 11:17 PM, Uri Lublin wrote: > On 11/06/2013 10:07 PM, Marc-André Lureau wrote: >> >> Add an optional message sent by the client to ask the agent not to send >> clipboard data bigger than a certain size, in bytes. The message can be >> sent if the agent supports the capabili

Re: [Spice-devel] [PATCH 2/2] vdagent: add max-clipboard message

2013-11-07 Thread Marc-André Lureau
On Thu, Nov 7, 2013 at 11:37 PM, Marc-André Lureau wrote: > On Thu, Nov 7, 2013 at 11:17 PM, Uri Lublin wrote: >> On 11/06/2013 10:07 PM, Marc-André Lureau wrote: >>> >>> Add an optional message sent by the client to ask the agent not to send >>> clipboard data bigger than a certain size, in byte

Re: [Spice-devel] [PATCH spice-gtk 0/5] RFC: Improve handling of large clipboard data

2013-11-07 Thread Jonathon Jongsma
Other than the minor issues I pointed out separately, the rest of this looks OK to me. On Wed, 2013-11-06 at 22:25 +0100, Marc-André Lureau wrote: > From: Marc-André Lureau > > Hi, > > It's quite easy to crash a spice-gtk client when a clipboard operation > take large data buffers. There are s

Re: [Spice-devel] [PATCH spice-gtk 0/5] RFC: Improve handling of large clipboard data

2013-11-07 Thread Marc-André Lureau
I'll hold it for now, since we are still discussing the protocol message. On Thu, Nov 7, 2013 at 11:42 PM, Jonathon Jongsma wrote: > Other than the minor issues I pointed out separately, the rest of this > looks OK to me. > > On Wed, 2013-11-06 at 22:25 +0100, Marc-André Lureau wrote: >> From: Ma

Re: [Spice-devel] [PATCH spice-gtk 1/5] Block sending clipboard data > max-clipboard

2013-11-07 Thread Uri Lublin
On 11/06/2013 11:25 PM, Marc-André Lureau wrote: From: Marc-André Lureau Attempt to send very large clipboard data may easy cause OOM abort, either in gdk - some patch are proposed to improve the situation, or in spice-gtk itself. Let's have a property that blocks unreasonably big clipboard d

Re: [Spice-devel] [PATCH 2/2] vdagent: add max-clipboard message

2013-11-07 Thread Uri Lublin
On 11/08/2013 12:37 AM, Marc-André Lureau wrote: On Thu, Nov 7, 2013 at 11:17 PM, Uri Lublin wrote: On 11/06/2013 10:07 PM, Marc-André Lureau wrote: Add an optional message sent by the client to ask the agent not to send clipboard data bigger than a certain size, in bytes. The message can be

Re: [Spice-devel] [PATCH spice-gtk 1/5] Block sending clipboard data > max-clipboard

2013-11-07 Thread Marc-André Lureau
On Thu, Nov 7, 2013 at 11:47 PM, Uri Lublin wrote: > On 11/06/2013 11:25 PM, Marc-André Lureau wrote: >> >> From: Marc-André Lureau >> >> Attempt to send very large clipboard data may easy cause OOM >> abort, either in gdk - some patch are proposed to improve the situation, >> or in spice-gtk it

Re: [Spice-devel] [PATCH 2/2] vdagent: add max-clipboard message

2013-11-07 Thread Marc-André Lureau
On Thu, Nov 7, 2013 at 11:58 PM, Uri Lublin wrote: > On 11/08/2013 12:37 AM, Marc-André Lureau wrote: >> >> On Thu, Nov 7, 2013 at 11:17 PM, Uri Lublin wrote: >>> >>> On 11/06/2013 10:07 PM, Marc-André Lureau wrote: Add an optional message sent by the client to ask the agent not to send

Re: [Spice-devel] [PATCH spice-gtk 1/5] Block sending clipboard data > max-clipboard

2013-11-07 Thread Uri Lublin
On 11/08/2013 01:06 AM, Marc-André Lureau wrote: On Thu, Nov 7, 2013 at 11:47 PM, Uri Lublin wrote: diff --git a/gtk/channel-main.c b/gtk/channel-main.c index 5c33e67..dbcaff8 100644 --- a/gtk/channel-main.c +++ b/gtk/channel-main.c diff --git a/gtk/spice-gtk-session.c b/gtk/spice-gtk-session

Re: [Spice-devel] [PATCH 2/2] vdagent: add max-clipboard message

2013-11-07 Thread Uri Lublin
On 11/08/2013 01:11 AM, Marc-André Lureau wrote: On Thu, Nov 7, 2013 at 11:58 PM, Uri Lublin wrote: On 11/08/2013 12:37 AM, Marc-André Lureau wrote: On Thu, Nov 7, 2013 at 11:17 PM, Uri Lublin wrote: On 11/06/2013 10:07 PM, Marc-André Lureau wrote: Add an optional message sent by the client