Re: [Spice-devel] Spice bug62033, Gnome bug 680195 rework: new inhibitors for desktop effects

2013-11-04 Thread Bastien Nocera
On Thu, 2013-10-31 at 14:44 +0400, Fedor Lyakhov wrote: > Hi Bastien, > > I'm working on a bug/enhancement for Spice reported by Zeeshan: > https://bugs.freedesktop.org/show_bug.cgi?id=62033 (Means to detect > local-only). It is related to Gnome bug > https://bugzilla.gnome.org/show_bug.cgi?id=680

[Spice-devel] [PATCH] Require alsa only with --enable-client

2013-11-04 Thread Christian Ruppert
Hey guys, the alsa libraries/header seem to be required only when configured with --enable-client so I wrote a patch to make configure respect it. -- Regards, Christian Ruppert From 53683cc75ba092799f856f710cb45b2aacfb6123 Mon Sep 17 00:00:00 2001 From: Christian Ruppert Date: Sun, 3 Nov 2013 1

Re: [Spice-devel] [PATCH] Require alsa only with --enable-client

2013-11-04 Thread Christophe Fergeau
On Sun, Nov 03, 2013 at 06:38:55PM +0100, Christian Ruppert wrote: > Hey guys, > > the alsa libraries/header seem to be required only when configured with > --enable-client so I wrote a patch to make configure respect it. ACK, thanks! Christophe pgpYsHQ2T1o38.pgp Description: PGP signature ___

Re: [Spice-devel] Spice bug62033, Gnome bug 680195 rework: new inhibitors for desktop effects

2013-11-04 Thread Hans de Goede
Hi, On 11/02/2013 05:50 PM, Fedor Lyakhov wrote: Bastein, Hans, We need an agreement on this topic so I can implement something - and have it accepted in both Spice and Gnome eventually. There are 2 possible approaches conflicting here: (i) (spice-proposed) DEs to export API for toggling effec

Re: [Spice-devel] [spice sound rework 2/3 (take 3)] Revise the spice client and server to use the new snd_codec functions in spice-common.

2013-11-04 Thread Christophe Fergeau
On Thu, Oct 31, 2013 at 11:09:37AM -0500, Jeremy White wrote: > @@ -1572,18 +1541,16 @@ void snd_set_playback_compression(int on) > { > SndWorker *now = workers; > > -playback_compression = on ? SPICE_AUDIO_DATA_MODE_CELT_0_5_1 : > SPICE_AUDIO_DATA_MODE_RAW; > +playback_compression

[Spice-devel] [PATCH 2/2] SpiceDisplay: validate 'self' argument for public API

2013-11-04 Thread Jonathon Jongsma
Add defensive g_return[_val]_if_fail(SPICE_IS_DISPLAY()) to all public API --- gtk/spice-widget.c | 34 -- 1 file changed, 28 insertions(+), 6 deletions(-) diff --git a/gtk/spice-widget.c b/gtk/spice-widget.c index 8b5fa59..014d2fb 100644 --- a/gtk/spice-widget.c +

[Spice-devel] [PATCH 1/2] Add ability to get SpiceDisplay resolution

2013-11-04 Thread Jonathon Jongsma
Add spice_display_get_monitor_config() to get the current configuration of the display. --- doc/reference/spice-gtk-sections.txt | 2 ++ gtk/channel-display.c| 2 +- gtk/channel-display.h| 9 gtk/map-file | 1 + gtk/spice-gtk-sym

Re: [Spice-devel] [PATCH 1/2] Add ability to get SpiceDisplay resolution

2013-11-04 Thread Marc-André Lureau
- Original Message - > Add spice_display_get_monitor_config() to get the current configuration of > the > display. > --- > doc/reference/spice-gtk-sections.txt | 2 ++ > gtk/channel-display.c| 2 +- > gtk/channel-display.h| 9 > gtk/map-file

Re: [Spice-devel] [PATCH 2/2] SpiceDisplay: validate 'self' argument for public API

2013-11-04 Thread Marc-André Lureau
- Original Message - > Add defensive g_return[_val]_if_fail(SPICE_IS_DISPLAY()) to all public API > --- > gtk/spice-widget.c | 34 -- > 1 file changed, 28 insertions(+), 6 deletions(-) > > diff --git a/gtk/spice-widget.c b/gtk/spice-widget.c > index 8b5fa

[Spice-devel] [spice sound rework 2/3 (!!take 3)] Revise the spice client and server to use the new snd_codec functions in spice-common.

2013-11-04 Thread Jeremy White
This makes celt optional, and paves the way to readily add additional codecs. Signed-off-by: Jeremy White --- README |1 - client/audio_channels.h | 12 ++- client/playback_channel.cpp | 59 ++-- client/record_channel.cpp | 69 ++- configu

Re: [Spice-devel] [spice sound rework 2/3 (take 3)] Revise the spice client and server to use the new snd_codec functions in spice-common.

2013-11-04 Thread Jeremy White
On 11/04/2013 10:17 AM, Christophe Fergeau wrote: > On Thu, Oct 31, 2013 at 11:09:37AM -0500, Jeremy White wrote: >> @@ -1572,18 +1541,16 @@ void snd_set_playback_compression(int >> on) { SndWorker *now = workers; >> >> -playback_compression = on ? SPICE_AUDIO_DATA_MODE_CELT_0_5_1 >> : SPICE_A