2012/11/22 Fabio Fantoni
> Il 22/11/2012 08:46, Qian Hu ha scritto:
>
> Hi, Fabio
>
> Thank you for your advice! I have successfully added the patch to
> xen-4.2.0 and set the parameters as you said.
>
> It works and the client seems to be better than before.
>
> Still, there is a little prob
Hi, everyone!
I am working on spice for xen-4.2.0 with QXL support. With the patch for
QXL, I have successfully connected to guest(win7) now.
While testing the audio, I found that system crashed when recording through
the windows recorder.
I am sure the audiospeaker is OK and the device manager
Hi,
Videos are OK after the system boot.
I am sorry I am not authorized to access the bug in
https://bugzilla.redhat.com/show_bug.cgi?id=667689
Could anyone help to paste it here ?
Thank you!
2012/11/22 Fabio Fantoni
> Il 22/11/2012 08:46, Qian Hu ha scritto:
>
> Hi, Fabio
>
> Thank you f
At present, Vmware and Virtualbox has supported file drag&drop feature,
I think it's a good feature for users, so we want qemu/spice to
supports it.
This patch first adds communication protocol between client and guest,
we must make the agent protocol stable before coding, this is what we
want thi
These patches simply implement file drag-and-drop from client to guest.
I think this patches can be merge upstream soonish as a first version
if protocol related file transfer is stable.
V1 -> V2:
* Address Marc-André and hans's comments, most of the code are rewritten.
* Move all file oper
This patch is aimed to handle various xfer messages.
How it works:
0) our main channel introduces a API spice_main_file_xfer().
1) When user drags a file and drop to spice client, spice client will
catch a signal "drag-data-received", then it should call
spice_main_file_xfer() for transferi
When user drags a file to SpiceDisplay and drops it, a signal named
"drag-data-received" will be emitted, the signal will be received by
SpiceDisplay, then our signal handler should receive data which contains
file path, and call spice_main_file_xfer() to transfer file to guest.
Signed-off-by: Dun
Signed-off-by: Dunrong Huang
---
gtk/channel-main.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/gtk/channel-main.c b/gtk/channel-main.c
index 3ea3958..efbed15 100644
--- a/gtk/channel-main.c
+++ b/gtk/channel-main.c
@@ -2447,6 +2447,13 @@ static void file_xfer_send_start_msg(gpoint
The patch makes linux agent support drag-n-drop feature.
Signed-off-by: Dunrong Huang
---
V1 -> V2:
* New transfer protocol
src/vdagent.c | 153 +
src/vdagentd.c | 44 +
2 files changed, 197 insertions(+)
diff --gi
Hi, Hans
Very thanks for your patient guidance.
2012/11/17 Hans de Goede :
> Hi,
>
> First of all many many thanks for working on this. For a first version these
> patches look very good!
>
> Second sorry for being a bit late with this reply I started composing it a
> week ago, and then other stu
Hi
- Mensaje original -
> At present, Vmware and Virtualbox has supported file drag&drop
> feature,
> I think it's a good feature for users, so we want qemu/spice to
> supports it.
Btw, have you done a small comparison of what VirtualBox can support and how it
is implemented?
> This pat
Hi Marc-André,
On 11/23/2012 12:53 PM, Marc-André Lureau wrote:
Hi
+enum {
+VD_AGENT_FILE_XFER_RESULT_SUCCESS,
What does success indicates? When is it sent?
I believe that Dunrong Huang based this second version on my protocol proposal,
which answers this and a few of your other q
Hi,
On 11/23/2012 01:07 PM, Hans de Goede wrote:
[vdagent-file-xfer]
type=directory
mime=application/x-xz-compressed-tar
name=Downloads
time-modified=1353085649
time-...
can-read=true
can-execute=true
can-write=false
size=515416
[vdagent-context]
pointer-position=+34+98
We need to define the
Hi
- Mensaje original -
> Hi Marc-André,
>
> On 11/23/2012 12:53 PM, Marc-André Lureau wrote:
> > Hi
> >
>
>
>
> >>
> >> +enum {
> >> +VD_AGENT_FILE_XFER_RESULT_SUCCESS,
> >
> > What does success indicates? When is it sent?
>
> I believe that Dunrong Huang based this second versio
Hi,
On 11/23/2012 01:10 PM, Marc-André Lureau wrote:
Hi
- Mensaje original -
Hi Marc-André,
On 11/23/2012 12:53 PM, Marc-André Lureau wrote:
Hi
+enum {
+VD_AGENT_FILE_XFER_RESULT_SUCCESS,
What does success indicates? When is it sent?
I believe that Dunrong Huang based
spice_server_set_ticket and spice_server_set_addr get (library)
user-provided strings as arguments, and copy them to fixed-size
buffers using strncpy. However, if these strings are too long,
the copied string will not be 0-terminated, which will cause issues
later. This commit copies one byte less
We currently output a warning when getaddrinfo fails, but then
we go on trying to use the information it couldn't read. Make
sure we bail out of reds_init_socket if getaddrinfo fails.
---
server/reds.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/server/reds.c b/server/reds.c
index 5a03043.
Hi,
On 11/23/2012 01:18 PM, Christophe Fergeau wrote:
spice_server_set_ticket and spice_server_set_addr get (library)
user-provided strings as arguments, and copy them to fixed-size
buffers using strncpy. However, if these strings are too long,
the copied string will not be 0-terminated, which w
ack.
On 11/23/2012 01:18 PM, Christophe Fergeau wrote:
We currently output a warning when getaddrinfo fails, but then
we go on trying to use the information it couldn't read. Make
sure we bail out of reds_init_socket if getaddrinfo fails.
---
server/reds.c | 1 +
1 file changed, 1 insertion(+
On Fri, Nov 23, 2012 at 01:25:55PM +0100, Hans de Goede wrote:
> On 11/23/2012 01:18 PM, Christophe Fergeau wrote:
> >spice_server_set_ticket and spice_server_set_addr get (library)
> >user-provided strings as arguments, and copy them to fixed-size
> >buffers using strncpy. However, if these string
Hi,
On 11/23/2012 01:42 PM, Christophe Fergeau wrote:
On Fri, Nov 23, 2012 at 01:25:55PM +0100, Hans de Goede wrote:
On 11/23/2012 01:18 PM, Christophe Fergeau wrote:
spice_server_set_ticket and spice_server_set_addr get (library)
user-provided strings as arguments, and copy them to fixed-size
- Mensaje original -
> See my reply to myself. I'm fine with using glib-keyfile. I wonder
> what this
> means for the windows agent though?
We can link the agent statically today with the few libraries we link to.
Hopefully, we can also link with glib statically (note: we strip the resu
Hi,
On 11/23/2012 01:59 PM, Marc-André Lureau wrote:
- Mensaje original -
See my reply to myself. I'm fine with using glib-keyfile. I wonder
what this
means for the windows agent though?
We can link the agent statically today with the few libraries we link to.
Hopefully, we can als
Hi, Marc-André
Thanks for reply
2012/11/23 Marc-André Lureau :
> Hi
>
> - Mensaje original -
>> At present, Vmware and Virtualbox has supported file drag&drop
>> feature,
>> I think it's a good feature for users, so we want qemu/spice to
>> supports it.
>
> Btw, have you done a small comp
Hi Dunrong Huang,
Thanks for your continued work on this!
And sorry that we keep tweaking the protocol, but getting the
protocol right is very important as we cannot change that later.
On 11/23/2012 02:02 PM, Dunrong Huang wrote:
Hi, Marc-André
Thanks for reply
2012/11/23 Marc-André Lureau :
Hey,
This patch series introduces 2 build system changes that are worth some
attention. The first one disables client build by default as it's deprecated,
and the second patch adds a dependency on glib2. Both of these patches
are steps in the right direction in my opinion, but I'm happy with
dropp
It has been superseded by virt-viewer/remote-viewer
---
configure.ac | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/configure.ac b/configure.ac
index d02ea19..a12e119 100644
--- a/configure.ac
+++ b/configure.ac
@@ -150,7 +150,7 @@ fi
AC_ARG_ENABLE(client,
[ --enable-clie
Now that QEMU depends on glib, it won't really hurt if we depend
on it as well, and we won't have to reinvent our own helpers.
---
configure.ac | 3 +++
server/Makefile.am | 2 ++
2 files changed, 5 insertions(+)
diff --git a/configure.ac b/configure.ac
index a12e119..fc0216f 100644
--- a/c
reds.c is using strncpy with a length one byte less than the
destination buffer size, and is relying on the fact that the
destination buffers are static global variables.
Now that we depend on glib, we can use g_strlcpy instead, which
avoids relying on such a subtle trick to get a nul-terminated
st
On Wed, Nov 21, 2012 at 07:27:36PM +, Jodi Curtis wrote:
> I have been working with kvm-spice connected to virt-viewer/remote-viewer
>
> I have a Ubuntu server 12.10 hosting four virtual machines, one is a spice
> desktop, Xubuntu 12.10, the others are ubuntu Server 12.10
>
> All were install
Verified that with your patch things still work as expected.
The minor issue remaining is that when switching users, the client window
get resized for a brief moment to previous resolution before the agent
actually adjust to current window resolution, and then the client window is
restored.
This
31 matches
Mail list logo
