Using spice-gtk b9b658f6ea41a2473853149b41fef2cb808ec4f2
spice 914e50814f151a9a5680018e2f264fd900885af9
qemu 33cf629a3754b58a1e2dbbe01d91d97e712b7c06
[ykaul@ykaul spice-gtk]$ gtk/spicy &
[1] 29428
[ykaul@ykaul spice-gtk]$ GSpice-Message: main channel: failed to connect
GSpice-Message: main channe
On Mon, Mar 19, 2012 at 09:19:35PM +0100, Marc-André Lureau wrote:
> ---
> .gitignore| 17
> Makefile.am | 21 +-
> configure.ac |2 +
> git.mk| 212
> +
> spice/Makefile.am | 36 +
> 5
Hmm, what does that bring to spice-protocol which is not modified that
often?
Christophe
On Mon, Mar 19, 2012 at 09:19:35PM +0100, Marc-André Lureau wrote:
> ---
> .gitignore| 17
> Makefile.am | 21 +-
> configure.ac |2 +
> git.mk| 212
> ++
- Mensaje original -
> >
> > -DISTCLEANFILES = \
> > - spice-protocol.pc
>
> So where does this go? DISTCLEANFILES is not needed anymore? Don't we
> want make distclean to remove spice-protocol.pc?
Files generated during configure are automatically added to distclean rul
First defined in spice.h, fixes build failure with gcc 4.4.6
---
server/red_worker.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/server/red_worker.c b/server/red_worker.c
index 276ada4..e3a9e10 100644
--- a/server/red_worker.c
+++ b/server/red_worker.c
@@ -236,11 +23
ack
--
Marc-André Lureau
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/spice-devel
On 03/15/2012 02:48 PM, Marc-André Lureau wrote:
> Peter,
>
> To resume the discussion and be a bit more specific:
>
>> +#if __GNUC__
>> +static inline std::string pretty_func_to_func_name(const std::string&
>> f_name)
>> +{
>> +std::string name(f_name);
>> +std::string::size_type end_po
- Original Message -
> On 03/15/2012 02:48 PM, Marc-André Lureau wrote:
> > why not use only __FUNCTION__?
> >
>
> Because, it does not format the string to meet this pattern for
> classes:
> "class::method". What I get is only the method name, which is not
> enough
> in this case.
Appa
Hi,
> We can either store and migrate the cache, or choose to reset it.
> In the extinct spice seamless migration solution, the cache was reset.
Hmm, this makes me wonder what the main advantage of seamless migration
used to be? image cache was reset, surfaces didn't exist back then. So
any i
---
gtk/Makefile.am |8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/gtk/Makefile.am b/gtk/Makefile.am
index cd6da20..9cbcab5 100644
--- a/gtk/Makefile.am
+++ b/gtk/Makefile.am
@@ -513,16 +513,16 @@ spice-widget-enums.h: spice-widget.h
# Note despite being autogene
The spice controller socket name used to be hardcoded to
/tmp/SpiceController-%lu.uds and generated using snprintf. A 50 bytes
buffer was enough for that, but this was changed in commit 79fffbf95
because this was predictable and allowed other users on the system
to sniff the browser/client communic
When we get the socket name for the foreign menu socket from
an environment variable, we cannot make assumptions about its length.
Currently, we are strncpying to a 50 byte buffer which is easily
too small.
---
client/foreign_menu.cpp | 13 -
1 files changed, 8 insertions(+), 5 delet
On Tue, Mar 20, 2012 at 04:14:07PM +0100, Christophe Fergeau wrote:
> The spice controller socket name used to be hardcoded to
> /tmp/SpiceController-%lu.uds and generated using snprintf. A 50 bytes
> buffer was enough for that, but this was changed in commit 79fffbf95
> because this was predictabl
The various Canvas have _max and _base variables which are not
used, better to remove them.
---
client/canvas.cpp |1 -
client/canvas.h |3 ---
client/red_gdi_canvas.h |2 --
client/red_sw_canvas.h |2 --
4 files changed, 0 insertions(+), 8 deletions(-)
diff --git a
Ack.
On 03/20/2012 04:33 PM, Christophe Fergeau wrote:
The various Canvas have _max and _base variables which are not
used, better to remove them.
---
client/canvas.cpp |1 -
client/canvas.h |3 ---
client/red_gdi_canvas.h |2 --
client/red_sw_canvas.h |2 --
Hi,
On 03/20/2012 03:58 PM, Gerd Hoffmann wrote:
Hi,
We can either store and migrate the cache, or choose to reset it.
In the extinct spice seamless migration solution, the cache was reset.
Hmm, this makes me wonder what the main advantage of seamless migration
used to be? image cache was
Hide symbol from API to fix pygobject.
Also vapigen chokes on "record" typename
SpiceClientGtk-3.0.gir:32.55-32.55: error: The type name `Gtk.BoxClass' could
not be found
This seems to be a bug in symbol lookup in vapigen. Using a struct
typedef solves it.
---
gtk/usb-device-widget.h | 12 +
Don't use DIST_SUBDIRS, it's not needed anyway.
---
Makefile.am |4 +---
1 files changed, 1 insertions(+), 3 deletions(-)
diff --git a/Makefile.am b/Makefile.am
index 334752b..5f1353c 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -1,9 +1,7 @@
ACLOCAL_AMFLAGS = -I m4
NULL =
-SUBDIRS = comm
On Tue, Mar 20, 2012 at 06:40:11PM +0100, Marc-André Lureau wrote:
> Hide symbol from API to fix pygobject.
>
> Also vapigen chokes on "record" typename
>
> SpiceClientGtk-3.0.gir:32.55-32.55: error: The type name `Gtk.BoxClass' could
> not be found
>
> This seems to be a bug in symbol lookup
On Tue, Mar 20, 2012 at 6:52 PM, Alon Levy wrote:
>> This seems to be a bug in symbol lookup in vapigen. Using a struct
>> typedef solves it.
>
> Well, if it works.. Although it sounds a bit magic. File a bug upstream?
> (/me hides)
I discussed the bug with the maintainer, but that doesn't seem v
qemu can call spice_server_set_name(s, NULL) when the name is not
given. Let's not crash in this case
---
server/main_channel.c |4 ++--
server/red_tunnel_worker.c |4 ++--
server/reds.c | 12 ++--
3 files changed, 10 insertions(+), 10 deletions(-)
diff --git a
---
server/reds.c | 18 --
1 files changed, 8 insertions(+), 10 deletions(-)
diff --git a/server/reds.c b/server/reds.c
index b5d185e..30e3ac0 100644
--- a/server/reds.c
+++ b/server/reds.c
@@ -2480,9 +2480,7 @@ static void reds_start_auth_sasl(RedLinkInfo *link)
if (er
Latest Spice dissector in Wireshark trunk[1] has been enhanced to
support these two new main channel messages.
(It was a bit surprising to find out the UUID is sent as big endian,
while most of the protocol is little endian)
Y.
[1]
http://anonsvn.wireshark.org/viewvc/trunk/epan/dissectors/pack
Ack series.
On 03/20/2012 08:30 PM, Marc-André Lureau wrote:
qemu can call spice_server_set_name(s, NULL) when the name is not
given. Let's not crash in this case
---
server/main_channel.c |4 ++--
server/red_tunnel_worker.c |4 ++--
server/reds.c | 12 ++-
It turned out the demarshaller wasn't allocating enough space to
memcpy the name. In order to take into account the size of a variable
array, it needs to be marked with the @end tag so that the
"extra_size" is added to the allocated memory.
It would be nice if the demarshaller would somehow fail i
Ack.
On 03/20/2012 09:42 PM, Marc-André Lureau wrote:
It turned out the demarshaller wasn't allocating enough space to
memcpy the name. In order to take into account the size of a variable
array, it needs to be marked with the @end tag so that the
"extra_size" is added to the allocated memory.
26 matches
Mail list logo
