Re: [Spice-devel] [PATCH spice-gtk] Fix incorrect array size check

2012-03-15 Thread Hans de Goede
Ack. On 03/14/2012 11:26 PM, Marc-André Lureau wrote: --- gtk/spice-channel.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/gtk/spice-channel.c b/gtk/spice-channel.c index 77b066e..be95f00 100644 --- a/gtk/spice-channel.c +++ b/gtk/spice-channel.c @@ -1863,7 +1863,

[Spice-devel] log file for spice-gtk

2012-03-15 Thread Yonit Halperin
Hi, Are there any plans to have a log file for spice-gtk? I think that it is very important to have logging with configurable debug level via a configuration file. It will be helpful for live debugging of user problems that are hard to reproduce. I also saw there was some discussion about .sp

Re: [Spice-devel] [PATCH 5/5] build: use common/client_{de, }marshallers.h

2012-03-15 Thread Alon Levy
On Thu, Mar 15, 2012 at 02:13:35AM +0100, Marc-André Lureau wrote: Arnon, could you test this? it touched the vcproj file, I don't have a build environment atm. Thanks. > --- > client/Makefile.am |6 +-- > client/demarshallers.h | 27 -- > client/marshallers

Re: [Spice-devel] [PATCH 5/5] build: use common/client_{de, }marshallers.h

2012-03-15 Thread Alon Levy
On Thu, Mar 15, 2012 at 02:13:35AM +0100, Marc-André Lureau wrote: This last patch doesn't apply on top of master. Last commit: 914e508 red_worker: Check for NULL watches > --- > client/Makefile.am |6 +-- > client/demarshallers.h | 27 -- > client/marshal

Re: [Spice-devel] [PATCH 5/5] build: use common/client_{de, }marshallers.h

2012-03-15 Thread Alon Levy
On Thu, Mar 15, 2012 at 02:13:35AM +0100, Marc-André Lureau wrote: The failures when applying "by hand": patching file client/windows/generate.bat Hunk #1 NOT MERGED at 1-5. patching file client/windows/generate1.bat patching file client/windows/redc.vcproj Hunk #1 NOT MERGED at 695-705. > --- >

Re: [Spice-devel] [PATCH 5/5] build: use common/client_{de, }marshallers.h

2012-03-15 Thread Alon Levy
On Thu, Mar 15, 2012 at 02:13:35AM +0100, Marc-André Lureau wrote: EOL is different, your patches are unix EOL, the files are dos EOL. > --- > client/Makefile.am |6 +-- > client/demarshallers.h | 27 -- > client/marshallers.h | 63 > -

Re: [Spice-devel] log file for spice-gtk

2012-03-15 Thread Daniel P. Berrange
On Thu, Mar 15, 2012 at 11:14:15AM +0200, Yonit Halperin wrote: > Hi, > > Are there any plans to have a log file for spice-gtk? > I think that it is very important to have logging with configurable > debug level via a configuration file. It will be helpful for live > debugging of user problems tha

Re: [Spice-devel] log file for spice-gtk

2012-03-15 Thread Alon Levy
On Thu, Mar 15, 2012 at 10:23:28AM +, Daniel P. Berrange wrote: > On Thu, Mar 15, 2012 at 11:14:15AM +0200, Yonit Halperin wrote: > > Hi, > > > > Are there any plans to have a log file for spice-gtk? > > I think that it is very important to have logging with configurable > > debug level via a

Re: [Spice-devel] log file for spice-gtk

2012-03-15 Thread Daniel P. Berrange
On Thu, Mar 15, 2012 at 12:39:13PM +0200, Alon Levy wrote: > On Thu, Mar 15, 2012 at 10:23:28AM +, Daniel P. Berrange wrote: > > On Thu, Mar 15, 2012 at 11:14:15AM +0200, Yonit Halperin wrote: > > > Hi, > > > > > > Are there any plans to have a log file for spice-gtk? > > > I think that it is

Re: [Spice-devel] log file for spice-gtk

2012-03-15 Thread Marc-André Lureau
On Thu, Mar 15, 2012 at 11:39 AM, Alon Levy wrote: > OK, so I think there is place to make remote-viewer produce a log file > by default. The caller of virt-viewer/spice-gtk can redirect logging to files. By experience, I'd say this is the right solution, as it avoid filling disk or getting compl

Re: [Spice-devel] log file for spice-gtk

2012-03-15 Thread Alon Levy
On Thu, Mar 15, 2012 at 12:25:19PM +0100, Marc-André Lureau wrote: > On Thu, Mar 15, 2012 at 11:39 AM, Alon Levy wrote: > > OK, so I think there is place to make remote-viewer produce a log file > > by default. > > The caller of virt-viewer/spice-gtk can redirect logging to files. By > experience

Re: [Spice-devel] log file for spice-gtk

2012-03-15 Thread Christophe Fergeau
On Thu, Mar 15, 2012 at 12:25:19PM +0100, Marc-André Lureau wrote: > > 1. For any hard to reproduce error there will be a log file by default. > And in the end, 99% of the bugs are solved with: backtrace + > reproducer. Not logging. For real bugs in the code that's true. However, this work only st

Re: [Spice-devel] log file for spice-gtk

2012-03-15 Thread Yonit Halperin
On 03/15/2012 01:25 PM, Marc-André Lureau wrote: On Thu, Mar 15, 2012 at 11:39 AM, Alon Levy wrote: OK, so I think there is place to make remote-viewer produce a log file by default. The caller of virt-viewer/spice-gtk can redirect logging to files. By experience, I'd say this is the right so

Re: [Spice-devel] log file for spice-gtk

2012-03-15 Thread Marc-André Lureau
On Thu, Mar 15, 2012 at 1:00 PM, Christophe Fergeau wrote: > For real bugs in the code that's true. However, this work only starts once > you've ruled out user-related issues, bad system configuration, > network issues, ... and for this kind of issues, logging is much more > helpful than a backtra

Re: [Spice-devel] log file for spice-gtk

2012-03-15 Thread Marc-André Lureau
On Thu, Mar 15, 2012 at 1:00 PM, Yonit Halperin wrote: >> The caller of virt-viewer/spice-gtk can redirect logging to files. By >> experience, I'd say this is the right solution, as it avoid filling >> disk or getting complicated logging (it's not difficult to get several >> megabytes in several f

Re: [Spice-devel] log file for spice-gtk

2012-03-15 Thread Alon Levy
On Thu, Mar 15, 2012 at 01:05:17PM +0100, Marc-André Lureau wrote: > On Thu, Mar 15, 2012 at 1:00 PM, Christophe Fergeau > wrote: > > For real bugs in the code that's true. However, this work only starts once > > you've ruled out user-related issues, bad system configuration, > > network issues,

Re: [Spice-devel] log file for spice-gtk

2012-03-15 Thread Marc-André Lureau
Hi On Thu, Mar 15, 2012 at 1:00 PM, Alon Levy wrote: >> What do you mean by default? There are very good reasons why logging >> files aren't used, not even by default. There are tons of things > > Can you give examples? libvirt produces logging files for qemu and > itself, for example. system da

Re: [Spice-devel] [Qemu-devel] seamless migration with spice

2012-03-15 Thread Yonit Halperin
On 03/13/2012 09:40 AM, Gerd Hoffmann wrote: Hi, It is not easy when you have 2 components, and it is much less easy when you have 3 or 4 components. So why make it more complicated if you can avoid it. Especially since there is no functional reason for making the qemu/client capabilities/ve

Re: [Spice-devel] log file for spice-gtk

2012-03-15 Thread Marc-André Lureau
On Thu, Mar 15, 2012 at 1:13 PM, Marc-André Lureau wrote: > If we aim for a RHEL-only solution, I would use the spice-xpi-client > scripts to do redirection, I already proposed that. It's actually what the spice-xpi-client-* scripts are doing today. There are just missing G_MESSAGES_DEBUG=.. SPIC

Re: [Spice-devel] log file for spice-gtk

2012-03-15 Thread Christophe Fergeau
On Thu, Mar 15, 2012 at 01:13:23PM +0100, Marc-André Lureau wrote: > It's mostly useless and harmful, that's an argument . It's useless *to you*, I think there has been several people who said they had a use for it... Christophe pgpQICCw4PmNE.pgp Description: PGP signature _

Re: [Spice-devel] [Qemu-devel] seamless migration with spice

2012-03-15 Thread Hans de Goede
Hi, On 03/15/2012 01:11 PM, Yonit Halperin wrote: On 03/13/2012 09:40 AM, Gerd Hoffmann wrote: Hi, It is not easy when you have 2 components, and it is much less easy when you have 3 or 4 components. So why make it more complicated if you can avoid it. Especially since there is no functional

Re: [Spice-devel] log file for spice-gtk

2012-03-15 Thread Marc-André Lureau
On Thu, Mar 15, 2012 at 1:23 PM, Christophe Fergeau wrote: > It's useless *to you*, I think there has been several people who said they > had a use for it... I said mostly. If it wasn't useful at all, I don't think we would have the discussion, I wouldn't have enabled it by default in the spice-x

Re: [Spice-devel] log file for spice-gtk

2012-03-15 Thread Christophe Fergeau
On Thu, Mar 15, 2012 at 01:40:00PM +0100, Marc-André Lureau wrote: > And it's not only "me", I haven't seen bugs solved only with automated > logging. Backtrace and/or reproducer is what it takes most of the > time. From there we can actually use various debugging technics, > including logging (ver

Re: [Spice-devel] log file for spice-gtk

2012-03-15 Thread Marc-André Lureau
On Thu, Mar 15, 2012 at 1:55 PM, Christophe Fergeau wrote: > Once again, I'm not saying logging will help fixing a real bug. However, > for bugs we can't reproduce, you often see "I can't reproduce, can you > attach spicec.log? Oh, I see XXX in the logs, did you do before the > bug occurred?"

Re: [Spice-devel] log file for spice-gtk

2012-03-15 Thread Alon Levy
On Thu, Mar 15, 2012 at 01:59:41PM +0100, Marc-André Lureau wrote: > On Thu, Mar 15, 2012 at 1:55 PM, Christophe Fergeau > wrote: > > Once again, I'm not saying logging will help fixing a real bug. However, > > for bugs we can't reproduce, you often see "I can't reproduce, can you > > attach spic

Re: [Spice-devel] log file for spice-gtk

2012-03-15 Thread Christophe Fergeau
On Thu, Mar 15, 2012 at 01:59:41PM +0100, Marc-André Lureau wrote: > On Thu, Mar 15, 2012 at 1:55 PM, Christophe Fergeau > wrote: > > Once again, I'm not saying logging will help fixing a real bug. However, > > for bugs we can't reproduce, you often see "I can't reproduce, can you > > attach spic

Re: [Spice-devel] log file for spice-gtk

2012-03-15 Thread Marc-André Lureau
On Thu, Mar 15, 2012 at 2:14 PM, Alon Levy wrote: > But No, logging to syslog works fine for linux, but even there a lot of > programs produce their own log files. You can put the log file on a Which program produce its own log file on the desktop? > tmpfs (i.e.  /tmp, or /var/tmp, or the new /r

Re: [Spice-devel] log file for spice-gtk

2012-03-15 Thread Alon Levy
On Thu, Mar 15, 2012 at 02:20:33PM +0100, Marc-André Lureau wrote: > On Thu, Mar 15, 2012 at 2:14 PM, Alon Levy wrote: > > But No, logging to syslog works fine for linux, but even there a lot of > > programs produce their own log files. You can put the log file on a > > Which program produce its

Re: [Spice-devel] log file for spice-gtk

2012-03-15 Thread Alon Levy
On Thu, Mar 15, 2012 at 03:36:38PM +0200, Alon Levy wrote: > On Thu, Mar 15, 2012 at 02:20:33PM +0100, Marc-André Lureau wrote: > > On Thu, Mar 15, 2012 at 2:14 PM, Alon Levy wrote: > > > But No, logging to syslog works fine for linux, but even there a lot of > > > programs produce their own log f

Re: [Spice-devel] spice-xpi

2012-03-15 Thread Marc-André Lureau
Peter, To resume the discussion and be a bit more specific: > +#if __GNUC__ > +static inline std::string pretty_func_to_func_name(const std::string& f_name) > +{ > +std::string name(f_name); > +std::string::size_type end_pos = f_name.find('('); > +if (end_pos == std::string::npos) > +

Re: [Spice-devel] log file for spice-gtk

2012-03-15 Thread Marc-André Lureau
On Thu, Mar 15, 2012 at 2:36 PM, Alon Levy wrote: > /home/alon/.cache/shotwell/shotwell.log I have this one too, it's overwritten after each run. > /home/alon/.cache/telepathy/logger > /home/alon/.cache/telepathy/logger/sqlite-data > /home/alon/.cache/tracker/ontologies.gvdb false positive > /

Re: [Spice-devel] log file for spice-gtk

2012-03-15 Thread Marc-André Lureau
On Thu, Mar 15, 2012 at 2:36 PM, Alon Levy wrote: > /home/alon/.cache/zeitgeist/daemon.log btw, this is very scary if you know that zeitgeist basically watch everything you do. This should definetly be turned off by default. -- Marc-André Lureau ___ S

Re: [Spice-devel] [Qemu-devel] seamless migration with spice

2012-03-15 Thread Yonit Halperin
Hi, On 03/15/2012 02:36 PM, Hans de Goede wrote: Hi, On 03/15/2012 01:11 PM, Yonit Halperin wrote: On 03/13/2012 09:40 AM, Gerd Hoffmann wrote: Hi, It is not easy when you have 2 components, and it is much less easy when you have 3 or 4 components. So why make it more complicated if you can

Re: [Spice-devel] log file for spice-gtk

2012-03-15 Thread Christophe Fergeau
On Thu, Mar 15, 2012 at 02:59:30PM +0100, Marc-André Lureau wrote: > On Thu, Mar 15, 2012 at 2:36 PM, Alon Levy wrote: > > /home/alon/.cache/shotwell/shotwell.log > > I have this one too, it's overwritten after each run. > > > /home/alon/.cache/telepathy/logger > > /home/alon/.cache/telepathy/lo

Re: [Spice-devel] log file for spice-gtk

2012-03-15 Thread Alon Levy
On Thu, Mar 15, 2012 at 02:59:30PM +0100, Marc-André Lureau wrote: > On Thu, Mar 15, 2012 at 2:36 PM, Alon Levy wrote: > > /home/alon/.cache/shotwell/shotwell.log > > I have this one too, it's overwritten after each run. > > > /home/alon/.cache/telepathy/logger > > /home/alon/.cache/telepathy/lo

Re: [Spice-devel] [Qemu-devel] seamless migration with spice

2012-03-15 Thread Hans de Goede
Hi, On 03/15/2012 03:07 PM, Yonit Halperin wrote: Hi, On 03/15/2012 02:36 PM, Hans de Goede wrote: Hi, On 03/15/2012 01:11 PM, Yonit Halperin wrote: On 03/13/2012 09:40 AM, Gerd Hoffmann wrote: Hi, It is not easy when you have 2 components, and it is much less easy when you have 3 or 4 com

Re: [Spice-devel] [Qemu-devel] seamless migration with spice

2012-03-15 Thread Alon Levy
On Thu, Mar 15, 2012 at 01:36:23PM +0100, Hans de Goede wrote: > Hi, > > On 03/15/2012 01:11 PM, Yonit Halperin wrote: > >On 03/13/2012 09:40 AM, Gerd Hoffmann wrote: > >>Hi, > >> > >>>It is not easy when you have 2 components, and it is much less easy when > >>>you have 3 or 4 components. So why

Re: [Spice-devel] [Qemu-devel] seamless migration with spice

2012-03-15 Thread Hans de Goede
Hi, On 03/15/2012 03:22 PM, Alon Levy wrote: On Thu, Mar 15, 2012 at 01:36:23PM +0100, Hans de Goede wrote: Hi, On 03/15/2012 01:11 PM, Yonit Halperin wrote: On 03/13/2012 09:40 AM, Gerd Hoffmann wrote: Hi, It is not easy when you have 2 components, and it is much less easy when you have 3

Re: [Spice-devel] [Qemu-devel] seamless migration with spice

2012-03-15 Thread Alon Levy
On Thu, Mar 15, 2012 at 03:34:19PM +0100, Hans de Goede wrote: > Hi, > > On 03/15/2012 03:22 PM, Alon Levy wrote: > >On Thu, Mar 15, 2012 at 01:36:23PM +0100, Hans de Goede wrote: > >>Hi, > >> > >>On 03/15/2012 01:11 PM, Yonit Halperin wrote: > >>>On 03/13/2012 09:40 AM, Gerd Hoffmann wrote: > >>>

Re: [Spice-devel] [Engine-devel] Hints for building up a spicec connection in Ovirt

2012-03-15 Thread Andrew Wells
On Thu, Mar 15, 2012 at 11:07 AM, Itamar Heim wrote: > On 03/15/2012 05:03 PM, Andrew Wells wrote: > >> On Thu, Mar 15, 2012 at 2:58 AM, Michael Pasternak > > wrote: >> > ... > > >> Is the api-power-shell >> https://rhevm.example.com:**8443/rhevm-api-powershell

Re: [Spice-devel] [Engine-devel] Hints for building up a spicec connection in Ovirt

2012-03-15 Thread Andrew Wells
And is their any documentation on using the python rhev libraries as that would be helpful as well. you guys are getting me excited thinking this might work. On Thu, Mar 15, 2012 at 11:32 AM, Andrew Wells wrote: > > > On Thu, Mar 15, 2012 at 11:07 AM, Itamar Heim wrote: > >> On 03/15/2012 05:03

Re: [Spice-devel] [PATCH spice-gtk 00/15] Expand usage of compiler warnings

2012-03-15 Thread Marc-André Lureau
Daniel, > - Mensaje original - > > The first 14 patches in this series fix misc issues in the code > > which would otherwise trigger warnings. The last patch actually > > enables the warnings. It also enables some GCC runtime protection > > features, commonly used by distros in their packa

Re: [Spice-devel] [Engine-devel] Hints for building up a spicec connection in Ovirt

2012-03-15 Thread Itamar Heim
On 03/15/2012 05:33 PM, Andrew Wells wrote: And is their any documentation on using the python rhev libraries as that would be helpful as well. you guys are getting me excited thinking this might work. to both your questions: http://www.ovirt.org/wiki/CLI http://www.ovirt.org/wiki/SDK http://li

Re: [Spice-devel] [Engine-devel] Hints for building up a spicec connection in Ovirt

2012-03-15 Thread Andrew Wells
On Thu, Mar 15, 2012 at 11:47 AM, Itamar Heim wrote: > On 03/15/2012 05:33 PM, Andrew Wells wrote: > >> And is their any documentation on using the python rhev libraries as >> that would be helpful as well. you guys are getting me excited thinking >> this might work. >> > > to both your questions

Re: [Spice-devel] [Engine-devel] Hints for building up a spicec connection in Ovirt

2012-03-15 Thread Christophe Fergeau
Hey, On Thu, Mar 15, 2012 at 11:33:15AM -0400, Andrew Wells wrote: > And is their any documentation on using the python rhev libraries as that > would be helpful as well. you guys are getting me excited thinking this > might work. If that can be helpful to you, I've worked on some C code to talk

Re: [Spice-devel] [Engine-devel] Hints for building up a spicec connection in Ovirt

2012-03-15 Thread Andrew Wells
On Thu, Mar 15, 2012 at 12:32 PM, Christophe Fergeau wrote: > Hey, > > On Thu, Mar 15, 2012 at 11:33:15AM -0400, Andrew Wells wrote: > > And is their any documentation on using the python rhev libraries as that > > would be helpful as well. you guys are getting me excited thinking this > > might w

[Spice-devel] [ANNOUNCE] xf86-video-qxl 0.0.17

2012-03-15 Thread Søren Sandmann
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Version 0.0.17 of the QXL driver is available now. Soren Alon Levy (17): xspice: add missing --tls-port default README.xspice: use consistent and vnc default port spiceqxl.xorg.conf.example: typo and order fixes xspice: make

Re: [Spice-devel] [Engine-devel] Hints for building up a spicec connection in Ovirt

2012-03-15 Thread Christophe Fergeau
On Thu, Mar 15, 2012 at 12:38:05PM -0400, Andrew Wells wrote: > On Thu, Mar 15, 2012 at 12:32 PM, Christophe Fergeau > wrote: > > > Hey, > > > > On Thu, Mar 15, 2012 at 11:33:15AM -0400, Andrew Wells wrote: > > > And is their any documentation on using the python rhev libraries as that > > > woul

Re: [Spice-devel] Problem about qxl and vmc

2012-03-15 Thread wangfeng wangfeng
Hi, Can I use spicevmc and tablet simultaneously, let tablet control the mouse ,and spicevmc control any other thing without the mouse? 2012/3/12 wangfeng wangfeng > > > 2012/3/9 Alon Levy > >> On Fri, Mar 09, 2012 at 09:01:06AM +0800, wangfeng wangfeng wrote: >> > Hi, thank you for your patien