Re: [Spice-devel] [PATCH v2] qxl: don't render stuff when the vm is stopped.

2012-02-16 Thread Alon Levy
On Wed, Feb 15, 2012 at 06:28:53PM +0200, Alon Levy wrote: > On Wed, Feb 15, 2012 at 03:45:30PM +0100, Gerd Hoffmann wrote: > > This patch fixes the local qxl renderer to not kick spice-server > > in case the vm is stopped. First it is largely pointless because > > we ask spice-server to process a

Re: [Spice-devel] gl_canvas.c...

2012-02-16 Thread Alon Levy
On Thu, Feb 16, 2012 at 12:33:03AM -0600, Brian Vetter wrote: > I'm new to Spice and have been looking over the spice_gtk sources, trying to > piece together all that is there. I saw that in the common directory, there > are a collection of gl*.[ch] files look to be opengl client rendering > ser

Re: [Spice-devel] gl_canvas.c...

2012-02-16 Thread Marc-André Lureau
Hi Brian, On Thu, Feb 16, 2012 at 11:25 AM, Alon Levy wrote: > On Thu, Feb 16, 2012 at 12:33:03AM -0600, Brian Vetter wrote: >> I'm new to Spice and have been looking over the spice_gtk sources, trying to >> piece together all that is there. I saw that in the common directory, there >> are a co

Re: [Spice-devel] Windows binary download?

2012-02-16 Thread Charles Wilson
On 2/14/2012 6:44 PM, Marc-André Lureau wrote: >> Le 14/02/2012 17:31, Charles Wilson a écrit : >>> an error popup complaining about a missing 'libp11-kit-0.dll' > > Meanwhile you can copy this file under \virt-viewer\bin: > > http://elmarco.fedorapeople.org/libp11-kit-0.dll > > sorry for that!

[Spice-devel] [PATCH 0/7] Series of patches to add non-Linux server support

2012-02-16 Thread Dan McGee
This is a set of patches to enable building the server library on a non-Linux, non-pure-GNU toolchain platform. The patches range from build system tweaks to code changes. Add configure-time check for -Wl,--version-script option This is a GNU-specific linker option, or at least one not univers

[Spice-devel] [PATCH 1/7] Add configure-time check for -Wl, --version-script option

2012-02-16 Thread Dan McGee
This is supported by the GNU linker, but not the Solaris linker, which is used as the default on that platform even when compiling with GCC. Omit passing the option to the linker on platforms that do not support it. Signed-off-by: Dan McGee --- configure.ac | 10 ++ server/Makefi

[Spice-devel] [PATCH 2/7] red_worker: rename epoll_timeout to event_timeout

2012-02-16 Thread Dan McGee
With future patches in mind that will allow for some other non-Linux-specific event polling sytem to be used, rename this to a more generic name. All of the select/poll/epoll/kqueue family of calls are related to evented I/O, so 'event_' makes sense in this case. Signed-off-by: Dan McGee --- ser

[Spice-devel] [PATCH 3/7] Cleanup definitions of disconnect methods

2012-02-16 Thread Dan McGee
We had multiple stub methods that simply called other disconnect methods, making my head hurt with the indirection. Call the right methods at the right time and rip out the stub methods; if they are truely needed later they can be added again. Signed-off-by: Dan McGee --- server/red_channel.c |

[Spice-devel] [PATCH 4/7] Use memcpy call in red_channel_create

2012-02-16 Thread Dan McGee
Rather than assign the callbacks one-by-one, we can just memcpy the struct into the one we have allocated in our RedChannel object, which is much more efficient, not to mention future-proof when more callbacks are added. Signed-off-by: Dan McGee --- server/red_channel.c |9 + 1 files

[Spice-devel] [PATCH 5/7] red_worker: reimplement event loop using poll()

2012-02-16 Thread Dan McGee
This removes the epoll dependency we had in red_worker, which was the last Linux-specific call we were using in the entire Spice server. Given we never have more than 10 file descriptors involved, there is little performance gain had here by using epoll() over poll(). The biggest change is introdu

[Spice-devel] [PATCH 6/7] Respect IOV_MAX if defined

2012-02-16 Thread Dan McGee
Solaris has a pitiful maximum writev vector size of only 16, so the ping request at initial startup destroyed this call and broke things immediately. Reimplement stream_writev_cb() to respect IOV_MAX and break the writev() calls into chunks as necessary. Care was taken to return the correct values

[Spice-devel] [PATCH 7/7] Use standard IOV_MAX definition where applicable

2012-02-16 Thread Dan McGee
This is provided by on all platforms as long as _XOPEN_SOURCE is defined. On Linux, this is 1024, on Solaris, this is 16, and on any other platform, we now respect the value supported by the OS. Signed-off-by: Dan McGee --- server/main_channel.c |2 -- server/red_channel.c |2 +- serve