On 7/2/24 17:20, Thomas Zimmermann wrote:
> @@ -190,7 +190,13 @@ int qxl_bo_vmap(struct qxl_bo *bo, struct iosys_map *map)
> if (r)
> return r;
>
> + r = qxl_bo_pin_locked(bo);
> + if (r)
> + return r;
Is qxl_bo_unreserve() missing here?
> +
> r = q
Hi
Am 08.07.24 um 13:55 schrieb Dmitry Osipenko:
On 7/2/24 17:20, Thomas Zimmermann wrote:
@@ -190,7 +190,13 @@ int qxl_bo_vmap(struct qxl_bo *bo, struct iosys_map *map)
if (r)
return r;
+ r = qxl_bo_pin_locked(bo);
+ if (r)
+ return r;
Is qxl_bo
Hi
Am 08.07.24 um 10:58 schrieb Daniel Vetter:
On Mon, Jul 08, 2024 at 10:09:44AM +0200, Thomas Zimmermann wrote:
Hi,
ping for a review. This is a bugfix for a serious problem.
I tried to look around whether there's any place where we could WARN_ON if
we create a vmap but it's not pinned. But
On Mon, Jul 08, 2024 at 10:09:44AM +0200, Thomas Zimmermann wrote:
> Hi,
>
> ping for a review. This is a bugfix for a serious problem.
I tried to look around whether there's any place where we could WARN_ON if
we create a vmap but it's not pinned. But there's lots of places where we
want the vma
Hi,
ping for a review. This is a bugfix for a serious problem.
Best regards
Thomas
Am 02.07.24 um 16:20 schrieb Thomas Zimmermann:
Add qxl_bo_pin_and_vmap() that pins and vmaps a buffer object in one
step. Update callers of the regular qxl_bo_vmap(). Fixes a bug where
qxl accesses an unpinned
