On Tue, Apr 19, 2016 at 07:46:14PM +0530, RK RK wrote:
> Thanks for your reply Christophe, I am using oVirt 3.6.3 in my production
> environment with 250 Virtual Desktops accessed from within the office
> premises.
>
> Our users will have thin client devices running trimmed down version of
> CentO
On Tue, Apr 19, 2016 at 5:16 PM, RK RK wrote:
> Thanks for your reply Christophe, I am using oVirt 3.6.3 in my production
> environment with 250 Virtual Desktops accessed from within the office
> premises.
>
> Our users will have thin client devices running trimmed down version of
> CentOS 7 with
I have attached the deprecation message screenshot for your reference.
On Tue, Apr 19, 2016 at 7:46 PM, RK RK wrote:
> Thanks for your reply Christophe, I am using oVirt 3.6.3 in my production
> environment with 250 Virtual Desktops accessed from within the office
> premises.
>
> Our users will
Thanks for your reply Christophe, I am using oVirt 3.6.3 in my production
environment with 250 Virtual Desktops accessed from within the office
premises.
Our users will have thin client devices running trimmed down version of
CentOS 7 with spice-xpi installed via yum.
Please let me know if you ne
On Tue, Apr 19, 2016 at 11:36:21AM +0530, RK RK wrote:
> Hi Team,
>
> I have seen in https://bugs.freedesktop.org/enter_bug.cgi?product=Spice
> that xpi-activex (Browser plugins (to be deprecated)).
I cannot find the "to be deprecated" that you mention by looking
at this page, or at the bug list
Hi Team,
I have seen in https://bugs.freedesktop.org/enter_bug.cgi?product=Spice
that xpi-activex (Browser plugins (to be deprecated)).
Does it mean that spice-xpi (Provided via yum in fedora and centos) will be
deprecated and not supported in future releases? If so, then what will be
drop in rep
spice-xpi was not logging changes to the smartcard, color-depth,
disable-effects and proxy properties
Resolves: rhbz#1049486
---
SpiceXPI/src/plugin/plugin.cpp | 8
1 file changed, 8 insertions(+)
diff --git a/SpiceXPI/src/plugin/plugin.cpp b/SpiceXPI/src/plugin/plugin.cpp
index fdb4954
> Something like that diff squashed into this patch?
Yep, looks okay.
This is an interesting hack by firefox btw, looks hard to catch.
> --- a/SpiceXPI/src/plugin/controller.cpp
> +++ b/SpiceXPI/src/plugin/controller.cpp
> @@ -174,6 +174,7 @@ gpointer SpiceController::ClientThread(gpointer data)
On Thu, Jun 04, 2015 at 11:14:03AM +0200, Victor Toso wrote:
> Hey,
>
> On Wed, Jun 03, 2015 at 03:36:09PM +0200, Christophe Fergeau wrote:
> > Ping ?
>
> I would only add a FIXME in the comment to easily find it and check
> if it is already fixed;
Something like that diff squashed into this pat
On Thu, Jun 04, 2015 at 11:14:03AM +0200, Victor Toso wrote:
> Hey,
>
> On Wed, Jun 03, 2015 at 03:36:09PM +0200, Christophe Fergeau wrote:
> > Ping ?
>
> I would only add a FIXME in the comment to easily find it and check
> if it is already fixed;
Sure, I'll add this.
Christophe
>
> -toso
>
Hey,
On Wed, Jun 03, 2015 at 03:36:09PM +0200, Christophe Fergeau wrote:
> Ping ?
I would only add a FIXME in the comment to easily find it and check
if it is already fixed;
-toso
>
> On Thu, May 28, 2015 at 01:37:24PM +0200, Christophe Fergeau wrote:
> > When it's built with gtk3, firefox plug
Ping ?
Christophe
On Thu, May 28, 2015 at 01:37:24PM +0200, Christophe Fergeau wrote:
> When it's built with gtk3, firefox plugin-container will use some
> LD_PRELOAD hack in order to be able to load the gtk2 flash plugin.
> However, this LD_PRELOAD'ed .so will cause gtk3 remote-viewer to crash
>
When it's built with gtk3, firefox plugin-container will use some
LD_PRELOAD hack in order to be able to load the gtk2 flash plugin.
However, this LD_PRELOAD'ed .so will cause gtk3 remote-viewer to crash
when it's started by spice-xpi
This commit just cleans up the unwanted LD_PRELOAD variable fro
On 12/08/2014 09:55 PM, Alex wrote:
Hi, I have a RHEV 3.3 environment but I run 3.17.4-1-ARCH on my work
station and would like to access the RHEV spice server on the VM's, I
have also tried with openSuSE but I never get the expected "Spice
window frame" that I would get if I used a RHEL syst
Hi, I have a RHEV 3.3 environment but I run 3.17.4-1-ARCH on my work station
and would like to access the RHEV spice server on the VM's, I have also tried
with
openSuSE but I never get the expected "Spice window frame" that I would get if
I
used a RHEL system with the spice-xpi. The spice f
Hey,
On Mon, Dec 08, 2014 at 02:31:51PM -0800, Alex wrote:
> Hi, I have a RHEV 3.3 environment but I run 3.17.4-1-ARCH on my work station
> and would like to access the RHEV spice server on the VM's, I have also
> tried with openSuSE but I never get the expected "Spice window frame" that I
> w
Hi, I have a RHEV 3.3 environment but I run 3.17.4-1-ARCH on my work station
and would like to access the RHEV spice server on the VM's, I have also tried
with openSuSE but I never get the expected "Spice window frame" that I would
get if I used a RHEL system with the spice-xpi. The spice fra
coverity is reporting dead code in that test: if len is >= 36, then the
next part of the condition will always be false: (len == 8 || len == 13
|| len == 18 || len == 23)
This code is checking that the UUID does not have alphanumeric characters where
a '-' is expected, so the adjusted condition sh
Hey,
I've just made a new development release of spice-xpi. spice-xpi is a Firefox
plugin which allows to open SPICE consoles (using virt-viewer) from the
oVirt/RHEV[1]
web portals.
This release is tagged as a development release as the code has seen
significant reorganization in order to add Wi
> The plugin binary name was changed from libnsISpice to npSpiceConsole,
> but the Makefile.am rule optionnally building SpiceXpi.xpi was not
> changed to take this rename into account.
ACK series.
> ---
> SpiceXPI/Makefile.am | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff
The nsISpicec -> npSpiceConsole rename was not propagated there.
---
SpiceXPI/src/plugin/resource.rc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/SpiceXPI/src/plugin/resource.rc b/SpiceXPI/src/plugin/resource.rc
index 8892b0a..38a50d2 100644
--- a/SpiceXPI/src/plugin/resourc
The plugin binary name was changed from libnsISpice to npSpiceConsole,
but the Makefile.am rule optionnally building SpiceXpi.xpi was not
changed to take this rename into account.
---
SpiceXPI/Makefile.am | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/SpiceXPI/Makefile.am
Python is needed to generate nsISpicec.h and nsISpicec.xpt from
nsISpicec.idl.
---
configure.ac | 1 +
1 file changed, 1 insertion(+)
diff --git a/configure.ac b/configure.ac
index 39a1f7e..4a79626 100644
--- a/configure.ac
+++ b/configure.ac
@@ -50,6 +50,7 @@ AC_ARG_ENABLE([xpi],
On Mon, Apr 08, 2013 at 01:52:34PM +0200, Marc-André Lureau wrote:
> ack
All pushed now, thanks!
Christophe
pgpRKVLl8OpAl.pgp
Description: PGP signature
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailma
Many thanks.
I have already solved this problem as you suggested.
Regards
> _
>
> Il 8 aprile 2013 alle 14.46 Uri Lublin ha scritto:
> > On 04/03/2013 07:51 PM, Ignazio Cassano wrote:
> > > Hi all, I do not know if
On 04/03/2013 07:51 PM, Ignazio Cassano wrote:
Hi all, I do not know if this is the correct emailing list to ask about my
problem, any case I am very interested to know about spice-xpi .
I created a java script for launching the spice-xpi plugin but I'd like to know
what TrustStore parameter must
ack
On Mon, Apr 8, 2013 at 10:37 AM, Christophe Fergeau wrote:
> Ping?
>
> Christophe
>
> On Wed, Mar 27, 2013 at 02:09:08PM +0100, Christophe Fergeau wrote:
> > This class implements the controller interface for Windows/mingw.
> > ---
> >
> > Changes since v1:
> > - Adjusted copyright notice
>
Ping?
Christophe
On Wed, Mar 27, 2013 at 02:09:08PM +0100, Christophe Fergeau wrote:
> This class implements the controller interface for Windows/mingw.
> ---
>
> Changes since v1:
> - Adjusted copyright notice
> - Initialize random seed with current time
> - Simplify error handling in several p
Hi all, I do not know if this is the correct emailing list to ask about my
problem, any case I am very interested to know about spice-xpi .
I created a java script for launching the spice-xpi plugin but I'd like to know
what TrustStore parameter must contain .
I read it must be the "der encoded ce
Hi,
On Mon, Mar 25, 2013 at 08:06:27AM -0400, Marc-André Lureau wrote:
> - Mensaje original -
> > > In general, returning true on success is easier to read.
> >
> > This mimics the return value of connect(2), I'd prefer to keep that
> > (at
> > least in that patch, can be improved as a s
As it's not very convenient to get logging output from the plugin
while firefox is running, this commit adds a dumb glib logging
implementation that writes the logging information to a file.
As this is not efficient at all, it's disabled by default unless
the SPICE_XPI_LOG_TO_FILE environment varia
This class implements the controller interface for Windows/mingw.
---
Changes since v1:
- Adjusted copyright notice
- Initialize random seed with current time
- Simplify error handling in several places by bailing out early
- Use TEXT() instead of recoding it
- Use g_shell_parse_argv() rather than
- Mensaje original -
> On Mon, Mar 25, 2013 at 12:18:32PM +0100, Marc-André Lureau wrote:
> > On Mon, Mar 25, 2013 at 11:50 AM, Christophe Fergeau
> > wrote:
> > > I've considered that, but this means I'd have to sanitize the
> > > filename for
> > > \, '..', and probably some other thin
- Mensaje original -
> > In general, returning true on success is easier to read.
>
> This mimics the return value of connect(2), I'd prefer to keep that
> (at
> least in that patch, can be improved as a separate cleanup as this
> needs
> changes in SpiceController and SpiceControllerUn
Hey, thanks for the detailed review!
A few questions below,
On Sun, Mar 24, 2013 at 11:27:45PM +0100, Marc-André Lureau wrote:
> On Sun, Mar 24, 2013 at 12:16 PM, Christophe Fergeau
> wrote:
> > +SpiceControllerWin::~SpiceControllerWin()
> > +{
> > +}
> > +
> > +int SpiceControllerWin::Connect()
On Mon, Mar 25, 2013 at 12:18:32PM +0100, Marc-André Lureau wrote:
> On Mon, Mar 25, 2013 at 11:50 AM, Christophe Fergeau
> wrote:
> > I've considered that, but this means I'd have to sanitize the filename for
> > \, '..', and probably some other things I didn't think of. As this is just
> > a deb
On Mon, Mar 25, 2013 at 11:50 AM, Christophe Fergeau
wrote:
> I've considered that, but this means I'd have to sanitize the filename for
> \, '..', and probably some other things I didn't think of. As this is just
> a debugging help, I've chosen to go with a hardcoded filename which does
> not nee
On Sun, Mar 24, 2013 at 11:27:41PM +0100, Marc-André Lureau wrote:
> > +}
> > +
> > +static void glib_setup_logging(void)
> > +{
> > +#if defined(XP_WIN)
> > +FILE *log_file;
> > +gchar *log_filename;
> > +
> > +if (!g_getenv("SPICE_XPI_LOG_TO_FILE"))
> > +return;
>
> Imho, it
ack
On Sun, Mar 24, 2013 at 12:16 PM, Christophe Fergeau
wrote:
> Based on a patch from Nerijus Baliunas
> ---
> SpiceXPI/src/plugin/Makefile.am | 23 ---
> SpiceXPI/src/plugin/resource.rc | 34 ++
> configure.ac| 19 ++
ack
On Sun, Mar 24, 2013 at 12:16 PM, Christophe Fergeau
wrote:
> Windows Firefox expects the plugin filename to start with 'np'
> otherwise it won't pick it up as a plugin.
> ---
> SpiceXPI/src/plugin/Makefile.am | 16
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff
ack
On Sun, Mar 24, 2013 at 12:16 PM, Christophe Fergeau
wrote:
> NPAPI plugins only need to have 3 symbols exported, make that
> explicit. This is also required when building Windows plugins
> as these symbols *must* be explicitly exported.
> ---
> SpiceXPI/src/plugin/Makefile.am | 9
On Sun, Mar 24, 2013 at 12:16 PM, Christophe Fergeau
wrote:
> This class implements the controller interface for Windows/mingw.
> ---
> SpiceXPI/src/plugin/Makefile.am| 2 +
> SpiceXPI/src/plugin/controller-win.cpp | 266
> +
> SpiceXPI/src/plugin/contro
On Sun, Mar 24, 2013 at 12:16 PM, Christophe Fergeau
wrote:
> As it's not very convenient to get logging output from the plugin
> while firefox is running, this commit adds a dumb glib logging
> implementation that writes the logging information to a file.
> As this is not efficient at all, it's d
As it's not very convenient to get logging output from the plugin
while firefox is running, this commit adds a dumb glib logging
implementation that writes the logging information to a file.
As this is not efficient at all, it's disabled by default unless
the SPICE_XPI_LOG_TO_FILE environment varia
This class implements the controller interface for Windows/mingw.
---
SpiceXPI/src/plugin/Makefile.am| 2 +
SpiceXPI/src/plugin/controller-win.cpp | 266 +
SpiceXPI/src/plugin/controller-win.h | 93
SpiceXPI/src/plugin/controller.cpp |
NPAPI plugins only need to have 3 symbols exported, make that
explicit. This is also required when building Windows plugins
as these symbols *must* be explicitly exported.
---
SpiceXPI/src/plugin/Makefile.am | 9 -
SpiceXPI/src/plugin/npapi-plugin.syms | 3 +++
2 files changed, 11 in
Windows Firefox expects the plugin filename to start with 'np'
otherwise it won't pick it up as a plugin.
---
SpiceXPI/src/plugin/Makefile.am | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/SpiceXPI/src/plugin/Makefile.am b/SpiceXPI/src/plugin/Makefile.am
index
Based on a patch from Nerijus Baliunas
---
SpiceXPI/src/plugin/Makefile.am | 23 ---
SpiceXPI/src/plugin/resource.rc | 34 ++
configure.ac| 19 ++-
3 files changed, 72 insertions(+), 4 deletions(-)
create mod
On Wed, Mar 13, 2013 at 01:52:59PM +0100, Marc-André Lureau wrote:
> Except the g_message vs g_critical, ack the series.
Thanks, pushed with that change! Only a few more patches to go, which I'll
send once I write proper commit logs and do a bit of cleanup :)
Christophe
pgpJFf9ArtmQF.pgp
Descr
Except the g_message vs g_critical, ack the series.
--
Marc-André Lureau
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/spice-devel
On Wed, Mar 13, 2013 at 11:15 AM, Christophe Fergeau
wrote:
> +tmp_file = g_file_new_tmp("trustore.pem-XX", &iostream, NULL);
> +if (tmp_file == NULL) {
> +g_message("Couldn't create truststore");
> +return false;
> }
> -else
> -{
> -g_critical("cou
This has the big advantage of being portable, in addition to removing
some code. Big disadvantage is that this adds a dependency on gio.
---
SpiceXPI/src/plugin/plugin.cpp | 69 ++
SpiceXPI/src/plugin/plugin.h | 2 ++
configure.ac | 2 +
On Tue, Mar 12, 2013 at 01:16:20PM +0100, Marc-André Lureau wrote:
> On Tue, Mar 12, 2013 at 12:23 PM, Christophe Fergeau
> wrote:
> > +/* FIXME: we are not in the main thread!! */
> > +fake_this->m_plugin->OnSpiceClientExit(status);
>
> That scares me, but it looks like you didn't introd
It contains all the generic code, then platform-specific controller
implementations will inherit from it and overload the non-generic parts
abstract methods.
---
v2:
- adjust to the changes in other patches, in particular the split of
GetClientPaths, which should fix a compilation issue that
g_usleep is more portable than sleep()
---
SpiceXPI/src/plugin/controller-unix.cpp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/SpiceXPI/src/plugin/controller-unix.cpp
b/SpiceXPI/src/plugin/controller-unix.cpp
index 16f7033..04257e9 100644
--- a/SpiceXPI/src/plugin/controll
The SPICE client paths will be different on Windows and Unix so add
a helper function returning the paths to use to spawn the clients.
---
v2:
- use g_strdupv rather than manually duping everything
- split GetClientPaths to GetClientPath and GetFallbackClientPath
SpiceXPI/src/plugin/controlle
Communication with the client is done differently on Windows and
Linux (named pipe VS unix socket), so move this platform-specific
setup to a distinct method.
---
SpiceXPI/src/plugin/controller-unix.cpp | 15 +++
SpiceXPI/src/plugin/controller.h| 2 ++
2 files changed, 13 inse
This removes quite a lot of OS-specific code.
---
v2
- use g_thread_new instead of g_thread_create
SpiceXPI/src/plugin/controller-unix.cpp | 143 +---
SpiceXPI/src/plugin/controller.h| 7 +-
configure.ac| 2 +-
3 files changed
This is platform specific, and is related to starting the
receiver of controller messages, so let's move it with the rest
of the platform-specific code.
---
SpiceXPI/src/plugin/controller-unix.cpp | 106 +-
SpiceXPI/src/plugin/controller.h| 13 +++-
SpiceXPI/sr
It's only used internally, external code calls Connect(int retries)
---
SpiceXPI/src/plugin/controller.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/SpiceXPI/src/plugin/controller.h b/SpiceXPI/src/plugin/controller.h
index dbcc424..001d2b3 100644
--- a/SpiceXPI/src/plugin/c
---
SpiceXPI/src/plugin/controller-unix.cpp | 6 --
SpiceXPI/src/plugin/controller.h| 1 -
2 files changed, 7 deletions(-)
diff --git a/SpiceXPI/src/plugin/controller-unix.cpp
b/SpiceXPI/src/plugin/controller-unix.cpp
index 2499cae..0d8f0f8 100644
--- a/SpiceXPI/src/plugin/controller
---
v2:
- extend copyright range from 2009-2011 to 2009-2013 rather
than adding a new line
SpiceXPI/src/plugin/controller-unix.cpp | 3 ++-
SpiceXPI/src/plugin/controller.h| 3 ++-
SpiceXPI/src/plugin/plugin.cpp | 3 ++-
3 files changed, 6 insertions(+), 3 deletions(-)
dif
It mostly contain low-level controller/plugin communication code,
and this is mainly non-portable code, let's rename this file to
make this explicit. We will then add a controller.cpp file
containing the generic code, and a controller-win.cpp file
with the Windows specific code.
---
SpiceXPI/src/p
This makes it more readable, and moves OS-specific code to separate
functions.
---
v2:
- only call g_type_init() on older glib
- removed extra space
SpiceXPI/src/plugin/plugin.cpp | 170 +++--
SpiceXPI/src/plugin/plugin.h | 3 +
2 files changed, 99 inse
On Tue, Mar 12, 2013 at 01:00:42PM +0100, Marc-André Lureau wrote:
> On Tue, Mar 12, 2013 at 12:22 PM, Christophe Fergeau
> wrote:
> > Copyright 2009-2011, Red Hat Inc.
> > + * Copyright 2013, Red Hat Inc.
>
> I would just update the range, instead of adding extra line (one for
> each year?).
On Tue, Mar 12, 2013 at 2:55 PM, Christophe Fergeau wrote:
> Yup, the Windows version of this function will be using dynamic allocation
> as we need to get the client name from the registry, split it, ...
You could make use of g_strdupv() instead perhaps?
--
Marc-André Lureau
__
On Tue, Mar 12, 2013 at 01:37:06PM +0100, Marc-André Lureau wrote:
> after this patch:
>
> "LoadPlugin: failed to initialize"..., 212LoadPlugin: failed to
> initialize shared library
> /home/elmarco/.mozilla/plugins/libnsISpicec.so
> [/home/elmarco/.mozilla/plugins/libnsISpicec.so: undefined symbo
On Tue, Mar 12, 2013 at 01:32:13PM +0100, Marc-André Lureau wrote:
> On Tue, Mar 12, 2013 at 12:23 PM, Christophe Fergeau
> wrote:
> > void SpiceController::GetClientPaths(GStrv *client_argv, GStrv
> > *fallback_argv)
> > +{
> > +if (client_argv != NULL) {
> > +*client_argv = g_new0(c
On Tue, Mar 12, 2013 at 12:32:55PM +0100, Marc-André Lureau wrote:
> ack (please push for the next series to be reviewed)
Sorry, I just saw that email, I've now pushed the series with the added
configure log you asked for, but this comes after sending the next series.
Christophe
pgpqEzTRZz_Cz.p
after this patch:
"LoadPlugin: failed to initialize"..., 212LoadPlugin: failed to
initialize shared library
/home/elmarco/.mozilla/plugins/libnsISpicec.so
[/home/elmarco/.mozilla/plugins/libnsISpicec.so: undefined symbol:
_ZN19SpiceControllerUnix14GetClientPathsEPPPcS2_
On Tue, Mar 12, 2013 at 1
On Tue, Mar 12, 2013 at 12:23 PM, Christophe Fergeau
wrote:
> void SpiceController::GetClientPaths(GStrv *client_argv, GStrv *fallback_argv)
> +{
> +if (client_argv != NULL) {
> +*client_argv = g_new0(char *, 2);
> +(*client_argv)[0] = g_strdup("/usr/libexec/spice-xpi-client");
You could also fix this deprecation
warning: 'GThread* g_thread_create(GThreadFunc, gpointer, gboolean,
GError**)' is deprecated (declared at
/usr/include/glib-2.0/glib/deprecated/gthread.h:100): Use
'g_thread_new' instead [-Wdeprecated-declarations]
--
Marc-André Lureau
__
On Tue, Mar 12, 2013 at 12:23 PM, Christophe Fergeau
wrote:
> +/* FIXME: we are not in the main thread!! */
> +fake_this->m_plugin->OnSpiceClientExit(status);
That scares me, but it looks like you didn't introduce that, so it's
okay I guess.
Apparently, it was done in "Drop sigchld handl
On Tue, Mar 12, 2013 at 12:22 PM, Christophe Fergeau
wrote:
> Copyright 2009-2011, Red Hat Inc.
> + * Copyright 2013, Red Hat Inc.
I would just update the range, instead of adding extra line (one for
each year?).
--
Marc-André Lureau
___
Spice-de
On Tue, Mar 12, 2013 at 12:22 PM, Christophe Fergeau
wrote:
> This has the big advantage of being portable, in addition to removing
> some code. Big disadvantage is that this adds a dependency on gio.
> ---
> SpiceXPI/src/plugin/plugin.cpp | 67
> +-
> Spi
ack (please push for the next series to be reviewed)
On Mon, Mar 11, 2013 at 12:52 PM, Christophe Fergeau
wrote:
> On Mon, Mar 11, 2013 at 12:24:03PM +0100, Marc-André Lureau wrote:
>> How do you apply this? if fails on both current master, and after the
>> previous 10 patches.
>
> As indicated i
It contains all the generic code, then platform-specific controller
implementations will inherit from it and overload the non-generic parts
abstract methods.
---
SpiceXPI/src/plugin/Makefile.am | 2 +
SpiceXPI/src/plugin/controller-unix.cpp | 209 +++---
SpiceXPI/src/
g_usleep is more portable than sleep()
---
SpiceXPI/src/plugin/controller-unix.cpp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/SpiceXPI/src/plugin/controller-unix.cpp
b/SpiceXPI/src/plugin/controller-unix.cpp
index 743e00b..ddbd8c0 100644
--- a/SpiceXPI/src/plugin/controll
The SPICE client paths will be different on Windows and Unix so add
a helper function returning the paths to use to spawn the clients.
---
SpiceXPI/src/plugin/controller-unix.cpp | 66 -
SpiceXPI/src/plugin/controller.h| 1 +
2 files changed, 49 insertions(
Communication with the client is done differently on Windows and
Linux (named pipe VS unix socket), so move this platform-specific
setup to a distinct method.
---
SpiceXPI/src/plugin/controller-unix.cpp | 15 +++
SpiceXPI/src/plugin/controller.h| 2 ++
2 files changed, 13 inse
This removes quite a lot of OS-specific code.
---
SpiceXPI/src/plugin/controller-unix.cpp | 143 +---
SpiceXPI/src/plugin/controller.h| 7 +-
configure.ac| 2 +-
3 files changed, 85 insertions(+), 67 deletions(-)
diff --git a/Spi
This is platform specific, and is related to starting the
receiver of controller messages, so let's move it with the rest
of the platform-specific code.
---
SpiceXPI/src/plugin/controller-unix.cpp | 106 +-
SpiceXPI/src/plugin/controller.h| 13 +++-
SpiceXPI/sr
It's only used internally, external code calls Connect(int retries)
---
SpiceXPI/src/plugin/controller.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/SpiceXPI/src/plugin/controller.h b/SpiceXPI/src/plugin/controller.h
index 9f372a4..5bbf291 100644
--- a/SpiceXPI/src/plugin/c
---
SpiceXPI/src/plugin/controller-unix.cpp | 6 --
SpiceXPI/src/plugin/controller.h| 1 -
2 files changed, 7 deletions(-)
diff --git a/SpiceXPI/src/plugin/controller-unix.cpp
b/SpiceXPI/src/plugin/controller-unix.cpp
index d2a59f3..e2a513c 100644
--- a/SpiceXPI/src/plugin/controller
---
SpiceXPI/src/plugin/controller-unix.cpp | 2 ++
SpiceXPI/src/plugin/controller.h| 2 ++
SpiceXPI/src/plugin/plugin.cpp | 2 ++
3 files changed, 6 insertions(+)
diff --git a/SpiceXPI/src/plugin/controller-unix.cpp
b/SpiceXPI/src/plugin/controller-unix.cpp
index b912c27..d2a59
It mostly contain low-level controller/plugin communication code,
and this is mainly non-portable code, let's rename this file to
make this explicit. We will then add a controller.cpp file
containing the generic code, and a controller-win.cpp file
with the Windows specific code.
---
SpiceXPI/src/p
This has the big advantage of being portable, in addition to removing
some code. Big disadvantage is that this adds a dependency on gio.
---
SpiceXPI/src/plugin/plugin.cpp | 67 +-
SpiceXPI/src/plugin/plugin.h | 2 ++
configure.ac | 2 +
This makes it more readable, and moves OS-specific code to separate
functions.
---
SpiceXPI/src/plugin/plugin.cpp | 170 +++--
SpiceXPI/src/plugin/plugin.h | 3 +
2 files changed, 99 insertions(+), 74 deletions(-)
diff --git a/SpiceXPI/src/plugin/plugin.cpp
Hey,
Here is the next patch series for spice-xpi. This one reworks the existing code
to
* make some of the code generic by using glib functionality instead of
directly using libc
* move all the platform-specific code to a ControllerUnix class, and
leave the generic code in a parent Controller
On Mon, Mar 11, 2013 at 01:56:04PM +0100, Marc-André Lureau wrote:
> On Mon, Mar 11, 2013 at 10:16 AM, Christophe Fergeau
> wrote:
>
> > +AC_ARG_ENABLE([xpi],
> > + [AS_HELP_STRING([--enable-xpi],
> > + [Enable compilation of an xpi package])],
> > + [], [enable_xpi=no])
> > +i
On Mon, Mar 11, 2013 at 10:16 AM, Christophe Fergeau
wrote:
> +AC_ARG_ENABLE([xpi],
> + [AS_HELP_STRING([--enable-xpi],
> + [Enable compilation of an xpi package])],
> + [], [enable_xpi=no])
> +if test x"$enable_xpi" != xno; then
> PKG_CHECK_MODULES(XUL, libxul-embedding >= 10
- Mensaje original -
> On Mon, Mar 11, 2013 at 01:24:34PM +0100, Marc-André Lureau wrote:
> > On Mon, Mar 11, 2013 at 10:16 AM, Christophe Fergeau
> > wrote:
> > > AC_ARG_ENABLE 3rd argument is what to do when the argument is
> > > specified and the 4th arg is what to do when the argumen
On Mon, Mar 11, 2013 at 01:24:34PM +0100, Marc-André Lureau wrote:
> On Mon, Mar 11, 2013 at 10:16 AM, Christophe Fergeau
> wrote:
> > AC_ARG_ENABLE 3rd argument is what to do when the argument is
> > specified and the 4th arg is what to do when the argument is
> > not specified. Using [enable_gen
On Mon, Mar 11, 2013 at 10:16 AM, Christophe Fergeau
wrote:
> AC_ARG_ENABLE 3rd argument is what to do when the argument is
> specified and the 4th arg is what to do when the argument is
> not specified. Using [enable_generator=true] as the 3rd argument
> is wrong as this would enable the generato
On Mon, Mar 11, 2013 at 12:24:03PM +0100, Marc-André Lureau wrote:
> How do you apply this? if fails on both current master, and after the
> previous 10 patches.
As indicated in the cover letter:
"thiss series also replaces patches 8/9 and 9/9 of the previous series as
the configure.ac changes fro
How do you apply this? if fails on both current master, and after the
previous 10 patches.
--
Marc-André Lureau
___
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/spice-devel
Now that we switched to using the headers from npapi-sdk to build
the spice-xpi plugin, the only reason we are depending on xulrunner
is to build an xpi package for the plugin for easier installation
in firefox. However, this .xpi is not installed by default nor
packaged by distributions, so it's n
The xpidl binary is no longer available in xulrunner 10, so we no longer
need the Makefile magic using xpidl now that we require it. We'll always
directly use header.py/typelib.py instead.
---
SpiceXPI/src/plugin/Makefile.am | 8
configure.ac| 11 ---
2 files
Even RHEL5 has at least xulrunner 10 these days, so no need to keep that
compat code around.
---
SpiceXPI/src/plugin/np_entry.cpp | 7 ---
SpiceXPI/src/plugin/npplat.h | 6 +-
SpiceXPI/src/plugin/plugin.cpp | 7 ---
configure.ac | 43 +--
AC_ARG_ENABLE 3rd argument is what to do when the argument is
specified and the 4th arg is what to do when the argument is
not specified. Using [enable_generator=true] as the 3rd argument
is wrong as this would enable the generator when using
--disable-generator.
---
configure.ac | 4 ++--
1 file
1 - 100 of 196 matches
Mail list logo
