Re: [Spice-devel] qxl and page flip

2017-10-16 Thread Gerd Hoffmann
Hi, > Why extending QXL protocol is not worth doing but writing workaround > on workaround is? Problem is extending the qxl protocol requires changes on the host side. A fix which doesn't need that has the advantage that it'll work on hosts with old spice-server and qemu versions. We can look

Re: [Spice-devel] qxl and page flip

2017-10-13 Thread Frediano Ziglio
> > Hi, > > > Switching the qxl kms driver to use a scratchpad model too should be > > easy for userspace apps not using qxl ioctls (i.e. basically > > everything > > but xorg-x11-drv-qxl).  Just use the vga memory region (start of pci > > bar 0) as scratchpad, then we can safely use framebuffer

Re: [Spice-devel] qxl and page flip

2017-10-13 Thread Gerd Hoffmann
Hi, > Switching the qxl kms driver to use a scratchpad model too should be > easy for userspace apps not using qxl ioctls (i.e. basically > everything > but xorg-x11-drv-qxl).  Just use the vga memory region (start of pci > bar 0) as scratchpad, then we can safely use framebuffer blits for > dis

Re: [Spice-devel] qxl and page flip

2017-10-12 Thread Gerd Hoffmann
Hi, > > Daniel Vetter suggested we take a different path for atomic page > > flip, and > > put back the copy mechanism until we can support atomic modesetting > > properly, > > which might be simpler than reverting all the qxl atomic work. > > > > Dave. > About my suggestion on create+destroy

Re: [Spice-devel] qxl and page flip

2017-10-12 Thread Frediano Ziglio
> > On 12 October 2017 at 19:16, Gerd Hoffmann wrote: > > On Fri, 2017-10-06 at 12:40 +0200, Gerd Hoffmann wrote: > >> Hi, > >> > >> > Would not actually be possible to detect a destroy + create > >> > commands and avoid having to change any version/driver? > >> > >> Well, that would be option

Re: [Spice-devel] qxl and page flip

2017-10-12 Thread Dave Airlie
On 12 October 2017 at 19:16, Gerd Hoffmann wrote: > On Fri, 2017-10-06 at 12:40 +0200, Gerd Hoffmann wrote: >> Hi, >> >> > Would not actually be possible to detect a destroy + create >> > commands and avoid having to change any version/driver? >> >> Well, that would be option (3) of the original

Re: [Spice-devel] qxl and page flip

2017-10-12 Thread Gerd Hoffmann
On Fri, 2017-10-06 at 12:40 +0200, Gerd Hoffmann wrote: >   Hi, > > > Would not actually be possible to detect a destroy + create > > commands and avoid having to change any version/driver? > > Well, that would be option (3) of the original mail:  Make the spice > client hide this.  Basically not

Re: [Spice-devel] qxl and page flip

2017-10-06 Thread Justin Forbes
On Fri, Oct 6, 2017 at 5:40 AM, Gerd Hoffmann wrote: > Hi, > >> Would not actually be possible to detect a destroy + create >> commands and avoid having to change any version/driver? > > Well, that would be option (3) of the original mail: Make the spice > client hide this. Basically not go in

Re: [Spice-devel] qxl and page flip

2017-10-06 Thread Gerd Hoffmann
Hi, > Would not actually be possible to detect a destroy + create > commands and avoid having to change any version/driver? Well, that would be option (3) of the original mail: Make the spice client hide this. Basically not go into "no display" mode instantly after destroy-surface, but wait a

Re: [Spice-devel] qxl and page flip

2017-10-06 Thread Frediano Ziglio
>From 47f514ba3c2d261dc3fa76ebab37f0bb5d566252 Mon Sep 17 00:00:00 2001 From: Gerd Hoffmann Date: Fri, 6 Oct 2017 10:17:10 +0200 Subject: [RfC PATCH] qxl: add primary surface update support This operation allows to update the primary surface without going through a destroy + create cycle. It is

Re: [Spice-devel] qxl and page flip

2017-10-06 Thread Gerd Hoffmann
Hi, > The other option is we revert atomic modesetting from upstream qxl > until the hw > is upgraded to it, and we use the atomic path only on the newer > hardware. Well, the non-atomic "page-flip support" is blitting one framebuffer over the other. I wouldn't call this a solution either. It

Re: [Spice-devel] qxl and page flip

2017-10-05 Thread Dave Airlie
On 4 October 2017 at 21:38, Gerd Hoffmann wrote: > Hi, > >> > So, the options I see are: >> > >> > (1) Declare qxl deprecated, promote virtio-vga instead. >> > >> > (2) Pimp the qxl hardware, add page-flip support. Requires >> > changes >> > in spice-server (due to lazy rendering), qemu

Re: [Spice-devel] qxl and page flip

2017-10-04 Thread Gerd Hoffmann
Hi, > > So, the options I see are: > > > >  (1) Declare qxl deprecated, promote virtio-vga instead. > > > >  (2) Pimp the qxl hardware, add page-flip support.  Requires > > changes > >  in spice-server (due to lazy rendering), qemu qxl emulation > > and > >  guest kernel driver.  Shoul

Re: [Spice-devel] qxl and page flip

2017-10-04 Thread Frediano Ziglio
> > Hi, > > qxl kms driver has been converted over to atomic mode setting recently. > Caused some problems, most are fixed meanwhile. > > See https://bugzilla.kernel.org/show_bug.cgi?id=196777 > > One pretty fundamental issue sticks though: The qxl virtual hardware > doesn't support pageflip

[Spice-devel] qxl and page flip

2017-10-04 Thread Gerd Hoffmann
Hi, qxl kms driver has been converted over to atomic mode setting recently. Caused some problems, most are fixed meanwhile. See https://bugzilla.kernel.org/show_bug.cgi?id=196777 One pretty fundamental issue sticks though: The qxl virtual hardware doesn't support pageflip (see comment 11 in