finish the patch and address Jeremy's comment? It's imo
worthy to fix and It would be nice If you can finish that.
- Original Message -
From: "Jeremy White"
To: "bigclouds"
Cc: spice-devel@lists.freedesktop.org
Sent: Wednesday, November 6, 2013 4:28:45 PM
On 03/26/2014 11:30 AM, longguang.yue wrote:
please forgive my ignore.
jwhite you are right, i post a new patch as you suggest.
Yes, this patch does look correct. I have been meaning to get time to
put it through some further testing, and then push it. I hope to do
that this week.
Cheers
worthy to fix and It would be nice If you can finish that.
>
>- Original Message -
>> From: "Jeremy White"
>> To: "bigclouds"
>> Cc: spice-devel@lists.freedesktop.org
>> Sent: Wednesday, November 6, 2013 4:28:45 PM
>> Subject: Re: [S
worthy to fix and It would be nice If you can finish that.
>
>- Original Message -
>> From: "Jeremy White"
>> To: "bigclouds"
>> Cc: spice-devel@lists.freedesktop.org
>> Sent: Wednesday, November 6, 2013 4:28:45 PM
>> Subject: Re: [S
sts.freedesktop.org
> Sent: Wednesday, November 6, 2013 4:28:45 PM
> Subject: Re: [Spice-devel] patch[1/1] fix a memory leak in qxl_screen_init
>
> On 11/06/2013 08:48 AM, bigclouds wrote:
> > it is needed to detect the return of qxl_uxa_init in qxl_screen_init .
>
&g
On 11/06/2013 08:48 AM, bigclouds wrote:
> it is needed to detect the return of qxl_uxa_init in qxl_screen_init .
I don't think we have understood each other.
There is a duplicate allocation; you are trying to fix that. As I
understand it, your patch removes the allocation in qxl_uxa_init and
l
it is needed to detect the return of qxl_uxa_init in qxl_screen_init .
At 2013-11-06 21:59:58,"Jeremy White" wrote:
>Nice catch!
>
>On 11/06/2013 03:37 AM, bigclouds wrote:
>> hi, it allocate twice memory for qxl->uxa in function qxl_screen_init and
>> qxl_uxa_init
>> -
>
Nice catch!
On 11/06/2013 03:37 AM, bigclouds wrote:
hi, it allocate twice memory for qxl->uxa in function qxl_screen_init and
qxl_uxa_init
-
diff --git a/src/qxl_driver.c b/src/qxl_driver.c
index 91ba6c2..6be61e4 100644
--- a/src/qxl_driver.c
+++ b/src/qxl_driver.c
@@ -746,7 +7
hi, it allocate twice memory for qxl->uxa in function qxl_screen_init and
qxl_uxa_init
-
diff --git a/src/qxl_driver.c b/src/qxl_driver.c
index 91ba6c2..6be61e4 100644
--- a/src/qxl_driver.c
+++ b/src/qxl_driver.c
@@ -746,7 +746,9 @@ qxl_screen_init (SCREEN_INIT_ARGS_DECL)
}
