Re: [Spice-devel] leaking drawables

2010-09-09 Thread Gerd Hoffmann
Hi, Eventually we reach the case where prod is 6 (and lets say cons is still 0). We put stuff in item 6, then SPICE_RING_PUSH increasing prod to 7, initialize item 7. No overwrite here. Then when prod is 7 we keep appending to the item 7 list, but never push it because prod - cons + 1 = 7 - 0

Re: [Spice-devel] leaking drawables

2010-09-09 Thread Alexander Larsson
On Thu, 2010-09-09 at 09:31 +0200, Gerd Hoffmann wrote: > > There is one special thing in the release ring usage though. As you > know qxl builds up a linked lists there, where the heads are in the > ring. qxl does also store the head of the list which it currently > builds into the ring, but

Re: [Spice-devel] leaking drawables

2010-09-09 Thread Gerd Hoffmann
On 09/08/10 21:24, Alexander Larsson wrote: On Tue, 2010-09-07 at 17:08 +0200, Gerd Hoffmann wrote: Hi, This happens for several consecutive resource releases. Looking at what actually gets released by the driver we see that the resources are freed in the same order as they were release, its j

Re: [Spice-devel] leaking drawables

2010-09-08 Thread Soeren Sandmann
Gerd Hoffmann writes: >Hi, > > > This happens for several consecutive resource releases. Looking at what > > actually gets released by the driver we see that the resources are freed > > in the same order as they were release, its just that a chunk of > > resources are missing here and there.

Re: [Spice-devel] leaking drawables

2010-09-08 Thread Alexander Larsson
On Tue, 2010-09-07 at 17:08 +0200, Gerd Hoffmann wrote: > Hi, > > > This happens for several consecutive resource releases. Looking at what > > actually gets released by the driver we see that the resources are freed > > in the same order as they were release, its just that a chunk of > > resource

Re: [Spice-devel] leaking drawables

2010-09-07 Thread Gerd Hoffmann
Hi, This happens for several consecutive resource releases. Looking at what actually gets released by the driver we see that the resources are freed in the same order as they were release, its just that a chunk of resources are missing here and there. Try the attached patch. I'm pretty sure

[Spice-devel] leaking drawables

2010-09-06 Thread Alexander Larsson
I've been tracking the "out of memory" issue. i.e. we seem to be getting these to often. And it seems we might be leaking resources. I modified the driver and the server to print Drawables as they are freed. In one run there were several instances of the server releasing a drawable. I.E. in free_r