Re: [Spice-devel] hardcoded NUM_DRAWABLES too small

2013-10-09 Thread Dietmar Maurer
> An alternative approach is to monitor the actual size that is currently > occupied > by drawables that are referenced by the display channel, and to limit *this* > size, > instead of the number of drawables Another alternative is to draw always (see DRAW_ALL in the code). My tests with spicet

Re: [Spice-devel] hardcoded NUM_DRAWABLES too small

2013-10-09 Thread Dietmar Maurer
> I think the hardcoded limit was intended for limiting the occupancy of the dev > ram with drawables that are referenced by the display channel. > If the limit is reasonable it should help with keeping allocations in the > driver > fluent, and avoiding IO_OOM. > An alternative approach is to moni

Re: [Spice-devel] hardcoded NUM_DRAWABLES too small

2013-10-09 Thread Dietmar Maurer
> > No. There is no need to draw anything at the server side (for spiceterm). > > Ok, that would be interesting. I wonder if you are not better off > implementing a > new display channel for your use case, if you just need to send off your own > rendering commands without any change. why is that

Re: [Spice-devel] hardcoded NUM_DRAWABLES too small

2013-10-09 Thread Yonit Halperin
Hi, I think the hardcoded limit was intended for limiting the occupancy of the dev ram with drawables that are referenced by the display channel. If the limit is reasonable it should help with keeping allocations in the driver fluent, and avoiding IO_OOM. An alternative approach is to monitor t

Re: [Spice-devel] hardcoded NUM_DRAWABLES too small

2013-10-09 Thread Marc-André Lureau
- Original Message - > > > I just detected that my simple spiceterm generates more than > > > > > > 1000 drawables, so alloc_drawable() always fail. > > > > > > > > > > > > The effect is that I always draw twice (on server and at client)! > > > > This is an area I am newbie ;) > > > > I

Re: [Spice-devel] hardcoded NUM_DRAWABLES too small

2013-10-09 Thread Dietmar Maurer
> > I just detected that my simple spiceterm generates more than > > > > 1000 drawables, so alloc_drawable() always fail. > > > > > > > > The effect is that I always draw twice (on server and at client)! > > This is an area I am newbie ;) > > Isn't the server always drawing anyway at some point?

Re: [Spice-devel] hardcoded NUM_DRAWABLES too small

2013-10-09 Thread Marc-André Lureau
- Original Message - > > > I just detected that my simple spiceterm generates more than > > 1000 drawables, so alloc_drawable() always fail. > > > > The effect is that I always draw twice (on server and at client)! This is an area I am newbie ;) Isn't the server always drawing any

[Spice-devel] hardcoded NUM_DRAWABLES too small

2013-10-09 Thread Dietmar Maurer
I just detected that my simple spiceterm generates more than 1000 drawables, so alloc_drawable() always fail. The effect is that I always draw twice (on server and at client)! I guess one would see the same effect when running a xterm inside a VM, because a terminal has a size of 80x25 character