Re: [Spice-devel] bool or gboolean

2017-02-20 Thread Victor Toso
Hi, On Thu, Feb 16, 2017 at 01:24:04PM +0100, Christophe de Dinechin wrote: > > > On 16 Feb 2017, at 13:17, Pavel Grunt wrote: > > > > On Wed, 2017-02-15 at 11:39 -0500, Frediano Ziglio wrote: > >> Hi, > >> question was raised recently on the ML and IRC. > >> > >> Some time ago we decided to u

Re: [Spice-devel] bool or gboolean

2017-02-16 Thread Christophe de Dinechin
> On 16 Feb 2017, at 13:17, Pavel Grunt wrote: > > On Wed, 2017-02-15 at 11:39 -0500, Frediano Ziglio wrote: >> Hi, >> question was raised recently on the ML and IRC. >> >> Some time ago we decided to use gboolean but some of us would like >> to discuss again. >> >> As any style changes ther

Re: [Spice-devel] bool or gboolean

2017-02-16 Thread Frediano Ziglio
> > On Wed, Feb 15, 2017 at 04:59:43PM +, Daniel P. Berrange wrote: > > On Wed, Feb 15, 2017 at 11:39:32AM -0500, Frediano Ziglio wrote: > > > Hi, > > > question was raised recently on the ML and IRC. > > > > > > Some time ago we decided to use gboolean but some of us would like > > > to di

Re: [Spice-devel] bool or gboolean

2017-02-16 Thread Pavel Grunt
On Wed, 2017-02-15 at 11:39 -0500, Frediano Ziglio wrote: > Hi, >   question was raised recently on the ML and IRC. > > Some time ago we decided to use gboolean but some of us would like > to discuss again. > > As any style changes there's no right or wrong, mainly personal > opinions but I think

Re: [Spice-devel] bool or gboolean

2017-02-16 Thread Christophe Fergeau
On Wed, Feb 15, 2017 at 04:59:43PM +, Daniel P. Berrange wrote: > On Wed, Feb 15, 2017 at 11:39:32AM -0500, Frediano Ziglio wrote: > > Hi, > > question was raised recently on the ML and IRC. > > > > Some time ago we decided to use gboolean but some of us would like > > to discuss again. > >

Re: [Spice-devel] bool or gboolean

2017-02-16 Thread Frediano Ziglio
> > On Wed, 2017-02-15 at 18:01 +0100, Christophe Fergeau wrote: > > On Wed, Feb 15, 2017 at 11:39:32AM -0500, Frediano Ziglio wrote: > > > Hi, > > >   question was raised recently on the ML and IRC. > > > > > > Some time ago we decided to use gboolean but some of us would like > > > to discuss a

Re: [Spice-devel] bool or gboolean

2017-02-15 Thread Jonathon Jongsma
On Wed, 2017-02-15 at 18:01 +0100, Christophe Fergeau wrote: > On Wed, Feb 15, 2017 at 11:39:32AM -0500, Frediano Ziglio wrote: > > Hi, > >   question was raised recently on the ML and IRC. > > > > Some time ago we decided to use gboolean but some of us would like > > to discuss again. > > So...

Re: [Spice-devel] bool or gboolean

2017-02-15 Thread Christophe Fergeau
On Wed, Feb 15, 2017 at 11:39:32AM -0500, Frediano Ziglio wrote: > Hi, > question was raised recently on the ML and IRC. > > Some time ago we decided to use gboolean but some of us would like > to discuss again. So... As said a few times, I would have preferred to wait for a bit to have that di

Re: [Spice-devel] bool or gboolean

2017-02-15 Thread Daniel P. Berrange
On Wed, Feb 15, 2017 at 11:39:32AM -0500, Frediano Ziglio wrote: > Hi, > question was raised recently on the ML and IRC. > > Some time ago we decided to use gboolean but some of us would like > to discuss again. > > As any style changes there's no right or wrong, mainly personal > opinions but

[Spice-devel] bool or gboolean

2017-02-15 Thread Frediano Ziglio
Hi, question was raised recently on the ML and IRC. Some time ago we decided to use gboolean but some of us would like to discuss again. As any style changes there's no right or wrong, mainly personal opinions but I think consistency is quite important. Some consideration (feel free to add/rem