On Mon, Dec 09, 2013 at 12:25:51PM -0500, i iordanov wrote:
> Hi Christophe,
>
> Here's the new patch with the extra safety checks.
Thanks, I've pushed it after fixing the use of tabs in
ovirt_vm_pool_refresh_from_xml()
I've also fixed the G_MAXUINT32 test in the string->guint conversion.
Christ
On Mon, Dec 09, 2013 at 11:56:31AM -0500, i iordanov wrote:
> On Mon, Dec 9, 2013 at 11:35 AM, Christophe Fergeau
> wrote:
> > > I also switched out the two G_MAXUINT's in OvirtVmPool for G_MAXUINT32's.
> >
> > Hmm, I'm not sure about that one, what is the reasoning for it? I'd move
> > this to a
Hi Christophe,
Here's the new patch with the extra safety checks.
Cheers!
iordan
On Mon, Dec 9, 2013 at 11:56 AM, i iordanov wrote:
> Hi Christophe,
>
> On Mon, Dec 9, 2013 at 11:35 AM, Christophe Fergeau
> wrote:
>
>> Ah cool, thanks. This mostly looks good, though I'd probably add a check
Hi Christophe,
On Mon, Dec 9, 2013 at 11:35 AM, Christophe Fergeau wrote:
> Ah cool, thanks. This mostly looks good, though I'd probably add a check
> that the property has the right type using g_object_class_find_property.
>
That's a good idea.
>
> > I also switched out the two G_MAXUINT's in
Hey,
On Fri, Dec 06, 2013 at 06:14:52PM -0500, i iordanov wrote:
> Hi Christophe,
>
> I have another patch for you to consider. This one removes some duplicated
> code by creating and using a utility function to ovirt-utils.c.
Ah cool, thanks. This mostly looks good, though I'd probably add a ch
Hi Christophe,
I have another patch for you to consider. This one removes some duplicated
code by creating and using a utility function to ovirt-utils.c. I also
switched out the two G_MAXUINT's in OvirtVmPool for G_MAXUINT32's.
We can make use of it any time an integer attribute needs to be parse
On Wed, Dec 04, 2013 at 11:12:09PM -0500, i iordanov wrote:
> On Wed, Dec 4, 2013 at 10:30 AM, Christophe Fergeau
> wrote:
> > It would be nice if you could check I did not break anything for you (I
> > haven't tested ovirt_vm_pool_activate_vm() at all). Then I can push all of
> > it to git master
Hi,
On Wed, Dec 4, 2013 at 10:30 AM, Christophe Fergeau wrote:
> It would be nice if you could check I did not break anything for you (I
> haven't tested ovirt_vm_pool_activate_vm() at all). Then I can push all of
> it to git master ;)
>
I tested and it allocates VMs just as well as the before y
Hi Christophe,
I'll do some testing this evening and will let you know.
Thanks!
iordan
On Wed, Dec 4, 2013 at 10:30 AM, Christophe Fergeau wrote:
> Hey,
>
> On Tue, Dec 03, 2013 at 06:21:22PM +0100, Christophe Fergeau wrote:
> > On Tue, Dec 03, 2013 at 11:46:40AM -0500, i iordanov wrote:
> > >
Hey,
On Tue, Dec 03, 2013 at 06:21:22PM +0100, Christophe Fergeau wrote:
> On Tue, Dec 03, 2013 at 11:46:40AM -0500, i iordanov wrote:
> > Would you like me to generate a patch with all the suggested changes and a
> > better log entry?
>
> I've been doing that actually, with various changes:
> -
On Tue, Dec 03, 2013 at 11:46:40AM -0500, i iordanov wrote:
> Would you like me to generate a patch with all the suggested changes and a
> better log entry?
I've been doing that actually, with various changes:
- renamed allocatevm to allocate_vm
- renamed _vmpool_ to _vm_pool
- moved ovirt_vm_pool
Hi Christophe,
On Tue, Dec 3, 2013 at 5:12 AM, Christophe Fergeau wrote:
> Thanks for the patch, a few quick initial comments:
> - formatting of the commit log was off, see (for example)
>
> https://wiki.openstack.org/wiki/GitCommitMessages#Summary_of_GIT_commit_message_structure
> for the reco
Hey Iordan,
On Tue, Dec 03, 2013 at 03:07:09AM -0500, i iordanov wrote:
> My pleasure! Attached find the patch, generated the way you wanted.
Thanks for the patch, a few quick initial comments:
- formatting of the commit log was off, see (for example)
https://wiki.openstack.org/wiki/GitCommitM
Hi Christophe,
On Mon, Dec 2, 2013 at 4:33 AM, Christophe Fergeau wrote:
> Thanks a lot for working on that!
>
My pleasure! Attached find the patch, generated the way you wanted.
Cheers,
iordan
--
The conscious mind has only one thread of execution.
From d940ea24d8146a8d728ac5b7e38ec03eaf8080
On Fri, Nov 29, 2013 at 10:32:03PM -0500, i iordanov wrote:
> 0) Do you require the asynchronous functions before I submit my changes?
Would be better, but I can live without it/add it myself, don't worry ;)
>
> 1) Would a patch against libgovirt 0.30 be acceptable, or would you require
> a patc
Hi Christophe,
Good news! I have added the functionality we discussed to libgovirt 0.30
and it works. The only thing I don't have is
ovirt_vmpool_invoke_action_async() and related functions. I use the
synchronous call.
Can you please tell me:
0) Do you require the asynchronous functions before I
Yes, I had noticed that which is why I retracted my question :D.
Thanks Christophe!
iordan
On Tue, Nov 26, 2013 at 9:17 AM, Christophe Fergeau wrote:
> On Tue, Nov 26, 2013 at 09:12:16AM -0500, i iordanov wrote:
> > I take this back, the "action" here would be "allocatevm", right? I
> should
>
On Tue, Nov 26, 2013 at 09:12:16AM -0500, i iordanov wrote:
> I take this back, the "action" here would be "allocatevm", right? I should
> try playing with this.
Yes it is, you can get the list of actions by accessing /api/vmpools/ in
your webbrowser (OvirtVm has code to parse the available action
I take this back, the "action" here would be "allocatevm", right? I should
try playing with this.
Thanks!
iordan
On Tue, Nov 26, 2013 at 9:10 AM, i iordanov wrote:
>
>
>
> On Tue, Nov 26, 2013 at 9:03 AM, Christophe Fergeau
> wrote:
>
>> I'd expect that doing something similar to ovirt_vm_act
On Tue, Nov 26, 2013 at 9:03 AM, Christophe Fergeau wrote:
> I'd expect that doing something similar to ovirt_vm_action() should work?
> This action stuff needs to be moved from OvirtVm to OvirtResource, but I
> did not get to it yet ;)
>
Yes, but at least one thing that we don't know is what "ac
On Tue, Nov 26, 2013 at 08:55:09AM -0500, i iordanov wrote:
> From the following file in my oVirt installation:
> /usr/lib/python2.7/site-packages/ovirtsdk/infrastructure/brokers.py
>
> I gather that a POST request must be made to
> /api/vmpools/SOMEVMPOOLID/allocatevm
>
> with a certain content,
On Tue, Nov 26, 2013 at 6:41 AM, Christophe Fergeau wrote:
> From a quick look at the documentation
>
> https://access.redhat.com/site/documentation/en-US/Red_Hat_Enterprise_Virtualization/3.3-Beta/html/Developer_Guide/chap-Virtual_Machine_Pools.html
> it should not be too hard to add support for
Hey Iordan,
On Mon, Nov 25, 2013 at 09:17:55PM -0500, i iordanov wrote:
> Do you guys think that there is a use-case for the client to be able to
> show the pool to the user and allow him/her to start a VM from that pool
> right then and there without needing the web interface?
Probably makes sen
Hi guys!
I discovered the "Pools" feature in oVirt (I am using v3.3), and created a
pool of VMs. Then in FreeIPA I created a group and added a bunch of users
to it. I added the group to the pool's permissions with UserRole.
Now the way the web console works seems correct. When I login with one of
24 matches
Mail list logo
