Re: [Spice-devel] RFC - Direct smart card support in libcacard/spice-gtk

2015-01-19 Thread Jeremy White
>> Feedback appreciated. If it doesn't seem offensive, I will likely >> polish it a bit and submit it properly. > > Great! I think this is a better fit, thanks. For a quick glance, the > spice-gtk patch looks good, I would try to keep the "smartcard" prefix in > options and properties though (-

Re: [Spice-devel] RFC - Direct smart card support in libcacard/spice-gtk

2015-01-13 Thread Robert Relyea
On 12/23/2014 12:49 PM, Jeremy White wrote: I am hoping to ask: 1. Does this basic approach seem reasonable? It depends on usage. The main thing to be careful of is card sharing between various VMs and hosts. They fall into two categories: card locking - software like pcsc-lite allows ap

Re: [Spice-devel] RFC - Direct smart card support in libcacard/spice-gtk

2015-01-13 Thread Marc-André Lureau
Hi - Original Message - > > I've spun up v2 of this discussion patch set. I struggled for a while; > I made an attempt to rename the vcard_emul_init entry point, and in the > end, I felt that it was a pointless ABI change, just to satisfy my need > to feel that the name made sense. (I'm

Re: [Spice-devel] RFC - Direct smart card support in libcacard/spice-gtk

2015-01-09 Thread Jeremy White
After some discussion on irc, I decided to explore expanding libcacard to support sending the apdus directly to the card, using the PC/SC (aka pcsclite) library. I've attached a proof of concept set of patches - one for the client, and the substantial one for qemu/libcacard. The basic approach i

Re: [Spice-devel] RFC - Direct smart card support in libcacard/spice-gtk

2014-12-23 Thread Jeremy White
I am hoping to ask: 1. Does this basic approach seem reasonable? I think VCardEmulType VCARD_EMUL_PASSTHRU was supposed to be used for this case, although the current code doesn't make it straightforward to add that, as it initializes nss in vcard_emul_init. It should be possible to change

Re: [Spice-devel] RFC - Direct smart card support in libcacard/spice-gtk

2014-12-23 Thread Marc-André Lureau
Hi On Tue, Dec 23, 2014 at 9:49 PM, Jeremy White wrote: > Hi folks, > > I've been working a lot with smartcards for Xspice. > > As I've done this, I've come to understand that the Spice client doesn't > actually send the physical smartcard data across; instead it sends > virtualized smartcard apd

[Spice-devel] RFC - Direct smart card support in libcacard/spice-gtk

2014-12-23 Thread Jeremy White
Hi folks, I've been working a lot with smartcards for Xspice. As I've done this, I've come to understand that the Spice client doesn't actually send the physical smartcard data across; instead it sends virtualized smartcard apdus, using PK11 information it gets from libnss. After some discus