Re: [Spice-devel] RFC: Lightweight tracing mechanism

Hi - Original Message - > Top remark: here is what I expected to see discussed when I shared the code. > Sending a github link isn't really sharing code. It is not our cmmon practice, so we can't easily review/discuss it. > 1. What categories do we want? > 2. How do spread the categori

Re: [Spice-devel] RFC: Lightweight tracing mechanism

Hi - Original Message - > Hi > > - Original Message - > > On Fri, Jun 09, 2017 at 12:11:50PM -0400, Marc-André Lureau wrote: > > > I don't get the problem with spice-gtk logging though. > > > > I never remember whether G_MESSAGES_DEBUG=all, SPICE_DEBUG=1 and > > --spice-debug are

Re: [Spice-devel] RFC: Lightweight tracing mechanism

Hi - Original Message - > On Fri, Jun 09, 2017 at 12:11:50PM -0400, Marc-André Lureau wrote: > > I don't get the problem with spice-gtk logging though. > > I never remember whether G_MESSAGES_DEBUG=all, SPICE_DEBUG=1 and > --spice-debug are the same or not, I think they are not, and if yo

Re: [Spice-devel] RFC: Lightweight tracing mechanism

On Fri, Jun 09, 2017 at 12:11:50PM -0400, Marc-André Lureau wrote: > I don't get the problem with spice-gtk logging though. I never remember whether G_MESSAGES_DEBUG=all, SPICE_DEBUG=1 and --spice-debug are the same or not, I think they are not, and if you only use eg G_MESSAGES_DEBUG=all, you don

Re: [Spice-devel] RFC: Lightweight tracing mechanism

Top remark: here is what I expected to see discussed when I shared the code. 1. What categories do we want? 2. How do spread the categorization work? 3. How much do today’s developers depend on existing output? 4. What categories do we request e.g. in bug reports (IOW, what should --spice-debu

Re: [Spice-devel] RFC: Lightweight tracing mechanism

On Mon, Jun 12, 2017 at 12:40 AM Marc-André Lureau < marcandre.lur...@gmail.com> wrote: > Hi > > On Fri, Jun 9, 2017 at 10:08 PM Jonathon Jongsma > wrote: > >> On Fri, 2017-06-09 at 12:11 -0400, Marc-André Lureau wrote: >> > > >> > >> > - Original Message - >> > > >> > > > On 9 Jun 2017,

Re: [Spice-devel] RFC: Lightweight tracing mechanism

Hi On Fri, Jun 9, 2017 at 10:08 PM Jonathon Jongsma wrote: > On Fri, 2017-06-09 at 12:11 -0400, Marc-André Lureau wrote: > > > > > > > - Original Message - > > > > > > > On 9 Jun 2017, at 17:16, Jonathon Jongsma > > > > wrote: > > > > > > > > On Fri, 2017-06-09 at 10:59 +0200, Christoph

Re: [Spice-devel] RFC: Lightweight tracing mechanism

On Fri, 2017-06-09 at 12:11 -0400, Marc-André Lureau wrote: > > > > - Original Message - > > > > > On 9 Jun 2017, at 17:16, Jonathon Jongsma > > > wrote: > > > > > > On Fri, 2017-06-09 at 10:59 +0200, Christophe de Dinechin wrote: > > > > > > What I see on the thread: > > > > > > - log

Re: [Spice-devel] RFC: Lightweight tracing mechanism

- Original Message - > > > On 9 Jun 2017, at 17:16, Jonathon Jongsma wrote: > > > > On Fri, 2017-06-09 at 10:59 +0200, Christophe de Dinechin wrote: > What I see on the thread: > - log categorization. This was similar to Djasa bug but I think > he just > proposed

Re: [Spice-devel] RFC: Lightweight tracing mechanism

- Original Message - > [drop_stats]id=0 #in-frames=99 #late=99 (100.00%, avg 2995.89 ms) > #drop-on-playback=0 (0.00%) > [drop_stats]id=0 #in-frames=198 #late=198 (100.00%, avg 2160.48 ms) > #drop-on-playback=3 (1.52%) > [drop_stats]id=0 #in-frames=297 #late=297 (100.00%, avg 1881.11 ms)

Re: [Spice-devel] RFC: Lightweight tracing mechanism

> On 9 Jun 2017, at 17:16, Jonathon Jongsma wrote: > > On Fri, 2017-06-09 at 10:59 +0200, Christophe de Dinechin wrote: What I see on the thread: - log categorization. This was similar to Djasa bug but I think he just proposed to use domains in the glib log sense; >> >> Pu

Re: [Spice-devel] RFC: Lightweight tracing mechanism

> On 9 Jun 2017, at 11:48, Marc-André Lureau > wrote: > > Hi > > I'll focus on your examples, as I think it's the most relevant for the > discussion (let's avoid side-track). > > - Original Message - > >>> spicy -t drop_stats=100 -h turbo -p 5901 >> [drop_stats]id=0 #in-frames=100 #

Re: [Spice-devel] RFC: Lightweight tracing mechanism

On Fri, 2017-06-09 at 10:59 +0200, Christophe de Dinechin wrote: > > > What I see on the thread: > > > - log categorization. This was similar to Djasa bug but I think > > > he just > > >   proposed to use domains in the glib log sense; > > Punchcard analogy: “Printer sheet categorization. This was

Re: [Spice-devel] RFC: Lightweight tracing mechanism

> > Hi > > I'll focus on your examples, as I think it's the most relevant for the > discussion (let's avoid side-track). > > - Original Message - > > > > spicy -t drop_stats=100 -h turbo -p 5901 > > [drop_stats]id=0 #in-frames=100 #late=100 (100.00%, avg 1639.24 ms) > > #drop-on-playbac

Re: [Spice-devel] RFC: Lightweight tracing mechanism

Hi, On Fri, Jun 09, 2017 at 11:25:15AM +0200, Christophe de Dinechin wrote: > Some interesting stuff in there. Victor, do you have a repository / > branch where I could fetch that (even if it’s stale)? https://cgit.freedesktop.org/~victortoso/spice-common/log/?h=logs It was far from what I inten

Re: [Spice-devel] RFC: Lightweight tracing mechanism

Hi I'll focus on your examples, as I think it's the most relevant for the discussion (let's avoid side-track). - Original Message - > > spicy -t drop_stats=100 -h turbo -p 5901 > [drop_stats]id=0 #in-frames=100 #late=100 (100.00%, avg 1639.24 ms) > #drop-on-playback=8 (8.00%) > [drop_st

Re: [Spice-devel] RFC: Lightweight tracing mechanism

Some interesting stuff in there. Victor, do you have a repository / branch where I could fetch that (even if it’s stale)? Thanks Christophe > On 7 Jun 2017, at 17:39, Christophe Fergeau wrote: > > On Wed, Jun 07, 2017 at 11:30:24AM -0400, Marc-André Lureau wrote: >> Or it's not performance-sen

Re: [Spice-devel] RFC: Lightweight tracing mechanism

This is a response to Christophe, Marc André and Frediano, but it starts with a top-post for context. My intent should become clearer with actual examples. You can test the code and examples from the same location as before: https://github.com/c3d/spice-gtk/compare/master...c3d:traces and http

Re: [Spice-devel] RFC: Lightweight tracing mechanism

Hey, I was about to send an email in the saim vein ;) On Thu, Jun 08, 2017 at 10:55:55AM -0400, Frediano Ziglio wrote: > Not much to add honestly. But maybe this thread is try to tackle too > many things at the same time. What I see on the thread: > - log categorization. This was similar to Djasa

Re: [Spice-devel] RFC: Lightweight tracing mechanism

> From: "Marc-André Lureau" > > Hi > > - Original Message - > > > > > On 7 Jun 2017, at 13:51, Marc-André Lureau > > > wrote: > > > > > > Hi > > > > > > - Original Message - > > >> > > >>> On 6 Jun 2017, at 20:45, Marc-André Lureau > > >>> > > >>> wrote: > > >>> > > >>>

Re: [Spice-devel] RFC: Lightweight tracing mechanism

On Wed, Jun 07, 2017 at 11:30:24AM -0400, Marc-André Lureau wrote: > Or it's not performance-sensitive, and can be in production builds and > printf/structured logging & grep/query are your best friends. Regarding structured logging, forgot if this old series from Victor has been mentioned in this

Re: [Spice-devel] RFC: Lightweight tracing mechanism

On Tue, Jun 06, 2017 at 03:17:07PM +0200, Christophe de Dinechin wrote: > >> On 23 May 2017, at 11:51, Christophe Fergeau wrote: > > > >> I think we have SPICE_DEBUG already which might make > >> sense, another alternative would be to have a --enable-alignment-debug, > >> or something like glib (

Re: [Spice-devel] RFC: Lightweight tracing mechanism

Hi - Original Message - > > > On 7 Jun 2017, at 13:51, Marc-André Lureau > > wrote: > > > > Hi > > > > - Original Message - > >> > >>> On 6 Jun 2017, at 20:45, Marc-André Lureau > >>> wrote: > >>> > >>> I don't think any of these measurements couldn't be reported accurately

Re: [Spice-devel] RFC: Lightweight tracing mechanism

> On 7 Jun 2017, at 13:51, Marc-André Lureau > wrote: > > Hi > > - Original Message - >> >>> On 6 Jun 2017, at 20:45, Marc-André Lureau >>> wrote: >>> >>> I don't think any of these measurements couldn't be reported accurately >>> with a regular log or structured log. Thus I don't u

Re: [Spice-devel] RFC: Lightweight tracing mechanism

Hi - Original Message - > > > On 6 Jun 2017, at 20:45, Marc-André Lureau > > wrote: > > > > I don't think any of these measurements couldn't be reported accurately > > with a regular log or structured log. Thus I don't understand what problem > > you try to solve. > > > > Sorry, but I

Re: [Spice-devel] RFC: Lightweight tracing mechanism

> On 6 Jun 2017, at 20:45, Marc-André Lureau > wrote: > > I don't think any of these measurements couldn't be reported accurately with > a regular log or structured log. Thus I don't understand what problem you try > to solve. > > Sorry, but I also have a hard time to understand what your tr

Re: [Spice-devel] RFC: Lightweight tracing mechanism

Hi - Original Message - > >> 3. Scalable, and therefore as fine-grained as we need it to be. With a > >> similar mechanism, Tao-3D has about 70 traces (see > >> https://github.com/c3d/tao-3D/blob/master/tao/traces.tbl > >> for the

Re: [Spice-devel] RFC: Lightweight tracing mechanism

> On 6 Jun 2017, at 16:29, Marc-André Lureau > wrote: > > Hi > > - Original Message - >> Answering two emails from Frediano and Marc-André that were asking closely >> related questions, to avoid duplication… >> >>> On 6 Jun 2017, at 13:28, Frediano Ziglio wrote: >>> >>> Would be hel

Re: [Spice-devel] RFC: Lightweight tracing mechanism

On Tue, 2017-06-06 at 15:17 +0200, Christophe de Dinechin wrote: > Answering two emails from Frediano and Marc-André that were asking > closely related questions, to avoid duplication… > > On 6 Jun 2017, at 13:28, Frediano Ziglio > > wrote: > > > > Would be helpful if you had recap Pavel problems

Re: [Spice-devel] RFC: Lightweight tracing mechanism

Hi - Original Message - > Answering two emails from Frediano and Marc-André that were asking closely > related questions, to avoid duplication… > > > On 6 Jun 2017, at 13:28, Frediano Ziglio wrote: > > > > Would be helpful if you had recap Pavel problems. I don't remember. > > I did no

Re: [Spice-devel] RFC: Lightweight tracing mechanism

Answering two emails from Frediano and Marc-André that were asking closely related questions, to avoid duplication… > On 6 Jun 2017, at 13:28, Frediano Ziglio wrote: > > Would be helpful if you had recap Pavel problems. I don't remember. I did not find it in email, so it was probably IRC. I re

Re: [Spice-devel] RFC: Lightweight tracing mechanism

> > On 23 May 2017, at 12:55, Victor Toso < victort...@redhat.com > wrote: > > > On Tue, May 23, 2017 at 11:51:01AM +0200, Christophe Fergeau wrote: > > > > or something like glib (SPICE_XXX_DEBUG=alignment:foo:bar) > > > > > Just to point out that we have a bug for this [0] and IMHO it woul

Re: [Spice-devel] RFC: Lightweight tracing mechanism

Hi - Original Message - > > > > > On 23 May 2017, at 12:55, Victor Toso < victort...@redhat.com > wrote: > > On Tue, May 23, 2017 at 11:51:01AM +0200, Christophe Fergeau wrote: > > > > or something like glib (SPICE_XXX_DEBUG=alignment:foo:bar) > > Just to point out that we have a

[Spice-devel] RFC: Lightweight tracing mechanism

> On 23 May 2017, at 12:55, Victor Toso wrote: > > On Tue, May 23, 2017 at 11:51:01AM +0200, Christophe Fergeau wrote: > >> or something like glib (SPICE_XXX_DEBUG=alignment:foo:bar) > > Just to point out that we have a bug for this [0] and IMHO it would be > the best approach but it would tak