Re: [Spice-devel] Question on fill_mask() (server/red_worker.c)

2011-10-04 Thread Yaniv Kaul
On 10/04/2011 01:25 PM, Yonit Halperin wrote: On 10/04/2011 01:20 PM, Alon Levy wrote: On Tue, Oct 04, 2011 at 01:00:47PM +0200, Alon Levy wrote: On Tue, Oct 04, 2011 at 12:40:21PM +0200, Yaniv Kaul wrote: Unless I'm misreading the code (which may very well be), the function looks like: if (m

Re: [Spice-devel] Question on fill_mask() (server/red_worker.c)

2011-10-04 Thread Yonit Halperin
On 10/04/2011 01:20 PM, Alon Levy wrote: On Tue, Oct 04, 2011 at 01:00:47PM +0200, Alon Levy wrote: On Tue, Oct 04, 2011 at 12:40:21PM +0200, Yaniv Kaul wrote: Unless I'm misreading the code (which may very well be), the function looks like: if (mask_bitmap&& m) { if (this or that) {

Re: [Spice-devel] Question on fill_mask() (server/red_worker.c)

2011-10-04 Thread Alon Levy
On Tue, Oct 04, 2011 at 01:00:47PM +0200, Alon Levy wrote: > On Tue, Oct 04, 2011 at 12:40:21PM +0200, Yaniv Kaul wrote: > > Unless I'm misreading the code (which may very well be), the > > function looks like: > > > > if (mask_bitmap && m) { > > if (this or that) { > > do X > >

Re: [Spice-devel] Question on fill_mask() (server/red_worker.c)

2011-10-04 Thread Yaniv Kaul
On 10/04/2011 01:00 PM, Alon Levy wrote: On Tue, Oct 04, 2011 at 12:40:21PM +0200, Yaniv Kaul wrote: Unless I'm misreading the code (which may very well be), the function looks like: if (mask_bitmap&& m) { if (this or that) { do X fill_bits(...) } else { fi

Re: [Spice-devel] Question on fill_mask() (server/red_worker.c)

2011-10-04 Thread Alon Levy
On Tue, Oct 04, 2011 at 12:40:21PM +0200, Yaniv Kaul wrote: > Unless I'm misreading the code (which may very well be), the > function looks like: > > if (mask_bitmap && m) { > if (this or that) { > do X > fill_bits(...) > } else { > fill_bits(...) > } > } > > S

[Spice-devel] Question on fill_mask() (server/red_worker.c)

2011-10-04 Thread Yaniv Kaul
Unless I'm misreading the code (which may very well be), the function looks like: if (mask_bitmap && m) { if (this or that) { do X fill_bits(...) } else { fill_bits(...) } } So essentially, if the condition (mask_bitmap && m) is NOT met, we do not fill the b