Re: [Spice-devel] Purpose of interface version checks in server/reds.c

2011-07-05 Thread Uri Lublin
On 07/05/2011 11:57 AM, Christophe Fergeau wrote: On Mon, Jul 04, 2011 at 02:37:09PM +0200, Christophe Fergeau wrote: On Mon, Jul 04, 2011 at 01:27:16PM +0200, Gerd Hoffmann wrote: On 07/01/11 15:58, Christophe Fergeau wrote: if (strcmp(interface->type, SPICE_INTERFACE_RECORD) == 0) { red

Re: [Spice-devel] Purpose of interface version checks in server/reds.c

2011-07-05 Thread Christophe Fergeau
On Mon, Jul 04, 2011 at 02:37:09PM +0200, Christophe Fergeau wrote: > On Mon, Jul 04, 2011 at 01:27:16PM +0200, Gerd Hoffmann wrote: > > On 07/01/11 15:58, Christophe Fergeau wrote: > > >if (strcmp(interface->type, SPICE_INTERFACE_RECORD) == 0) { > > > red_printf("SPICE_INTERFACE_RECORD"); > >

Re: [Spice-devel] Purpose of interface version checks in server/reds.c

2011-07-04 Thread Gerd Hoffmann
Hi, I see, thanks. In this case, the change adds new messages and new methods for the Playback and Record channels, so nothing should change unless these new methods are explicitly called from qemu, which means raising the minor version number was probably not strictly needed (but not harmful

Re: [Spice-devel] Purpose of interface version checks in server/reds.c

2011-07-04 Thread Christophe Fergeau
Hi, On Mon, Jul 04, 2011 at 01:27:16PM +0200, Gerd Hoffmann wrote: > On 07/01/11 15:58, Christophe Fergeau wrote: > >if (strcmp(interface->type, SPICE_INTERFACE_RECORD) == 0) { > > red_printf("SPICE_INTERFACE_RECORD"); > > if (interface->major_version != SPICE_INTERFACE_RECORD_MAJOR || > >

Re: [Spice-devel] Purpose of interface version checks in server/reds.c

2011-07-04 Thread Gerd Hoffmann
On 07/01/11 15:58, Christophe Fergeau wrote: Hi, While looking at a crash in qemu when SPICE_INTERFACE_PLAYBACK_MINOR was increased, I came across the version checking code in spice_server_add_interface in server/reds.c which does stuff like if (strcmp(interface->type, SPICE_INTERFACE_RECORD) =

Re: [Spice-devel] Purpose of interface version checks in server/reds.c

2011-07-01 Thread Alon Levy
On Fri, Jul 01, 2011 at 03:58:01PM +0200, Christophe Fergeau wrote: > Hi, > > While looking at a crash in qemu when SPICE_INTERFACE_PLAYBACK_MINOR was > increased, I came across the version checking code in > spice_server_add_interface > in server/reds.c which does stuff like > > if (strcmp(inte

[Spice-devel] Purpose of interface version checks in server/reds.c

2011-07-01 Thread Christophe Fergeau
Hi, While looking at a crash in qemu when SPICE_INTERFACE_PLAYBACK_MINOR was increased, I came across the version checking code in spice_server_add_interface in server/reds.c which does stuff like if (strcmp(interface->type, SPICE_INTERFACE_RECORD) == 0) { red_printf("SPICE_INTERFACE_RECORD")