Re: [Spice-devel] Patch to support LZ4 compression algorithm

2014-12-03 Thread Javier Celaya
El Miércoles, 3 de diciembre de 2014 10:41:42 Christophe Fergeau escribió: > On Thu, Nov 13, 2014 at 05:11:52PM +0100, Javier Celaya wrote: > > However, don't forget that, since spice-protocol is a submodule of spice- > > common, once you push the commit for spice-protocol, the commit for spice- >

Re: [Spice-devel] Patch to support LZ4 compression algorithm

2014-12-03 Thread Christophe Fergeau
On Thu, Nov 13, 2014 at 05:11:52PM +0100, Javier Celaya wrote: > However, don't forget that, since spice-protocol is a submodule of spice- > common, once you push the commit for spice-protocol, the commit for spice- > common should point to it. The same with spice and spice-gtk in relation to > sp

Re: [Spice-devel] Patch to support LZ4 compression algorithm

2014-11-13 Thread Javier Celaya
Hello There they go. However, don't forget that, since spice-protocol is a submodule of spice- common, once you push the commit for spice-protocol, the commit for spice- common should point to it. The same with spice and spice-gtk in relation to spice-common. Regards El Jueves, 13 de noviembre

Re: [Spice-devel] Patch to support LZ4 compression algorithm

2014-11-13 Thread Christophe Fergeau
Hey, On Fri, Nov 07, 2014 at 10:17:11AM +0100, Javier Celaya wrote: > Hello > > I resend the patch for the spice repository. I just realized I forgot to > remove a debug message from red_worker.c, sorry. Thanks for the updated patches, they look good to me. There are 2 blank lines at the end o

Re: [Spice-devel] Patch to support LZ4 compression algorithm

2014-11-07 Thread Javier Celaya
Hello I resend the patch for the spice repository. I just realized I forgot to remove a debug message from red_worker.c, sorry. El Jueves, 6 de noviembre de 2014 18:21:21 Javier Celaya escribió: > Hello > > El Jueves, 6 de noviembre de 2014 17:20:42 Christophe Fergeau escribió: > > On Thu, Nov

Re: [Spice-devel] Patch to support LZ4 compression algorithm

2014-11-06 Thread Javier Celaya
Hello El Jueves, 6 de noviembre de 2014 17:20:42 Christophe Fergeau escribió: > On Thu, Nov 06, 2014 at 10:33:19AM +0100, Javi wrote: > > diff --git a/configure.ac b/configure.ac > > index f47ee20..d295c5b 100644 > > --- a/configure.ac > > +++ b/configure.ac > > @@ -694,6 +694,24 @@ if test "x$ena

Re: [Spice-devel] Patch to support LZ4 compression algorithm

2014-11-06 Thread Christophe Fergeau
On Thu, Nov 06, 2014 at 10:33:19AM +0100, Javi wrote: > diff --git a/configure.ac b/configure.ac > index f47ee20..d295c5b 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -694,6 +694,24 @@ if test "x$enable_dbus" != "xno"; then >fi > fi > > +AC_ARG_ENABLE([lz4], > + AS_HELP_STRING([--e

Re: [Spice-devel] Patch to support LZ4 compression algorithm

2014-11-06 Thread Javi
Hello Marc-André, I added the changes you asked for. A new compression type SPICE_IMAGE_COMPRESS_LZ4 has been added, so that either LZ or LZ4 can be selected. Then, when LZ4 is selected, it will gracely fallback to LZ if: - LZ4 support was not enabled in the server during compilation. - The clie

Re: [Spice-devel] Patch to support LZ4 compression algorithm

2014-11-05 Thread Javier Celaya
Hello El Miércoles, 5 de noviembre de 2014 08:58:25 Marc-André Lureau escribió: > Hi > > - Original Message - > > > Hello > > > > My name is Javier Celaya and I work for Flexible Solutions [1]. We develop > > a virtualization product that includes a VDI module with Spice. As part > > of

Re: [Spice-devel] Patch to support LZ4 compression algorithm

2014-11-05 Thread Marc-André Lureau
Hi - Original Message - > Hello > > My name is Javier Celaya and I work for Flexible Solutions [1]. We develop a > virtualization product that includes a VDI module with Spice. As part of this > module, we have included support for the LZ4 compression algorithm [2], and > we > would like

[Spice-devel] Patch to support LZ4 compression algorithm

2014-11-05 Thread Javier Celaya
Hello My name is Javier Celaya and I work for Flexible Solutions [1]. We develop a virtualization product that includes a VDI module with Spice. As part of this module, we have included support for the LZ4 compression algorithm [2], and we would like to contribute it to the main project. The L