Re: [Spice-devel] Coding style and naming conventions for C++

2018-02-06 Thread Victor Toso
On Tue, Feb 06, 2018 at 04:40:18AM -0500, Frediano Ziglio wrote: > > > > On Tue, 2018-01-30 at 11:50 +0100, Christophe de Dinechin wrote: > > > > > > Let’s first share our preference on existing styles to see > > > if we agree on anything… > > > As for me, I have a slight preference for the LLVM

Re: [Spice-devel] Coding style and naming conventions for C++

2018-02-06 Thread Frediano Ziglio
> > On Tue, 2018-01-30 at 11:50 +0100, Christophe de Dinechin wrote: > > > > Let’s first share our preference on existing styles to see if we agree on > > anything… > > As for me, I have a slight preference for the LLVM coding style, but I made > > modifications in my own clang-format files. > >

Re: [Spice-devel] Coding style and naming conventions for C++

2018-02-05 Thread Lukáš Hrázký
On Tue, 2018-01-30 at 11:50 +0100, Christophe de Dinechin wrote: > > Let’s first share our preference on existing styles to see if we agree on > anything… > As for me, I have a slight preference for the LLVM coding style, but I made > modifications in my own clang-format files. Ok, so since nobo

Re: [Spice-devel] Coding style and naming conventions for C++

2018-01-30 Thread Christophe de Dinechin
> On 30 Jan 2018, at 14:05, Lukáš Hrázký wrote: > > On Tue, 2018-01-30 at 11:50 +0100, Christophe de Dinechin wrote: >> Hi Lukáš, >> >> >> In the specific case of the streaming agent, I believe it matters >> for instant productivity that the code follow a style that does not >> require additi

Re: [Spice-devel] Coding style and naming conventions for C++

2018-01-30 Thread Lukáš Hrázký
On Tue, 2018-01-30 at 07:09 -0500, Frediano Ziglio wrote: ... > > > 3. Namespace coding style > > > > > > a) Let's not use `using namespace ...` ever even in .cpp files > > > (see > > > i.e. [1]). In streaming agent we have at the beginning of every > > > .cpp: > > > > > > using namespace std; >

Re: [Spice-devel] Coding style and naming conventions for C++

2018-01-30 Thread Lukáš Hrázký
On Tue, 2018-01-30 at 11:50 +0100, Christophe de Dinechin wrote: > Hi Lukáš, > > > In the specific case of the streaming agent, I believe it matters > for instant productivity that the code follow a style that does not > require additional thinking on Frediano’s part. So if Frediano likes > it, i

Re: [Spice-devel] Coding style and naming conventions for C++

2018-01-30 Thread Frediano Ziglio
> > Hi Lukáš, > > > In the specific case of the streaming agent, I believe it matters > for instant productivity that the code follow a style that does not > require additional thinking on Frediano’s part. So if Frediano likes > it, it’s fine by me, otherwise don’t care. > > Also, rather than i

Re: [Spice-devel] Coding style and naming conventions for C++

2018-01-30 Thread Christophe de Dinechin
Hi Lukáš, In the specific case of the streaming agent, I believe it matters for instant productivity that the code follow a style that does not require additional thinking on Frediano’s part. So if Frediano likes it, it’s fine by me, otherwise don’t care. Also, rather than invent a style, I’d ra

Re: [Spice-devel] Coding style and naming conventions for C++

2018-01-30 Thread Lukáš Hrázký
On Tue, 2018-01-30 at 04:47 -0500, Frediano Ziglio wrote: > Currently there's a docs/spice_style.txt file in spice-server > repository > (the website on spice-space uses it). > I don't know how much of a good idea to extend it, maybe some styles > do not fit that well with C++ (like the multi line

Re: [Spice-devel] Coding style and naming conventions for C++

2018-01-30 Thread Lukáš Hrázký
On Tue, 2018-01-30 at 04:47 -0500, Frediano Ziglio wrote: > > > > 3. Namespace coding style > > > > a) Let's not use `using namespace ...` ever even in .cpp files (see > > i.e. [1]). In streaming agent we have at the beginning of every > > .cpp: > > > > using namespace std; > > using namespace S

Re: [Spice-devel] Coding style and naming conventions for C++

2018-01-30 Thread Frediano Ziglio
> > Hello everybody, > > I'd like to discuss a few things about the coding style for C++ in > Spice (looking at the streaming agent atm). > > Trying to keep this short and concise. > > > 1. Method names > Currently the method names are in CamelCase throughout the streaming > agent. Methods are

[Spice-devel] Coding style and naming conventions for C++

2018-01-29 Thread Lukáš Hrázký
Hello everybody, I'd like to discuss a few things about the coding style for C++ in Spice (looking at the streaming agent atm). Trying to keep this short and concise. 1. Method names Currently the method names are in CamelCase throughout the streaming agent. Methods are basically functions atta