Re: [Spice-devel] [win-vdagent PATCH] vdagent: protect against NULL entry in _displays

2013-05-06 Thread Uri Lublin
On 05/03/2013 02:03 AM, Marc-André Lureau wrote: So when this happens (even if the agent is fixed to not crash), then we get randomly loaded drivers assigned to channels A guest monitor 3 might end up on display channel 4 if for example, driver failed to load for card associated to display cha

Re: [Spice-devel] [win-vdagent PATCH] vdagent: protect against NULL entry in _displays

2013-05-06 Thread Uri Lublin
On 05/03/2013 01:57 AM, Marc-André Lureau wrote: Hi On Tue, Apr 30, 2013 at 12:10 PM, Uri Lublin > wrote: if (display_count) { There is at least one more use you forgot, and that caused still a crash if (min_x || min_y) { for (iter = _displays.begi

Re: [Spice-devel] [win-vdagent PATCH] vdagent: protect against NULL entry in _displays

2013-05-02 Thread Marc-André Lureau
So when this happens (even if the agent is fixed to not crash), then we get randomly loaded drivers assigned to channels A guest monitor 3 might end up on display channel 4 if for example, driver failed to load for card associated to display channel 3.. This means that virt-viewer will show a "wa

Re: [Spice-devel] [win-vdagent PATCH] vdagent: protect against NULL entry in _displays

2013-05-02 Thread Marc-André Lureau
Hi On Tue, Apr 30, 2013 at 12:10 PM, Uri Lublin wrote: > if (display_count) { There is at least one more use you forgot, and that caused still a crash if (min_x || min_y) { for (iter = _displays.begin(); iter != _displays.end(); iter++) { +if (!*iter) { + continue; +} -- M

Re: [Spice-devel] [win-vdagent PATCH] vdagent: protect against NULL entry in _displays

2013-04-30 Thread agilboa
ack On 04/30/2013 01:10 PM, Uri Lublin wrote: rhbz#958051 It may be that a _displays entry will be NULL. I encountered it when running with multiple QXL devices, for one of which the driver failed to load since it was "out of resources" Iterations over _displays should handle that case. I foun

[Spice-devel] [win-vdagent PATCH] vdagent: protect against NULL entry in _displays

2013-04-30 Thread Uri Lublin
rhbz#958051 It may be that a _displays entry will be NULL. I encountered it when running with multiple QXL devices, for one of which the driver failed to load since it was "out of resources" Iterations over _displays should handle that case. I found three such iterations, and fixed them in this p