On Mon, Jul 24, 2017 at 07:32:19AM -0400, Frediano Ziglio wrote:
> >
> > On Fri, Jul 21, 2017 at 02:51:38PM +0100, Frediano Ziglio wrote:
> > > +const int palette_colors = out_bits > 8 ? 0 : 1 << (bits == 2 ? 2 :
> > > out_bits);
> >
> > This really deserves to be split in multiple statements
>
> On Fri, Jul 21, 2017 at 02:51:38PM +0100, Frediano Ziglio wrote:
> > +const int palette_colors = out_bits > 8 ? 0 : 1 << (bits == 2 ? 2 :
> > out_bits);
>
> This really deserves to be split in multiple statements to make this
> easier to parse :)
>
> Looks good otherwise.
>
> Christophe
On Fri, Jul 21, 2017 at 02:51:38PM +0100, Frediano Ziglio wrote:
> +const int palette_colors = out_bits > 8 ? 0 : 1 << (bits == 2 ? 2 :
> out_bits);
This really deserves to be split in multiple statements to make this
easier to parse :)
Looks good otherwise.
Christophe
signature.asc
Descr
Signed-off-by: Frediano Ziglio
---
Makefile.am | 6 +-
configure.ac | 3 +
vdagent/image.cpp| 8 +-
vdagent/imagepng.cpp | 236 +++
vdagent/imagepng.h | 25 ++
5 files changed, 269 insertions(+), 9 deletions(-)
cre
