Re: [Spice-devel] [vdagent-win PATCH 4/4] imagetest: replace assert with printf

2017-07-17 Thread Frediano Ziglio
> > On Fri, Jul 14, 2017 at 05:48:45AM -0400, Frediano Ziglio wrote: > > > > > > If one does not have gdb installed it's nicer > > > to simply get the error message (and some > > > debug messages). > > > > > > > I don't really agree. The imagetest is supposed to be a test > > utility so is used

Re: [Spice-devel] [vdagent-win PATCH 4/4] imagetest: replace assert with printf

2017-07-17 Thread Christophe Fergeau
On Fri, Jul 14, 2017 at 05:48:45AM -0400, Frediano Ziglio wrote: > > > > If one does not have gdb installed it's nicer > > to simply get the error message (and some > > debug messages). > > > > I don't really agree. The imagetest is supposed to be a test > utility so is used only during developm

Re: [Spice-devel] [vdagent-win PATCH 4/4] imagetest: replace assert with printf

2017-07-14 Thread Frediano Ziglio
> > If one does not have gdb installed it's nicer > to simply get the error message (and some > debug messages). > I don't really agree. The imagetest is supposed to be a test utility so is used only during development. Without a debug you still can see the source file and line printed. The clea

[Spice-devel] [vdagent-win PATCH 4/4] imagetest: replace assert with printf

2017-07-11 Thread Uri Lublin
If one does not have gdb installed it's nicer to simply get the error message (and some debug messages). Signed-off-by: Uri Lublin --- vdagent/imagetest.cpp | 99 ++- 1 file changed, 83 insertions(+), 16 deletions(-) diff --git a/vdagent/imagetest