Re: [Spice-devel] [spice v1 2/2] display-channel: Make video-codecs readwrite

2016-12-05 Thread Victor Toso
Hi, On Fri, Dec 02, 2016 at 01:09:54PM -0500, Frediano Ziglio wrote: > > Indeed, it seems that it can be improved but I'm not sure how it should > > be designed? > > > > Nowadays: > > > > host calls reds:spice_server_set_video_codecs() that calls > > reds_on_vc_change() which end up sending > > RE

Re: [Spice-devel] [spice v1 2/2] display-channel: Make video-codecs readwrite

2016-12-05 Thread Christophe Fergeau
On Fri, Dec 02, 2016 at 06:37:26PM +0100, Victor Toso wrote: > > I prefer accessors. > > Should I drop also the change from G_PARAM_WRITABLE to > G_PARAM_READWRITE or should I drop the patch entirely? You can go with both :) > > > Also streaming code should have access to this information, in a

Re: [Spice-devel] [spice v1 2/2] display-channel: Make video-codecs readwrite

2016-12-02 Thread Frediano Ziglio
> > Hi, > > On Fri, Dec 02, 2016 at 12:17:00PM -0500, Frediano Ziglio wrote: > > > > > > From: Victor Toso > > > > > > By making video-codecs readeable, we can avoid other objects to access > > > the internals of DisplayChannel. > > > > > > The GArray video-codecs is copied as static, no need

Re: [Spice-devel] [spice v1 2/2] display-channel: Make video-codecs readwrite

2016-12-02 Thread Victor Toso
Hi, On Fri, Dec 02, 2016 at 12:17:00PM -0500, Frediano Ziglio wrote: > > > > From: Victor Toso > > > > By making video-codecs readeable, we can avoid other objects to access > > the internals of DisplayChannel. > > > > The GArray video-codecs is copied as static, no need to unref it > > afterw

Re: [Spice-devel] [spice v1 2/2] display-channel: Make video-codecs readwrite

2016-12-02 Thread Frediano Ziglio
> > From: Victor Toso > > By making video-codecs readeable, we can avoid other objects to access > the internals of DisplayChannel. > > The GArray video-codecs is copied as static, no need to unref it > afterwards. > > Signed-off-by: Victor Toso > --- > server/display-channel.c | 5 - >

[Spice-devel] [spice v1 2/2] display-channel: Make video-codecs readwrite

2016-12-02 Thread Victor Toso
From: Victor Toso By making video-codecs readeable, we can avoid other objects to access the internals of DisplayChannel. The GArray video-codecs is copied as static, no need to unref it afterwards. Signed-off-by: Victor Toso --- server/display-channel.c | 5 - server/stream.c |