Re: [Spice-devel] [spice-xpi PATCHv2 01/12] Split nsPluginInstance::connect a bit

2013-03-14 Thread Christophe Fergeau
On Wed, Mar 13, 2013 at 01:52:59PM +0100, Marc-André Lureau wrote: > Except the g_message vs g_critical, ack the series. Thanks, pushed with that change! Only a few more patches to go, which I'll send once I write proper commit logs and do a bit of cleanup :) Christophe pgpJFf9ArtmQF.pgp Descr

Re: [Spice-devel] [spice-xpi PATCHv2 01/12] Split nsPluginInstance::connect a bit

2013-03-13 Thread Marc-André Lureau
Except the g_message vs g_critical, ack the series. -- Marc-André Lureau ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/spice-devel

[Spice-devel] [spice-xpi PATCHv2 01/12] Split nsPluginInstance::connect a bit

2013-03-13 Thread Christophe Fergeau
This makes it more readable, and moves OS-specific code to separate functions. --- v2: - only call g_type_init() on older glib - removed extra space SpiceXPI/src/plugin/plugin.cpp | 170 +++-- SpiceXPI/src/plugin/plugin.h | 3 + 2 files changed, 99 inse