Re: [Spice-devel] [spice-xpi 5/5] Add glib Windows logging

2013-03-25 Thread Marc-André Lureau
- Mensaje original - > On Mon, Mar 25, 2013 at 12:18:32PM +0100, Marc-André Lureau wrote: > > On Mon, Mar 25, 2013 at 11:50 AM, Christophe Fergeau > > wrote: > > > I've considered that, but this means I'd have to sanitize the > > > filename for > > > \, '..', and probably some other thin

Re: [Spice-devel] [spice-xpi 5/5] Add glib Windows logging

2013-03-25 Thread Christophe Fergeau
On Mon, Mar 25, 2013 at 12:18:32PM +0100, Marc-André Lureau wrote: > On Mon, Mar 25, 2013 at 11:50 AM, Christophe Fergeau > wrote: > > I've considered that, but this means I'd have to sanitize the filename for > > \, '..', and probably some other things I didn't think of. As this is just > > a deb

Re: [Spice-devel] [spice-xpi 5/5] Add glib Windows logging

2013-03-25 Thread Marc-André Lureau
On Mon, Mar 25, 2013 at 11:50 AM, Christophe Fergeau wrote: > I've considered that, but this means I'd have to sanitize the filename for > \, '..', and probably some other things I didn't think of. As this is just > a debugging help, I've chosen to go with a hardcoded filename which does > not nee

Re: [Spice-devel] [spice-xpi 5/5] Add glib Windows logging

2013-03-25 Thread Christophe Fergeau
On Sun, Mar 24, 2013 at 11:27:41PM +0100, Marc-André Lureau wrote: > > +} > > + > > +static void glib_setup_logging(void) > > +{ > > +#if defined(XP_WIN) > > +FILE *log_file; > > +gchar *log_filename; > > + > > +if (!g_getenv("SPICE_XPI_LOG_TO_FILE")) > > +return; > > Imho, it

Re: [Spice-devel] [spice-xpi 5/5] Add glib Windows logging

2013-03-24 Thread Marc-André Lureau
On Sun, Mar 24, 2013 at 12:16 PM, Christophe Fergeau wrote: > As it's not very convenient to get logging output from the plugin > while firefox is running, this commit adds a dumb glib logging > implementation that writes the logging information to a file. > As this is not efficient at all, it's d

[Spice-devel] [spice-xpi 5/5] Add glib Windows logging

2013-03-24 Thread Christophe Fergeau
As it's not very convenient to get logging output from the plugin while firefox is running, this commit adds a dumb glib logging implementation that writes the logging information to a file. As this is not efficient at all, it's disabled by default unless the SPICE_XPI_LOG_TO_FILE environment varia