Hi,
On Mon, Mar 25, 2013 at 08:06:27AM -0400, Marc-André Lureau wrote:
> - Mensaje original -
> > > In general, returning true on success is easier to read.
> >
> > This mimics the return value of connect(2), I'd prefer to keep that
> > (at
> > least in that patch, can be improved as a s
- Mensaje original -
> > In general, returning true on success is easier to read.
>
> This mimics the return value of connect(2), I'd prefer to keep that
> (at
> least in that patch, can be improved as a separate cleanup as this
> needs
> changes in SpiceController and SpiceControllerUn
Hey, thanks for the detailed review!
A few questions below,
On Sun, Mar 24, 2013 at 11:27:45PM +0100, Marc-André Lureau wrote:
> On Sun, Mar 24, 2013 at 12:16 PM, Christophe Fergeau
> wrote:
> > +SpiceControllerWin::~SpiceControllerWin()
> > +{
> > +}
> > +
> > +int SpiceControllerWin::Connect()
On Sun, Mar 24, 2013 at 12:16 PM, Christophe Fergeau
wrote:
> This class implements the controller interface for Windows/mingw.
> ---
> SpiceXPI/src/plugin/Makefile.am| 2 +
> SpiceXPI/src/plugin/controller-win.cpp | 266
> +
> SpiceXPI/src/plugin/contro
This class implements the controller interface for Windows/mingw.
---
SpiceXPI/src/plugin/Makefile.am| 2 +
SpiceXPI/src/plugin/controller-win.cpp | 266 +
SpiceXPI/src/plugin/controller-win.h | 93
SpiceXPI/src/plugin/controller.cpp |
